123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202 |
- /*
- Copyright 2014 The Kubernetes Authors.
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- */
- package validation
- import (
- "strings"
- "testing"
- metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
- "k8s.io/apimachinery/pkg/util/validation/field"
- authorizationapi "k8s.io/kubernetes/pkg/apis/authorization"
- )
- func TestValidateSARSpec(t *testing.T) {
- successCases := []authorizationapi.SubjectAccessReviewSpec{
- {ResourceAttributes: &authorizationapi.ResourceAttributes{}, User: "me"},
- {NonResourceAttributes: &authorizationapi.NonResourceAttributes{}, Groups: []string{"my-group"}},
- }
- for _, successCase := range successCases {
- if errs := ValidateSubjectAccessReviewSpec(successCase, field.NewPath("spec")); len(errs) != 0 {
- t.Errorf("expected success: %v", errs)
- }
- }
- errorCases := []struct {
- name string
- obj authorizationapi.SubjectAccessReviewSpec
- msg string
- }{
- {
- name: "neither request",
- obj: authorizationapi.SubjectAccessReviewSpec{User: "me"},
- msg: "exactly one of nonResourceAttributes or resourceAttributes must be specified",
- },
- {
- name: "both requests",
- obj: authorizationapi.SubjectAccessReviewSpec{
- ResourceAttributes: &authorizationapi.ResourceAttributes{},
- NonResourceAttributes: &authorizationapi.NonResourceAttributes{},
- User: "me",
- },
- msg: "cannot be specified in combination with resourceAttributes",
- },
- {
- name: "no subject",
- obj: authorizationapi.SubjectAccessReviewSpec{
- ResourceAttributes: &authorizationapi.ResourceAttributes{},
- },
- msg: `spec.user: Invalid value: "": at least one of user or group must be specified`,
- },
- }
- for _, c := range errorCases {
- errs := ValidateSubjectAccessReviewSpec(c.obj, field.NewPath("spec"))
- if len(errs) == 0 {
- t.Errorf("%s: expected failure for %q", c.name, c.msg)
- } else if !strings.Contains(errs[0].Error(), c.msg) {
- t.Errorf("%s: unexpected error: %q, expected: %q", c.name, errs[0], c.msg)
- }
- errs = ValidateSubjectAccessReview(&authorizationapi.SubjectAccessReview{Spec: c.obj})
- if len(errs) == 0 {
- t.Errorf("%s: expected failure for %q", c.name, c.msg)
- } else if !strings.Contains(errs[0].Error(), c.msg) {
- t.Errorf("%s: unexpected error: %q, expected: %q", c.name, errs[0], c.msg)
- }
- errs = ValidateLocalSubjectAccessReview(&authorizationapi.LocalSubjectAccessReview{Spec: c.obj})
- if len(errs) == 0 {
- t.Errorf("%s: expected failure for %q", c.name, c.msg)
- } else if !strings.Contains(errs[0].Error(), c.msg) {
- t.Errorf("%s: unexpected error: %q, expected: %q", c.name, errs[0], c.msg)
- }
- }
- }
- func TestValidateSelfSAR(t *testing.T) {
- successCases := []authorizationapi.SelfSubjectAccessReviewSpec{
- {ResourceAttributes: &authorizationapi.ResourceAttributes{}},
- }
- for _, successCase := range successCases {
- if errs := ValidateSelfSubjectAccessReviewSpec(successCase, field.NewPath("spec")); len(errs) != 0 {
- t.Errorf("expected success: %v", errs)
- }
- }
- errorCases := []struct {
- name string
- obj authorizationapi.SelfSubjectAccessReviewSpec
- msg string
- }{
- {
- name: "neither request",
- obj: authorizationapi.SelfSubjectAccessReviewSpec{},
- msg: "exactly one of nonResourceAttributes or resourceAttributes must be specified",
- },
- {
- name: "both requests",
- obj: authorizationapi.SelfSubjectAccessReviewSpec{
- ResourceAttributes: &authorizationapi.ResourceAttributes{},
- NonResourceAttributes: &authorizationapi.NonResourceAttributes{},
- },
- msg: "cannot be specified in combination with resourceAttributes",
- },
- }
- for _, c := range errorCases {
- errs := ValidateSelfSubjectAccessReviewSpec(c.obj, field.NewPath("spec"))
- if len(errs) == 0 {
- t.Errorf("%s: expected failure for %q", c.name, c.msg)
- } else if !strings.Contains(errs[0].Error(), c.msg) {
- t.Errorf("%s: unexpected error: %q, expected: %q", c.name, errs[0], c.msg)
- }
- errs = ValidateSelfSubjectAccessReview(&authorizationapi.SelfSubjectAccessReview{Spec: c.obj})
- if len(errs) == 0 {
- t.Errorf("%s: expected failure for %q", c.name, c.msg)
- } else if !strings.Contains(errs[0].Error(), c.msg) {
- t.Errorf("%s: unexpected error: %q, expected: %q", c.name, errs[0], c.msg)
- }
- }
- }
- func TestValidateLocalSAR(t *testing.T) {
- successCases := []authorizationapi.LocalSubjectAccessReview{
- {
- Spec: authorizationapi.SubjectAccessReviewSpec{
- ResourceAttributes: &authorizationapi.ResourceAttributes{},
- User: "user",
- },
- },
- }
- for _, successCase := range successCases {
- if errs := ValidateLocalSubjectAccessReview(&successCase); len(errs) != 0 {
- t.Errorf("expected success: %v", errs)
- }
- }
- errorCases := []struct {
- name string
- obj *authorizationapi.LocalSubjectAccessReview
- msg string
- }{
- {
- name: "name",
- obj: &authorizationapi.LocalSubjectAccessReview{
- ObjectMeta: metav1.ObjectMeta{Name: "a"},
- Spec: authorizationapi.SubjectAccessReviewSpec{
- ResourceAttributes: &authorizationapi.ResourceAttributes{},
- User: "user",
- },
- },
- msg: "must be empty except for namespace",
- },
- {
- name: "namespace conflict",
- obj: &authorizationapi.LocalSubjectAccessReview{
- ObjectMeta: metav1.ObjectMeta{Namespace: "a"},
- Spec: authorizationapi.SubjectAccessReviewSpec{
- ResourceAttributes: &authorizationapi.ResourceAttributes{},
- User: "user",
- },
- },
- msg: "must match metadata.namespace",
- },
- {
- name: "nonresource",
- obj: &authorizationapi.LocalSubjectAccessReview{
- ObjectMeta: metav1.ObjectMeta{Namespace: "a"},
- Spec: authorizationapi.SubjectAccessReviewSpec{
- NonResourceAttributes: &authorizationapi.NonResourceAttributes{},
- User: "user",
- },
- },
- msg: "disallowed on this kind of request",
- },
- }
- for _, c := range errorCases {
- errs := ValidateLocalSubjectAccessReview(c.obj)
- if len(errs) == 0 {
- t.Errorf("%s: expected failure for %q", c.name, c.msg)
- } else if !strings.Contains(errs[0].Error(), c.msg) {
- t.Errorf("%s: unexpected error: %q, expected: %q", c.name, errs[0], c.msg)
- }
- }
- }
|