123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556 |
- /*
- Copyright 2015 The Kubernetes Authors.
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- */
- package iscsi
- import (
- "fmt"
- "os"
- "strings"
- "testing"
- "k8s.io/utils/exec/testing"
- "k8s.io/utils/mount"
- v1 "k8s.io/api/core/v1"
- metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
- "k8s.io/apimachinery/pkg/types"
- "k8s.io/client-go/kubernetes/fake"
- utiltesting "k8s.io/client-go/util/testing"
- "k8s.io/kubernetes/pkg/volume"
- volumetest "k8s.io/kubernetes/pkg/volume/testing"
- )
- func TestCanSupport(t *testing.T) {
- tmpDir, err := utiltesting.MkTmpdir("iscsi_test")
- if err != nil {
- t.Fatalf("error creating temp dir: %v", err)
- }
- defer os.RemoveAll(tmpDir)
- plugMgr := volume.VolumePluginMgr{}
- plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, volumetest.NewFakeVolumeHost(t, tmpDir, nil, nil))
- plug, err := plugMgr.FindPluginByName("kubernetes.io/iscsi")
- if err != nil {
- t.Errorf("Can't find the plugin by name")
- }
- if plug.GetPluginName() != "kubernetes.io/iscsi" {
- t.Errorf("Wrong name: %s", plug.GetPluginName())
- }
- if plug.CanSupport(&volume.Spec{Volume: &v1.Volume{VolumeSource: v1.VolumeSource{}}}) {
- t.Errorf("Expected false")
- }
- if plug.CanSupport(&volume.Spec{}) {
- t.Errorf("Expected false")
- }
- if !plug.CanSupport(&volume.Spec{Volume: &v1.Volume{VolumeSource: v1.VolumeSource{ISCSI: &v1.ISCSIVolumeSource{}}}}) {
- t.Errorf("Expected true")
- }
- if plug.CanSupport(&volume.Spec{PersistentVolume: &v1.PersistentVolume{Spec: v1.PersistentVolumeSpec{}}}) {
- t.Errorf("Expected false")
- }
- if plug.CanSupport(&volume.Spec{PersistentVolume: &v1.PersistentVolume{Spec: v1.PersistentVolumeSpec{PersistentVolumeSource: v1.PersistentVolumeSource{}}}}) {
- t.Errorf("Expected false")
- }
- if !plug.CanSupport(&volume.Spec{PersistentVolume: &v1.PersistentVolume{Spec: v1.PersistentVolumeSpec{PersistentVolumeSource: v1.PersistentVolumeSource{ISCSI: &v1.ISCSIPersistentVolumeSource{}}}}}) {
- t.Errorf("Expected true")
- }
- }
- func TestGetAccessModes(t *testing.T) {
- tmpDir, err := utiltesting.MkTmpdir("iscsi_test")
- if err != nil {
- t.Fatalf("error creating temp dir: %v", err)
- }
- defer os.RemoveAll(tmpDir)
- plugMgr := volume.VolumePluginMgr{}
- plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, volumetest.NewFakeVolumeHost(t, tmpDir, nil, nil))
- plug, err := plugMgr.FindPersistentPluginByName("kubernetes.io/iscsi")
- if err != nil {
- t.Errorf("Can't find the plugin by name")
- }
- if !volumetest.ContainsAccessMode(plug.GetAccessModes(), v1.ReadWriteOnce) || !volumetest.ContainsAccessMode(plug.GetAccessModes(), v1.ReadOnlyMany) {
- t.Errorf("Expected two AccessModeTypes: %s and %s", v1.ReadWriteOnce, v1.ReadOnlyMany)
- }
- }
- type fakeDiskManager struct {
- tmpDir string
- attachCalled bool
- detachCalled bool
- }
- func NewFakeDiskManager() *fakeDiskManager {
- return &fakeDiskManager{
- tmpDir: utiltesting.MkTmpdirOrDie("iscsi_test"),
- }
- }
- func (fake *fakeDiskManager) Cleanup() {
- os.RemoveAll(fake.tmpDir)
- }
- func (fake *fakeDiskManager) MakeGlobalPDName(disk iscsiDisk) string {
- return fake.tmpDir
- }
- func (fake *fakeDiskManager) MakeGlobalVDPDName(disk iscsiDisk) string {
- return fake.tmpDir
- }
- func (fake *fakeDiskManager) AttachDisk(b iscsiDiskMounter) (string, error) {
- globalPath := b.manager.MakeGlobalPDName(*b.iscsiDisk)
- err := os.MkdirAll(globalPath, 0750)
- if err != nil {
- return "", err
- }
- // Simulate the global mount so that the fakeMounter returns the
- // expected number of mounts for the attached disk.
- b.mounter.Mount(globalPath, globalPath, b.fsType, nil)
- return "/dev/sdb", nil
- }
- func (fake *fakeDiskManager) DetachDisk(c iscsiDiskUnmounter, mntPath string) error {
- globalPath := c.manager.MakeGlobalPDName(*c.iscsiDisk)
- err := os.RemoveAll(globalPath)
- if err != nil {
- return err
- }
- return nil
- }
- func (fake *fakeDiskManager) DetachBlockISCSIDisk(c iscsiDiskUnmapper, mntPath string) error {
- globalPath := c.manager.MakeGlobalVDPDName(*c.iscsiDisk)
- err := os.RemoveAll(globalPath)
- if err != nil {
- return err
- }
- return nil
- }
- func doTestPlugin(t *testing.T, spec *volume.Spec) {
- tmpDir, err := utiltesting.MkTmpdir("iscsi_test")
- if err != nil {
- t.Fatalf("error creating temp dir: %v", err)
- }
- defer os.RemoveAll(tmpDir)
- plugMgr := volume.VolumePluginMgr{}
- plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, volumetest.NewFakeVolumeHost(t, tmpDir, nil, nil))
- plug, err := plugMgr.FindPluginByName("kubernetes.io/iscsi")
- if err != nil {
- t.Errorf("Can't find the plugin by name")
- }
- fakeManager := NewFakeDiskManager()
- defer fakeManager.Cleanup()
- fakeMounter := mount.NewFakeMounter(nil)
- fakeExec := &testingexec.FakeExec{}
- mounter, err := plug.(*iscsiPlugin).newMounterInternal(spec, types.UID("poduid"), fakeManager, fakeMounter, fakeExec, nil)
- if err != nil {
- t.Errorf("Failed to make a new Mounter: %v", err)
- }
- if mounter == nil {
- t.Error("Got a nil Mounter")
- }
- path := mounter.GetPath()
- expectedPath := fmt.Sprintf("%s/pods/poduid/volumes/kubernetes.io~iscsi/vol1", tmpDir)
- if path != expectedPath {
- t.Errorf("Unexpected path, expected %q, got: %q", expectedPath, path)
- }
- if err := mounter.SetUp(volume.MounterArgs{}); err != nil {
- t.Errorf("Expected success, got: %v", err)
- }
- if _, err := os.Stat(path); err != nil {
- if os.IsNotExist(err) {
- t.Errorf("SetUp() failed, volume path not created: %s", path)
- } else {
- t.Errorf("SetUp() failed: %v", err)
- }
- }
- fakeManager2 := NewFakeDiskManager()
- defer fakeManager2.Cleanup()
- unmounter, err := plug.(*iscsiPlugin).newUnmounterInternal("vol1", types.UID("poduid"), fakeManager2, fakeMounter, fakeExec)
- if err != nil {
- t.Errorf("Failed to make a new Unmounter: %v", err)
- }
- if unmounter == nil {
- t.Error("Got a nil Unmounter")
- }
- if err := unmounter.TearDown(); err != nil {
- t.Errorf("Expected success, got: %v", err)
- }
- if _, err := os.Stat(path); err == nil {
- t.Errorf("TearDown() failed, volume path still exists: %s", path)
- } else if !os.IsNotExist(err) {
- t.Errorf("TearDown() failed: %v", err)
- }
- }
- func TestPluginVolume(t *testing.T) {
- vol := &v1.Volume{
- Name: "vol1",
- VolumeSource: v1.VolumeSource{
- ISCSI: &v1.ISCSIVolumeSource{
- TargetPortal: "127.0.0.1:3260",
- IQN: "iqn.2014-12.server:storage.target01",
- FSType: "ext4",
- Lun: 0,
- },
- },
- }
- doTestPlugin(t, volume.NewSpecFromVolume(vol))
- }
- func TestPluginPersistentVolume(t *testing.T) {
- vol := &v1.PersistentVolume{
- ObjectMeta: metav1.ObjectMeta{
- Name: "vol1",
- },
- Spec: v1.PersistentVolumeSpec{
- PersistentVolumeSource: v1.PersistentVolumeSource{
- ISCSI: &v1.ISCSIPersistentVolumeSource{
- TargetPortal: "127.0.0.1:3260",
- IQN: "iqn.2014-12.server:storage.target01",
- FSType: "ext4",
- Lun: 0,
- },
- },
- },
- }
- doTestPlugin(t, volume.NewSpecFromPersistentVolume(vol, false))
- }
- func TestPersistentClaimReadOnlyFlag(t *testing.T) {
- tmpDir, err := utiltesting.MkTmpdir("iscsi_test")
- if err != nil {
- t.Fatalf("error creating temp dir: %v", err)
- }
- defer os.RemoveAll(tmpDir)
- pv := &v1.PersistentVolume{
- ObjectMeta: metav1.ObjectMeta{
- Name: "pvA",
- },
- Spec: v1.PersistentVolumeSpec{
- PersistentVolumeSource: v1.PersistentVolumeSource{
- ISCSI: &v1.ISCSIPersistentVolumeSource{
- TargetPortal: "127.0.0.1:3260",
- IQN: "iqn.2014-12.server:storage.target01",
- FSType: "ext4",
- Lun: 0,
- },
- },
- ClaimRef: &v1.ObjectReference{
- Name: "claimA",
- },
- },
- }
- claim := &v1.PersistentVolumeClaim{
- ObjectMeta: metav1.ObjectMeta{
- Name: "claimA",
- Namespace: "nsA",
- },
- Spec: v1.PersistentVolumeClaimSpec{
- VolumeName: "pvA",
- },
- Status: v1.PersistentVolumeClaimStatus{
- Phase: v1.ClaimBound,
- },
- }
- client := fake.NewSimpleClientset(pv, claim)
- plugMgr := volume.VolumePluginMgr{}
- plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, volumetest.NewFakeVolumeHost(t, tmpDir, client, nil))
- plug, _ := plugMgr.FindPluginByName(iscsiPluginName)
- // readOnly bool is supplied by persistent-claim volume source when its mounter creates other volumes
- spec := volume.NewSpecFromPersistentVolume(pv, true)
- pod := &v1.Pod{ObjectMeta: metav1.ObjectMeta{UID: types.UID("poduid")}}
- mounter, _ := plug.NewMounter(spec, pod, volume.VolumeOptions{})
- if mounter == nil {
- t.Fatalf("Got a nil Mounter")
- }
- if !mounter.GetAttributes().ReadOnly {
- t.Errorf("Expected true for mounter.IsReadOnly")
- }
- }
- func TestPortalMounter(t *testing.T) {
- if portal := portalMounter("127.0.0.1"); portal != "127.0.0.1:3260" {
- t.Errorf("wrong portal: %s", portal)
- }
- if portal := portalMounter("127.0.0.1:3260"); portal != "127.0.0.1:3260" {
- t.Errorf("wrong portal: %s", portal)
- }
- }
- type testcase struct {
- name string
- defaultNs string
- spec *volume.Spec
- // Expected return of the test
- expectedName string
- expectedNs string
- expectedIface string
- expectedError error
- expectedDiscoveryCHAP bool
- expectedSessionCHAP bool
- }
- func TestGetSecretNameAndNamespaceForPV(t *testing.T) {
- tests := []testcase{
- {
- name: "persistent volume source",
- defaultNs: "default",
- spec: &volume.Spec{
- PersistentVolume: &v1.PersistentVolume{
- Spec: v1.PersistentVolumeSpec{
- PersistentVolumeSource: v1.PersistentVolumeSource{
- ISCSI: &v1.ISCSIPersistentVolumeSource{
- TargetPortal: "127.0.0.1:3260",
- IQN: "iqn.2014-12.server:storage.target01",
- FSType: "ext4",
- Lun: 0,
- SecretRef: &v1.SecretReference{
- Name: "name",
- Namespace: "ns",
- },
- },
- },
- },
- },
- },
- expectedName: "name",
- expectedNs: "ns",
- expectedError: nil,
- },
- {
- name: "persistent volume source without namespace",
- defaultNs: "default",
- spec: &volume.Spec{
- PersistentVolume: &v1.PersistentVolume{
- Spec: v1.PersistentVolumeSpec{
- PersistentVolumeSource: v1.PersistentVolumeSource{
- ISCSI: &v1.ISCSIPersistentVolumeSource{
- TargetPortal: "127.0.0.1:3260",
- IQN: "iqn.2014-12.server:storage.target01",
- FSType: "ext4",
- Lun: 0,
- SecretRef: &v1.SecretReference{
- Name: "name",
- },
- },
- },
- },
- },
- },
- expectedName: "name",
- expectedNs: "default",
- expectedError: nil,
- },
- {
- name: "pod volume source",
- defaultNs: "default",
- spec: &volume.Spec{
- Volume: &v1.Volume{
- VolumeSource: v1.VolumeSource{
- ISCSI: &v1.ISCSIVolumeSource{
- TargetPortal: "127.0.0.1:3260",
- IQN: "iqn.2014-12.server:storage.target01",
- FSType: "ext4",
- Lun: 0,
- },
- },
- },
- },
- expectedName: "",
- expectedNs: "",
- expectedError: nil,
- },
- }
- for _, testcase := range tests {
- resultName, resultNs, err := getISCSISecretNameAndNamespace(testcase.spec, testcase.defaultNs)
- if err != testcase.expectedError || resultName != testcase.expectedName || resultNs != testcase.expectedNs {
- t.Errorf("%s failed: expected err=%v ns=%q name=%q, got %v/%q/%q", testcase.name, testcase.expectedError, testcase.expectedNs, testcase.expectedName,
- err, resultNs, resultName)
- }
- }
- }
- func TestGetISCSIInitiatorInfo(t *testing.T) {
- tests := []testcase{
- {
- name: "persistent volume source",
- spec: &volume.Spec{
- PersistentVolume: &v1.PersistentVolume{
- Spec: v1.PersistentVolumeSpec{
- PersistentVolumeSource: v1.PersistentVolumeSource{
- ISCSI: &v1.ISCSIPersistentVolumeSource{
- TargetPortal: "127.0.0.1:3260",
- IQN: "iqn.2014-12.server:storage.target01",
- FSType: "ext4",
- Lun: 0,
- ISCSIInterface: "tcp",
- },
- },
- },
- },
- },
- expectedIface: "tcp",
- expectedError: nil,
- },
- {
- name: "pod volume source",
- spec: &volume.Spec{
- Volume: &v1.Volume{
- VolumeSource: v1.VolumeSource{
- ISCSI: &v1.ISCSIVolumeSource{
- TargetPortal: "127.0.0.1:3260",
- IQN: "iqn.2014-12.server:storage.target01",
- FSType: "ext4",
- Lun: 0,
- ISCSIInterface: "tcp",
- },
- },
- },
- },
- expectedIface: "tcp",
- expectedError: nil,
- },
- }
- for _, testcase := range tests {
- resultIface, _, err := getISCSIInitiatorInfo(testcase.spec)
- if err != testcase.expectedError || resultIface != testcase.expectedIface {
- t.Errorf("%s failed: expected err=%v iface=%s, got %v/%s", testcase.name, testcase.expectedError, testcase.expectedIface,
- err, resultIface)
- }
- }
- }
- func TestGetISCSICHAP(t *testing.T) {
- tests := []testcase{
- {
- name: "persistent volume source",
- spec: &volume.Spec{
- PersistentVolume: &v1.PersistentVolume{
- Spec: v1.PersistentVolumeSpec{
- PersistentVolumeSource: v1.PersistentVolumeSource{
- ISCSI: &v1.ISCSIPersistentVolumeSource{
- DiscoveryCHAPAuth: true,
- SessionCHAPAuth: true,
- },
- },
- },
- },
- },
- expectedDiscoveryCHAP: true,
- expectedSessionCHAP: true,
- expectedError: nil,
- },
- {
- name: "pod volume source",
- spec: &volume.Spec{
- Volume: &v1.Volume{
- VolumeSource: v1.VolumeSource{
- ISCSI: &v1.ISCSIVolumeSource{
- DiscoveryCHAPAuth: true,
- SessionCHAPAuth: true,
- },
- },
- },
- },
- expectedDiscoveryCHAP: true,
- expectedSessionCHAP: true,
- expectedError: nil,
- },
- {
- name: "no volume",
- spec: &volume.Spec{},
- expectedDiscoveryCHAP: false,
- expectedSessionCHAP: false,
- expectedError: fmt.Errorf("Spec does not reference an ISCSI volume type"),
- },
- }
- for _, testcase := range tests {
- resultDiscoveryCHAP, err := getISCSIDiscoveryCHAPInfo(testcase.spec)
- resultSessionCHAP, err := getISCSISessionCHAPInfo(testcase.spec)
- switch testcase.name {
- case "no volume":
- if err.Error() != testcase.expectedError.Error() || resultDiscoveryCHAP != testcase.expectedDiscoveryCHAP || resultSessionCHAP != testcase.expectedSessionCHAP {
- t.Errorf("%s failed: expected err=%v DiscoveryCHAP=%v SessionCHAP=%v, got %v/%v/%v",
- testcase.name, testcase.expectedError, testcase.expectedDiscoveryCHAP, testcase.expectedSessionCHAP,
- err, resultDiscoveryCHAP, resultSessionCHAP)
- }
- default:
- if err != testcase.expectedError || resultDiscoveryCHAP != testcase.expectedDiscoveryCHAP || resultSessionCHAP != testcase.expectedSessionCHAP {
- t.Errorf("%s failed: expected err=%v DiscoveryCHAP=%v SessionCHAP=%v, got %v/%v/%v", testcase.name, testcase.expectedError, testcase.expectedDiscoveryCHAP, testcase.expectedSessionCHAP,
- err, resultDiscoveryCHAP, resultSessionCHAP)
- }
- }
- }
- }
- func TestGetVolumeSpec(t *testing.T) {
- path := "plugins/kubernetes.io/iscsi/volumeDevices/iface-default/127.0.0.1:3260-iqn.2014-12.server:storage.target01-lun-0"
- spec, _ := getVolumeSpecFromGlobalMapPath("test", path)
- portal := spec.PersistentVolume.Spec.PersistentVolumeSource.ISCSI.TargetPortal
- if portal != "127.0.0.1:3260" {
- t.Errorf("wrong portal: %v", portal)
- }
- iqn := spec.PersistentVolume.Spec.PersistentVolumeSource.ISCSI.IQN
- if iqn != "iqn.2014-12.server:storage.target01" {
- t.Errorf("wrong iqn: %v", iqn)
- }
- lun := spec.PersistentVolume.Spec.PersistentVolumeSource.ISCSI.Lun
- if lun != 0 {
- t.Errorf("wrong lun: %v", lun)
- }
- iface := spec.PersistentVolume.Spec.PersistentVolumeSource.ISCSI.ISCSIInterface
- if iface != "default" {
- t.Errorf("wrong ISCSIInterface: %v", iface)
- }
- }
- func TestGetVolumeSpec_no_lun(t *testing.T) {
- path := "plugins/kubernetes.io/iscsi/volumeDevices/iface-default/127.0.0.1:3260-iqn.2014-12.server:storage.target01"
- _, err := getVolumeSpecFromGlobalMapPath("test", path)
- if !strings.Contains(err.Error(), "malformatted mnt path") {
- t.Errorf("should get error: malformatted mnt path")
- }
- }
- func TestGetVolumeSpec_no_iface(t *testing.T) {
- path := "plugins/kubernetes.io/iscsi/volumeDevices/default/127.0.0.1:3260-iqn.2014-12.server:storage.target01-lun-0"
- _, err := getVolumeSpecFromGlobalMapPath("test", path)
- if !strings.Contains(err.Error(), "failed to retrieve iface") {
- t.Errorf("should get error: failed to retrieve iface")
- }
- }
|