123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926 |
- package controller
- import (
- "context"
- "encoding/json"
- "fmt"
- "math"
- "math/rand"
- "net/http/httptest"
- "sort"
- "sync"
- "testing"
- "time"
- apps "k8s.io/api/apps/v1"
- v1 "k8s.io/api/core/v1"
- apiequality "k8s.io/apimachinery/pkg/api/equality"
- metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
- "k8s.io/apimachinery/pkg/runtime"
- "k8s.io/apimachinery/pkg/runtime/schema"
- "k8s.io/apimachinery/pkg/util/clock"
- "k8s.io/apimachinery/pkg/util/sets"
- "k8s.io/apimachinery/pkg/util/uuid"
- clientset "k8s.io/client-go/kubernetes"
- "k8s.io/client-go/kubernetes/fake"
- clientscheme "k8s.io/client-go/kubernetes/scheme"
- restclient "k8s.io/client-go/rest"
- "k8s.io/client-go/tools/cache"
- "k8s.io/client-go/tools/record"
- utiltesting "k8s.io/client-go/util/testing"
- _ "k8s.io/kubernetes/pkg/apis/core/install"
- "k8s.io/kubernetes/pkg/controller/testutil"
- "k8s.io/kubernetes/pkg/securitycontext"
- "github.com/stretchr/testify/assert"
- )
- func NewFakeControllerExpectationsLookup(ttl time.Duration) (*ControllerExpectations, *clock.FakeClock) {
- fakeTime := time.Date(2009, time.November, 10, 23, 0, 0, 0, time.UTC)
- fakeClock := clock.NewFakeClock(fakeTime)
- ttlPolicy := &cache.TTLPolicy{TTL: ttl, Clock: fakeClock}
- ttlStore := cache.NewFakeExpirationStore(
- ExpKeyFunc, nil, ttlPolicy, fakeClock)
- return &ControllerExpectations{ttlStore}, fakeClock
- }
- func newReplicationController(replicas int) *v1.ReplicationController {
- rc := &v1.ReplicationController{
- TypeMeta: metav1.TypeMeta{APIVersion: "v1"},
- ObjectMeta: metav1.ObjectMeta{
- UID: uuid.NewUUID(),
- Name: "foobar",
- Namespace: metav1.NamespaceDefault,
- ResourceVersion: "18",
- },
- Spec: v1.ReplicationControllerSpec{
- Replicas: func() *int32 { i := int32(replicas); return &i }(),
- Selector: map[string]string{"foo": "bar"},
- Template: &v1.PodTemplateSpec{
- ObjectMeta: metav1.ObjectMeta{
- Labels: map[string]string{
- "name": "foo",
- "type": "production",
- },
- },
- Spec: v1.PodSpec{
- Containers: []v1.Container{
- {
- Image: "foo/bar",
- TerminationMessagePath: v1.TerminationMessagePathDefault,
- ImagePullPolicy: v1.PullIfNotPresent,
- SecurityContext: securitycontext.ValidSecurityContextWithContainerDefaults(),
- },
- },
- RestartPolicy: v1.RestartPolicyAlways,
- DNSPolicy: v1.DNSDefault,
- NodeSelector: map[string]string{
- "baz": "blah",
- },
- },
- },
- },
- }
- return rc
- }
- func newPodList(store cache.Store, count int, status v1.PodPhase, rc *v1.ReplicationController) *v1.PodList {
- pods := []v1.Pod{}
- for i := 0; i < count; i++ {
- newPod := v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: fmt.Sprintf("pod%d", i),
- Labels: rc.Spec.Selector,
- Namespace: rc.Namespace,
- },
- Status: v1.PodStatus{Phase: status},
- }
- if store != nil {
- store.Add(&newPod)
- }
- pods = append(pods, newPod)
- }
- return &v1.PodList{
- Items: pods,
- }
- }
- func newReplicaSet(name string, replicas int) *apps.ReplicaSet {
- return &apps.ReplicaSet{
- TypeMeta: metav1.TypeMeta{APIVersion: "v1"},
- ObjectMeta: metav1.ObjectMeta{
- UID: uuid.NewUUID(),
- Name: name,
- Namespace: metav1.NamespaceDefault,
- ResourceVersion: "18",
- },
- Spec: apps.ReplicaSetSpec{
- Replicas: func() *int32 { i := int32(replicas); return &i }(),
- Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}},
- Template: v1.PodTemplateSpec{
- ObjectMeta: metav1.ObjectMeta{
- Labels: map[string]string{
- "name": "foo",
- "type": "production",
- },
- },
- Spec: v1.PodSpec{
- Containers: []v1.Container{
- {
- Image: "foo/bar",
- TerminationMessagePath: v1.TerminationMessagePathDefault,
- ImagePullPolicy: v1.PullIfNotPresent,
- SecurityContext: securitycontext.ValidSecurityContextWithContainerDefaults(),
- },
- },
- RestartPolicy: v1.RestartPolicyAlways,
- DNSPolicy: v1.DNSDefault,
- NodeSelector: map[string]string{
- "baz": "blah",
- },
- },
- },
- },
- }
- }
- func TestControllerExpectations(t *testing.T) {
- ttl := 30 * time.Second
- e, fakeClock := NewFakeControllerExpectationsLookup(ttl)
-
-
-
- adds, dels := 10, 30
- rc := newReplicationController(1)
-
- rcKey, err := KeyFunc(rc)
- assert.NoError(t, err, "Couldn't get key for object %#v: %v", rc, err)
- e.SetExpectations(rcKey, adds, dels)
- var wg sync.WaitGroup
- for i := 0; i < adds+1; i++ {
- wg.Add(1)
- go func() {
-
-
- e.CreationObserved(rcKey)
- wg.Done()
- }()
- }
- wg.Wait()
-
- assert.False(t, e.SatisfiedExpectations(rcKey), "Rc will sync before expectations are met")
- for i := 0; i < dels+1; i++ {
- wg.Add(1)
- go func() {
- e.DeletionObserved(rcKey)
- wg.Done()
- }()
- }
- wg.Wait()
-
- podExp, exists, err := e.GetExpectations(rcKey)
- assert.NoError(t, err, "Could not get expectations for rc, exists %v and err %v", exists, err)
- assert.True(t, exists, "Could not get expectations for rc, exists %v and err %v", exists, err)
- add, del := podExp.GetExpectations()
- assert.Equal(t, int64(-1), add, "Unexpected pod expectations %#v", podExp)
- assert.Equal(t, int64(-1), del, "Unexpected pod expectations %#v", podExp)
- assert.True(t, e.SatisfiedExpectations(rcKey), "Expectations are met but the rc will not sync")
-
- e.SetExpectations(rcKey, 1, 2)
- podExp, exists, err = e.GetExpectations(rcKey)
- assert.NoError(t, err, "Could not get expectations for rc, exists %v and err %v", exists, err)
- assert.True(t, exists, "Could not get expectations for rc, exists %v and err %v", exists, err)
- add, del = podExp.GetExpectations()
- assert.Equal(t, int64(1), add, "Unexpected pod expectations %#v", podExp)
- assert.Equal(t, int64(2), del, "Unexpected pod expectations %#v", podExp)
-
- fakeClock.Step(ttl + 1)
- assert.True(t, e.SatisfiedExpectations(rcKey),
- "Expectations should have expired but didn't")
- }
- func TestUIDExpectations(t *testing.T) {
- uidExp := NewUIDTrackingControllerExpectations(NewControllerExpectations())
- rcList := []*v1.ReplicationController{
- newReplicationController(2),
- newReplicationController(1),
- newReplicationController(0),
- newReplicationController(5),
- }
- rcToPods := map[string][]string{}
- rcKeys := []string{}
- for i := range rcList {
- rc := rcList[i]
- rcName := fmt.Sprintf("rc-%v", i)
- rc.Name = rcName
- rc.Spec.Selector[rcName] = rcName
- podList := newPodList(nil, 5, v1.PodRunning, rc)
- rcKey, err := KeyFunc(rc)
- if err != nil {
- t.Fatalf("Couldn't get key for object %#v: %v", rc, err)
- }
- rcKeys = append(rcKeys, rcKey)
- rcPodNames := []string{}
- for i := range podList.Items {
- p := &podList.Items[i]
- p.Name = fmt.Sprintf("%v-%v", p.Name, rc.Name)
- rcPodNames = append(rcPodNames, PodKey(p))
- }
- rcToPods[rcKey] = rcPodNames
- uidExp.ExpectDeletions(rcKey, rcPodNames)
- }
- for i := range rcKeys {
- j := rand.Intn(i + 1)
- rcKeys[i], rcKeys[j] = rcKeys[j], rcKeys[i]
- }
- for _, rcKey := range rcKeys {
- assert.False(t, uidExp.SatisfiedExpectations(rcKey),
- "Controller %v satisfied expectations before deletion", rcKey)
- for _, p := range rcToPods[rcKey] {
- uidExp.DeletionObserved(rcKey, p)
- }
- assert.True(t, uidExp.SatisfiedExpectations(rcKey),
- "Controller %v didn't satisfy expectations after deletion", rcKey)
- uidExp.DeleteExpectations(rcKey)
- assert.Nil(t, uidExp.GetUIDs(rcKey),
- "Failed to delete uid expectations for %v", rcKey)
- }
- }
- func TestCreatePods(t *testing.T) {
- ns := metav1.NamespaceDefault
- body := runtime.EncodeOrDie(clientscheme.Codecs.LegacyCodec(v1.SchemeGroupVersion), &v1.Pod{ObjectMeta: metav1.ObjectMeta{Name: "empty_pod"}})
- fakeHandler := utiltesting.FakeHandler{
- StatusCode: 200,
- ResponseBody: string(body),
- }
- testServer := httptest.NewServer(&fakeHandler)
- defer testServer.Close()
- clientset := clientset.NewForConfigOrDie(&restclient.Config{Host: testServer.URL, ContentConfig: restclient.ContentConfig{GroupVersion: &schema.GroupVersion{Group: "", Version: "v1"}}})
- podControl := RealPodControl{
- KubeClient: clientset,
- Recorder: &record.FakeRecorder{},
- }
- controllerSpec := newReplicationController(1)
-
- err := podControl.CreatePods(ns, controllerSpec.Spec.Template, controllerSpec)
- assert.NoError(t, err, "unexpected error: %v", err)
- expectedPod := v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Labels: controllerSpec.Spec.Template.Labels,
- GenerateName: fmt.Sprintf("%s-", controllerSpec.Name),
- },
- Spec: controllerSpec.Spec.Template.Spec,
- }
- fakeHandler.ValidateRequest(t, "/api/v1/namespaces/default/pods", "POST", nil)
- var actualPod = &v1.Pod{}
- err = json.Unmarshal([]byte(fakeHandler.RequestBody), actualPod)
- assert.NoError(t, err, "unexpected error: %v", err)
- assert.True(t, apiequality.Semantic.DeepDerivative(&expectedPod, actualPod),
- "Body: %s", fakeHandler.RequestBody)
- }
- func TestDeletePodsAllowsMissing(t *testing.T) {
- fakeClient := fake.NewSimpleClientset()
- podControl := RealPodControl{
- KubeClient: fakeClient,
- Recorder: &record.FakeRecorder{},
- }
- controllerSpec := newReplicationController(1)
- err := podControl.DeletePod("namespace-name", "podName", controllerSpec)
- assert.NoError(t, err, "unexpected error: %v", err)
- }
- func TestActivePodFiltering(t *testing.T) {
-
- rc := newReplicationController(0)
- podList := newPodList(nil, 5, v1.PodRunning, rc)
- podList.Items[0].Status.Phase = v1.PodSucceeded
- podList.Items[1].Status.Phase = v1.PodFailed
- expectedNames := sets.NewString()
- for _, pod := range podList.Items[2:] {
- expectedNames.Insert(pod.Name)
- }
- var podPointers []*v1.Pod
- for i := range podList.Items {
- podPointers = append(podPointers, &podList.Items[i])
- }
- got := FilterActivePods(podPointers)
- gotNames := sets.NewString()
- for _, pod := range got {
- gotNames.Insert(pod.Name)
- }
- assert.Equal(t, 0, expectedNames.Difference(gotNames).Len(),
- "expected %v, got %v", expectedNames.List(), gotNames.List())
- assert.Equal(t, 0, gotNames.Difference(expectedNames).Len(),
- "expected %v, got %v", expectedNames.List(), gotNames.List())
- }
- func TestSortingActivePods(t *testing.T) {
- numPods := 9
-
- rc := newReplicationController(0)
- podList := newPodList(nil, numPods, v1.PodRunning, rc)
- pods := make([]*v1.Pod, len(podList.Items))
- for i := range podList.Items {
- pods[i] = &podList.Items[i]
- }
-
- pods[0].Spec.NodeName = ""
- pods[0].Status.Phase = v1.PodPending
-
- pods[1].Spec.NodeName = "bar"
- pods[1].Status.Phase = v1.PodPending
-
- pods[2].Spec.NodeName = "foo"
- pods[2].Status.Phase = v1.PodUnknown
-
- pods[3].Spec.NodeName = "foo"
- pods[3].Status.Phase = v1.PodRunning
-
- now := metav1.Now()
- pods[4].Spec.NodeName = "foo"
- pods[4].Status.Phase = v1.PodRunning
- pods[4].Status.Conditions = []v1.PodCondition{{Type: v1.PodReady, Status: v1.ConditionTrue}}
- pods[4].Status.ContainerStatuses = []v1.ContainerStatus{{RestartCount: 3}, {RestartCount: 0}}
-
- pods[5].Spec.NodeName = "foo"
- pods[5].Status.Phase = v1.PodRunning
- pods[5].Status.Conditions = []v1.PodCondition{{Type: v1.PodReady, Status: v1.ConditionTrue, LastTransitionTime: now}}
- pods[5].Status.ContainerStatuses = []v1.ContainerStatus{{RestartCount: 3}, {RestartCount: 0}}
-
- then := metav1.Time{Time: now.AddDate(0, -1, 0)}
- pods[6].Spec.NodeName = "foo"
- pods[6].Status.Phase = v1.PodRunning
- pods[6].Status.Conditions = []v1.PodCondition{{Type: v1.PodReady, Status: v1.ConditionTrue, LastTransitionTime: then}}
- pods[6].Status.ContainerStatuses = []v1.ContainerStatus{{RestartCount: 3}, {RestartCount: 0}}
-
- pods[7].Spec.NodeName = "foo"
- pods[7].Status.Phase = v1.PodRunning
- pods[7].Status.Conditions = []v1.PodCondition{{Type: v1.PodReady, Status: v1.ConditionTrue, LastTransitionTime: then}}
- pods[7].Status.ContainerStatuses = []v1.ContainerStatus{{RestartCount: 2}, {RestartCount: 1}}
- pods[7].CreationTimestamp = now
-
- pods[8].Spec.NodeName = "foo"
- pods[8].Status.Phase = v1.PodRunning
- pods[8].Status.Conditions = []v1.PodCondition{{Type: v1.PodReady, Status: v1.ConditionTrue, LastTransitionTime: then}}
- pods[8].Status.ContainerStatuses = []v1.ContainerStatus{{RestartCount: 2}, {RestartCount: 1}}
- pods[8].CreationTimestamp = then
- getOrder := func(pods []*v1.Pod) []string {
- names := make([]string, len(pods))
- for i := range pods {
- names[i] = pods[i].Name
- }
- return names
- }
- expected := getOrder(pods)
- for i := 0; i < 20; i++ {
- idx := rand.Perm(numPods)
- randomizedPods := make([]*v1.Pod, numPods)
- for j := 0; j < numPods; j++ {
- randomizedPods[j] = pods[idx[j]]
- }
- sort.Sort(ActivePods(randomizedPods))
- actual := getOrder(randomizedPods)
- assert.EqualValues(t, expected, actual, "expected %v, got %v", expected, actual)
- }
- }
- func TestSortingActivePodsWithRanks(t *testing.T) {
- now := metav1.Now()
- then := metav1.Time{Time: now.AddDate(0, -1, 0)}
- zeroTime := metav1.Time{}
- pod := func(podName, nodeName string, phase v1.PodPhase, ready bool, restarts int32, readySince metav1.Time, created metav1.Time) *v1.Pod {
- var conditions []v1.PodCondition
- var containerStatuses []v1.ContainerStatus
- if ready {
- conditions = []v1.PodCondition{{Type: v1.PodReady, Status: v1.ConditionTrue, LastTransitionTime: readySince}}
- containerStatuses = []v1.ContainerStatus{{RestartCount: restarts}}
- }
- return &v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- CreationTimestamp: created,
- Name: podName,
- },
- Spec: v1.PodSpec{NodeName: nodeName},
- Status: v1.PodStatus{
- Conditions: conditions,
- ContainerStatuses: containerStatuses,
- Phase: phase,
- },
- }
- }
- var (
- unscheduledPod = pod("unscheduled", "", v1.PodPending, false, 0, zeroTime, zeroTime)
- scheduledPendingPod = pod("pending", "node", v1.PodPending, false, 0, zeroTime, zeroTime)
- unknownPhasePod = pod("unknown-phase", "node", v1.PodUnknown, false, 0, zeroTime, zeroTime)
- runningNotReadyPod = pod("not-ready", "node", v1.PodRunning, false, 0, zeroTime, zeroTime)
- runningReadyNoLastTransitionTimePod = pod("ready-no-last-transition-time", "node", v1.PodRunning, true, 0, zeroTime, zeroTime)
- runningReadyNow = pod("ready-now", "node", v1.PodRunning, true, 0, now, now)
- runningReadyThen = pod("ready-then", "node", v1.PodRunning, true, 0, then, then)
- runningReadyNowHighRestarts = pod("ready-high-restarts", "node", v1.PodRunning, true, 9001, now, now)
- runningReadyNowCreatedThen = pod("ready-now-created-then", "node", v1.PodRunning, true, 0, now, then)
- )
- equalityTests := []*v1.Pod{
- unscheduledPod,
- scheduledPendingPod,
- unknownPhasePod,
- runningNotReadyPod,
- runningReadyNowCreatedThen,
- runningReadyNow,
- runningReadyThen,
- runningReadyNowHighRestarts,
- runningReadyNowCreatedThen,
- }
- for _, pod := range equalityTests {
- podsWithRanks := ActivePodsWithRanks{
- Pods: []*v1.Pod{pod, pod},
- Rank: []int{1, 1},
- }
- if podsWithRanks.Less(0, 1) || podsWithRanks.Less(1, 0) {
- t.Errorf("expected pod %q not to be less than than itself", pod.Name)
- }
- }
- type podWithRank struct {
- pod *v1.Pod
- rank int
- }
- inequalityTests := []struct {
- lesser, greater podWithRank
- }{
- {podWithRank{unscheduledPod, 1}, podWithRank{scheduledPendingPod, 2}},
- {podWithRank{unscheduledPod, 2}, podWithRank{scheduledPendingPod, 1}},
- {podWithRank{scheduledPendingPod, 1}, podWithRank{unknownPhasePod, 2}},
- {podWithRank{unknownPhasePod, 1}, podWithRank{runningNotReadyPod, 2}},
- {podWithRank{runningNotReadyPod, 1}, podWithRank{runningReadyNoLastTransitionTimePod, 1}},
- {podWithRank{runningReadyNoLastTransitionTimePod, 1}, podWithRank{runningReadyNow, 1}},
- {podWithRank{runningReadyNow, 2}, podWithRank{runningReadyNoLastTransitionTimePod, 1}},
- {podWithRank{runningReadyNow, 1}, podWithRank{runningReadyThen, 1}},
- {podWithRank{runningReadyNow, 2}, podWithRank{runningReadyThen, 1}},
- {podWithRank{runningReadyNowHighRestarts, 1}, podWithRank{runningReadyNow, 1}},
- {podWithRank{runningReadyNow, 2}, podWithRank{runningReadyNowHighRestarts, 1}},
- {podWithRank{runningReadyNow, 1}, podWithRank{runningReadyNowCreatedThen, 1}},
- {podWithRank{runningReadyNowCreatedThen, 2}, podWithRank{runningReadyNow, 1}},
- }
- for _, test := range inequalityTests {
- podsWithRanks := ActivePodsWithRanks{
- Pods: []*v1.Pod{test.lesser.pod, test.greater.pod},
- Rank: []int{test.lesser.rank, test.greater.rank},
- }
- if !podsWithRanks.Less(0, 1) {
- t.Errorf("expected pod %q with rank %v to be less than %q with rank %v", podsWithRanks.Pods[0].Name, podsWithRanks.Rank[0], podsWithRanks.Pods[1].Name, podsWithRanks.Rank[1])
- }
- if podsWithRanks.Less(1, 0) {
- t.Errorf("expected pod %q with rank %v not to be less than %v with rank %v", podsWithRanks.Pods[1].Name, podsWithRanks.Rank[1], podsWithRanks.Pods[0].Name, podsWithRanks.Rank[0])
- }
- }
- }
- func TestActiveReplicaSetsFiltering(t *testing.T) {
- var replicaSets []*apps.ReplicaSet
- replicaSets = append(replicaSets, newReplicaSet("zero", 0))
- replicaSets = append(replicaSets, nil)
- replicaSets = append(replicaSets, newReplicaSet("foo", 1))
- replicaSets = append(replicaSets, newReplicaSet("bar", 2))
- expectedNames := sets.NewString()
- for _, rs := range replicaSets[2:] {
- expectedNames.Insert(rs.Name)
- }
- got := FilterActiveReplicaSets(replicaSets)
- gotNames := sets.NewString()
- for _, rs := range got {
- gotNames.Insert(rs.Name)
- }
- assert.Equal(t, 0, expectedNames.Difference(gotNames).Len(),
- "expected %v, got %v", expectedNames.List(), gotNames.List())
- assert.Equal(t, 0, gotNames.Difference(expectedNames).Len(),
- "expected %v, got %v", expectedNames.List(), gotNames.List())
- }
- func TestComputeHash(t *testing.T) {
- collisionCount := int32(1)
- otherCollisionCount := int32(2)
- maxCollisionCount := int32(math.MaxInt32)
- tests := []struct {
- name string
- template *v1.PodTemplateSpec
- collisionCount *int32
- otherCollisionCount *int32
- }{
- {
- name: "simple",
- template: &v1.PodTemplateSpec{},
- collisionCount: &collisionCount,
- otherCollisionCount: &otherCollisionCount,
- },
- {
- name: "using math.MaxInt64",
- template: &v1.PodTemplateSpec{},
- collisionCount: nil,
- otherCollisionCount: &maxCollisionCount,
- },
- }
- for _, test := range tests {
- hash := ComputeHash(test.template, test.collisionCount)
- otherHash := ComputeHash(test.template, test.otherCollisionCount)
- assert.NotEqual(t, hash, otherHash, "expected different hashes but got the same: %d", hash)
- }
- }
- func TestRemoveTaintOffNode(t *testing.T) {
- tests := []struct {
- name string
- nodeHandler *testutil.FakeNodeHandler
- nodeName string
- taintsToRemove []*v1.Taint
- expectedTaints []v1.Taint
- requestCount int
- }{
- {
- name: "remove one taint from node",
- nodeHandler: &testutil.FakeNodeHandler{
- Existing: []*v1.Node{
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "node1",
- },
- Spec: v1.NodeSpec{
- Taints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- },
- },
- },
- },
- Clientset: fake.NewSimpleClientset(&v1.PodList{Items: []v1.Pod{*testutil.NewPod("pod0", "node0")}}),
- },
- nodeName: "node1",
- taintsToRemove: []*v1.Taint{
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- },
- expectedTaints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- },
- requestCount: 4,
- },
- {
- name: "remove multiple taints from node",
- nodeHandler: &testutil.FakeNodeHandler{
- Existing: []*v1.Node{
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "node1",
- },
- Spec: v1.NodeSpec{
- Taints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- {Key: "key3", Value: "value3", Effect: "NoSchedule"},
- {Key: "key4", Value: "value4", Effect: "NoExecute"},
- },
- },
- },
- },
- Clientset: fake.NewSimpleClientset(&v1.PodList{Items: []v1.Pod{*testutil.NewPod("pod0", "node0")}}),
- },
- nodeName: "node1",
- taintsToRemove: []*v1.Taint{
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- {Key: "key3", Value: "value3", Effect: "NoSchedule"},
- },
- expectedTaints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- {Key: "key4", Value: "value4", Effect: "NoExecute"},
- },
- requestCount: 4,
- },
- {
- name: "remove no-exist taints from node",
- nodeHandler: &testutil.FakeNodeHandler{
- Existing: []*v1.Node{
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "node1",
- },
- Spec: v1.NodeSpec{
- Taints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- },
- },
- },
- },
- Clientset: fake.NewSimpleClientset(&v1.PodList{Items: []v1.Pod{*testutil.NewPod("pod0", "node0")}}),
- },
- nodeName: "node1",
- taintsToRemove: []*v1.Taint{
- {Key: "key3", Value: "value3", Effect: "NoSchedule"},
- },
- expectedTaints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- },
- requestCount: 2,
- },
- {
- name: "remove taint from node without taints",
- nodeHandler: &testutil.FakeNodeHandler{
- Existing: []*v1.Node{
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "node1",
- },
- },
- },
- Clientset: fake.NewSimpleClientset(&v1.PodList{Items: []v1.Pod{*testutil.NewPod("pod0", "node0")}}),
- },
- nodeName: "node1",
- taintsToRemove: []*v1.Taint{
- {Key: "key3", Value: "value3", Effect: "NoSchedule"},
- },
- expectedTaints: nil,
- requestCount: 2,
- },
- {
- name: "remove empty taint list from node without taints",
- nodeHandler: &testutil.FakeNodeHandler{
- Existing: []*v1.Node{
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "node1",
- },
- },
- },
- Clientset: fake.NewSimpleClientset(&v1.PodList{Items: []v1.Pod{*testutil.NewPod("pod0", "node0")}}),
- },
- nodeName: "node1",
- taintsToRemove: []*v1.Taint{},
- expectedTaints: nil,
- requestCount: 2,
- },
- {
- name: "remove empty taint list from node",
- nodeHandler: &testutil.FakeNodeHandler{
- Existing: []*v1.Node{
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "node1",
- },
- Spec: v1.NodeSpec{
- Taints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- },
- },
- },
- },
- Clientset: fake.NewSimpleClientset(&v1.PodList{Items: []v1.Pod{*testutil.NewPod("pod0", "node0")}}),
- },
- nodeName: "node1",
- taintsToRemove: []*v1.Taint{},
- expectedTaints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- },
- requestCount: 2,
- },
- }
- for _, test := range tests {
- node, _ := test.nodeHandler.Get(context.TODO(), test.nodeName, metav1.GetOptions{})
- err := RemoveTaintOffNode(test.nodeHandler, test.nodeName, node, test.taintsToRemove...)
- assert.NoError(t, err, "%s: RemoveTaintOffNode() error = %v", test.name, err)
- node, _ = test.nodeHandler.Get(context.TODO(), test.nodeName, metav1.GetOptions{})
- assert.EqualValues(t, test.expectedTaints, node.Spec.Taints,
- "%s: failed to remove taint off node: expected %+v, got %+v",
- test.name, test.expectedTaints, node.Spec.Taints)
- assert.Equal(t, test.requestCount, test.nodeHandler.RequestCount,
- "%s: unexpected request count: expected %+v, got %+v",
- test.name, test.requestCount, test.nodeHandler.RequestCount)
- }
- }
- func TestAddOrUpdateTaintOnNode(t *testing.T) {
- tests := []struct {
- name string
- nodeHandler *testutil.FakeNodeHandler
- nodeName string
- taintsToAdd []*v1.Taint
- expectedTaints []v1.Taint
- requestCount int
- }{
- {
- name: "add one taint on node",
- nodeHandler: &testutil.FakeNodeHandler{
- Existing: []*v1.Node{
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "node1",
- },
- Spec: v1.NodeSpec{
- Taints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- },
- },
- },
- },
- Clientset: fake.NewSimpleClientset(&v1.PodList{Items: []v1.Pod{*testutil.NewPod("pod0", "node0")}}),
- },
- nodeName: "node1",
- taintsToAdd: []*v1.Taint{
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- },
- expectedTaints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- },
- requestCount: 3,
- },
- {
- name: "add multiple taints to node",
- nodeHandler: &testutil.FakeNodeHandler{
- Existing: []*v1.Node{
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "node1",
- },
- Spec: v1.NodeSpec{
- Taints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- },
- },
- },
- },
- Clientset: fake.NewSimpleClientset(&v1.PodList{Items: []v1.Pod{*testutil.NewPod("pod0", "node0")}}),
- },
- nodeName: "node1",
- taintsToAdd: []*v1.Taint{
- {Key: "key3", Value: "value3", Effect: "NoSchedule"},
- {Key: "key4", Value: "value4", Effect: "NoExecute"},
- },
- expectedTaints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- {Key: "key3", Value: "value3", Effect: "NoSchedule"},
- {Key: "key4", Value: "value4", Effect: "NoExecute"},
- },
- requestCount: 3,
- },
- {
- name: "add exist taints to node",
- nodeHandler: &testutil.FakeNodeHandler{
- Existing: []*v1.Node{
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "node1",
- },
- Spec: v1.NodeSpec{
- Taints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- },
- },
- },
- },
- Clientset: fake.NewSimpleClientset(&v1.PodList{Items: []v1.Pod{*testutil.NewPod("pod0", "node0")}}),
- },
- nodeName: "node1",
- taintsToAdd: []*v1.Taint{
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- },
- expectedTaints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- },
- requestCount: 2,
- },
- {
- name: "add taint to node without taints",
- nodeHandler: &testutil.FakeNodeHandler{
- Existing: []*v1.Node{
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "node1",
- },
- },
- },
- Clientset: fake.NewSimpleClientset(&v1.PodList{Items: []v1.Pod{*testutil.NewPod("pod0", "node0")}}),
- },
- nodeName: "node1",
- taintsToAdd: []*v1.Taint{
- {Key: "key3", Value: "value3", Effect: "NoSchedule"},
- },
- expectedTaints: []v1.Taint{
- {Key: "key3", Value: "value3", Effect: "NoSchedule"},
- },
- requestCount: 3,
- },
- {
- name: "add empty taint list to node without taints",
- nodeHandler: &testutil.FakeNodeHandler{
- Existing: []*v1.Node{
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "node1",
- },
- },
- },
- Clientset: fake.NewSimpleClientset(&v1.PodList{Items: []v1.Pod{*testutil.NewPod("pod0", "node0")}}),
- },
- nodeName: "node1",
- taintsToAdd: []*v1.Taint{},
- expectedTaints: nil,
- requestCount: 1,
- },
- {
- name: "add empty taint list to node",
- nodeHandler: &testutil.FakeNodeHandler{
- Existing: []*v1.Node{
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "node1",
- },
- Spec: v1.NodeSpec{
- Taints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- },
- },
- },
- },
- Clientset: fake.NewSimpleClientset(&v1.PodList{Items: []v1.Pod{*testutil.NewPod("pod0", "node0")}}),
- },
- nodeName: "node1",
- taintsToAdd: []*v1.Taint{},
- expectedTaints: []v1.Taint{
- {Key: "key1", Value: "value1", Effect: "NoSchedule"},
- {Key: "key2", Value: "value2", Effect: "NoExecute"},
- },
- requestCount: 1,
- },
- }
- for _, test := range tests {
- err := AddOrUpdateTaintOnNode(test.nodeHandler, test.nodeName, test.taintsToAdd...)
- assert.NoError(t, err, "%s: AddOrUpdateTaintOnNode() error = %v", test.name, err)
- node, _ := test.nodeHandler.Get(context.TODO(), test.nodeName, metav1.GetOptions{})
- assert.EqualValues(t, test.expectedTaints, node.Spec.Taints,
- "%s: failed to add taint to node: expected %+v, got %+v",
- test.name, test.expectedTaints, node.Spec.Taints)
- assert.Equal(t, test.requestCount, test.nodeHandler.RequestCount,
- "%s: unexpected request count: expected %+v, got %+v",
- test.name, test.requestCount, test.nodeHandler.RequestCount)
- }
- }
|