configfiles_test.go 5.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215
  1. /*
  2. Copyright 2017 The Kubernetes Authors.
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. http://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package configfiles
  14. import (
  15. "fmt"
  16. "path/filepath"
  17. "testing"
  18. apiequality "k8s.io/apimachinery/pkg/api/equality"
  19. kubeletconfigv1beta1 "k8s.io/kubelet/config/v1beta1"
  20. kubeletconfig "k8s.io/kubernetes/pkg/kubelet/apis/config"
  21. kubeletscheme "k8s.io/kubernetes/pkg/kubelet/apis/config/scheme"
  22. utilfiles "k8s.io/kubernetes/pkg/kubelet/kubeletconfig/util/files"
  23. utiltest "k8s.io/kubernetes/pkg/kubelet/kubeletconfig/util/test"
  24. utilfs "k8s.io/kubernetes/pkg/util/filesystem"
  25. )
  26. const configDir = "/test-config-dir"
  27. const relativePath = "relative/path/test"
  28. const kubeletFile = "kubelet"
  29. func TestLoad(t *testing.T) {
  30. cases := []struct {
  31. desc string
  32. file *string
  33. expect *kubeletconfig.KubeletConfiguration
  34. err string
  35. }{
  36. // missing file
  37. {
  38. "missing file",
  39. nil,
  40. nil,
  41. "failed to read",
  42. },
  43. // empty file
  44. {
  45. "empty file",
  46. newString(``),
  47. nil,
  48. "was empty",
  49. },
  50. // invalid format
  51. {
  52. "invalid yaml",
  53. newString(`*`),
  54. nil,
  55. "failed to decode",
  56. },
  57. {
  58. "invalid json",
  59. newString(`{*`),
  60. nil,
  61. "failed to decode",
  62. },
  63. // invalid object
  64. {
  65. "missing kind",
  66. newString(`{"apiVersion":"kubelet.config.k8s.io/v1beta1"}`),
  67. nil,
  68. "failed to decode",
  69. },
  70. {
  71. "missing version",
  72. newString(`{"kind":"KubeletConfiguration"}`),
  73. nil,
  74. "failed to decode",
  75. },
  76. {
  77. "unregistered kind",
  78. newString(`{"kind":"BogusKind","apiVersion":"kubelet.config.k8s.io/v1beta1"}`),
  79. nil,
  80. "failed to decode",
  81. },
  82. {
  83. "unregistered version",
  84. newString(`{"kind":"KubeletConfiguration","apiVersion":"bogusversion"}`),
  85. nil,
  86. "failed to decode",
  87. },
  88. // empty object with correct kind and version should result in the defaults for that kind and version
  89. {
  90. "default from yaml",
  91. newString(`kind: KubeletConfiguration
  92. apiVersion: kubelet.config.k8s.io/v1beta1`),
  93. newConfig(t),
  94. "",
  95. },
  96. {
  97. "default from json",
  98. newString(`{"kind":"KubeletConfiguration","apiVersion":"kubelet.config.k8s.io/v1beta1"}`),
  99. newConfig(t),
  100. "",
  101. },
  102. // relative path
  103. {
  104. "yaml, relative path is resolved",
  105. newString(fmt.Sprintf(`kind: KubeletConfiguration
  106. apiVersion: kubelet.config.k8s.io/v1beta1
  107. staticPodPath: %s`, relativePath)),
  108. func() *kubeletconfig.KubeletConfiguration {
  109. kc := newConfig(t)
  110. kc.StaticPodPath = filepath.Join(configDir, relativePath)
  111. return kc
  112. }(),
  113. "",
  114. },
  115. {
  116. "json, relative path is resolved",
  117. newString(fmt.Sprintf(`{"kind":"KubeletConfiguration","apiVersion":"kubelet.config.k8s.io/v1beta1","staticPodPath":"%s"}`, relativePath)),
  118. func() *kubeletconfig.KubeletConfiguration {
  119. kc := newConfig(t)
  120. kc.StaticPodPath = filepath.Join(configDir, relativePath)
  121. return kc
  122. }(),
  123. "",
  124. },
  125. }
  126. for _, c := range cases {
  127. t.Run(c.desc, func(t *testing.T) {
  128. fs := utilfs.NewFakeFs()
  129. path := filepath.Join(configDir, kubeletFile)
  130. if c.file != nil {
  131. if err := addFile(fs, path, *c.file); err != nil {
  132. t.Fatalf("unexpected error: %v", err)
  133. }
  134. }
  135. loader, err := NewFsLoader(fs, path)
  136. if err != nil {
  137. t.Fatalf("unexpected error: %v", err)
  138. }
  139. kc, err := loader.Load()
  140. if utiltest.SkipRest(t, c.desc, err, c.err) {
  141. return
  142. }
  143. if !apiequality.Semantic.DeepEqual(c.expect, kc) {
  144. t.Fatalf("expect %#v but got %#v", *c.expect, *kc)
  145. }
  146. })
  147. }
  148. }
  149. func TestResolveRelativePaths(t *testing.T) {
  150. absolutePath := filepath.Join(configDir, "absolute")
  151. cases := []struct {
  152. desc string
  153. path string
  154. expect string
  155. }{
  156. {"empty path", "", ""},
  157. {"absolute path", absolutePath, absolutePath},
  158. {"relative path", relativePath, filepath.Join(configDir, relativePath)},
  159. }
  160. paths := kubeletconfig.KubeletConfigurationPathRefs(newConfig(t))
  161. if len(paths) == 0 {
  162. t.Fatalf("requires at least one path field to exist in the KubeletConfiguration type")
  163. }
  164. for _, c := range cases {
  165. t.Run(c.desc, func(t *testing.T) {
  166. // set the path, resolve it, and check if it resolved as we would expect
  167. *(paths[0]) = c.path
  168. resolveRelativePaths(paths, configDir)
  169. if *(paths[0]) != c.expect {
  170. t.Fatalf("expect %s but got %s", c.expect, *(paths[0]))
  171. }
  172. })
  173. }
  174. }
  175. func newString(s string) *string {
  176. return &s
  177. }
  178. func addFile(fs utilfs.Filesystem, path string, file string) error {
  179. if err := utilfiles.EnsureDir(fs, filepath.Dir(path)); err != nil {
  180. return err
  181. }
  182. return utilfiles.ReplaceFile(fs, path, []byte(file))
  183. }
  184. func newConfig(t *testing.T) *kubeletconfig.KubeletConfiguration {
  185. kubeletScheme, _, err := kubeletscheme.NewSchemeAndCodecs()
  186. if err != nil {
  187. t.Fatalf("unexpected error: %v", err)
  188. }
  189. // get the built-in default configuration
  190. external := &kubeletconfigv1beta1.KubeletConfiguration{}
  191. kubeletScheme.Default(external)
  192. kc := &kubeletconfig.KubeletConfiguration{}
  193. err = kubeletScheme.Convert(external, kc, nil)
  194. if err != nil {
  195. t.Fatalf("unexpected error: %v", err)
  196. }
  197. return kc
  198. }