reconcile_rolebindings_test.go 5.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182
  1. /*
  2. Copyright 2017 The Kubernetes Authors.
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. http://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package reconciliation
  14. import (
  15. "testing"
  16. rbacv1 "k8s.io/api/rbac/v1"
  17. "k8s.io/kubernetes/pkg/apis/core/helper"
  18. )
  19. func binding(roleRef rbacv1.RoleRef, subjects []rbacv1.Subject) *rbacv1.ClusterRoleBinding {
  20. return &rbacv1.ClusterRoleBinding{RoleRef: roleRef, Subjects: subjects}
  21. }
  22. func ref(name string) rbacv1.RoleRef {
  23. return rbacv1.RoleRef{Name: name}
  24. }
  25. func subject(name string) rbacv1.Subject {
  26. return rbacv1.Subject{Name: name}
  27. }
  28. func subjects(names ...string) []rbacv1.Subject {
  29. r := []rbacv1.Subject{}
  30. for _, name := range names {
  31. r = append(r, subject(name))
  32. }
  33. return r
  34. }
  35. func TestDiffObjectReferenceLists(t *testing.T) {
  36. tests := map[string]struct {
  37. A []rbacv1.Subject
  38. B []rbacv1.Subject
  39. ExpectedOnlyA []rbacv1.Subject
  40. ExpectedOnlyB []rbacv1.Subject
  41. }{
  42. "empty": {},
  43. "matching, order-independent": {
  44. A: subjects("foo", "bar"),
  45. B: subjects("bar", "foo"),
  46. },
  47. "partial match": {
  48. A: subjects("foo", "bar"),
  49. B: subjects("foo", "baz"),
  50. ExpectedOnlyA: subjects("bar"),
  51. ExpectedOnlyB: subjects("baz"),
  52. },
  53. "missing": {
  54. A: subjects("foo"),
  55. B: subjects("bar"),
  56. ExpectedOnlyA: subjects("foo"),
  57. ExpectedOnlyB: subjects("bar"),
  58. },
  59. "remove duplicates": {
  60. A: subjects("foo", "foo"),
  61. B: subjects("bar", "bar"),
  62. ExpectedOnlyA: subjects("foo"),
  63. ExpectedOnlyB: subjects("bar"),
  64. },
  65. }
  66. for k, tc := range tests {
  67. onlyA, onlyB := diffSubjectLists(tc.A, tc.B)
  68. if !helper.Semantic.DeepEqual(onlyA, tc.ExpectedOnlyA) {
  69. t.Errorf("%s: Expected %#v, got %#v", k, tc.ExpectedOnlyA, onlyA)
  70. }
  71. if !helper.Semantic.DeepEqual(onlyB, tc.ExpectedOnlyB) {
  72. t.Errorf("%s: Expected %#v, got %#v", k, tc.ExpectedOnlyB, onlyB)
  73. }
  74. }
  75. }
  76. func TestComputeUpdate(t *testing.T) {
  77. tests := map[string]struct {
  78. ExpectedBinding *rbacv1.ClusterRoleBinding
  79. ActualBinding *rbacv1.ClusterRoleBinding
  80. RemoveExtraSubjects bool
  81. ExpectedUpdatedBinding *rbacv1.ClusterRoleBinding
  82. ExpectedUpdateNeeded bool
  83. }{
  84. "match without union": {
  85. ExpectedBinding: binding(ref("role"), subjects("a")),
  86. ActualBinding: binding(ref("role"), subjects("a")),
  87. RemoveExtraSubjects: true,
  88. ExpectedUpdatedBinding: nil,
  89. ExpectedUpdateNeeded: false,
  90. },
  91. "match with union": {
  92. ExpectedBinding: binding(ref("role"), subjects("a")),
  93. ActualBinding: binding(ref("role"), subjects("a")),
  94. RemoveExtraSubjects: false,
  95. ExpectedUpdatedBinding: nil,
  96. ExpectedUpdateNeeded: false,
  97. },
  98. "different roleref with identical subjects": {
  99. ExpectedBinding: binding(ref("role"), subjects("a")),
  100. ActualBinding: binding(ref("differentRole"), subjects("a")),
  101. RemoveExtraSubjects: false,
  102. ExpectedUpdatedBinding: binding(ref("role"), subjects("a")),
  103. ExpectedUpdateNeeded: true,
  104. },
  105. "extra subjects without union": {
  106. ExpectedBinding: binding(ref("role"), subjects("a")),
  107. ActualBinding: binding(ref("role"), subjects("a", "b")),
  108. RemoveExtraSubjects: true,
  109. ExpectedUpdatedBinding: binding(ref("role"), subjects("a")),
  110. ExpectedUpdateNeeded: true,
  111. },
  112. "extra subjects with union": {
  113. ExpectedBinding: binding(ref("role"), subjects("a")),
  114. ActualBinding: binding(ref("role"), subjects("a", "b")),
  115. RemoveExtraSubjects: false,
  116. ExpectedUpdatedBinding: nil,
  117. ExpectedUpdateNeeded: false,
  118. },
  119. "missing subjects without union": {
  120. ExpectedBinding: binding(ref("role"), subjects("a", "c")),
  121. ActualBinding: binding(ref("role"), subjects("a", "b")),
  122. RemoveExtraSubjects: true,
  123. ExpectedUpdatedBinding: binding(ref("role"), subjects("a", "c")),
  124. ExpectedUpdateNeeded: true,
  125. },
  126. "missing subjects with union": {
  127. ExpectedBinding: binding(ref("role"), subjects("a", "c")),
  128. ActualBinding: binding(ref("role"), subjects("a", "b")),
  129. RemoveExtraSubjects: false,
  130. ExpectedUpdatedBinding: binding(ref("role"), subjects("a", "b", "c")),
  131. ExpectedUpdateNeeded: true,
  132. },
  133. }
  134. for k, tc := range tests {
  135. actualRoleBinding := ClusterRoleBindingAdapter{ClusterRoleBinding: tc.ActualBinding}
  136. expectedRoleBinding := ClusterRoleBindingAdapter{ClusterRoleBinding: tc.ExpectedBinding}
  137. result, err := computeReconciledRoleBinding(actualRoleBinding, expectedRoleBinding, tc.RemoveExtraSubjects)
  138. if err != nil {
  139. t.Errorf("%s: %v", k, err)
  140. continue
  141. }
  142. updateNeeded := result.Operation != ReconcileNone
  143. updatedBinding := result.RoleBinding.(ClusterRoleBindingAdapter).ClusterRoleBinding
  144. if updateNeeded != tc.ExpectedUpdateNeeded {
  145. t.Errorf("%s: Expected\n\t%v\ngot\n\t%v (%v)", k, tc.ExpectedUpdateNeeded, updateNeeded, result.Operation)
  146. continue
  147. }
  148. if updateNeeded && !helper.Semantic.DeepEqual(updatedBinding, tc.ExpectedUpdatedBinding) {
  149. t.Errorf("%s: Expected\n\t%v %v\ngot\n\t%v %v", k, tc.ExpectedUpdatedBinding.RoleRef, tc.ExpectedUpdatedBinding.Subjects, updatedBinding.RoleRef, updatedBinding.Subjects)
  150. }
  151. }
  152. }