123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248 |
- /*
- Copyright 2016 The Kubernetes Authors.
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- */
- package v1_test
- import (
- "reflect"
- "testing"
- batchv1 "k8s.io/api/batch/v1"
- "k8s.io/api/core/v1"
- metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
- "k8s.io/apimachinery/pkg/runtime"
- "k8s.io/kubernetes/pkg/api/legacyscheme"
- _ "k8s.io/kubernetes/pkg/apis/batch/install"
- . "k8s.io/kubernetes/pkg/apis/batch/v1"
- _ "k8s.io/kubernetes/pkg/apis/core/install"
- utilpointer "k8s.io/utils/pointer"
- )
- func TestSetDefaultJob(t *testing.T) {
- defaultLabels := map[string]string{"default": "default"}
- tests := map[string]struct {
- original *batchv1.Job
- expected *batchv1.Job
- expectLabels bool
- }{
- "All unspecified -> sets all to default values": {
- original: &batchv1.Job{
- Spec: batchv1.JobSpec{
- Template: v1.PodTemplateSpec{
- ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
- },
- },
- },
- expected: &batchv1.Job{
- Spec: batchv1.JobSpec{
- Completions: utilpointer.Int32Ptr(1),
- Parallelism: utilpointer.Int32Ptr(1),
- BackoffLimit: utilpointer.Int32Ptr(6),
- },
- },
- expectLabels: true,
- },
- "All unspecified -> all integers are defaulted and no default labels": {
- original: &batchv1.Job{
- ObjectMeta: metav1.ObjectMeta{
- Labels: map[string]string{"mylabel": "myvalue"},
- },
- Spec: batchv1.JobSpec{
- Template: v1.PodTemplateSpec{
- ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
- },
- },
- },
- expected: &batchv1.Job{
- Spec: batchv1.JobSpec{
- Completions: utilpointer.Int32Ptr(1),
- Parallelism: utilpointer.Int32Ptr(1),
- BackoffLimit: utilpointer.Int32Ptr(6),
- },
- },
- },
- "WQ: Parallelism explicitly 0 and completions unset -> BackoffLimit is defaulted": {
- original: &batchv1.Job{
- Spec: batchv1.JobSpec{
- Parallelism: utilpointer.Int32Ptr(0),
- Template: v1.PodTemplateSpec{
- ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
- },
- },
- },
- expected: &batchv1.Job{
- Spec: batchv1.JobSpec{
- Parallelism: utilpointer.Int32Ptr(0),
- BackoffLimit: utilpointer.Int32Ptr(6),
- },
- },
- expectLabels: true,
- },
- "WQ: Parallelism explicitly 2 and completions unset -> BackoffLimit is defaulted": {
- original: &batchv1.Job{
- Spec: batchv1.JobSpec{
- Parallelism: utilpointer.Int32Ptr(2),
- Template: v1.PodTemplateSpec{
- ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
- },
- },
- },
- expected: &batchv1.Job{
- Spec: batchv1.JobSpec{
- Parallelism: utilpointer.Int32Ptr(2),
- BackoffLimit: utilpointer.Int32Ptr(6),
- },
- },
- expectLabels: true,
- },
- "Completions explicitly 2 and others unset -> parallelism and BackoffLimit are defaulted": {
- original: &batchv1.Job{
- Spec: batchv1.JobSpec{
- Completions: utilpointer.Int32Ptr(2),
- Template: v1.PodTemplateSpec{
- ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
- },
- },
- },
- expected: &batchv1.Job{
- Spec: batchv1.JobSpec{
- Completions: utilpointer.Int32Ptr(2),
- Parallelism: utilpointer.Int32Ptr(1),
- BackoffLimit: utilpointer.Int32Ptr(6),
- },
- },
- expectLabels: true,
- },
- "BackoffLimit explicitly 5 and others unset -> parallelism and completions are defaulted": {
- original: &batchv1.Job{
- Spec: batchv1.JobSpec{
- BackoffLimit: utilpointer.Int32Ptr(5),
- Template: v1.PodTemplateSpec{
- ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
- },
- },
- },
- expected: &batchv1.Job{
- Spec: batchv1.JobSpec{
- Completions: utilpointer.Int32Ptr(1),
- Parallelism: utilpointer.Int32Ptr(1),
- BackoffLimit: utilpointer.Int32Ptr(5),
- },
- },
- expectLabels: true,
- },
- "All set -> no change": {
- original: &batchv1.Job{
- Spec: batchv1.JobSpec{
- Completions: utilpointer.Int32Ptr(8),
- Parallelism: utilpointer.Int32Ptr(9),
- BackoffLimit: utilpointer.Int32Ptr(10),
- Template: v1.PodTemplateSpec{
- ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
- },
- },
- },
- expected: &batchv1.Job{
- Spec: batchv1.JobSpec{
- Completions: utilpointer.Int32Ptr(8),
- Parallelism: utilpointer.Int32Ptr(9),
- BackoffLimit: utilpointer.Int32Ptr(10),
- Template: v1.PodTemplateSpec{
- ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
- },
- },
- },
- expectLabels: true,
- },
- "All set, flipped -> no change": {
- original: &batchv1.Job{
- Spec: batchv1.JobSpec{
- Completions: utilpointer.Int32Ptr(11),
- Parallelism: utilpointer.Int32Ptr(10),
- BackoffLimit: utilpointer.Int32Ptr(9),
- Template: v1.PodTemplateSpec{
- ObjectMeta: metav1.ObjectMeta{Labels: defaultLabels},
- },
- },
- },
- expected: &batchv1.Job{
- Spec: batchv1.JobSpec{
- Completions: utilpointer.Int32Ptr(11),
- Parallelism: utilpointer.Int32Ptr(10),
- BackoffLimit: utilpointer.Int32Ptr(9),
- },
- },
- expectLabels: true,
- },
- }
- for name, test := range tests {
- original := test.original
- expected := test.expected
- obj2 := roundTrip(t, runtime.Object(original))
- actual, ok := obj2.(*batchv1.Job)
- if !ok {
- t.Errorf("%s: unexpected object: %v", name, actual)
- t.FailNow()
- }
- validateDefaultInt32(t, name, "Completions", actual.Spec.Completions, expected.Spec.Completions)
- validateDefaultInt32(t, name, "Parallelism", actual.Spec.Parallelism, expected.Spec.Parallelism)
- validateDefaultInt32(t, name, "BackoffLimit", actual.Spec.BackoffLimit, expected.Spec.BackoffLimit)
- if test.expectLabels != reflect.DeepEqual(actual.Labels, actual.Spec.Template.Labels) {
- if test.expectLabels {
- t.Errorf("%s: expected: %v, got: %v", name, actual.Spec.Template.Labels, actual.Labels)
- } else {
- t.Errorf("%s: unexpected equality: %v", name, actual.Labels)
- }
- }
- }
- }
- func validateDefaultInt32(t *testing.T, name string, field string, actual *int32, expected *int32) {
- if (actual == nil) != (expected == nil) {
- t.Errorf("%s: got different *%s than expected: %v %v", name, field, actual, expected)
- }
- if actual != nil && expected != nil {
- if *actual != *expected {
- t.Errorf("%s: got different %s than expected: %d %d", name, field, *actual, *expected)
- }
- }
- }
- func roundTrip(t *testing.T, obj runtime.Object) runtime.Object {
- data, err := runtime.Encode(legacyscheme.Codecs.LegacyCodec(SchemeGroupVersion), obj)
- if err != nil {
- t.Errorf("%v\n %#v", err, obj)
- return nil
- }
- obj2, err := runtime.Decode(legacyscheme.Codecs.UniversalDecoder(), data)
- if err != nil {
- t.Errorf("%v\nData: %s\nSource: %#v", err, string(data), obj)
- return nil
- }
- obj3 := reflect.New(reflect.TypeOf(obj).Elem()).Interface().(runtime.Object)
- err = legacyscheme.Scheme.Convert(obj2, obj3, nil)
- if err != nil {
- t.Errorf("%v\nSource: %#v", err, obj2)
- return nil
- }
- return obj3
- }
|