123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332 |
- /*
- Copyright 2017 The Kubernetes Authors.
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- */
- package queue
- import (
- "fmt"
- "reflect"
- "sync"
- "testing"
- "time"
- dto "github.com/prometheus/client_model/go"
- "k8s.io/api/core/v1"
- metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
- "k8s.io/apimachinery/pkg/types"
- "k8s.io/apimachinery/pkg/util/clock"
- podutil "k8s.io/kubernetes/pkg/api/v1/pod"
- framework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
- internalcache "k8s.io/kubernetes/pkg/scheduler/internal/cache"
- "k8s.io/kubernetes/pkg/scheduler/metrics"
- "k8s.io/kubernetes/pkg/scheduler/util"
- )
- var negPriority, lowPriority, midPriority, highPriority, veryHighPriority = int32(-100), int32(0), int32(100), int32(1000), int32(10000)
- var mediumPriority = (lowPriority + highPriority) / 2
- var highPriorityPod, highPriNominatedPod, medPriorityPod, unschedulablePod = v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: "hpp",
- Namespace: "ns1",
- UID: "hppns1",
- },
- Spec: v1.PodSpec{
- Priority: &highPriority,
- },
- },
- v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: "hpp",
- Namespace: "ns1",
- UID: "hppns1",
- },
- Spec: v1.PodSpec{
- Priority: &highPriority,
- },
- Status: v1.PodStatus{
- NominatedNodeName: "node1",
- },
- },
- v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: "mpp",
- Namespace: "ns2",
- UID: "mppns2",
- Annotations: map[string]string{
- "annot2": "val2",
- },
- },
- Spec: v1.PodSpec{
- Priority: &mediumPriority,
- },
- Status: v1.PodStatus{
- NominatedNodeName: "node1",
- },
- },
- v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: "up",
- Namespace: "ns1",
- UID: "upns1",
- Annotations: map[string]string{
- "annot2": "val2",
- },
- },
- Spec: v1.PodSpec{
- Priority: &lowPriority,
- },
- Status: v1.PodStatus{
- Conditions: []v1.PodCondition{
- {
- Type: v1.PodScheduled,
- Status: v1.ConditionFalse,
- Reason: v1.PodReasonUnschedulable,
- },
- },
- NominatedNodeName: "node1",
- },
- }
- func addOrUpdateUnschedulablePod(p *PriorityQueue, pod *v1.Pod) {
- p.lock.Lock()
- defer p.lock.Unlock()
- p.unschedulableQ.addOrUpdate(p.newPodInfo(pod))
- }
- func getUnschedulablePod(p *PriorityQueue, pod *v1.Pod) *v1.Pod {
- p.lock.Lock()
- defer p.lock.Unlock()
- pInfo := p.unschedulableQ.get(pod)
- if pInfo != nil {
- return pInfo.Pod
- }
- return nil
- }
- func TestPriorityQueue_Add(t *testing.T) {
- q := NewPriorityQueue(nil, nil)
- if err := q.Add(&medPriorityPod); err != nil {
- t.Errorf("add failed: %v", err)
- }
- if err := q.Add(&unschedulablePod); err != nil {
- t.Errorf("add failed: %v", err)
- }
- if err := q.Add(&highPriorityPod); err != nil {
- t.Errorf("add failed: %v", err)
- }
- expectedNominatedPods := &nominatedPodMap{
- nominatedPodToNode: map[types.UID]string{
- medPriorityPod.UID: "node1",
- unschedulablePod.UID: "node1",
- },
- nominatedPods: map[string][]*v1.Pod{
- "node1": {&medPriorityPod, &unschedulablePod},
- },
- }
- if !reflect.DeepEqual(q.nominatedPods, expectedNominatedPods) {
- t.Errorf("Unexpected nominated map after adding pods. Expected: %v, got: %v", expectedNominatedPods, q.nominatedPods)
- }
- if p, err := q.Pop(); err != nil || p != &highPriorityPod {
- t.Errorf("Expected: %v after Pop, but got: %v", highPriorityPod.Name, p.Name)
- }
- if p, err := q.Pop(); err != nil || p != &medPriorityPod {
- t.Errorf("Expected: %v after Pop, but got: %v", medPriorityPod.Name, p.Name)
- }
- if p, err := q.Pop(); err != nil || p != &unschedulablePod {
- t.Errorf("Expected: %v after Pop, but got: %v", unschedulablePod.Name, p.Name)
- }
- if len(q.nominatedPods.nominatedPods["node1"]) != 2 {
- t.Errorf("Expected medPriorityPod and unschedulablePod to be still present in nomindatePods: %v", q.nominatedPods.nominatedPods["node1"])
- }
- }
- type fakeFramework struct{}
- func (*fakeFramework) QueueSortFunc() framework.LessFunc {
- return func(podInfo1, podInfo2 *framework.PodInfo) bool {
- prio1 := util.GetPodPriority(podInfo1.Pod)
- prio2 := util.GetPodPriority(podInfo2.Pod)
- return prio1 < prio2
- }
- }
- func (*fakeFramework) NodeInfoSnapshot() *internalcache.NodeInfoSnapshot {
- return nil
- }
- func (*fakeFramework) RunPrebindPlugins(pc *framework.PluginContext, pod *v1.Pod, nodeName string) *framework.Status {
- return nil
- }
- func (*fakeFramework) RunPostbindPlugins(pc *framework.PluginContext, pod *v1.Pod, nodeName string) {}
- func (*fakeFramework) RunReservePlugins(pc *framework.PluginContext, pod *v1.Pod, nodeName string) *framework.Status {
- return nil
- }
- func (*fakeFramework) RunUnreservePlugins(pc *framework.PluginContext, pod *v1.Pod, nodeName string) {}
- func (*fakeFramework) RunPermitPlugins(pc *framework.PluginContext, pod *v1.Pod, nodeName string) *framework.Status {
- return nil
- }
- func (*fakeFramework) IterateOverWaitingPods(callback func(framework.WaitingPod)) {}
- func (*fakeFramework) GetWaitingPod(uid types.UID) framework.WaitingPod {
- return nil
- }
- func TestPriorityQueue_AddWithReversePriorityLessFunc(t *testing.T) {
- q := NewPriorityQueue(nil, &fakeFramework{})
- if err := q.Add(&medPriorityPod); err != nil {
- t.Errorf("add failed: %v", err)
- }
- if err := q.Add(&highPriorityPod); err != nil {
- t.Errorf("add failed: %v", err)
- }
- if p, err := q.Pop(); err != nil || p != &medPriorityPod {
- t.Errorf("Expected: %v after Pop, but got: %v", medPriorityPod.Name, p.Name)
- }
- if p, err := q.Pop(); err != nil || p != &highPriorityPod {
- t.Errorf("Expected: %v after Pop, but got: %v", highPriorityPod.Name, p.Name)
- }
- }
- func TestPriorityQueue_AddIfNotPresent(t *testing.T) {
- q := NewPriorityQueue(nil, nil)
- addOrUpdateUnschedulablePod(q, &highPriNominatedPod)
- q.AddIfNotPresent(&highPriNominatedPod) // Must not add anything.
- q.AddIfNotPresent(&medPriorityPod)
- q.AddIfNotPresent(&unschedulablePod)
- expectedNominatedPods := &nominatedPodMap{
- nominatedPodToNode: map[types.UID]string{
- medPriorityPod.UID: "node1",
- unschedulablePod.UID: "node1",
- },
- nominatedPods: map[string][]*v1.Pod{
- "node1": {&medPriorityPod, &unschedulablePod},
- },
- }
- if !reflect.DeepEqual(q.nominatedPods, expectedNominatedPods) {
- t.Errorf("Unexpected nominated map after adding pods. Expected: %v, got: %v", expectedNominatedPods, q.nominatedPods)
- }
- if p, err := q.Pop(); err != nil || p != &medPriorityPod {
- t.Errorf("Expected: %v after Pop, but got: %v", medPriorityPod.Name, p.Name)
- }
- if p, err := q.Pop(); err != nil || p != &unschedulablePod {
- t.Errorf("Expected: %v after Pop, but got: %v", unschedulablePod.Name, p.Name)
- }
- if len(q.nominatedPods.nominatedPods["node1"]) != 2 {
- t.Errorf("Expected medPriorityPod and unschedulablePod to be still present in nomindatePods: %v", q.nominatedPods.nominatedPods["node1"])
- }
- if getUnschedulablePod(q, &highPriNominatedPod) != &highPriNominatedPod {
- t.Errorf("Pod %v was not found in the unschedulableQ.", highPriNominatedPod.Name)
- }
- }
- func TestPriorityQueue_AddUnschedulableIfNotPresent(t *testing.T) {
- q := NewPriorityQueue(nil, nil)
- q.Add(&highPriNominatedPod)
- q.AddUnschedulableIfNotPresent(&highPriNominatedPod, q.SchedulingCycle()) // Must not add anything.
- q.AddUnschedulableIfNotPresent(&unschedulablePod, q.SchedulingCycle())
- expectedNominatedPods := &nominatedPodMap{
- nominatedPodToNode: map[types.UID]string{
- unschedulablePod.UID: "node1",
- highPriNominatedPod.UID: "node1",
- },
- nominatedPods: map[string][]*v1.Pod{
- "node1": {&highPriNominatedPod, &unschedulablePod},
- },
- }
- if !reflect.DeepEqual(q.nominatedPods, expectedNominatedPods) {
- t.Errorf("Unexpected nominated map after adding pods. Expected: %v, got: %v", expectedNominatedPods, q.nominatedPods)
- }
- if p, err := q.Pop(); err != nil || p != &highPriNominatedPod {
- t.Errorf("Expected: %v after Pop, but got: %v", highPriNominatedPod.Name, p.Name)
- }
- if len(q.nominatedPods.nominatedPods) != 1 {
- t.Errorf("Expected nomindatePods to have one element: %v", q.nominatedPods)
- }
- if getUnschedulablePod(q, &unschedulablePod) != &unschedulablePod {
- t.Errorf("Pod %v was not found in the unschedulableQ.", unschedulablePod.Name)
- }
- }
- // TestPriorityQueue_AddUnschedulableIfNotPresent_Backoff tests scenario when
- // AddUnschedulableIfNotPresent is called asynchronously pods in and before
- // current scheduling cycle will be put back to activeQueue if we were trying
- // to schedule them when we received move request.
- func TestPriorityQueue_AddUnschedulableIfNotPresent_Backoff(t *testing.T) {
- q := NewPriorityQueue(nil, nil)
- totalNum := 10
- expectedPods := make([]v1.Pod, 0, totalNum)
- for i := 0; i < totalNum; i++ {
- priority := int32(i)
- p := v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: fmt.Sprintf("pod%d", i),
- Namespace: fmt.Sprintf("ns%d", i),
- UID: types.UID(fmt.Sprintf("upns%d", i)),
- },
- Spec: v1.PodSpec{
- Priority: &priority,
- },
- }
- expectedPods = append(expectedPods, p)
- // priority is to make pods ordered in the PriorityQueue
- q.Add(&p)
- }
- // Pop all pods except for the first one
- for i := totalNum - 1; i > 0; i-- {
- p, _ := q.Pop()
- if !reflect.DeepEqual(&expectedPods[i], p) {
- t.Errorf("Unexpected pod. Expected: %v, got: %v", &expectedPods[i], p)
- }
- }
- // move all pods to active queue when we were trying to schedule them
- q.MoveAllToActiveQueue()
- oldCycle := q.SchedulingCycle()
- firstPod, _ := q.Pop()
- if !reflect.DeepEqual(&expectedPods[0], firstPod) {
- t.Errorf("Unexpected pod. Expected: %v, got: %v", &expectedPods[0], firstPod)
- }
- // mark pods[1] ~ pods[totalNum-1] as unschedulable and add them back
- for i := 1; i < totalNum; i++ {
- unschedulablePod := expectedPods[i].DeepCopy()
- unschedulablePod.Status = v1.PodStatus{
- Conditions: []v1.PodCondition{
- {
- Type: v1.PodScheduled,
- Status: v1.ConditionFalse,
- Reason: v1.PodReasonUnschedulable,
- },
- },
- }
- q.AddUnschedulableIfNotPresent(unschedulablePod, oldCycle)
- }
- // Since there was a move request at the same cycle as "oldCycle", these pods
- // should be in the backoff queue.
- for i := 1; i < totalNum; i++ {
- if _, exists, _ := q.podBackoffQ.Get(newPodInfoNoTimestamp(&expectedPods[i])); !exists {
- t.Errorf("Expected %v to be added to podBackoffQ.", expectedPods[i].Name)
- }
- }
- }
- func TestPriorityQueue_Pop(t *testing.T) {
- q := NewPriorityQueue(nil, nil)
- wg := sync.WaitGroup{}
- wg.Add(1)
- go func() {
- defer wg.Done()
- if p, err := q.Pop(); err != nil || p != &medPriorityPod {
- t.Errorf("Expected: %v after Pop, but got: %v", medPriorityPod.Name, p.Name)
- }
- if len(q.nominatedPods.nominatedPods["node1"]) != 1 {
- t.Errorf("Expected medPriorityPod to be present in nomindatePods: %v", q.nominatedPods.nominatedPods["node1"])
- }
- }()
- q.Add(&medPriorityPod)
- wg.Wait()
- }
- func TestPriorityQueue_Update(t *testing.T) {
- q := NewPriorityQueue(nil, nil)
- q.Update(nil, &highPriorityPod)
- if _, exists, _ := q.activeQ.Get(newPodInfoNoTimestamp(&highPriorityPod)); !exists {
- t.Errorf("Expected %v to be added to activeQ.", highPriorityPod.Name)
- }
- if len(q.nominatedPods.nominatedPods) != 0 {
- t.Errorf("Expected nomindatePods to be empty: %v", q.nominatedPods)
- }
- // Update highPriorityPod and add a nominatedNodeName to it.
- q.Update(&highPriorityPod, &highPriNominatedPod)
- if q.activeQ.Len() != 1 {
- t.Error("Expected only one item in activeQ.")
- }
- if len(q.nominatedPods.nominatedPods) != 1 {
- t.Errorf("Expected one item in nomindatePods map: %v", q.nominatedPods)
- }
- // Updating an unschedulable pod which is not in any of the two queues, should
- // add the pod to activeQ.
- q.Update(&unschedulablePod, &unschedulablePod)
- if _, exists, _ := q.activeQ.Get(newPodInfoNoTimestamp(&unschedulablePod)); !exists {
- t.Errorf("Expected %v to be added to activeQ.", unschedulablePod.Name)
- }
- // Updating a pod that is already in activeQ, should not change it.
- q.Update(&unschedulablePod, &unschedulablePod)
- if len(q.unschedulableQ.podInfoMap) != 0 {
- t.Error("Expected unschedulableQ to be empty.")
- }
- if _, exists, _ := q.activeQ.Get(newPodInfoNoTimestamp(&unschedulablePod)); !exists {
- t.Errorf("Expected: %v to be added to activeQ.", unschedulablePod.Name)
- }
- if p, err := q.Pop(); err != nil || p != &highPriNominatedPod {
- t.Errorf("Expected: %v after Pop, but got: %v", highPriorityPod.Name, p.Name)
- }
- }
- func TestPriorityQueue_Delete(t *testing.T) {
- q := NewPriorityQueue(nil, nil)
- q.Update(&highPriorityPod, &highPriNominatedPod)
- q.Add(&unschedulablePod)
- if err := q.Delete(&highPriNominatedPod); err != nil {
- t.Errorf("delete failed: %v", err)
- }
- if _, exists, _ := q.activeQ.Get(newPodInfoNoTimestamp(&unschedulablePod)); !exists {
- t.Errorf("Expected %v to be in activeQ.", unschedulablePod.Name)
- }
- if _, exists, _ := q.activeQ.Get(newPodInfoNoTimestamp(&highPriNominatedPod)); exists {
- t.Errorf("Didn't expect %v to be in activeQ.", highPriorityPod.Name)
- }
- if len(q.nominatedPods.nominatedPods) != 1 {
- t.Errorf("Expected nomindatePods to have only 'unschedulablePod': %v", q.nominatedPods.nominatedPods)
- }
- if err := q.Delete(&unschedulablePod); err != nil {
- t.Errorf("delete failed: %v", err)
- }
- if len(q.nominatedPods.nominatedPods) != 0 {
- t.Errorf("Expected nomindatePods to be empty: %v", q.nominatedPods)
- }
- }
- func TestPriorityQueue_MoveAllToActiveQueue(t *testing.T) {
- q := NewPriorityQueue(nil, nil)
- q.Add(&medPriorityPod)
- addOrUpdateUnschedulablePod(q, &unschedulablePod)
- addOrUpdateUnschedulablePod(q, &highPriorityPod)
- q.MoveAllToActiveQueue()
- if q.activeQ.Len() != 3 {
- t.Error("Expected all items to be in activeQ.")
- }
- }
- // TestPriorityQueue_AssignedPodAdded tests AssignedPodAdded. It checks that
- // when a pod with pod affinity is in unschedulableQ and another pod with a
- // matching label is added, the unschedulable pod is moved to activeQ.
- func TestPriorityQueue_AssignedPodAdded(t *testing.T) {
- affinityPod := unschedulablePod.DeepCopy()
- affinityPod.Name = "afp"
- affinityPod.Spec = v1.PodSpec{
- Affinity: &v1.Affinity{
- PodAffinity: &v1.PodAffinity{
- RequiredDuringSchedulingIgnoredDuringExecution: []v1.PodAffinityTerm{
- {
- LabelSelector: &metav1.LabelSelector{
- MatchExpressions: []metav1.LabelSelectorRequirement{
- {
- Key: "service",
- Operator: metav1.LabelSelectorOpIn,
- Values: []string{"securityscan", "value2"},
- },
- },
- },
- TopologyKey: "region",
- },
- },
- },
- },
- Priority: &mediumPriority,
- }
- labelPod := v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: "lbp",
- Namespace: affinityPod.Namespace,
- Labels: map[string]string{"service": "securityscan"},
- },
- Spec: v1.PodSpec{NodeName: "machine1"},
- }
- q := NewPriorityQueue(nil, nil)
- q.Add(&medPriorityPod)
- // Add a couple of pods to the unschedulableQ.
- addOrUpdateUnschedulablePod(q, &unschedulablePod)
- addOrUpdateUnschedulablePod(q, affinityPod)
- // Simulate addition of an assigned pod. The pod has matching labels for
- // affinityPod. So, affinityPod should go to activeQ.
- q.AssignedPodAdded(&labelPod)
- if getUnschedulablePod(q, affinityPod) != nil {
- t.Error("affinityPod is still in the unschedulableQ.")
- }
- if _, exists, _ := q.activeQ.Get(newPodInfoNoTimestamp(affinityPod)); !exists {
- t.Error("affinityPod is not moved to activeQ.")
- }
- // Check that the other pod is still in the unschedulableQ.
- if getUnschedulablePod(q, &unschedulablePod) == nil {
- t.Error("unschedulablePod is not in the unschedulableQ.")
- }
- }
- func TestPriorityQueue_NominatedPodsForNode(t *testing.T) {
- q := NewPriorityQueue(nil, nil)
- q.Add(&medPriorityPod)
- q.Add(&unschedulablePod)
- q.Add(&highPriorityPod)
- if p, err := q.Pop(); err != nil || p != &highPriorityPod {
- t.Errorf("Expected: %v after Pop, but got: %v", highPriorityPod.Name, p.Name)
- }
- expectedList := []*v1.Pod{&medPriorityPod, &unschedulablePod}
- if !reflect.DeepEqual(expectedList, q.NominatedPodsForNode("node1")) {
- t.Error("Unexpected list of nominated Pods for node.")
- }
- if q.NominatedPodsForNode("node2") != nil {
- t.Error("Expected list of nominated Pods for node2 to be empty.")
- }
- }
- func TestPriorityQueue_PendingPods(t *testing.T) {
- makeSet := func(pods []*v1.Pod) map[*v1.Pod]struct{} {
- pendingSet := map[*v1.Pod]struct{}{}
- for _, p := range pods {
- pendingSet[p] = struct{}{}
- }
- return pendingSet
- }
- q := NewPriorityQueue(nil, nil)
- q.Add(&medPriorityPod)
- addOrUpdateUnschedulablePod(q, &unschedulablePod)
- addOrUpdateUnschedulablePod(q, &highPriorityPod)
- expectedSet := makeSet([]*v1.Pod{&medPriorityPod, &unschedulablePod, &highPriorityPod})
- if !reflect.DeepEqual(expectedSet, makeSet(q.PendingPods())) {
- t.Error("Unexpected list of pending Pods.")
- }
- // Move all to active queue. We should still see the same set of pods.
- q.MoveAllToActiveQueue()
- if !reflect.DeepEqual(expectedSet, makeSet(q.PendingPods())) {
- t.Error("Unexpected list of pending Pods...")
- }
- }
- func TestPriorityQueue_UpdateNominatedPodForNode(t *testing.T) {
- q := NewPriorityQueue(nil, nil)
- if err := q.Add(&medPriorityPod); err != nil {
- t.Errorf("add failed: %v", err)
- }
- // Update unschedulablePod on a different node than specified in the pod.
- q.UpdateNominatedPodForNode(&unschedulablePod, "node5")
- // Update nominated node name of a pod on a node that is not specified in the pod object.
- q.UpdateNominatedPodForNode(&highPriorityPod, "node2")
- expectedNominatedPods := &nominatedPodMap{
- nominatedPodToNode: map[types.UID]string{
- medPriorityPod.UID: "node1",
- highPriorityPod.UID: "node2",
- unschedulablePod.UID: "node5",
- },
- nominatedPods: map[string][]*v1.Pod{
- "node1": {&medPriorityPod},
- "node2": {&highPriorityPod},
- "node5": {&unschedulablePod},
- },
- }
- if !reflect.DeepEqual(q.nominatedPods, expectedNominatedPods) {
- t.Errorf("Unexpected nominated map after adding pods. Expected: %v, got: %v", expectedNominatedPods, q.nominatedPods)
- }
- if p, err := q.Pop(); err != nil || p != &medPriorityPod {
- t.Errorf("Expected: %v after Pop, but got: %v", medPriorityPod.Name, p.Name)
- }
- // List of nominated pods shouldn't change after popping them from the queue.
- if !reflect.DeepEqual(q.nominatedPods, expectedNominatedPods) {
- t.Errorf("Unexpected nominated map after popping pods. Expected: %v, got: %v", expectedNominatedPods, q.nominatedPods)
- }
- // Update one of the nominated pods that doesn't have nominatedNodeName in the
- // pod object. It should be updated correctly.
- q.UpdateNominatedPodForNode(&highPriorityPod, "node4")
- expectedNominatedPods = &nominatedPodMap{
- nominatedPodToNode: map[types.UID]string{
- medPriorityPod.UID: "node1",
- highPriorityPod.UID: "node4",
- unschedulablePod.UID: "node5",
- },
- nominatedPods: map[string][]*v1.Pod{
- "node1": {&medPriorityPod},
- "node4": {&highPriorityPod},
- "node5": {&unschedulablePod},
- },
- }
- if !reflect.DeepEqual(q.nominatedPods, expectedNominatedPods) {
- t.Errorf("Unexpected nominated map after updating pods. Expected: %v, got: %v", expectedNominatedPods, q.nominatedPods)
- }
- // Delete a nominated pod that doesn't have nominatedNodeName in the pod
- // object. It should be deleted.
- q.DeleteNominatedPodIfExists(&highPriorityPod)
- expectedNominatedPods = &nominatedPodMap{
- nominatedPodToNode: map[types.UID]string{
- medPriorityPod.UID: "node1",
- unschedulablePod.UID: "node5",
- },
- nominatedPods: map[string][]*v1.Pod{
- "node1": {&medPriorityPod},
- "node5": {&unschedulablePod},
- },
- }
- if !reflect.DeepEqual(q.nominatedPods, expectedNominatedPods) {
- t.Errorf("Unexpected nominated map after deleting pods. Expected: %v, got: %v", expectedNominatedPods, q.nominatedPods)
- }
- }
- func TestUnschedulablePodsMap(t *testing.T) {
- var pods = []*v1.Pod{
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "p0",
- Namespace: "ns1",
- Annotations: map[string]string{
- "annot1": "val1",
- },
- },
- Status: v1.PodStatus{
- NominatedNodeName: "node1",
- },
- },
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "p1",
- Namespace: "ns1",
- Annotations: map[string]string{
- "annot": "val",
- },
- },
- },
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "p2",
- Namespace: "ns2",
- Annotations: map[string]string{
- "annot2": "val2", "annot3": "val3",
- },
- },
- Status: v1.PodStatus{
- NominatedNodeName: "node3",
- },
- },
- {
- ObjectMeta: metav1.ObjectMeta{
- Name: "p3",
- Namespace: "ns4",
- },
- Status: v1.PodStatus{
- NominatedNodeName: "node1",
- },
- },
- }
- var updatedPods = make([]*v1.Pod, len(pods))
- updatedPods[0] = pods[0].DeepCopy()
- updatedPods[1] = pods[1].DeepCopy()
- updatedPods[3] = pods[3].DeepCopy()
- tests := []struct {
- name string
- podsToAdd []*v1.Pod
- expectedMapAfterAdd map[string]*framework.PodInfo
- podsToUpdate []*v1.Pod
- expectedMapAfterUpdate map[string]*framework.PodInfo
- podsToDelete []*v1.Pod
- expectedMapAfterDelete map[string]*framework.PodInfo
- }{
- {
- name: "create, update, delete subset of pods",
- podsToAdd: []*v1.Pod{pods[0], pods[1], pods[2], pods[3]},
- expectedMapAfterAdd: map[string]*framework.PodInfo{
- util.GetPodFullName(pods[0]): {Pod: pods[0]},
- util.GetPodFullName(pods[1]): {Pod: pods[1]},
- util.GetPodFullName(pods[2]): {Pod: pods[2]},
- util.GetPodFullName(pods[3]): {Pod: pods[3]},
- },
- podsToUpdate: []*v1.Pod{updatedPods[0]},
- expectedMapAfterUpdate: map[string]*framework.PodInfo{
- util.GetPodFullName(pods[0]): {Pod: updatedPods[0]},
- util.GetPodFullName(pods[1]): {Pod: pods[1]},
- util.GetPodFullName(pods[2]): {Pod: pods[2]},
- util.GetPodFullName(pods[3]): {Pod: pods[3]},
- },
- podsToDelete: []*v1.Pod{pods[0], pods[1]},
- expectedMapAfterDelete: map[string]*framework.PodInfo{
- util.GetPodFullName(pods[2]): {Pod: pods[2]},
- util.GetPodFullName(pods[3]): {Pod: pods[3]},
- },
- },
- {
- name: "create, update, delete all",
- podsToAdd: []*v1.Pod{pods[0], pods[3]},
- expectedMapAfterAdd: map[string]*framework.PodInfo{
- util.GetPodFullName(pods[0]): {Pod: pods[0]},
- util.GetPodFullName(pods[3]): {Pod: pods[3]},
- },
- podsToUpdate: []*v1.Pod{updatedPods[3]},
- expectedMapAfterUpdate: map[string]*framework.PodInfo{
- util.GetPodFullName(pods[0]): {Pod: pods[0]},
- util.GetPodFullName(pods[3]): {Pod: updatedPods[3]},
- },
- podsToDelete: []*v1.Pod{pods[0], pods[3]},
- expectedMapAfterDelete: map[string]*framework.PodInfo{},
- },
- {
- name: "delete non-existing and existing pods",
- podsToAdd: []*v1.Pod{pods[1], pods[2]},
- expectedMapAfterAdd: map[string]*framework.PodInfo{
- util.GetPodFullName(pods[1]): {Pod: pods[1]},
- util.GetPodFullName(pods[2]): {Pod: pods[2]},
- },
- podsToUpdate: []*v1.Pod{updatedPods[1]},
- expectedMapAfterUpdate: map[string]*framework.PodInfo{
- util.GetPodFullName(pods[1]): {Pod: updatedPods[1]},
- util.GetPodFullName(pods[2]): {Pod: pods[2]},
- },
- podsToDelete: []*v1.Pod{pods[2], pods[3]},
- expectedMapAfterDelete: map[string]*framework.PodInfo{
- util.GetPodFullName(pods[1]): {Pod: updatedPods[1]},
- },
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- upm := newUnschedulablePodsMap(nil)
- for _, p := range test.podsToAdd {
- upm.addOrUpdate(newPodInfoNoTimestamp(p))
- }
- if !reflect.DeepEqual(upm.podInfoMap, test.expectedMapAfterAdd) {
- t.Errorf("Unexpected map after adding pods. Expected: %v, got: %v",
- test.expectedMapAfterAdd, upm.podInfoMap)
- }
- if len(test.podsToUpdate) > 0 {
- for _, p := range test.podsToUpdate {
- upm.addOrUpdate(newPodInfoNoTimestamp(p))
- }
- if !reflect.DeepEqual(upm.podInfoMap, test.expectedMapAfterUpdate) {
- t.Errorf("Unexpected map after updating pods. Expected: %v, got: %v",
- test.expectedMapAfterUpdate, upm.podInfoMap)
- }
- }
- for _, p := range test.podsToDelete {
- upm.delete(p)
- }
- if !reflect.DeepEqual(upm.podInfoMap, test.expectedMapAfterDelete) {
- t.Errorf("Unexpected map after deleting pods. Expected: %v, got: %v",
- test.expectedMapAfterDelete, upm.podInfoMap)
- }
- upm.clear()
- if len(upm.podInfoMap) != 0 {
- t.Errorf("Expected the map to be empty, but has %v elements.", len(upm.podInfoMap))
- }
- })
- }
- }
- func TestSchedulingQueue_Close(t *testing.T) {
- tests := []struct {
- name string
- q SchedulingQueue
- expectedErr error
- }{
- {
- name: "PriorityQueue close",
- q: NewPriorityQueue(nil, nil),
- expectedErr: fmt.Errorf(queueClosed),
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- wg := sync.WaitGroup{}
- wg.Add(1)
- go func() {
- defer wg.Done()
- pod, err := test.q.Pop()
- if err.Error() != test.expectedErr.Error() {
- t.Errorf("Expected err %q from Pop() if queue is closed, but got %q", test.expectedErr.Error(), err.Error())
- }
- if pod != nil {
- t.Errorf("Expected pod nil from Pop() if queue is closed, but got: %v", pod)
- }
- }()
- test.q.Close()
- wg.Wait()
- })
- }
- }
- // TestRecentlyTriedPodsGoBack tests that pods which are recently tried and are
- // unschedulable go behind other pods with the same priority. This behavior
- // ensures that an unschedulable pod does not block head of the queue when there
- // are frequent events that move pods to the active queue.
- func TestRecentlyTriedPodsGoBack(t *testing.T) {
- q := NewPriorityQueue(nil, nil)
- // Add a few pods to priority queue.
- for i := 0; i < 5; i++ {
- p := v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: fmt.Sprintf("test-pod-%v", i),
- Namespace: "ns1",
- UID: types.UID(fmt.Sprintf("tp00%v", i)),
- },
- Spec: v1.PodSpec{
- Priority: &highPriority,
- },
- Status: v1.PodStatus{
- NominatedNodeName: "node1",
- },
- }
- q.Add(&p)
- }
- // Simulate a pod being popped by the scheduler, determined unschedulable, and
- // then moved back to the active queue.
- p1, err := q.Pop()
- if err != nil {
- t.Errorf("Error while popping the head of the queue: %v", err)
- }
- // Update pod condition to unschedulable.
- podutil.UpdatePodCondition(&p1.Status, &v1.PodCondition{
- Type: v1.PodScheduled,
- Status: v1.ConditionFalse,
- Reason: v1.PodReasonUnschedulable,
- Message: "fake scheduling failure",
- LastProbeTime: metav1.Now(),
- })
- // Put in the unschedulable queue.
- q.AddUnschedulableIfNotPresent(p1, q.SchedulingCycle())
- // Move all unschedulable pods to the active queue.
- q.MoveAllToActiveQueue()
- // Simulation is over. Now let's pop all pods. The pod popped first should be
- // the last one we pop here.
- for i := 0; i < 5; i++ {
- p, err := q.Pop()
- if err != nil {
- t.Errorf("Error while popping pods from the queue: %v", err)
- }
- if (i == 4) != (p1 == p) {
- t.Errorf("A pod tried before is not the last pod popped: i: %v, pod name: %v", i, p.Name)
- }
- }
- }
- // TestPodFailedSchedulingMultipleTimesDoesNotBlockNewerPod tests
- // that a pod determined as unschedulable multiple times doesn't block any newer pod.
- // This behavior ensures that an unschedulable pod does not block head of the queue when there
- // are frequent events that move pods to the active queue.
- func TestPodFailedSchedulingMultipleTimesDoesNotBlockNewerPod(t *testing.T) {
- q := NewPriorityQueue(nil, nil)
- // Add an unschedulable pod to a priority queue.
- // This makes a situation that the pod was tried to schedule
- // and had been determined unschedulable so far.
- unschedulablePod := v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: "test-pod-unscheduled",
- Namespace: "ns1",
- UID: "tp001",
- },
- Spec: v1.PodSpec{
- Priority: &highPriority,
- },
- Status: v1.PodStatus{
- NominatedNodeName: "node1",
- },
- }
- // Update pod condition to unschedulable.
- podutil.UpdatePodCondition(&unschedulablePod.Status, &v1.PodCondition{
- Type: v1.PodScheduled,
- Status: v1.ConditionFalse,
- Reason: v1.PodReasonUnschedulable,
- Message: "fake scheduling failure",
- })
- // Put in the unschedulable queue
- q.AddUnschedulableIfNotPresent(&unschedulablePod, q.SchedulingCycle())
- // Clear its backoff to simulate backoff its expiration
- q.clearPodBackoff(&unschedulablePod)
- // Move all unschedulable pods to the active queue.
- q.MoveAllToActiveQueue()
- // Simulate a pod being popped by the scheduler,
- // At this time, unschedulable pod should be popped.
- p1, err := q.Pop()
- if err != nil {
- t.Errorf("Error while popping the head of the queue: %v", err)
- }
- if p1 != &unschedulablePod {
- t.Errorf("Expected that test-pod-unscheduled was popped, got %v", p1.Name)
- }
- // Assume newer pod was added just after unschedulable pod
- // being popped and before being pushed back to the queue.
- newerPod := v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: "test-newer-pod",
- Namespace: "ns1",
- UID: "tp002",
- CreationTimestamp: metav1.Now(),
- },
- Spec: v1.PodSpec{
- Priority: &highPriority,
- },
- Status: v1.PodStatus{
- NominatedNodeName: "node1",
- },
- }
- q.Add(&newerPod)
- // And then unschedulablePod was determined as unschedulable AGAIN.
- podutil.UpdatePodCondition(&unschedulablePod.Status, &v1.PodCondition{
- Type: v1.PodScheduled,
- Status: v1.ConditionFalse,
- Reason: v1.PodReasonUnschedulable,
- Message: "fake scheduling failure",
- })
- // And then, put unschedulable pod to the unschedulable queue
- q.AddUnschedulableIfNotPresent(&unschedulablePod, q.SchedulingCycle())
- // Clear its backoff to simulate its backoff expiration
- q.clearPodBackoff(&unschedulablePod)
- // Move all unschedulable pods to the active queue.
- q.MoveAllToActiveQueue()
- // At this time, newerPod should be popped
- // because it is the oldest tried pod.
- p2, err2 := q.Pop()
- if err2 != nil {
- t.Errorf("Error while popping the head of the queue: %v", err2)
- }
- if p2 != &newerPod {
- t.Errorf("Expected that test-newer-pod was popped, got %v", p2.Name)
- }
- }
- // TestHighPriorityBackoff tests that a high priority pod does not block
- // other pods if it is unschedulable
- func TestHighProirotyBackoff(t *testing.T) {
- q := NewPriorityQueue(nil, nil)
- midPod := v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: "test-midpod",
- Namespace: "ns1",
- UID: types.UID("tp-mid"),
- },
- Spec: v1.PodSpec{
- Priority: &midPriority,
- },
- Status: v1.PodStatus{
- NominatedNodeName: "node1",
- },
- }
- highPod := v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: "test-highpod",
- Namespace: "ns1",
- UID: types.UID("tp-high"),
- },
- Spec: v1.PodSpec{
- Priority: &highPriority,
- },
- Status: v1.PodStatus{
- NominatedNodeName: "node1",
- },
- }
- q.Add(&midPod)
- q.Add(&highPod)
- // Simulate a pod being popped by the scheduler, determined unschedulable, and
- // then moved back to the active queue.
- p, err := q.Pop()
- if err != nil {
- t.Errorf("Error while popping the head of the queue: %v", err)
- }
- if p != &highPod {
- t.Errorf("Expected to get high prority pod, got: %v", p)
- }
- // Update pod condition to unschedulable.
- podutil.UpdatePodCondition(&p.Status, &v1.PodCondition{
- Type: v1.PodScheduled,
- Status: v1.ConditionFalse,
- Reason: v1.PodReasonUnschedulable,
- Message: "fake scheduling failure",
- })
- // Put in the unschedulable queue.
- q.AddUnschedulableIfNotPresent(p, q.SchedulingCycle())
- // Move all unschedulable pods to the active queue.
- q.MoveAllToActiveQueue()
- p, err = q.Pop()
- if err != nil {
- t.Errorf("Error while popping the head of the queue: %v", err)
- }
- if p != &midPod {
- t.Errorf("Expected to get mid prority pod, got: %v", p)
- }
- }
- // TestHighProirotyFlushUnschedulableQLeftover tests that pods will be moved to
- // activeQ after one minutes if it is in unschedulableQ
- func TestHighProirotyFlushUnschedulableQLeftover(t *testing.T) {
- q := NewPriorityQueue(nil, nil)
- midPod := v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: "test-midpod",
- Namespace: "ns1",
- UID: types.UID("tp-mid"),
- },
- Spec: v1.PodSpec{
- Priority: &midPriority,
- },
- Status: v1.PodStatus{
- NominatedNodeName: "node1",
- },
- }
- highPod := v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: "test-highpod",
- Namespace: "ns1",
- UID: types.UID("tp-high"),
- },
- Spec: v1.PodSpec{
- Priority: &highPriority,
- },
- Status: v1.PodStatus{
- NominatedNodeName: "node1",
- },
- }
- // Update pod condition to highPod.
- podutil.UpdatePodCondition(&highPod.Status, &v1.PodCondition{
- Type: v1.PodScheduled,
- Status: v1.ConditionFalse,
- Reason: v1.PodReasonUnschedulable,
- Message: "fake scheduling failure",
- })
- // Update pod condition to midPod.
- podutil.UpdatePodCondition(&midPod.Status, &v1.PodCondition{
- Type: v1.PodScheduled,
- Status: v1.ConditionFalse,
- Reason: v1.PodReasonUnschedulable,
- Message: "fake scheduling failure",
- })
- addOrUpdateUnschedulablePod(q, &highPod)
- addOrUpdateUnschedulablePod(q, &midPod)
- q.unschedulableQ.podInfoMap[util.GetPodFullName(&highPod)].Timestamp = time.Now().Add(-1 * unschedulableQTimeInterval)
- q.unschedulableQ.podInfoMap[util.GetPodFullName(&midPod)].Timestamp = time.Now().Add(-1 * unschedulableQTimeInterval)
- if p, err := q.Pop(); err != nil || p != &highPod {
- t.Errorf("Expected: %v after Pop, but got: %v", highPriorityPod.Name, p.Name)
- }
- if p, err := q.Pop(); err != nil || p != &midPod {
- t.Errorf("Expected: %v after Pop, but got: %v", medPriorityPod.Name, p.Name)
- }
- }
- type operation func(queue *PriorityQueue, pInfo *framework.PodInfo)
- var (
- addPodActiveQ = func(queue *PriorityQueue, pInfo *framework.PodInfo) {
- queue.lock.Lock()
- queue.activeQ.Add(pInfo)
- queue.lock.Unlock()
- }
- updatePodActiveQ = func(queue *PriorityQueue, pInfo *framework.PodInfo) {
- queue.lock.Lock()
- queue.activeQ.Update(pInfo)
- queue.lock.Unlock()
- }
- addPodUnschedulableQ = func(queue *PriorityQueue, pInfo *framework.PodInfo) {
- queue.lock.Lock()
- // Update pod condition to unschedulable.
- podutil.UpdatePodCondition(&pInfo.Pod.Status, &v1.PodCondition{
- Type: v1.PodScheduled,
- Status: v1.ConditionFalse,
- Reason: v1.PodReasonUnschedulable,
- Message: "fake scheduling failure",
- })
- queue.unschedulableQ.addOrUpdate(pInfo)
- queue.lock.Unlock()
- }
- addPodBackoffQ = func(queue *PriorityQueue, pInfo *framework.PodInfo) {
- queue.lock.Lock()
- queue.podBackoffQ.Add(pInfo)
- queue.lock.Unlock()
- }
- moveAllToActiveQ = func(queue *PriorityQueue, _ *framework.PodInfo) {
- queue.MoveAllToActiveQueue()
- }
- backoffPod = func(queue *PriorityQueue, pInfo *framework.PodInfo) {
- queue.backoffPod(pInfo.Pod)
- }
- flushBackoffQ = func(queue *PriorityQueue, _ *framework.PodInfo) {
- queue.clock.(*clock.FakeClock).Step(2 * time.Second)
- queue.flushBackoffQCompleted()
- }
- )
- // TestPodTimestamp tests the operations related to PodInfo.
- func TestPodTimestamp(t *testing.T) {
- pod1 := &v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: "test-pod-1",
- Namespace: "ns1",
- UID: types.UID("tp-1"),
- },
- Status: v1.PodStatus{
- NominatedNodeName: "node1",
- },
- }
- pod2 := &v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: "test-pod-2",
- Namespace: "ns2",
- UID: types.UID("tp-2"),
- },
- Status: v1.PodStatus{
- NominatedNodeName: "node2",
- },
- }
- var timestamp = time.Now()
- pInfo1 := &framework.PodInfo{
- Pod: pod1,
- Timestamp: timestamp,
- }
- pInfo2 := &framework.PodInfo{
- Pod: pod2,
- Timestamp: timestamp.Add(time.Second),
- }
- tests := []struct {
- name string
- operations []operation
- operands []*framework.PodInfo
- expected []*framework.PodInfo
- }{
- {
- name: "add two pod to activeQ and sort them by the timestamp",
- operations: []operation{
- addPodActiveQ,
- addPodActiveQ,
- },
- operands: []*framework.PodInfo{pInfo2, pInfo1},
- expected: []*framework.PodInfo{pInfo1, pInfo2},
- },
- {
- name: "update two pod to activeQ and sort them by the timestamp",
- operations: []operation{
- updatePodActiveQ,
- updatePodActiveQ,
- },
- operands: []*framework.PodInfo{pInfo2, pInfo1},
- expected: []*framework.PodInfo{pInfo1, pInfo2},
- },
- {
- name: "add two pod to unschedulableQ then move them to activeQ and sort them by the timestamp",
- operations: []operation{
- addPodUnschedulableQ,
- addPodUnschedulableQ,
- moveAllToActiveQ,
- },
- operands: []*framework.PodInfo{pInfo2, pInfo1, nil},
- expected: []*framework.PodInfo{pInfo1, pInfo2},
- },
- {
- name: "add one pod to BackoffQ and move it to activeQ",
- operations: []operation{
- addPodActiveQ,
- addPodBackoffQ,
- backoffPod,
- flushBackoffQ,
- moveAllToActiveQ,
- },
- operands: []*framework.PodInfo{pInfo2, pInfo1, pInfo1, nil, nil},
- expected: []*framework.PodInfo{pInfo1, pInfo2},
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- queue := NewPriorityQueueWithClock(nil, clock.NewFakeClock(timestamp), nil)
- var podInfoList []*framework.PodInfo
- for i, op := range test.operations {
- op(queue, test.operands[i])
- }
- for i := 0; i < len(test.expected); i++ {
- if pInfo, err := queue.activeQ.Pop(); err != nil {
- t.Errorf("Error while popping the head of the queue: %v", err)
- } else {
- podInfoList = append(podInfoList, pInfo.(*framework.PodInfo))
- }
- }
- if !reflect.DeepEqual(test.expected, podInfoList) {
- t.Errorf("Unexpected PodInfo list. Expected: %v, got: %v",
- test.expected, podInfoList)
- }
- })
- }
- }
- // TestPendingPodsMetric tests Prometheus metrics related with pending pods
- func TestPendingPodsMetric(t *testing.T) {
- total := 50
- timestamp := time.Now()
- var pInfos = make([]*framework.PodInfo, 0, total)
- for i := 1; i <= total; i++ {
- p := &framework.PodInfo{
- Pod: &v1.Pod{
- ObjectMeta: metav1.ObjectMeta{
- Name: fmt.Sprintf("test-pod-%d", i),
- Namespace: fmt.Sprintf("ns%d", i),
- UID: types.UID(fmt.Sprintf("tp-%d", i)),
- },
- },
- Timestamp: timestamp,
- }
- pInfos = append(pInfos, p)
- }
- tests := []struct {
- name string
- operations []operation
- operands [][]*framework.PodInfo
- expected []int64
- }{
- {
- name: "add pods to activeQ and unschedulableQ",
- operations: []operation{
- addPodActiveQ,
- addPodUnschedulableQ,
- },
- operands: [][]*framework.PodInfo{
- pInfos[:30],
- pInfos[30:],
- },
- expected: []int64{30, 0, 20},
- },
- {
- name: "add pods to all kinds of queues",
- operations: []operation{
- addPodActiveQ,
- backoffPod,
- addPodBackoffQ,
- addPodUnschedulableQ,
- },
- operands: [][]*framework.PodInfo{
- pInfos[:15],
- pInfos[15:40],
- pInfos[15:40],
- pInfos[40:],
- },
- expected: []int64{15, 25, 10},
- },
- {
- name: "add pods to unschedulableQ and then move all to activeQ",
- operations: []operation{
- addPodUnschedulableQ,
- moveAllToActiveQ,
- },
- operands: [][]*framework.PodInfo{
- pInfos[:total],
- {nil},
- },
- expected: []int64{int64(total), 0, 0},
- },
- {
- name: "make some pods subject to backoff, add pods to unschedulableQ, and then move all to activeQ",
- operations: []operation{
- backoffPod,
- addPodUnschedulableQ,
- moveAllToActiveQ,
- },
- operands: [][]*framework.PodInfo{
- pInfos[:20],
- pInfos[:total],
- {nil},
- },
- expected: []int64{int64(total - 20), 20, 0},
- },
- {
- name: "make some pods subject to backoff, add pods to unschedulableQ/activeQ, move all to activeQ, and finally flush backoffQ",
- operations: []operation{
- backoffPod,
- addPodUnschedulableQ,
- addPodActiveQ,
- moveAllToActiveQ,
- flushBackoffQ,
- },
- operands: [][]*framework.PodInfo{
- pInfos[:20],
- pInfos[:40],
- pInfos[40:],
- {nil},
- {nil},
- },
- expected: []int64{int64(total), 0, 0},
- },
- }
- resetMetrics := func() {
- metrics.ActivePods.Set(0)
- metrics.BackoffPods.Set(0)
- metrics.UnschedulablePods.Set(0)
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- resetMetrics()
- queue := NewPriorityQueueWithClock(nil, clock.NewFakeClock(timestamp), nil)
- for i, op := range test.operations {
- for _, pInfo := range test.operands[i] {
- op(queue, pInfo)
- }
- }
- var activeNum, backoffNum, unschedulableNum float64
- metricProto := &dto.Metric{}
- if err := metrics.ActivePods.Write(metricProto); err != nil {
- t.Errorf("error writing ActivePods metric: %v", err)
- }
- activeNum = metricProto.Gauge.GetValue()
- if int64(activeNum) != test.expected[0] {
- t.Errorf("ActivePods: Expected %v, got %v", test.expected[0], activeNum)
- }
- if err := metrics.BackoffPods.Write(metricProto); err != nil {
- t.Errorf("error writing BackoffPods metric: %v", err)
- }
- backoffNum = metricProto.Gauge.GetValue()
- if int64(backoffNum) != test.expected[1] {
- t.Errorf("BackoffPods: Expected %v, got %v", test.expected[1], backoffNum)
- }
- if err := metrics.UnschedulablePods.Write(metricProto); err != nil {
- t.Errorf("error writing UnschedulablePods metric: %v", err)
- }
- unschedulableNum = metricProto.Gauge.GetValue()
- if int64(unschedulableNum) != test.expected[2] {
- t.Errorf("UnschedulablePods: Expected %v, got %v", test.expected[2], unschedulableNum)
- }
- })
- }
- }
|