123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206 |
- /*
- Copyright 2016 The Kubernetes Authors.
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- */
- package reconciler
- import (
- "testing"
- "time"
- "k8s.io/api/core/v1"
- k8stypes "k8s.io/apimachinery/pkg/types"
- "k8s.io/apimachinery/pkg/util/wait"
- "k8s.io/client-go/informers"
- "k8s.io/client-go/tools/record"
- "k8s.io/kubernetes/pkg/controller"
- "k8s.io/kubernetes/pkg/controller/volume/attachdetach/cache"
- "k8s.io/kubernetes/pkg/controller/volume/attachdetach/statusupdater"
- controllervolumetesting "k8s.io/kubernetes/pkg/controller/volume/attachdetach/testing"
- volumetesting "k8s.io/kubernetes/pkg/volume/testing"
- "k8s.io/kubernetes/pkg/volume/util/operationexecutor"
- "k8s.io/kubernetes/pkg/volume/util/types"
- utilstrings "k8s.io/utils/strings"
- )
- const (
- reconcilerLoopPeriod time.Duration = 0 * time.Millisecond
- syncLoopPeriod time.Duration = 100 * time.Minute
- maxWaitForUnmountDuration time.Duration = 50 * time.Millisecond
- resyncPeriod time.Duration = 5 * time.Minute
- )
- // Calls Run()
- // Verifies there are no calls to attach or detach.
- func Test_Run_Positive_DoNothing(t *testing.T) {
- // Arrange
- volumePluginMgr, fakePlugin := volumetesting.GetTestVolumePluginMgr(t)
- dsw := cache.NewDesiredStateOfWorld(volumePluginMgr)
- asw := cache.NewActualStateOfWorld(volumePluginMgr)
- fakeKubeClient := controllervolumetesting.CreateTestClient()
- fakeRecorder := &record.FakeRecorder{}
- fakeHandler := volumetesting.NewBlockVolumePathHandler()
- ad := operationexecutor.NewOperationExecutor(operationexecutor.NewOperationGenerator(
- fakeKubeClient,
- volumePluginMgr,
- fakeRecorder,
- false, /* checkNodeCapabilitiesBeforeMount */
- fakeHandler))
- informerFactory := informers.NewSharedInformerFactory(fakeKubeClient, controller.NoResyncPeriodFunc())
- nsu := statusupdater.NewNodeStatusUpdater(
- fakeKubeClient, informerFactory.Core().V1().Nodes().Lister(), asw)
- reconciler := NewReconciler(
- reconcilerLoopPeriod, maxWaitForUnmountDuration, syncLoopPeriod, false, dsw, asw, ad, nsu, fakeRecorder)
- // Act
- ch := make(chan struct{})
- go reconciler.Run(ch)
- defer close(ch)
- // Assert
- waitForNewAttacherCallCount(t, 0 /* expectedCallCount */, fakePlugin)
- verifyNewAttacherCallCount(t, true /* expectZeroNewAttacherCallCount */, fakePlugin)
- verifyNewDetacherCallCount(t, true /* expectZeroNewDetacherCallCount */, fakePlugin)
- waitForAttachCallCount(t, 0 /* expectedAttachCallCount */, fakePlugin)
- waitForDetachCallCount(t, 0 /* expectedDetachCallCount */, fakePlugin)
- }
- // Populates desiredStateOfWorld cache with one node/volume/pod tuple.
- // Calls Run()
- // Verifies there is one attach call and no detach calls.
- func Test_Run_Positive_OneDesiredVolumeAttach(t *testing.T) {
- // Arrange
- volumePluginMgr, fakePlugin := volumetesting.GetTestVolumePluginMgr(t)
- dsw := cache.NewDesiredStateOfWorld(volumePluginMgr)
- asw := cache.NewActualStateOfWorld(volumePluginMgr)
- fakeKubeClient := controllervolumetesting.CreateTestClient()
- fakeRecorder := &record.FakeRecorder{}
- fakeHandler := volumetesting.NewBlockVolumePathHandler()
- ad := operationexecutor.NewOperationExecutor(operationexecutor.NewOperationGenerator(
- fakeKubeClient,
- volumePluginMgr,
- fakeRecorder,
- false, /* checkNodeCapabilitiesBeforeMount */
- fakeHandler))
- nsu := statusupdater.NewFakeNodeStatusUpdater(false /* returnError */)
- reconciler := NewReconciler(
- reconcilerLoopPeriod, maxWaitForUnmountDuration, syncLoopPeriod, false, dsw, asw, ad, nsu, fakeRecorder)
- podName := "pod-uid"
- volumeName := v1.UniqueVolumeName("volume-name")
- volumeSpec := controllervolumetesting.GetTestVolumeSpec(string(volumeName), volumeName)
- nodeName := k8stypes.NodeName("node-name")
- dsw.AddNode(nodeName, false /*keepTerminatedPodVolumes*/)
- volumeExists := dsw.VolumeExists(volumeName, nodeName)
- if volumeExists {
- t.Fatalf(
- "Volume %q/node %q should not exist, but it does.",
- volumeName,
- nodeName)
- }
- _, podErr := dsw.AddPod(types.UniquePodName(podName), controllervolumetesting.NewPod(podName, podName), volumeSpec, nodeName)
- if podErr != nil {
- t.Fatalf("AddPod failed. Expected: <no error> Actual: <%v>", podErr)
- }
- // Act
- ch := make(chan struct{})
- go reconciler.Run(ch)
- defer close(ch)
- // Assert
- waitForNewAttacherCallCount(t, 1 /* expectedCallCount */, fakePlugin)
- waitForAttachCallCount(t, 1 /* expectedAttachCallCount */, fakePlugin)
- verifyNewDetacherCallCount(t, true /* expectZeroNewDetacherCallCount */, fakePlugin)
- }
- // Populates desiredStateOfWorld cache with one node/volume/pod tuple.
- // Calls Run()
- // Verifies there is one attach call and no detach calls.
- // Marks the node/volume as unmounted.
- // Deletes the node/volume/pod tuple from desiredStateOfWorld cache.
- // Verifies there is one detach call and no (new) attach calls.
- func Test_Run_Positive_OneDesiredVolumeAttachThenDetachWithUnmountedVolume(t *testing.T) {
- // Arrange
- volumePluginMgr, fakePlugin := volumetesting.GetTestVolumePluginMgr(t)
- dsw := cache.NewDesiredStateOfWorld(volumePluginMgr)
- asw := cache.NewActualStateOfWorld(volumePluginMgr)
- fakeKubeClient := controllervolumetesting.CreateTestClient()
- fakeRecorder := &record.FakeRecorder{}
- fakeHandler := volumetesting.NewBlockVolumePathHandler()
- ad := operationexecutor.NewOperationExecutor(operationexecutor.NewOperationGenerator(
- fakeKubeClient,
- volumePluginMgr,
- fakeRecorder,
- false, /* checkNodeCapabilitiesBeforeMount */
- fakeHandler))
- nsu := statusupdater.NewFakeNodeStatusUpdater(false /* returnError */)
- reconciler := NewReconciler(
- reconcilerLoopPeriod, maxWaitForUnmountDuration, syncLoopPeriod, false, dsw, asw, ad, nsu, fakeRecorder)
- podName := "pod-uid"
- volumeName := v1.UniqueVolumeName("volume-name")
- volumeSpec := controllervolumetesting.GetTestVolumeSpec(string(volumeName), volumeName)
- nodeName := k8stypes.NodeName("node-name")
- dsw.AddNode(nodeName, false /*keepTerminatedPodVolumes*/)
- volumeExists := dsw.VolumeExists(volumeName, nodeName)
- if volumeExists {
- t.Fatalf(
- "Volume %q/node %q should not exist, but it does.",
- volumeName,
- nodeName)
- }
- generatedVolumeName, podAddErr := dsw.AddPod(types.UniquePodName(podName), controllervolumetesting.NewPod(podName, podName), volumeSpec, nodeName)
- if podAddErr != nil {
- t.Fatalf("AddPod failed. Expected: <no error> Actual: <%v>", podAddErr)
- }
- // Act
- ch := make(chan struct{})
- go reconciler.Run(ch)
- defer close(ch)
- // Assert
- waitForNewAttacherCallCount(t, 1 /* expectedCallCount */, fakePlugin)
- verifyNewAttacherCallCount(t, false /* expectZeroNewAttacherCallCount */, fakePlugin)
- waitForAttachCallCount(t, 1 /* expectedAttachCallCount */, fakePlugin)
- verifyNewDetacherCallCount(t, true /* expectZeroNewDetacherCallCount */, fakePlugin)
- waitForDetachCallCount(t, 0 /* expectedDetachCallCount */, fakePlugin)
- // Act
- dsw.DeletePod(types.UniquePodName(podName), generatedVolumeName, nodeName)
- volumeExists = dsw.VolumeExists(generatedVolumeName, nodeName)
- if volumeExists {
- t.Fatalf(
- "Deleted pod %q from volume %q/node %q. Volume should also be deleted but it still exists.",
- podName,
- generatedVolumeName,
- nodeName)
- }
- asw.SetVolumeMountedByNode(generatedVolumeName, nodeName, true /* mounted */)
- asw.SetVolumeMountedByNode(generatedVolumeName, nodeName, false /* mounted */)
- // Assert
- waitForNewDetacherCallCount(t, 1 /* expectedCallCount */, fakePlugin)
- verifyNewAttacherCallCount(t, false /* expectZeroNewAttacherCallCount */, fakePlugin)
- waitForAttachCallCount(t, 1 /* expectedAttachCallCount */, fakePlugin)
- verifyNewDetacherCallCount(t, false /* expectZeroNewDetacherCallCount */, fakePlugin)
- waitForDetachCallCount(t, 1 /* expectedDetachCallCount */, fakePlugin)
- }
- // Populates desiredStateOfWorld cache with one node/volume/pod tuple.
- // Calls Run()
- // Verifies there is one attach call and no detach calls.
- // Deletes the node/volume/pod tuple from desiredStateOfWorld cache without first marking the node/volume as unmounted.
- // Verifies there is one detach call and no (new) attach calls.
- func Test_Run_Positive_OneDesiredVolumeAttachThenDetachWithMountedVolume(t *testing.T) {
- // Arrange
- volumePluginMgr, fakePlugin := volumetesting.GetTestVolumePluginMgr(t)
- dsw := cache.NewDesiredStateOfWorld(volumePluginMgr)
- asw := cache.NewActualStateOfWorld(volumePluginMgr)
- fakeKubeClient := controllervolumetesting.CreateTestClient()
- fakeRecorder := &record.FakeRecorder{}
- fakeHandler := volumetesting.NewBlockVolumePathHandler()
- ad := operationexecutor.NewOperationExecutor(operationexecutor.NewOperationGenerator(
- fakeKubeClient,
- volumePluginMgr,
- fakeRecorder,
- false, /* checkNodeCapabilitiesBeforeMount */
- fakeHandler))
- nsu := statusupdater.NewFakeNodeStatusUpdater(false /* returnError */)
- reconciler := NewReconciler(
- reconcilerLoopPeriod, maxWaitForUnmountDuration, syncLoopPeriod, false, dsw, asw, ad, nsu, fakeRecorder)
- podName := "pod-uid"
- volumeName := v1.UniqueVolumeName("volume-name")
- volumeSpec := controllervolumetesting.GetTestVolumeSpec(string(volumeName), volumeName)
- nodeName := k8stypes.NodeName("node-name")
- dsw.AddNode(nodeName, false /*keepTerminatedPodVolumes*/)
- volumeExists := dsw.VolumeExists(volumeName, nodeName)
- if volumeExists {
- t.Fatalf(
- "Volume %q/node %q should not exist, but it does.",
- volumeName,
- nodeName)
- }
- generatedVolumeName, podAddErr := dsw.AddPod(types.UniquePodName(podName), controllervolumetesting.NewPod(podName, podName), volumeSpec, nodeName)
- if podAddErr != nil {
- t.Fatalf("AddPod failed. Expected: <no error> Actual: <%v>", podAddErr)
- }
- // Act
- ch := make(chan struct{})
- go reconciler.Run(ch)
- defer close(ch)
- // Assert
- waitForNewAttacherCallCount(t, 1 /* expectedCallCount */, fakePlugin)
- verifyNewAttacherCallCount(t, false /* expectZeroNewAttacherCallCount */, fakePlugin)
- waitForAttachCallCount(t, 1 /* expectedAttachCallCount */, fakePlugin)
- verifyNewDetacherCallCount(t, true /* expectZeroNewDetacherCallCount */, fakePlugin)
- waitForDetachCallCount(t, 0 /* expectedDetachCallCount */, fakePlugin)
- // Act
- dsw.DeletePod(types.UniquePodName(podName), generatedVolumeName, nodeName)
- volumeExists = dsw.VolumeExists(generatedVolumeName, nodeName)
- if volumeExists {
- t.Fatalf(
- "Deleted pod %q from volume %q/node %q. Volume should also be deleted but it still exists.",
- podName,
- generatedVolumeName,
- nodeName)
- }
- // Assert -- Timer will triger detach
- waitForNewDetacherCallCount(t, 1 /* expectedCallCount */, fakePlugin)
- verifyNewAttacherCallCount(t, false /* expectZeroNewAttacherCallCount */, fakePlugin)
- waitForAttachCallCount(t, 1 /* expectedAttachCallCount */, fakePlugin)
- verifyNewDetacherCallCount(t, false /* expectZeroNewDetacherCallCount */, fakePlugin)
- waitForDetachCallCount(t, 1 /* expectedDetachCallCount */, fakePlugin)
- }
- // Populates desiredStateOfWorld cache with one node/volume/pod tuple.
- // Has node update fail
- // Calls Run()
- // Verifies there is one attach call and no detach calls.
- // Marks the node/volume as unmounted.
- // Deletes the node/volume/pod tuple from desiredStateOfWorld cache.
- // Verifies there are NO detach call and no (new) attach calls.
- func Test_Run_Negative_OneDesiredVolumeAttachThenDetachWithUnmountedVolumeUpdateStatusFail(t *testing.T) {
- // Arrange
- volumePluginMgr, fakePlugin := volumetesting.GetTestVolumePluginMgr(t)
- dsw := cache.NewDesiredStateOfWorld(volumePluginMgr)
- asw := cache.NewActualStateOfWorld(volumePluginMgr)
- fakeKubeClient := controllervolumetesting.CreateTestClient()
- fakeRecorder := &record.FakeRecorder{}
- fakeHandler := volumetesting.NewBlockVolumePathHandler()
- ad := operationexecutor.NewOperationExecutor(operationexecutor.NewOperationGenerator(
- fakeKubeClient,
- volumePluginMgr,
- fakeRecorder,
- false, /* checkNodeCapabilitiesBeforeMount */
- fakeHandler))
- nsu := statusupdater.NewFakeNodeStatusUpdater(true /* returnError */)
- reconciler := NewReconciler(
- reconcilerLoopPeriod, maxWaitForUnmountDuration, syncLoopPeriod, false, dsw, asw, ad, nsu, fakeRecorder)
- podName := "pod-uid"
- volumeName := v1.UniqueVolumeName("volume-name")
- volumeSpec := controllervolumetesting.GetTestVolumeSpec(string(volumeName), volumeName)
- nodeName := k8stypes.NodeName("node-name")
- dsw.AddNode(nodeName, false /*keepTerminatedPodVolumes*/)
- volumeExists := dsw.VolumeExists(volumeName, nodeName)
- if volumeExists {
- t.Fatalf(
- "Volume %q/node %q should not exist, but it does.",
- volumeName,
- nodeName)
- }
- generatedVolumeName, podAddErr := dsw.AddPod(types.UniquePodName(podName), controllervolumetesting.NewPod(podName, podName), volumeSpec, nodeName)
- if podAddErr != nil {
- t.Fatalf("AddPod failed. Expected: <no error> Actual: <%v>", podAddErr)
- }
- // Act
- ch := make(chan struct{})
- go reconciler.Run(ch)
- defer close(ch)
- // Assert
- waitForNewAttacherCallCount(t, 1 /* expectedCallCount */, fakePlugin)
- verifyNewAttacherCallCount(t, false /* expectZeroNewAttacherCallCount */, fakePlugin)
- waitForAttachCallCount(t, 1 /* expectedAttachCallCount */, fakePlugin)
- verifyNewDetacherCallCount(t, true /* expectZeroNewDetacherCallCount */, fakePlugin)
- waitForDetachCallCount(t, 0 /* expectedDetachCallCount */, fakePlugin)
- // Act
- dsw.DeletePod(types.UniquePodName(podName), generatedVolumeName, nodeName)
- volumeExists = dsw.VolumeExists(generatedVolumeName, nodeName)
- if volumeExists {
- t.Fatalf(
- "Deleted pod %q from volume %q/node %q. Volume should also be deleted but it still exists.",
- podName,
- generatedVolumeName,
- nodeName)
- }
- asw.SetVolumeMountedByNode(generatedVolumeName, nodeName, true /* mounted */)
- asw.SetVolumeMountedByNode(generatedVolumeName, nodeName, false /* mounted */)
- // Assert
- verifyNewDetacherCallCount(t, true /* expectZeroNewDetacherCallCount */, fakePlugin)
- verifyNewAttacherCallCount(t, false /* expectZeroNewAttacherCallCount */, fakePlugin)
- waitForAttachCallCount(t, 1 /* expectedAttachCallCount */, fakePlugin)
- verifyNewDetacherCallCount(t, false /* expectZeroNewDetacherCallCount */, fakePlugin)
- waitForDetachCallCount(t, 0 /* expectedDetachCallCount */, fakePlugin)
- }
- // Creates a volume with accessMode ReadWriteMany
- // Populates desiredStateOfWorld cache with two ode/volume/pod tuples pointing to the created volume
- // Calls Run()
- // Verifies there are two attach calls and no detach calls.
- // Deletes the first node/volume/pod tuple from desiredStateOfWorld cache without first marking the node/volume as unmounted.
- // Verifies there is one detach call and no (new) attach calls.
- // Deletes the second node/volume/pod tuple from desiredStateOfWorld cache without first marking the node/volume as unmounted.
- // Verifies there are two detach calls and no (new) attach calls.
- func Test_Run_OneVolumeAttachAndDetachMultipleNodesWithReadWriteMany(t *testing.T) {
- // Arrange
- volumePluginMgr, fakePlugin := volumetesting.GetTestVolumePluginMgr(t)
- dsw := cache.NewDesiredStateOfWorld(volumePluginMgr)
- asw := cache.NewActualStateOfWorld(volumePluginMgr)
- fakeKubeClient := controllervolumetesting.CreateTestClient()
- fakeRecorder := &record.FakeRecorder{}
- fakeHandler := volumetesting.NewBlockVolumePathHandler()
- ad := operationexecutor.NewOperationExecutor(operationexecutor.NewOperationGenerator(
- fakeKubeClient,
- volumePluginMgr,
- fakeRecorder,
- false, /* checkNodeCapabilitiesBeforeMount */
- fakeHandler))
- nsu := statusupdater.NewFakeNodeStatusUpdater(false /* returnError */)
- reconciler := NewReconciler(
- reconcilerLoopPeriod, maxWaitForUnmountDuration, syncLoopPeriod, false, dsw, asw, ad, nsu, fakeRecorder)
- podName1 := "pod-uid1"
- podName2 := "pod-uid2"
- volumeName := v1.UniqueVolumeName("volume-name")
- volumeSpec := controllervolumetesting.GetTestVolumeSpec(string(volumeName), volumeName)
- volumeSpec.PersistentVolume.Spec.AccessModes = []v1.PersistentVolumeAccessMode{v1.ReadWriteMany}
- nodeName1 := k8stypes.NodeName("node-name1")
- nodeName2 := k8stypes.NodeName(volumetesting.MultiAttachNode)
- dsw.AddNode(nodeName1, false /*keepTerminatedPodVolumes*/)
- dsw.AddNode(nodeName2, false /*keepTerminatedPodVolumes*/)
- generatedVolumeName, podAddErr := dsw.AddPod(types.UniquePodName(podName1), controllervolumetesting.NewPod(podName1, podName1), volumeSpec, nodeName1)
- if podAddErr != nil {
- t.Fatalf("AddPod failed. Expected: <no error> Actual: <%v>", podAddErr)
- }
- _, podAddErr = dsw.AddPod(types.UniquePodName(podName2), controllervolumetesting.NewPod(podName2, podName2), volumeSpec, nodeName2)
- if podAddErr != nil {
- t.Fatalf("AddPod failed. Expected: <no error> Actual: <%v>", podAddErr)
- }
- // Act
- ch := make(chan struct{})
- go reconciler.Run(ch)
- defer close(ch)
- // Assert
- waitForNewAttacherCallCount(t, 2 /* expectedCallCount */, fakePlugin)
- verifyNewAttacherCallCount(t, false /* expectZeroNewAttacherCallCount */, fakePlugin)
- waitForTotalAttachCallCount(t, 2 /* expectedAttachCallCount */, fakePlugin)
- verifyNewDetacherCallCount(t, true /* expectZeroNewDetacherCallCount */, fakePlugin)
- waitForDetachCallCount(t, 0 /* expectedDetachCallCount */, fakePlugin)
- waitForAttachedToNodesCount(t, 2 /* expectedNodeCount */, generatedVolumeName, asw)
- // Act
- dsw.DeletePod(types.UniquePodName(podName1), generatedVolumeName, nodeName1)
- volumeExists := dsw.VolumeExists(generatedVolumeName, nodeName1)
- if volumeExists {
- t.Fatalf(
- "Deleted pod %q from volume %q/node %q. Volume should also be deleted but it still exists.",
- podName1,
- generatedVolumeName,
- nodeName1)
- }
- // Assert -- Timer will triger detach
- waitForNewDetacherCallCount(t, 1 /* expectedCallCount */, fakePlugin)
- verifyNewAttacherCallCount(t, false /* expectZeroNewAttacherCallCount */, fakePlugin)
- waitForTotalAttachCallCount(t, 2 /* expectedAttachCallCount */, fakePlugin)
- verifyNewDetacherCallCount(t, false /* expectZeroNewDetacherCallCount */, fakePlugin)
- waitForTotalDetachCallCount(t, 1 /* expectedDetachCallCount */, fakePlugin)
- // Act
- dsw.DeletePod(types.UniquePodName(podName2), generatedVolumeName, nodeName2)
- volumeExists = dsw.VolumeExists(generatedVolumeName, nodeName2)
- if volumeExists {
- t.Fatalf(
- "Deleted pod %q from volume %q/node %q. Volume should also be deleted but it still exists.",
- podName2,
- generatedVolumeName,
- nodeName2)
- }
- // Assert -- Timer will triger detach
- waitForNewDetacherCallCount(t, 2 /* expectedCallCount */, fakePlugin)
- verifyNewAttacherCallCount(t, false /* expectZeroNewAttacherCallCount */, fakePlugin)
- waitForTotalAttachCallCount(t, 2 /* expectedAttachCallCount */, fakePlugin)
- verifyNewDetacherCallCount(t, false /* expectZeroNewDetacherCallCount */, fakePlugin)
- waitForTotalDetachCallCount(t, 2 /* expectedDetachCallCount */, fakePlugin)
- }
- // Creates a volume with accessMode ReadWriteOnce
- // Populates desiredStateOfWorld cache with two ode/volume/pod tuples pointing to the created volume
- // Calls Run()
- // Verifies there is one attach call and no detach calls.
- // Deletes the node/volume/pod tuple from desiredStateOfWorld which succeeded in attaching
- // Verifies there are two attach call and one detach call.
- func Test_Run_OneVolumeAttachAndDetachMultipleNodesWithReadWriteOnce(t *testing.T) {
- // Arrange
- volumePluginMgr, fakePlugin := volumetesting.GetTestVolumePluginMgr(t)
- dsw := cache.NewDesiredStateOfWorld(volumePluginMgr)
- asw := cache.NewActualStateOfWorld(volumePluginMgr)
- fakeKubeClient := controllervolumetesting.CreateTestClient()
- fakeRecorder := &record.FakeRecorder{}
- fakeHandler := volumetesting.NewBlockVolumePathHandler()
- ad := operationexecutor.NewOperationExecutor(operationexecutor.NewOperationGenerator(
- fakeKubeClient,
- volumePluginMgr,
- fakeRecorder,
- false, /* checkNodeCapabilitiesBeforeMount */
- fakeHandler))
- nsu := statusupdater.NewFakeNodeStatusUpdater(false /* returnError */)
- reconciler := NewReconciler(
- reconcilerLoopPeriod, maxWaitForUnmountDuration, syncLoopPeriod, false, dsw, asw, ad, nsu, fakeRecorder)
- podName1 := "pod-uid1"
- podName2 := "pod-uid2"
- volumeName := v1.UniqueVolumeName("volume-name")
- volumeSpec := controllervolumetesting.GetTestVolumeSpec(string(volumeName), volumeName)
- volumeSpec.PersistentVolume.Spec.AccessModes = []v1.PersistentVolumeAccessMode{v1.ReadWriteOnce}
- nodeName1 := k8stypes.NodeName("node-name1")
- nodeName2 := k8stypes.NodeName("node-name2")
- dsw.AddNode(nodeName1, false /*keepTerminatedPodVolumes*/)
- dsw.AddNode(nodeName2, false /*keepTerminatedPodVolumes*/)
- // Add both pods at the same time to provoke a potential race condition in the reconciler
- generatedVolumeName, podAddErr := dsw.AddPod(types.UniquePodName(podName1), controllervolumetesting.NewPod(podName1, podName1), volumeSpec, nodeName1)
- if podAddErr != nil {
- t.Fatalf("AddPod failed. Expected: <no error> Actual: <%v>", podAddErr)
- }
- _, podAddErr = dsw.AddPod(types.UniquePodName(podName2), controllervolumetesting.NewPod(podName2, podName2), volumeSpec, nodeName2)
- if podAddErr != nil {
- t.Fatalf("AddPod failed. Expected: <no error> Actual: <%v>", podAddErr)
- }
- // Act
- ch := make(chan struct{})
- go reconciler.Run(ch)
- defer close(ch)
- // Assert
- waitForNewAttacherCallCount(t, 1 /* expectedCallCount */, fakePlugin)
- verifyNewAttacherCallCount(t, false /* expectZeroNewAttacherCallCount */, fakePlugin)
- waitForTotalAttachCallCount(t, 1 /* expectedAttachCallCount */, fakePlugin)
- verifyNewDetacherCallCount(t, true /* expectZeroNewDetacherCallCount */, fakePlugin)
- waitForDetachCallCount(t, 0 /* expectedDetachCallCount */, fakePlugin)
- waitForAttachedToNodesCount(t, 1 /* expectedNodeCount */, generatedVolumeName, asw)
- nodesForVolume := asw.GetNodesForAttachedVolume(generatedVolumeName)
- // check if multiattach is marked
- // at least one volume+node should be marked with multiattach error
- nodeAttachedTo := nodesForVolume[0]
- waitForMultiAttachErrorOnNode(t, nodeAttachedTo, dsw)
- // Act
- podToDelete := ""
- if nodesForVolume[0] == nodeName1 {
- podToDelete = podName1
- } else if nodesForVolume[0] == nodeName2 {
- podToDelete = podName2
- } else {
- t.Fatal("Volume attached to unexpected node")
- }
- dsw.DeletePod(types.UniquePodName(podToDelete), generatedVolumeName, nodesForVolume[0])
- volumeExists := dsw.VolumeExists(generatedVolumeName, nodesForVolume[0])
- if volumeExists {
- t.Fatalf(
- "Deleted pod %q from volume %q/node %q. Volume should also be deleted but it still exists.",
- podToDelete,
- generatedVolumeName,
- nodesForVolume[0])
- }
- // Assert
- waitForNewDetacherCallCount(t, 1 /* expectedCallCount */, fakePlugin)
- verifyNewDetacherCallCount(t, false /* expectZeroNewDetacherCallCount */, fakePlugin)
- waitForTotalDetachCallCount(t, 1 /* expectedDetachCallCount */, fakePlugin)
- waitForNewAttacherCallCount(t, 2 /* expectedCallCount */, fakePlugin)
- verifyNewAttacherCallCount(t, false /* expectZeroNewAttacherCallCount */, fakePlugin)
- waitForTotalAttachCallCount(t, 2 /* expectedAttachCallCount */, fakePlugin)
- }
- // Creates a volume with accessMode ReadWriteOnce
- // First create a pod which will try to attach the volume to the a node named "uncertain-node". The attach call for this node will
- // fail for timeout, but the volume will be actually attached to the node after the call.
- // Secondly, delete the this pod.
- // Lastly, create a pod scheduled to a normal node which will trigger attach volume to the node. The attach should return successfully.
- func Test_Run_OneVolumeAttachAndDetachUncertainNodesWithReadWriteOnce(t *testing.T) {
- // Arrange
- volumePluginMgr, _ := volumetesting.GetTestVolumePluginMgr(t)
- dsw := cache.NewDesiredStateOfWorld(volumePluginMgr)
- asw := cache.NewActualStateOfWorld(volumePluginMgr)
- fakeKubeClient := controllervolumetesting.CreateTestClient()
- fakeRecorder := &record.FakeRecorder{}
- fakeHandler := volumetesting.NewBlockVolumePathHandler()
- ad := operationexecutor.NewOperationExecutor(operationexecutor.NewOperationGenerator(
- fakeKubeClient,
- volumePluginMgr,
- fakeRecorder,
- false, /* checkNodeCapabilitiesBeforeMount */
- fakeHandler))
- nsu := statusupdater.NewFakeNodeStatusUpdater(false /* returnError */)
- reconciler := NewReconciler(
- reconcilerLoopPeriod, maxWaitForUnmountDuration, syncLoopPeriod, false, dsw, asw, ad, nsu, fakeRecorder)
- podName1 := "pod-uid1"
- podName2 := "pod-uid2"
- volumeName := v1.UniqueVolumeName("volume-name")
- volumeSpec := controllervolumetesting.GetTestVolumeSpec(string(volumeName), volumeName)
- volumeSpec.PersistentVolume.Spec.AccessModes = []v1.PersistentVolumeAccessMode{v1.ReadWriteOnce}
- nodeName1 := k8stypes.NodeName(volumetesting.UncertainAttachNode)
- nodeName2 := k8stypes.NodeName("node-name2")
- dsw.AddNode(nodeName1, false /*keepTerminatedPodVolumes*/)
- dsw.AddNode(nodeName2, false /*keepTerminatedPodVolumes*/)
- // Act
- ch := make(chan struct{})
- go reconciler.Run(ch)
- defer close(ch)
- // Add the pod in which the volume is attached to the uncertain node
- generatedVolumeName, podAddErr := dsw.AddPod(types.UniquePodName(podName1), controllervolumetesting.NewPod(podName1, podName1), volumeSpec, nodeName1)
- if podAddErr != nil {
- t.Fatalf("AddPod failed. Expected: <no error> Actual: <%v>", podAddErr)
- }
- time.Sleep(1 * time.Second)
- // Volume is added to asw. Because attach operation fails, volume should not reported as attached to the node.
- waitForVolumeAddedToNode(t, generatedVolumeName, nodeName1, asw)
- verifyVolumeAttachedToNode(t, generatedVolumeName, nodeName1, true, asw)
- verifyVolumeReportedAsAttachedToNode(t, generatedVolumeName, nodeName1, true, asw)
- // When volume is added to the node, it is set to mounted by default. Then the status will be updated by checking node status VolumeInUse.
- // Without this, the delete operation will be delayed due to mounted status
- asw.SetVolumeMountedByNode(generatedVolumeName, nodeName1, false /* mounted */)
- dsw.DeletePod(types.UniquePodName(podName1), generatedVolumeName, nodeName1)
- waitForVolumeRemovedFromNode(t, generatedVolumeName, nodeName1, asw)
- // Add a second pod which tries to attach the volume to a different node.
- generatedVolumeName, podAddErr = dsw.AddPod(types.UniquePodName(podName2), controllervolumetesting.NewPod(podName2, podName2), volumeSpec, nodeName2)
- if podAddErr != nil {
- t.Fatalf("AddPod failed. Expected: <no error> Actual: <%v>", podAddErr)
- }
- waitForVolumeAttachedToNode(t, generatedVolumeName, nodeName2, asw)
- verifyVolumeAttachedToNode(t, generatedVolumeName, nodeName2, true, asw)
- }
- // Creates a volume with accessMode ReadWriteOnce
- // First create a pod which will try to attach the volume to the a node named "timeout-node". The attach call for this node will
- // fail for timeout, but the volume will be actually attached to the node after the call.
- // Secondly, delete the this pod.
- // Lastly, create a pod scheduled to a normal node which will trigger attach volume to the node. The attach should return successfully.
- func Test_Run_OneVolumeAttachAndDetachTimeoutNodesWithReadWriteOnce(t *testing.T) {
- // Arrange
- volumePluginMgr, _ := volumetesting.GetTestVolumePluginMgr(t)
- dsw := cache.NewDesiredStateOfWorld(volumePluginMgr)
- asw := cache.NewActualStateOfWorld(volumePluginMgr)
- fakeKubeClient := controllervolumetesting.CreateTestClient()
- fakeRecorder := &record.FakeRecorder{}
- fakeHandler := volumetesting.NewBlockVolumePathHandler()
- ad := operationexecutor.NewOperationExecutor(operationexecutor.NewOperationGenerator(
- fakeKubeClient,
- volumePluginMgr,
- fakeRecorder,
- false, /* checkNodeCapabilitiesBeforeMount */
- fakeHandler))
- nsu := statusupdater.NewFakeNodeStatusUpdater(false /* returnError */)
- reconciler := NewReconciler(
- reconcilerLoopPeriod, maxWaitForUnmountDuration, syncLoopPeriod, false, dsw, asw, ad, nsu, fakeRecorder)
- podName1 := "pod-uid1"
- podName2 := "pod-uid2"
- volumeName := v1.UniqueVolumeName("volume-name")
- volumeSpec := controllervolumetesting.GetTestVolumeSpec(string(volumeName), volumeName)
- volumeSpec.PersistentVolume.Spec.AccessModes = []v1.PersistentVolumeAccessMode{v1.ReadWriteOnce}
- nodeName1 := k8stypes.NodeName(volumetesting.TimeoutAttachNode)
- nodeName2 := k8stypes.NodeName("node-name2")
- dsw.AddNode(nodeName1, false /*keepTerminatedPodVolumes*/)
- dsw.AddNode(nodeName2, false /*keepTerminatedPodVolumes*/)
- // Act
- ch := make(chan struct{})
- go reconciler.Run(ch)
- defer close(ch)
- // Add the pod in which the volume is attached to the timeout node
- generatedVolumeName, podAddErr := dsw.AddPod(types.UniquePodName(podName1), controllervolumetesting.NewPod(podName1, podName1), volumeSpec, nodeName1)
- if podAddErr != nil {
- t.Fatalf("AddPod failed. Expected: <no error> Actual: <%v>", podAddErr)
- }
- // Volume is added to asw. Because attach operation fails, volume should not reported as attached to the node.
- waitForVolumeAddedToNode(t, generatedVolumeName, nodeName1, asw)
- verifyVolumeAttachedToNode(t, generatedVolumeName, nodeName1, false, asw)
- verifyVolumeReportedAsAttachedToNode(t, generatedVolumeName, nodeName1, false, asw)
- // When volume is added to the node, it is set to mounted by default. Then the status will be updated by checking node status VolumeInUse.
- // Without this, the delete operation will be delayed due to mounted status
- asw.SetVolumeMountedByNode(generatedVolumeName, nodeName1, false /* mounted */)
- dsw.DeletePod(types.UniquePodName(podName1), generatedVolumeName, nodeName1)
- waitForVolumeRemovedFromNode(t, generatedVolumeName, nodeName1, asw)
- // Add a second pod which tries to attach the volume to a different node.
- generatedVolumeName, podAddErr = dsw.AddPod(types.UniquePodName(podName2), controllervolumetesting.NewPod(podName2, podName2), volumeSpec, nodeName2)
- if podAddErr != nil {
- t.Fatalf("AddPod failed. Expected: <no error> Actual: <%v>", podAddErr)
- }
- waitForVolumeAttachedToNode(t, generatedVolumeName, nodeName2, asw)
- verifyVolumeAttachedToNode(t, generatedVolumeName, nodeName2, true, asw)
- }
- func Test_ReportMultiAttachError(t *testing.T) {
- type nodeWithPods struct {
- name k8stypes.NodeName
- podNames []string
- }
- tests := []struct {
- name string
- nodes []nodeWithPods
- expectedEvents []string
- }{
- {
- "no pods use the volume",
- []nodeWithPods{
- {"node1", []string{"ns1/pod1"}},
- },
- []string{"Warning FailedAttachVolume Multi-Attach error for volume \"volume-name\" Volume is already exclusively attached to one node and can't be attached to another"},
- },
- {
- "pods in the same namespace use the volume",
- []nodeWithPods{
- {"node1", []string{"ns1/pod1"}},
- {"node2", []string{"ns1/pod2"}},
- },
- []string{"Warning FailedAttachVolume Multi-Attach error for volume \"volume-name\" Volume is already used by pod(s) pod2"},
- },
- {
- "pods in anotother namespace use the volume",
- []nodeWithPods{
- {"node1", []string{"ns1/pod1"}},
- {"node2", []string{"ns2/pod2"}},
- },
- []string{"Warning FailedAttachVolume Multi-Attach error for volume \"volume-name\" Volume is already used by 1 pod(s) in different namespaces"},
- },
- {
- "pods both in the same and anotother namespace use the volume",
- []nodeWithPods{
- {"node1", []string{"ns1/pod1"}},
- {"node2", []string{"ns2/pod2"}},
- {"node3", []string{"ns1/pod3"}},
- },
- []string{"Warning FailedAttachVolume Multi-Attach error for volume \"volume-name\" Volume is already used by pod(s) pod3 and 1 pod(s) in different namespaces"},
- },
- }
- for _, test := range tests {
- // Arrange
- t.Logf("Test %q starting", test.name)
- volumePluginMgr, _ := volumetesting.GetTestVolumePluginMgr(t)
- dsw := cache.NewDesiredStateOfWorld(volumePluginMgr)
- asw := cache.NewActualStateOfWorld(volumePluginMgr)
- fakeKubeClient := controllervolumetesting.CreateTestClient()
- fakeRecorder := record.NewFakeRecorder(100)
- fakeHandler := volumetesting.NewBlockVolumePathHandler()
- ad := operationexecutor.NewOperationExecutor(operationexecutor.NewOperationGenerator(
- fakeKubeClient,
- volumePluginMgr,
- fakeRecorder,
- false, /* checkNodeCapabilitiesBeforeMount */
- fakeHandler))
- nsu := statusupdater.NewFakeNodeStatusUpdater(false /* returnError */)
- rc := NewReconciler(
- reconcilerLoopPeriod, maxWaitForUnmountDuration, syncLoopPeriod, false, dsw, asw, ad, nsu, fakeRecorder)
- nodes := []k8stypes.NodeName{}
- for _, n := range test.nodes {
- dsw.AddNode(n.name, false /*keepTerminatedPodVolumes*/)
- nodes = append(nodes, n.name)
- for _, podName := range n.podNames {
- volumeName := v1.UniqueVolumeName("volume-name")
- volumeSpec := controllervolumetesting.GetTestVolumeSpec(string(volumeName), volumeName)
- volumeSpec.PersistentVolume.Spec.AccessModes = []v1.PersistentVolumeAccessMode{v1.ReadWriteOnce}
- uid := string(n.name) + "-" + podName // unique UID
- namespace, name := utilstrings.SplitQualifiedName(podName)
- pod := controllervolumetesting.NewPod(uid, name)
- pod.Namespace = namespace
- _, err := dsw.AddPod(types.UniquePodName(uid), pod, volumeSpec, n.name)
- if err != nil {
- t.Fatalf("Error adding pod %s to DSW: %s", podName, err)
- }
- }
- }
- // Act
- volumes := dsw.GetVolumesToAttach()
- for _, vol := range volumes {
- if vol.NodeName == "node1" {
- rc.(*reconciler).reportMultiAttachError(vol, nodes)
- }
- }
- // Assert
- close(fakeRecorder.Events)
- index := 0
- for event := range fakeRecorder.Events {
- if len(test.expectedEvents) < index {
- t.Errorf("Test %q: unexpected event received: %s", test.name, event)
- } else {
- expectedEvent := test.expectedEvents[index]
- if expectedEvent != event {
- t.Errorf("Test %q: event %d: expected %q, got %q", test.name, index, expectedEvent, event)
- }
- }
- index++
- }
- for i := index; i < len(test.expectedEvents); i++ {
- t.Errorf("Test %q: event %d: expected %q, got none", test.name, i, test.expectedEvents[i])
- }
- }
- }
- func waitForMultiAttachErrorOnNode(
- t *testing.T,
- attachedNode k8stypes.NodeName,
- dsow cache.DesiredStateOfWorld) {
- multAttachCheckFunc := func() (bool, error) {
- for _, volumeToAttach := range dsow.GetVolumesToAttach() {
- if volumeToAttach.NodeName != attachedNode {
- if volumeToAttach.MultiAttachErrorReported {
- return true, nil
- }
- }
- }
- t.Logf("Warning: MultiAttach error not yet set on Node. Will retry.")
- return false, nil
- }
- err := retryWithExponentialBackOff(100*time.Millisecond, multAttachCheckFunc)
- if err != nil {
- t.Fatalf("Timed out waiting for MultiAttach Error to be set on non-attached node")
- }
- }
- func waitForNewAttacherCallCount(
- t *testing.T,
- expectedCallCount int,
- fakePlugin *volumetesting.FakeVolumePlugin) {
- err := retryWithExponentialBackOff(
- time.Duration(5*time.Millisecond),
- func() (bool, error) {
- actualCallCount := fakePlugin.GetNewAttacherCallCount()
- if actualCallCount >= expectedCallCount {
- return true, nil
- }
- t.Logf(
- "Warning: Wrong NewAttacherCallCount. Expected: <%v> Actual: <%v>. Will retry.",
- expectedCallCount,
- actualCallCount)
- return false, nil
- },
- )
- if err != nil {
- t.Fatalf(
- "Timed out waiting for NewAttacherCallCount. Expected: <%v> Actual: <%v>",
- expectedCallCount,
- fakePlugin.GetNewAttacherCallCount())
- }
- }
- func waitForNewDetacherCallCount(
- t *testing.T,
- expectedCallCount int,
- fakePlugin *volumetesting.FakeVolumePlugin) {
- err := retryWithExponentialBackOff(
- time.Duration(5*time.Millisecond),
- func() (bool, error) {
- actualCallCount := fakePlugin.GetNewDetacherCallCount()
- if actualCallCount >= expectedCallCount {
- return true, nil
- }
- t.Logf(
- "Warning: Wrong NewDetacherCallCount. Expected: <%v> Actual: <%v>. Will retry.",
- expectedCallCount,
- actualCallCount)
- return false, nil
- },
- )
- if err != nil {
- t.Fatalf(
- "Timed out waiting for NewDetacherCallCount. Expected: <%v> Actual: <%v>",
- expectedCallCount,
- fakePlugin.GetNewDetacherCallCount())
- }
- }
- func waitForAttachCallCount(
- t *testing.T,
- expectedAttachCallCount int,
- fakePlugin *volumetesting.FakeVolumePlugin) {
- if len(fakePlugin.GetAttachers()) == 0 && expectedAttachCallCount == 0 {
- return
- }
- err := retryWithExponentialBackOff(
- time.Duration(5*time.Millisecond),
- func() (bool, error) {
- for i, attacher := range fakePlugin.GetAttachers() {
- actualCallCount := attacher.GetAttachCallCount()
- if actualCallCount == expectedAttachCallCount {
- return true, nil
- }
- t.Logf(
- "Warning: Wrong attacher[%v].GetAttachCallCount(). Expected: <%v> Actual: <%v>. Will try next attacher.",
- i,
- expectedAttachCallCount,
- actualCallCount)
- }
- t.Logf(
- "Warning: No attachers have expected AttachCallCount. Expected: <%v>. Will retry.",
- expectedAttachCallCount)
- return false, nil
- },
- )
- if err != nil {
- t.Fatalf(
- "No attachers have expected AttachCallCount. Expected: <%v>",
- expectedAttachCallCount)
- }
- }
- func waitForTotalAttachCallCount(
- t *testing.T,
- expectedAttachCallCount int,
- fakePlugin *volumetesting.FakeVolumePlugin) {
- if len(fakePlugin.GetAttachers()) == 0 && expectedAttachCallCount == 0 {
- return
- }
- err := retryWithExponentialBackOff(
- time.Duration(5*time.Millisecond),
- func() (bool, error) {
- totalCount := 0
- for _, attacher := range fakePlugin.GetAttachers() {
- totalCount += attacher.GetAttachCallCount()
- }
- if totalCount == expectedAttachCallCount {
- return true, nil
- }
- t.Logf(
- "Warning: Wrong total GetAttachCallCount(). Expected: <%v> Actual: <%v>. Will retry.",
- expectedAttachCallCount,
- totalCount)
- return false, nil
- },
- )
- if err != nil {
- t.Fatalf(
- "Total AttachCallCount does not match expected value. Expected: <%v>",
- expectedAttachCallCount)
- }
- }
- func waitForDetachCallCount(
- t *testing.T,
- expectedDetachCallCount int,
- fakePlugin *volumetesting.FakeVolumePlugin) {
- if len(fakePlugin.GetDetachers()) == 0 && expectedDetachCallCount == 0 {
- return
- }
- err := retryWithExponentialBackOff(
- time.Duration(5*time.Millisecond),
- func() (bool, error) {
- for i, detacher := range fakePlugin.GetDetachers() {
- actualCallCount := detacher.GetDetachCallCount()
- if actualCallCount == expectedDetachCallCount {
- return true, nil
- }
- t.Logf(
- "Wrong detacher[%v].GetDetachCallCount(). Expected: <%v> Actual: <%v>. Will try next detacher.",
- i,
- expectedDetachCallCount,
- actualCallCount)
- }
- t.Logf(
- "Warning: No detachers have expected DetachCallCount. Expected: <%v>. Will retry.",
- expectedDetachCallCount)
- return false, nil
- },
- )
- if err != nil {
- t.Fatalf(
- "No detachers have expected DetachCallCount. Expected: <%v>",
- expectedDetachCallCount)
- }
- }
- func waitForTotalDetachCallCount(
- t *testing.T,
- expectedDetachCallCount int,
- fakePlugin *volumetesting.FakeVolumePlugin) {
- if len(fakePlugin.GetDetachers()) == 0 && expectedDetachCallCount == 0 {
- return
- }
- err := retryWithExponentialBackOff(
- time.Duration(5*time.Millisecond),
- func() (bool, error) {
- totalCount := 0
- for _, detacher := range fakePlugin.GetDetachers() {
- totalCount += detacher.GetDetachCallCount()
- }
- if totalCount == expectedDetachCallCount {
- return true, nil
- }
- t.Logf(
- "Warning: Wrong total GetDetachCallCount(). Expected: <%v> Actual: <%v>. Will retry.",
- expectedDetachCallCount,
- totalCount)
- return false, nil
- },
- )
- if err != nil {
- t.Fatalf(
- "Total DetachCallCount does not match expected value. Expected: <%v>",
- expectedDetachCallCount)
- }
- }
- func waitForAttachedToNodesCount(
- t *testing.T,
- expectedNodeCount int,
- volumeName v1.UniqueVolumeName,
- asw cache.ActualStateOfWorld) {
- err := retryWithExponentialBackOff(
- time.Duration(5*time.Millisecond),
- func() (bool, error) {
- count := len(asw.GetNodesForAttachedVolume(volumeName))
- if count == expectedNodeCount {
- return true, nil
- }
- t.Logf(
- "Warning: Wrong number of nodes having <%v> attached. Expected: <%v> Actual: <%v>. Will retry.",
- volumeName,
- expectedNodeCount,
- count)
- return false, nil
- },
- )
- if err != nil {
- count := len(asw.GetNodesForAttachedVolume(volumeName))
- t.Fatalf(
- "Wrong number of nodes having <%v> attached. Expected: <%v> Actual: <%v>",
- volumeName,
- expectedNodeCount,
- count)
- }
- }
- func verifyNewAttacherCallCount(
- t *testing.T,
- expectZeroNewAttacherCallCount bool,
- fakePlugin *volumetesting.FakeVolumePlugin) {
- if expectZeroNewAttacherCallCount &&
- fakePlugin.GetNewAttacherCallCount() != 0 {
- t.Fatalf(
- "Wrong NewAttacherCallCount. Expected: <0> Actual: <%v>",
- fakePlugin.GetNewAttacherCallCount())
- }
- }
- func waitForVolumeAttachedToNode(
- t *testing.T,
- volumeName v1.UniqueVolumeName,
- nodeName k8stypes.NodeName,
- asw cache.ActualStateOfWorld) {
- err := retryWithExponentialBackOff(
- time.Duration(500*time.Millisecond),
- func() (bool, error) {
- if asw.IsVolumeAttachedToNode(volumeName, nodeName) {
- return true, nil
- }
- t.Logf(
- "Warning: Volume <%v> is not attached to node <%v> yet. Will retry.",
- volumeName,
- nodeName)
- return false, nil
- },
- )
- if err != nil && !asw.IsVolumeAttachedToNode(volumeName, nodeName) {
- t.Fatalf(
- "Volume <%v> is not attached to node <%v>.",
- volumeName,
- nodeName)
- }
- }
- func waitForVolumeAddedToNode(
- t *testing.T,
- volumeName v1.UniqueVolumeName,
- nodeName k8stypes.NodeName,
- asw cache.ActualStateOfWorld) {
- err := retryWithExponentialBackOff(
- time.Duration(500*time.Millisecond),
- func() (bool, error) {
- volumes := asw.GetAttachedVolumes()
- for _, volume := range volumes {
- if volume.VolumeName == volumeName && volume.NodeName == nodeName {
- return true, nil
- }
- }
- t.Logf(
- "Warning: Volume <%v> is not added to node <%v> yet. Will retry.",
- volumeName,
- nodeName)
- return false, nil
- },
- )
- if err != nil {
- t.Fatalf(
- "Volume <%v> is not added to node <%v>. %v",
- volumeName,
- nodeName, err)
- }
- }
- func waitForVolumeRemovedFromNode(
- t *testing.T,
- volumeName v1.UniqueVolumeName,
- nodeName k8stypes.NodeName,
- asw cache.ActualStateOfWorld) {
- err := retryWithExponentialBackOff(
- time.Duration(500*time.Millisecond),
- func() (bool, error) {
- volumes := asw.GetAttachedVolumes()
- exist := false
- for _, volume := range volumes {
- if volume.VolumeName == volumeName && volume.NodeName == nodeName {
- exist = true
- }
- }
- if exist {
- t.Logf(
- "Warning: Volume <%v> is not removed from the node <%v> yet. Will retry.",
- volumeName,
- nodeName)
- return false, nil
- }
- return true, nil
- },
- )
- if err != nil {
- t.Fatalf(
- "Volume <%v> is not removed from node <%v>. %v",
- volumeName,
- nodeName, err)
- }
- }
- func verifyVolumeAttachedToNode(
- t *testing.T,
- volumeName v1.UniqueVolumeName,
- nodeName k8stypes.NodeName,
- isAttached bool,
- asw cache.ActualStateOfWorld,
- ) {
- result := asw.IsVolumeAttachedToNode(volumeName, nodeName)
- if result == isAttached {
- return
- }
- t.Fatalf("Check volume <%v> is attached to node <%v>, got %v, expected %v",
- volumeName,
- nodeName,
- result,
- isAttached)
- }
- func verifyVolumeReportedAsAttachedToNode(
- t *testing.T,
- volumeName v1.UniqueVolumeName,
- nodeName k8stypes.NodeName,
- isAttached bool,
- asw cache.ActualStateOfWorld,
- ) {
- result := false
- volumes := asw.GetVolumesToReportAttached()
- for _, volume := range volumes[nodeName] {
- if volume.Name == volumeName {
- result = true
- }
- }
- if result == isAttached {
- return
- }
- t.Fatalf("Check volume <%v> is reported as attached to node <%v>, got %v, expected %v",
- volumeName,
- nodeName,
- result,
- isAttached)
- }
- func verifyNewDetacherCallCount(
- t *testing.T,
- expectZeroNewDetacherCallCount bool,
- fakePlugin *volumetesting.FakeVolumePlugin) {
- if expectZeroNewDetacherCallCount &&
- fakePlugin.GetNewDetacherCallCount() != 0 {
- t.Fatalf("Wrong NewDetacherCallCount. Expected: <0> Actual: <%v>",
- fakePlugin.GetNewDetacherCallCount())
- }
- }
- func retryWithExponentialBackOff(initialDuration time.Duration, fn wait.ConditionFunc) error {
- backoff := wait.Backoff{
- Duration: initialDuration,
- Factor: 3,
- Jitter: 0,
- Steps: 6,
- }
- return wait.ExponentialBackoff(backoff, fn)
- }
|