package_validator_test.go 6.3 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282
  1. /*
  2. Copyright 2017 The Kubernetes Authors.
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. http://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package system
  14. import (
  15. "fmt"
  16. "reflect"
  17. "testing"
  18. "github.com/pkg/errors"
  19. )
  20. func TestExtractUpstreamVersion(t *testing.T) {
  21. for _, test := range []struct {
  22. input string
  23. expected string
  24. }{
  25. {
  26. input: "",
  27. expected: "",
  28. },
  29. {
  30. input: "1.0.6",
  31. expected: "1.0.6",
  32. },
  33. {
  34. input: "1:1.0.6",
  35. expected: "1.0.6",
  36. },
  37. {
  38. input: "1.0.6-2ubuntu2.1",
  39. expected: "1.0.6",
  40. },
  41. {
  42. input: "1:1.0.6-2ubuntu2.1",
  43. expected: "1.0.6",
  44. },
  45. } {
  46. t.Run(fmt.Sprintf("input:%s,expected:%s", test.input, test.expected), func(t *testing.T) {
  47. got := extractUpstreamVersion(test.input)
  48. if test.expected != got {
  49. t.Errorf("extractUpstreamVersion(%q) = %q, want %q", test.input, got, test.expected)
  50. }
  51. })
  52. }
  53. }
  54. func TestToSemVer(t *testing.T) {
  55. for _, test := range []struct {
  56. input string
  57. expected string
  58. }{
  59. {
  60. input: "",
  61. expected: "",
  62. },
  63. {
  64. input: "1.2.3",
  65. expected: "1.2.3",
  66. },
  67. {
  68. input: "1.8.19p1",
  69. expected: "1.8.19",
  70. },
  71. {
  72. input: "1.8.19.p1",
  73. expected: "1.8.19",
  74. },
  75. {
  76. input: "p1",
  77. expected: "",
  78. },
  79. {
  80. input: "1.18",
  81. expected: "1.18.0",
  82. },
  83. {
  84. input: "481",
  85. expected: "481.0.0",
  86. },
  87. {
  88. input: "2.0.10.4",
  89. expected: "2.0.10",
  90. },
  91. {
  92. input: "03",
  93. expected: "3.0.0",
  94. },
  95. {
  96. input: "2.02",
  97. expected: "2.2.0",
  98. },
  99. {
  100. input: "8.0.0095",
  101. expected: "8.0.95",
  102. },
  103. } {
  104. t.Run(fmt.Sprintf("input:%s,expected:%s", test.input, test.expected), func(t *testing.T) {
  105. got := toSemVer(test.input)
  106. if test.expected != got {
  107. t.Errorf("toSemVer(%q) = %q, want %q", test.input, got, test.expected)
  108. }
  109. })
  110. }
  111. }
  112. func TestToSemVerRange(t *testing.T) {
  113. for _, test := range []struct {
  114. input string
  115. expected string
  116. }{
  117. {
  118. input: "",
  119. expected: "",
  120. },
  121. {
  122. input: ">=1.0.0",
  123. expected: ">=1.0.0",
  124. },
  125. {
  126. input: ">=1.0",
  127. expected: ">=1.0.x",
  128. },
  129. {
  130. input: ">=1",
  131. expected: ">=1.x",
  132. },
  133. {
  134. input: ">=1 || !2.3",
  135. expected: ">=1.x || !2.3.x",
  136. },
  137. {
  138. input: ">1 || >3.1.0 !4.2",
  139. expected: ">1.x || >3.1.0 !4.2.x",
  140. },
  141. } {
  142. t.Run(fmt.Sprintf("input:%s,expected:%s", test.input, test.expected), func(t *testing.T) {
  143. got := toSemVerRange(test.input)
  144. if test.expected != got {
  145. t.Errorf("toSemVerRange(%q) = %q, want %q", test.input, got, test.expected)
  146. }
  147. })
  148. }
  149. }
  150. // testPackageManager implements the packageManager interface.
  151. type testPackageManager struct {
  152. packageVersions map[string]string
  153. }
  154. func (m testPackageManager) getPackageVersion(packageName string) (string, error) {
  155. if v, ok := m.packageVersions[packageName]; ok {
  156. return v, nil
  157. }
  158. return "", errors.Errorf("package %q does not exist", packageName)
  159. }
  160. func TestValidatePackageVersion(t *testing.T) {
  161. testKernelRelease := "test-kernel-release"
  162. manager := testPackageManager{
  163. packageVersions: map[string]string{
  164. "foo": "1.0.0",
  165. "bar": "2.1.0",
  166. "bar-" + testKernelRelease: "3.0.0",
  167. },
  168. }
  169. v := &packageValidator{
  170. reporter: DefaultReporter,
  171. kernelRelease: testKernelRelease,
  172. }
  173. for _, test := range []struct {
  174. desc string
  175. specs []PackageSpec
  176. err error
  177. }{
  178. {
  179. desc: "all packages meet the spec",
  180. specs: []PackageSpec{
  181. {Name: "foo", VersionRange: ">=1.0"},
  182. {Name: "bar", VersionRange: ">=2.0 <= 3.0"},
  183. },
  184. },
  185. {
  186. desc: "package version does not meet the spec",
  187. specs: []PackageSpec{
  188. {Name: "foo", VersionRange: ">=1.0"},
  189. {Name: "bar", VersionRange: ">=3.0"},
  190. },
  191. err: errors.New("package \"bar 2.1.0\" does not meet the spec \"bar (>=3.0)\""),
  192. },
  193. {
  194. desc: "package not installed",
  195. specs: []PackageSpec{
  196. {Name: "baz"},
  197. },
  198. err: errors.New("package \"baz\" does not exist"),
  199. },
  200. {
  201. desc: "use variable in package name",
  202. specs: []PackageSpec{
  203. {Name: "bar-${KERNEL_RELEASE}", VersionRange: ">=3.0"},
  204. },
  205. },
  206. } {
  207. t.Run(test.desc, func(t *testing.T) {
  208. _, err := v.validate(test.specs, manager)
  209. if test.err == nil && err != nil {
  210. t.Errorf("%s: v.validate(): err = %s", test.desc, err)
  211. }
  212. if test.err != nil {
  213. if err == nil {
  214. t.Errorf("%s: v.validate() is expected to fail.", test.desc)
  215. } else if test.err.Error() != err.Error() {
  216. t.Errorf("%s: v.validate(): err = %q, want = %q", test.desc, err, test.err)
  217. }
  218. }
  219. })
  220. }
  221. }
  222. func TestApplyPackageOverride(t *testing.T) {
  223. for _, test := range []struct {
  224. name string
  225. overrides []PackageSpecOverride
  226. osDistro string
  227. specs []PackageSpec
  228. expected []PackageSpec
  229. }{
  230. {
  231. name: "foo>=1.0",
  232. specs: []PackageSpec{{Name: "foo", VersionRange: ">=1.0"}},
  233. expected: []PackageSpec{{Name: "foo", VersionRange: ">=1.0"}},
  234. },
  235. {
  236. name: "ubuntu:foo>=1.0/bar>=2.0",
  237. osDistro: "ubuntu",
  238. overrides: []PackageSpecOverride{
  239. {
  240. OSDistro: "ubuntu",
  241. Subtractions: []PackageSpec{{Name: "foo"}},
  242. Additions: []PackageSpec{{Name: "bar", VersionRange: ">=2.0"}},
  243. },
  244. },
  245. specs: []PackageSpec{{Name: "foo", VersionRange: ">=1.0"}},
  246. expected: []PackageSpec{{Name: "bar", VersionRange: ">=2.0"}},
  247. },
  248. {
  249. name: "ubuntu:foo>=1.0/debian:foo",
  250. osDistro: "ubuntu",
  251. overrides: []PackageSpecOverride{
  252. {
  253. OSDistro: "debian",
  254. Subtractions: []PackageSpec{{Name: "foo"}},
  255. },
  256. },
  257. specs: []PackageSpec{{Name: "foo", VersionRange: ">=1.0"}},
  258. expected: []PackageSpec{{Name: "foo", VersionRange: ">=1.0"}},
  259. },
  260. } {
  261. t.Run(test.name, func(t *testing.T) {
  262. got := applyPackageSpecOverride(test.specs, test.overrides, test.osDistro)
  263. if !reflect.DeepEqual(test.expected, got) {
  264. t.Errorf("applyPackageSpecOverride(%+v, %+v, %s) = %+v, want = %+v", test.specs, test.overrides, test.osDistro, got, test.expected)
  265. }
  266. })
  267. }
  268. }