rule.go 11 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359
  1. /*
  2. Copyright 2016 The Kubernetes Authors.
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. http://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package validation
  14. import (
  15. "context"
  16. "errors"
  17. "fmt"
  18. "strings"
  19. "k8s.io/klog"
  20. rbacv1 "k8s.io/api/rbac/v1"
  21. utilerrors "k8s.io/apimachinery/pkg/util/errors"
  22. "k8s.io/apimachinery/pkg/util/sets"
  23. "k8s.io/apiserver/pkg/authentication/serviceaccount"
  24. "k8s.io/apiserver/pkg/authentication/user"
  25. genericapirequest "k8s.io/apiserver/pkg/endpoints/request"
  26. rbacv1helpers "k8s.io/kubernetes/pkg/apis/rbac/v1"
  27. )
  28. type AuthorizationRuleResolver interface {
  29. // GetRoleReferenceRules attempts to resolve the role reference of a RoleBinding or ClusterRoleBinding. The passed namespace should be the namepsace
  30. // of the role binding, the empty string if a cluster role binding.
  31. GetRoleReferenceRules(roleRef rbacv1.RoleRef, namespace string) ([]rbacv1.PolicyRule, error)
  32. // RulesFor returns the list of rules that apply to a given user in a given namespace and error. If an error is returned, the slice of
  33. // PolicyRules may not be complete, but it contains all retrievable rules. This is done because policy rules are purely additive and policy determinations
  34. // can be made on the basis of those rules that are found.
  35. RulesFor(user user.Info, namespace string) ([]rbacv1.PolicyRule, error)
  36. // VisitRulesFor invokes visitor() with each rule that applies to a given user in a given namespace, and each error encountered resolving those rules.
  37. // If visitor() returns false, visiting is short-circuited.
  38. VisitRulesFor(user user.Info, namespace string, visitor func(source fmt.Stringer, rule *rbacv1.PolicyRule, err error) bool)
  39. }
  40. // ConfirmNoEscalation determines if the roles for a given user in a given namespace encompass the provided role.
  41. func ConfirmNoEscalation(ctx context.Context, ruleResolver AuthorizationRuleResolver, rules []rbacv1.PolicyRule) error {
  42. ruleResolutionErrors := []error{}
  43. user, ok := genericapirequest.UserFrom(ctx)
  44. if !ok {
  45. return fmt.Errorf("no user on context")
  46. }
  47. namespace, _ := genericapirequest.NamespaceFrom(ctx)
  48. ownerRules, err := ruleResolver.RulesFor(user, namespace)
  49. if err != nil {
  50. // As per AuthorizationRuleResolver contract, this may return a non fatal error with an incomplete list of policies. Log the error and continue.
  51. klog.V(1).Infof("non-fatal error getting local rules for %v: %v", user, err)
  52. ruleResolutionErrors = append(ruleResolutionErrors, err)
  53. }
  54. ownerRightsCover, missingRights := Covers(ownerRules, rules)
  55. if !ownerRightsCover {
  56. compactMissingRights := missingRights
  57. if compact, err := CompactRules(missingRights); err == nil {
  58. compactMissingRights = compact
  59. }
  60. missingDescriptions := sets.NewString()
  61. for _, missing := range compactMissingRights {
  62. missingDescriptions.Insert(rbacv1helpers.CompactString(missing))
  63. }
  64. msg := fmt.Sprintf("user %q (groups=%q) is attempting to grant RBAC permissions not currently held:\n%s", user.GetName(), user.GetGroups(), strings.Join(missingDescriptions.List(), "\n"))
  65. if len(ruleResolutionErrors) > 0 {
  66. msg = msg + fmt.Sprintf("; resolution errors: %v", ruleResolutionErrors)
  67. }
  68. return errors.New(msg)
  69. }
  70. return nil
  71. }
  72. type DefaultRuleResolver struct {
  73. roleGetter RoleGetter
  74. roleBindingLister RoleBindingLister
  75. clusterRoleGetter ClusterRoleGetter
  76. clusterRoleBindingLister ClusterRoleBindingLister
  77. }
  78. func NewDefaultRuleResolver(roleGetter RoleGetter, roleBindingLister RoleBindingLister, clusterRoleGetter ClusterRoleGetter, clusterRoleBindingLister ClusterRoleBindingLister) *DefaultRuleResolver {
  79. return &DefaultRuleResolver{roleGetter, roleBindingLister, clusterRoleGetter, clusterRoleBindingLister}
  80. }
  81. type RoleGetter interface {
  82. GetRole(namespace, name string) (*rbacv1.Role, error)
  83. }
  84. type RoleBindingLister interface {
  85. ListRoleBindings(namespace string) ([]*rbacv1.RoleBinding, error)
  86. }
  87. type ClusterRoleGetter interface {
  88. GetClusterRole(name string) (*rbacv1.ClusterRole, error)
  89. }
  90. type ClusterRoleBindingLister interface {
  91. ListClusterRoleBindings() ([]*rbacv1.ClusterRoleBinding, error)
  92. }
  93. func (r *DefaultRuleResolver) RulesFor(user user.Info, namespace string) ([]rbacv1.PolicyRule, error) {
  94. visitor := &ruleAccumulator{}
  95. r.VisitRulesFor(user, namespace, visitor.visit)
  96. return visitor.rules, utilerrors.NewAggregate(visitor.errors)
  97. }
  98. type ruleAccumulator struct {
  99. rules []rbacv1.PolicyRule
  100. errors []error
  101. }
  102. func (r *ruleAccumulator) visit(source fmt.Stringer, rule *rbacv1.PolicyRule, err error) bool {
  103. if rule != nil {
  104. r.rules = append(r.rules, *rule)
  105. }
  106. if err != nil {
  107. r.errors = append(r.errors, err)
  108. }
  109. return true
  110. }
  111. func describeSubject(s *rbacv1.Subject, bindingNamespace string) string {
  112. switch s.Kind {
  113. case rbacv1.ServiceAccountKind:
  114. if len(s.Namespace) > 0 {
  115. return fmt.Sprintf("%s %q", s.Kind, s.Name+"/"+s.Namespace)
  116. }
  117. return fmt.Sprintf("%s %q", s.Kind, s.Name+"/"+bindingNamespace)
  118. default:
  119. return fmt.Sprintf("%s %q", s.Kind, s.Name)
  120. }
  121. }
  122. type clusterRoleBindingDescriber struct {
  123. binding *rbacv1.ClusterRoleBinding
  124. subject *rbacv1.Subject
  125. }
  126. func (d *clusterRoleBindingDescriber) String() string {
  127. return fmt.Sprintf("ClusterRoleBinding %q of %s %q to %s",
  128. d.binding.Name,
  129. d.binding.RoleRef.Kind,
  130. d.binding.RoleRef.Name,
  131. describeSubject(d.subject, ""),
  132. )
  133. }
  134. type roleBindingDescriber struct {
  135. binding *rbacv1.RoleBinding
  136. subject *rbacv1.Subject
  137. }
  138. func (d *roleBindingDescriber) String() string {
  139. return fmt.Sprintf("RoleBinding %q of %s %q to %s",
  140. d.binding.Name+"/"+d.binding.Namespace,
  141. d.binding.RoleRef.Kind,
  142. d.binding.RoleRef.Name,
  143. describeSubject(d.subject, d.binding.Namespace),
  144. )
  145. }
  146. func (r *DefaultRuleResolver) VisitRulesFor(user user.Info, namespace string, visitor func(source fmt.Stringer, rule *rbacv1.PolicyRule, err error) bool) {
  147. if clusterRoleBindings, err := r.clusterRoleBindingLister.ListClusterRoleBindings(); err != nil {
  148. if !visitor(nil, nil, err) {
  149. return
  150. }
  151. } else {
  152. sourceDescriber := &clusterRoleBindingDescriber{}
  153. for _, clusterRoleBinding := range clusterRoleBindings {
  154. subjectIndex, applies := appliesTo(user, clusterRoleBinding.Subjects, "")
  155. if !applies {
  156. continue
  157. }
  158. rules, err := r.GetRoleReferenceRules(clusterRoleBinding.RoleRef, "")
  159. if err != nil {
  160. if !visitor(nil, nil, err) {
  161. return
  162. }
  163. continue
  164. }
  165. sourceDescriber.binding = clusterRoleBinding
  166. sourceDescriber.subject = &clusterRoleBinding.Subjects[subjectIndex]
  167. for i := range rules {
  168. if !visitor(sourceDescriber, &rules[i], nil) {
  169. return
  170. }
  171. }
  172. }
  173. }
  174. if len(namespace) > 0 {
  175. if roleBindings, err := r.roleBindingLister.ListRoleBindings(namespace); err != nil {
  176. if !visitor(nil, nil, err) {
  177. return
  178. }
  179. } else {
  180. sourceDescriber := &roleBindingDescriber{}
  181. for _, roleBinding := range roleBindings {
  182. subjectIndex, applies := appliesTo(user, roleBinding.Subjects, namespace)
  183. if !applies {
  184. continue
  185. }
  186. rules, err := r.GetRoleReferenceRules(roleBinding.RoleRef, namespace)
  187. if err != nil {
  188. if !visitor(nil, nil, err) {
  189. return
  190. }
  191. continue
  192. }
  193. sourceDescriber.binding = roleBinding
  194. sourceDescriber.subject = &roleBinding.Subjects[subjectIndex]
  195. for i := range rules {
  196. if !visitor(sourceDescriber, &rules[i], nil) {
  197. return
  198. }
  199. }
  200. }
  201. }
  202. }
  203. }
  204. // GetRoleReferenceRules attempts to resolve the RoleBinding or ClusterRoleBinding.
  205. func (r *DefaultRuleResolver) GetRoleReferenceRules(roleRef rbacv1.RoleRef, bindingNamespace string) ([]rbacv1.PolicyRule, error) {
  206. switch roleRef.Kind {
  207. case "Role":
  208. role, err := r.roleGetter.GetRole(bindingNamespace, roleRef.Name)
  209. if err != nil {
  210. return nil, err
  211. }
  212. return role.Rules, nil
  213. case "ClusterRole":
  214. clusterRole, err := r.clusterRoleGetter.GetClusterRole(roleRef.Name)
  215. if err != nil {
  216. return nil, err
  217. }
  218. return clusterRole.Rules, nil
  219. default:
  220. return nil, fmt.Errorf("unsupported role reference kind: %q", roleRef.Kind)
  221. }
  222. }
  223. // appliesTo returns whether any of the bindingSubjects applies to the specified subject,
  224. // and if true, the index of the first subject that applies
  225. func appliesTo(user user.Info, bindingSubjects []rbacv1.Subject, namespace string) (int, bool) {
  226. for i, bindingSubject := range bindingSubjects {
  227. if appliesToUser(user, bindingSubject, namespace) {
  228. return i, true
  229. }
  230. }
  231. return 0, false
  232. }
  233. func appliesToUser(user user.Info, subject rbacv1.Subject, namespace string) bool {
  234. switch subject.Kind {
  235. case rbacv1.UserKind:
  236. return user.GetName() == subject.Name
  237. case rbacv1.GroupKind:
  238. return has(user.GetGroups(), subject.Name)
  239. case rbacv1.ServiceAccountKind:
  240. // default the namespace to namespace we're working in if its available. This allows rolebindings that reference
  241. // SAs in th local namespace to avoid having to qualify them.
  242. saNamespace := namespace
  243. if len(subject.Namespace) > 0 {
  244. saNamespace = subject.Namespace
  245. }
  246. if len(saNamespace) == 0 {
  247. return false
  248. }
  249. // use a more efficient comparison for RBAC checking
  250. return serviceaccount.MatchesUsername(saNamespace, subject.Name, user.GetName())
  251. default:
  252. return false
  253. }
  254. }
  255. // NewTestRuleResolver returns a rule resolver from lists of role objects.
  256. func NewTestRuleResolver(roles []*rbacv1.Role, roleBindings []*rbacv1.RoleBinding, clusterRoles []*rbacv1.ClusterRole, clusterRoleBindings []*rbacv1.ClusterRoleBinding) (AuthorizationRuleResolver, *StaticRoles) {
  257. r := StaticRoles{
  258. roles: roles,
  259. roleBindings: roleBindings,
  260. clusterRoles: clusterRoles,
  261. clusterRoleBindings: clusterRoleBindings,
  262. }
  263. return newMockRuleResolver(&r), &r
  264. }
  265. func newMockRuleResolver(r *StaticRoles) AuthorizationRuleResolver {
  266. return NewDefaultRuleResolver(r, r, r, r)
  267. }
  268. // StaticRoles is a rule resolver that resolves from lists of role objects.
  269. type StaticRoles struct {
  270. roles []*rbacv1.Role
  271. roleBindings []*rbacv1.RoleBinding
  272. clusterRoles []*rbacv1.ClusterRole
  273. clusterRoleBindings []*rbacv1.ClusterRoleBinding
  274. }
  275. func (r *StaticRoles) GetRole(namespace, name string) (*rbacv1.Role, error) {
  276. if len(namespace) == 0 {
  277. return nil, errors.New("must provide namespace when getting role")
  278. }
  279. for _, role := range r.roles {
  280. if role.Namespace == namespace && role.Name == name {
  281. return role, nil
  282. }
  283. }
  284. return nil, errors.New("role not found")
  285. }
  286. func (r *StaticRoles) GetClusterRole(name string) (*rbacv1.ClusterRole, error) {
  287. for _, clusterRole := range r.clusterRoles {
  288. if clusterRole.Name == name {
  289. return clusterRole, nil
  290. }
  291. }
  292. return nil, errors.New("clusterrole not found")
  293. }
  294. func (r *StaticRoles) ListRoleBindings(namespace string) ([]*rbacv1.RoleBinding, error) {
  295. if len(namespace) == 0 {
  296. return nil, errors.New("must provide namespace when listing role bindings")
  297. }
  298. roleBindingList := []*rbacv1.RoleBinding{}
  299. for _, roleBinding := range r.roleBindings {
  300. if roleBinding.Namespace != namespace {
  301. continue
  302. }
  303. // TODO(ericchiang): need to implement label selectors?
  304. roleBindingList = append(roleBindingList, roleBinding)
  305. }
  306. return roleBindingList, nil
  307. }
  308. func (r *StaticRoles) ListClusterRoleBindings() ([]*rbacv1.ClusterRoleBinding, error) {
  309. return r.clusterRoleBindings, nil
  310. }