gc_admission_test.go 22 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624
  1. /*
  2. Copyright 2016 The Kubernetes Authors.
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. http://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package gc
  14. import (
  15. "fmt"
  16. "strings"
  17. "testing"
  18. appsv1 "k8s.io/api/apps/v1"
  19. corev1 "k8s.io/api/core/v1"
  20. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  21. "k8s.io/apimachinery/pkg/runtime"
  22. "k8s.io/apimachinery/pkg/runtime/schema"
  23. "k8s.io/apiserver/pkg/admission"
  24. "k8s.io/apiserver/pkg/admission/initializer"
  25. "k8s.io/apiserver/pkg/authentication/user"
  26. "k8s.io/apiserver/pkg/authorization/authorizer"
  27. fakediscovery "k8s.io/client-go/discovery/fake"
  28. "k8s.io/client-go/restmapper"
  29. coretesting "k8s.io/client-go/testing"
  30. api "k8s.io/kubernetes/pkg/apis/core"
  31. kubeadmission "k8s.io/kubernetes/pkg/kubeapiserver/admission"
  32. )
  33. type fakeAuthorizer struct{}
  34. func (fakeAuthorizer) Authorize(a authorizer.Attributes) (authorizer.Decision, string, error) {
  35. username := a.GetUser().GetName()
  36. if username == "non-deleter" {
  37. if a.GetVerb() == "delete" {
  38. return authorizer.DecisionNoOpinion, "", nil
  39. }
  40. if a.GetVerb() == "update" && a.GetSubresource() == "finalizers" {
  41. return authorizer.DecisionNoOpinion, "", nil
  42. }
  43. return authorizer.DecisionAllow, "", nil
  44. }
  45. if username == "non-pod-deleter" {
  46. if a.GetVerb() == "delete" && a.GetResource() == "pods" {
  47. return authorizer.DecisionNoOpinion, "", nil
  48. }
  49. if a.GetVerb() == "update" && a.GetResource() == "pods" && a.GetSubresource() == "finalizers" {
  50. return authorizer.DecisionNoOpinion, "", nil
  51. }
  52. return authorizer.DecisionAllow, "", nil
  53. }
  54. if username == "non-rc-deleter" {
  55. if a.GetVerb() == "delete" && a.GetResource() == "replicationcontrollers" {
  56. return authorizer.DecisionNoOpinion, "", nil
  57. }
  58. if a.GetVerb() == "update" && a.GetResource() == "replicationcontrollers" && a.GetSubresource() == "finalizers" {
  59. return authorizer.DecisionNoOpinion, "", nil
  60. }
  61. return authorizer.DecisionAllow, "", nil
  62. }
  63. if username == "non-node-deleter" {
  64. if a.GetVerb() == "delete" && a.GetResource() == "nodes" {
  65. return authorizer.DecisionNoOpinion, "", nil
  66. }
  67. if a.GetVerb() == "update" && a.GetResource() == "nodes" && a.GetSubresource() == "finalizers" {
  68. return authorizer.DecisionNoOpinion, "", nil
  69. }
  70. return authorizer.DecisionAllow, "", nil
  71. }
  72. return authorizer.DecisionAllow, "", nil
  73. }
  74. // newGCPermissionsEnforcement returns the admission controller configured for testing.
  75. func newGCPermissionsEnforcement() (*gcPermissionsEnforcement, error) {
  76. // the pods/status endpoint is ignored by this plugin since old kubelets
  77. // corrupt them. the pod status strategy ensures status updates cannot mutate
  78. // ownerRef.
  79. whiteList := []whiteListItem{
  80. {
  81. groupResource: schema.GroupResource{Resource: "pods"},
  82. subresource: "status",
  83. },
  84. }
  85. gcAdmit := &gcPermissionsEnforcement{
  86. Handler: admission.NewHandler(admission.Create, admission.Update),
  87. whiteList: whiteList,
  88. }
  89. genericPluginInitializer := initializer.New(nil, nil, fakeAuthorizer{})
  90. fakeDiscoveryClient := &fakediscovery.FakeDiscovery{Fake: &coretesting.Fake{}}
  91. fakeDiscoveryClient.Resources = []*metav1.APIResourceList{
  92. {
  93. GroupVersion: corev1.SchemeGroupVersion.String(),
  94. APIResources: []metav1.APIResource{
  95. {Name: "nodes", Namespaced: false, Kind: "Node"},
  96. {Name: "pods", Namespaced: true, Kind: "Pod"},
  97. {Name: "replicationcontrollers", Namespaced: true, Kind: "ReplicationController"},
  98. },
  99. },
  100. {
  101. GroupVersion: appsv1.SchemeGroupVersion.String(),
  102. APIResources: []metav1.APIResource{
  103. {Name: "daemonsets", Namespaced: true, Kind: "DaemonSet"},
  104. },
  105. },
  106. }
  107. restMapperRes, err := restmapper.GetAPIGroupResources(fakeDiscoveryClient)
  108. if err != nil {
  109. return nil, fmt.Errorf("unexpected error while constructing resource list from fake discovery client: %v", err)
  110. }
  111. restMapper := restmapper.NewDiscoveryRESTMapper(restMapperRes)
  112. pluginInitializer := kubeadmission.NewPluginInitializer(nil, restMapper, nil)
  113. initializersChain := admission.PluginInitializers{}
  114. initializersChain = append(initializersChain, genericPluginInitializer)
  115. initializersChain = append(initializersChain, pluginInitializer)
  116. initializersChain.Initialize(gcAdmit)
  117. return gcAdmit, nil
  118. }
  119. func TestGCAdmission(t *testing.T) {
  120. expectNoError := func(err error) bool {
  121. return err == nil
  122. }
  123. expectCantSetOwnerRefError := func(err error) bool {
  124. if err == nil {
  125. return false
  126. }
  127. return strings.Contains(err.Error(), "cannot set an ownerRef on a resource you can't delete")
  128. }
  129. tests := []struct {
  130. name string
  131. username string
  132. resource schema.GroupVersionResource
  133. subresource string
  134. oldObj runtime.Object
  135. newObj runtime.Object
  136. checkError func(error) bool
  137. }{
  138. {
  139. name: "super-user, create, no objectref change",
  140. username: "super",
  141. resource: api.SchemeGroupVersion.WithResource("pods"),
  142. newObj: &api.Pod{},
  143. checkError: expectNoError,
  144. },
  145. {
  146. name: "super-user, create, objectref change",
  147. username: "super",
  148. resource: api.SchemeGroupVersion.WithResource("pods"),
  149. newObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}}}},
  150. checkError: expectNoError,
  151. },
  152. {
  153. name: "non-deleter, create, no objectref change",
  154. username: "non-deleter",
  155. resource: api.SchemeGroupVersion.WithResource("pods"),
  156. newObj: &api.Pod{},
  157. checkError: expectNoError,
  158. },
  159. {
  160. name: "non-deleter, create, objectref change",
  161. username: "non-deleter",
  162. resource: api.SchemeGroupVersion.WithResource("pods"),
  163. newObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}}}},
  164. checkError: expectNoError,
  165. },
  166. {
  167. name: "non-pod-deleter, create, no objectref change",
  168. username: "non-pod-deleter",
  169. resource: api.SchemeGroupVersion.WithResource("pods"),
  170. newObj: &api.Pod{},
  171. checkError: expectNoError,
  172. },
  173. {
  174. name: "non-pod-deleter, create, objectref change",
  175. username: "non-pod-deleter",
  176. resource: api.SchemeGroupVersion.WithResource("pods"),
  177. newObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}}}},
  178. checkError: expectNoError,
  179. },
  180. {
  181. name: "non-pod-deleter, create, objectref change, but not a pod",
  182. username: "non-pod-deleter",
  183. resource: api.SchemeGroupVersion.WithResource("not-pods"),
  184. newObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}}}},
  185. checkError: expectNoError,
  186. },
  187. {
  188. name: "super-user, update, no objectref change",
  189. username: "super",
  190. resource: api.SchemeGroupVersion.WithResource("pods"),
  191. oldObj: &api.Pod{},
  192. newObj: &api.Pod{},
  193. checkError: expectNoError,
  194. },
  195. {
  196. name: "super-user, update, no objectref change two",
  197. username: "super",
  198. resource: api.SchemeGroupVersion.WithResource("pods"),
  199. oldObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}}}},
  200. newObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}}}},
  201. checkError: expectNoError,
  202. },
  203. {
  204. name: "super-user, update, objectref change",
  205. username: "super",
  206. resource: api.SchemeGroupVersion.WithResource("pods"),
  207. oldObj: &api.Pod{},
  208. newObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}}}},
  209. checkError: expectNoError,
  210. },
  211. {
  212. name: "non-deleter, update, no objectref change",
  213. username: "non-deleter",
  214. resource: api.SchemeGroupVersion.WithResource("pods"),
  215. oldObj: &api.Pod{},
  216. newObj: &api.Pod{},
  217. checkError: expectNoError,
  218. },
  219. {
  220. name: "non-deleter, update, no objectref change two",
  221. username: "non-deleter",
  222. resource: api.SchemeGroupVersion.WithResource("pods"),
  223. oldObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}}}},
  224. newObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}}}},
  225. checkError: expectNoError,
  226. },
  227. {
  228. name: "non-deleter, update, objectref change",
  229. username: "non-deleter",
  230. resource: api.SchemeGroupVersion.WithResource("pods"),
  231. oldObj: &api.Pod{},
  232. newObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}}}},
  233. checkError: expectCantSetOwnerRefError,
  234. },
  235. {
  236. name: "non-deleter, update, objectref change two",
  237. username: "non-deleter",
  238. resource: api.SchemeGroupVersion.WithResource("pods"),
  239. oldObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}}}},
  240. newObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}, {Name: "second"}}}},
  241. checkError: expectCantSetOwnerRefError,
  242. },
  243. {
  244. name: "non-pod-deleter, update, no objectref change",
  245. username: "non-pod-deleter",
  246. resource: api.SchemeGroupVersion.WithResource("pods"),
  247. oldObj: &api.Pod{},
  248. newObj: &api.Pod{},
  249. checkError: expectNoError,
  250. },
  251. {
  252. name: "non-pod-deleter, update status, objectref change",
  253. username: "non-pod-deleter",
  254. resource: api.SchemeGroupVersion.WithResource("pods"),
  255. subresource: "status",
  256. oldObj: &api.Pod{},
  257. newObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}}}},
  258. checkError: expectNoError,
  259. },
  260. {
  261. name: "non-pod-deleter, update, objectref change",
  262. username: "non-pod-deleter",
  263. resource: api.SchemeGroupVersion.WithResource("pods"),
  264. oldObj: &api.Pod{},
  265. newObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}}}},
  266. checkError: expectCantSetOwnerRefError,
  267. },
  268. {
  269. name: "non-pod-deleter, update, objectref change, but not a pod",
  270. username: "non-pod-deleter",
  271. resource: api.SchemeGroupVersion.WithResource("not-pods"),
  272. oldObj: &api.Pod{},
  273. newObj: &api.Pod{ObjectMeta: metav1.ObjectMeta{OwnerReferences: []metav1.OwnerReference{{Name: "first"}}}},
  274. checkError: expectNoError,
  275. },
  276. }
  277. for _, tc := range tests {
  278. t.Run(tc.name, func(t *testing.T) {
  279. gcAdmit, err := newGCPermissionsEnforcement()
  280. if err != nil {
  281. t.Error(err)
  282. }
  283. operation := admission.Create
  284. var options runtime.Object = &metav1.CreateOptions{}
  285. if tc.oldObj != nil {
  286. operation = admission.Update
  287. options = &metav1.UpdateOptions{}
  288. }
  289. user := &user.DefaultInfo{Name: tc.username}
  290. attributes := admission.NewAttributesRecord(tc.newObj, tc.oldObj, schema.GroupVersionKind{}, metav1.NamespaceDefault, "foo", tc.resource, tc.subresource, operation, options, false, user)
  291. err = gcAdmit.Validate(attributes, nil)
  292. if !tc.checkError(err) {
  293. t.Errorf("unexpected err: %v", err)
  294. }
  295. })
  296. }
  297. }
  298. func TestBlockOwnerDeletionAdmission(t *testing.T) {
  299. podWithOwnerRefs := func(refs ...metav1.OwnerReference) *api.Pod {
  300. var refSlice []metav1.OwnerReference
  301. refSlice = append(refSlice, refs...)
  302. return &api.Pod{
  303. ObjectMeta: metav1.ObjectMeta{
  304. OwnerReferences: refSlice,
  305. },
  306. }
  307. }
  308. getTrueVar := func() *bool {
  309. ret := true
  310. return &ret
  311. }
  312. getFalseVar := func() *bool {
  313. ret := false
  314. return &ret
  315. }
  316. blockRC1 := metav1.OwnerReference{
  317. APIVersion: "v1",
  318. Kind: "ReplicationController",
  319. Name: "rc1",
  320. BlockOwnerDeletion: getTrueVar(),
  321. }
  322. blockRC2 := metav1.OwnerReference{
  323. APIVersion: "v1",
  324. Kind: "ReplicationController",
  325. Name: "rc2",
  326. BlockOwnerDeletion: getTrueVar(),
  327. }
  328. notBlockRC1 := metav1.OwnerReference{
  329. APIVersion: "v1",
  330. Kind: "ReplicationController",
  331. Name: "rc1",
  332. BlockOwnerDeletion: getFalseVar(),
  333. }
  334. notBlockRC2 := metav1.OwnerReference{
  335. APIVersion: "v1",
  336. Kind: "ReplicationController",
  337. Name: "rc2",
  338. BlockOwnerDeletion: getFalseVar(),
  339. }
  340. nilBlockRC1 := metav1.OwnerReference{
  341. APIVersion: "v1",
  342. Kind: "ReplicationController",
  343. Name: "rc1",
  344. }
  345. nilBlockRC2 := metav1.OwnerReference{
  346. APIVersion: "v1",
  347. Kind: "ReplicationController",
  348. Name: "rc2",
  349. }
  350. blockDS1 := metav1.OwnerReference{
  351. APIVersion: "apps/v1",
  352. Kind: "DaemonSet",
  353. Name: "ds1",
  354. BlockOwnerDeletion: getTrueVar(),
  355. }
  356. notBlockDS1 := metav1.OwnerReference{
  357. APIVersion: "apps/v1",
  358. Kind: "DaemonSet",
  359. Name: "ds1",
  360. BlockOwnerDeletion: getFalseVar(),
  361. }
  362. blockNode := metav1.OwnerReference{
  363. APIVersion: "v1",
  364. Kind: "Node",
  365. Name: "node1",
  366. BlockOwnerDeletion: getTrueVar(),
  367. }
  368. notBlockNode := metav1.OwnerReference{
  369. APIVersion: "v1",
  370. Kind: "Node",
  371. Name: "node",
  372. BlockOwnerDeletion: getFalseVar(),
  373. }
  374. nilBlockNode := metav1.OwnerReference{
  375. APIVersion: "v1",
  376. Kind: "Node",
  377. Name: "node",
  378. }
  379. expectNoError := func(err error) bool {
  380. return err == nil
  381. }
  382. expectCantSetBlockOwnerDeletionError := func(err error) bool {
  383. if err == nil {
  384. return false
  385. }
  386. return strings.Contains(err.Error(), "cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on")
  387. }
  388. tests := []struct {
  389. name string
  390. username string
  391. resource schema.GroupVersionResource
  392. subresource string
  393. oldObj runtime.Object
  394. newObj runtime.Object
  395. checkError func(error) bool
  396. }{
  397. // cases for create
  398. {
  399. name: "super-user, create, no ownerReferences",
  400. username: "super",
  401. resource: api.SchemeGroupVersion.WithResource("pods"),
  402. newObj: podWithOwnerRefs(),
  403. checkError: expectNoError,
  404. },
  405. {
  406. name: "super-user, create, all ownerReferences have blockOwnerDeletion=false",
  407. username: "super",
  408. resource: api.SchemeGroupVersion.WithResource("pods"),
  409. newObj: podWithOwnerRefs(notBlockRC1, notBlockRC2),
  410. checkError: expectNoError,
  411. },
  412. {
  413. name: "super-user, create, some ownerReferences have blockOwnerDeletion=true",
  414. username: "super",
  415. resource: api.SchemeGroupVersion.WithResource("pods"),
  416. newObj: podWithOwnerRefs(blockRC1, blockRC2, blockNode),
  417. checkError: expectNoError,
  418. },
  419. {
  420. name: "non-rc-deleter, create, no ownerReferences",
  421. username: "non-rc-deleter",
  422. resource: api.SchemeGroupVersion.WithResource("pods"),
  423. newObj: podWithOwnerRefs(),
  424. checkError: expectNoError,
  425. },
  426. {
  427. name: "non-rc-deleter, create, all ownerReferences have blockOwnerDeletion=false or nil",
  428. username: "non-rc-deleter",
  429. resource: api.SchemeGroupVersion.WithResource("pods"),
  430. newObj: podWithOwnerRefs(notBlockRC1, nilBlockRC2),
  431. checkError: expectNoError,
  432. },
  433. {
  434. name: "non-node-deleter, create, all ownerReferences have blockOwnerDeletion=false",
  435. username: "non-node-deleter",
  436. resource: api.SchemeGroupVersion.WithResource("pods"),
  437. newObj: podWithOwnerRefs(notBlockNode),
  438. checkError: expectNoError,
  439. },
  440. {
  441. name: "non-rc-deleter, create, some ownerReferences have blockOwnerDeletion=true",
  442. username: "non-rc-deleter",
  443. resource: api.SchemeGroupVersion.WithResource("pods"),
  444. newObj: podWithOwnerRefs(blockRC1, notBlockRC2),
  445. checkError: expectCantSetBlockOwnerDeletionError,
  446. },
  447. {
  448. name: "non-rc-deleter, create, some ownerReferences have blockOwnerDeletion=true, but are pointing to daemonset",
  449. username: "non-rc-deleter",
  450. resource: api.SchemeGroupVersion.WithResource("pods"),
  451. newObj: podWithOwnerRefs(blockDS1),
  452. checkError: expectNoError,
  453. },
  454. {
  455. name: "non-node-deleter, create, some ownerReferences have blockOwnerDeletion=true",
  456. username: "non-node-deleter",
  457. resource: api.SchemeGroupVersion.WithResource("pods"),
  458. newObj: podWithOwnerRefs(blockNode),
  459. checkError: expectCantSetBlockOwnerDeletionError,
  460. },
  461. // cases are for update
  462. {
  463. name: "super-user, update, no ownerReferences change blockOwnerDeletion",
  464. username: "super",
  465. resource: api.SchemeGroupVersion.WithResource("pods"),
  466. oldObj: podWithOwnerRefs(nilBlockRC1, nilBlockNode),
  467. newObj: podWithOwnerRefs(notBlockRC1, notBlockNode),
  468. checkError: expectNoError,
  469. },
  470. {
  471. name: "super-user, update, some ownerReferences change to blockOwnerDeletion=true",
  472. username: "super",
  473. resource: api.SchemeGroupVersion.WithResource("pods"),
  474. oldObj: podWithOwnerRefs(notBlockRC1, notBlockNode),
  475. newObj: podWithOwnerRefs(blockRC1, blockNode),
  476. checkError: expectNoError,
  477. },
  478. {
  479. name: "super-user, update, add new ownerReferences with blockOwnerDeletion=true",
  480. username: "super",
  481. resource: api.SchemeGroupVersion.WithResource("pods"),
  482. oldObj: podWithOwnerRefs(),
  483. newObj: podWithOwnerRefs(blockRC1, blockNode),
  484. checkError: expectNoError,
  485. },
  486. {
  487. name: "non-rc-deleter, update, no ownerReferences change blockOwnerDeletion",
  488. username: "non-rc-deleter",
  489. resource: api.SchemeGroupVersion.WithResource("pods"),
  490. oldObj: podWithOwnerRefs(nilBlockRC1),
  491. newObj: podWithOwnerRefs(notBlockRC1),
  492. checkError: expectNoError,
  493. },
  494. {
  495. name: "non-rc-deleter, update, some ownerReferences change from blockOwnerDeletion=false to true",
  496. username: "non-rc-deleter",
  497. resource: api.SchemeGroupVersion.WithResource("pods"),
  498. oldObj: podWithOwnerRefs(notBlockRC1),
  499. newObj: podWithOwnerRefs(blockRC1),
  500. checkError: expectCantSetBlockOwnerDeletionError,
  501. },
  502. {
  503. name: "non-rc-deleter, update, some ownerReferences change from blockOwnerDeletion=nil to true",
  504. username: "non-rc-deleter",
  505. resource: api.SchemeGroupVersion.WithResource("pods"),
  506. oldObj: podWithOwnerRefs(nilBlockRC1),
  507. newObj: podWithOwnerRefs(blockRC1),
  508. checkError: expectCantSetBlockOwnerDeletionError,
  509. },
  510. {
  511. name: "non-node-deleter, update, some ownerReferences change from blockOwnerDeletion=nil to true",
  512. username: "non-node-deleter",
  513. resource: api.SchemeGroupVersion.WithResource("pods"),
  514. oldObj: podWithOwnerRefs(nilBlockNode),
  515. newObj: podWithOwnerRefs(blockNode),
  516. checkError: expectCantSetBlockOwnerDeletionError,
  517. },
  518. {
  519. name: "non-rc-deleter, update, some ownerReferences change from blockOwnerDeletion=true to false",
  520. username: "non-rc-deleter",
  521. resource: api.SchemeGroupVersion.WithResource("pods"),
  522. oldObj: podWithOwnerRefs(blockRC1),
  523. newObj: podWithOwnerRefs(notBlockRC1),
  524. checkError: expectNoError,
  525. },
  526. {
  527. name: "non-node-deleter, update, some ownerReferences change from blockOwnerDeletion=true to false",
  528. username: "non-node-deleter",
  529. resource: api.SchemeGroupVersion.WithResource("pods"),
  530. oldObj: podWithOwnerRefs(blockNode),
  531. newObj: podWithOwnerRefs(notBlockNode),
  532. checkError: expectNoError,
  533. },
  534. {
  535. name: "non-rc-deleter, update, some ownerReferences change blockOwnerDeletion, but all such references are to daemonset",
  536. username: "non-rc-deleter",
  537. resource: api.SchemeGroupVersion.WithResource("pods"),
  538. oldObj: podWithOwnerRefs(notBlockDS1),
  539. newObj: podWithOwnerRefs(blockDS1),
  540. checkError: expectNoError,
  541. },
  542. {
  543. name: "non-rc-deleter, update, add new ownerReferences with blockOwnerDeletion=nil or false",
  544. username: "non-rc-deleter",
  545. resource: api.SchemeGroupVersion.WithResource("pods"),
  546. oldObj: podWithOwnerRefs(),
  547. newObj: podWithOwnerRefs(notBlockRC1, nilBlockRC2),
  548. checkError: expectNoError,
  549. },
  550. {
  551. name: "non-rc-deleter, update, add new ownerReferences with blockOwnerDeletion=true",
  552. username: "non-rc-deleter",
  553. resource: api.SchemeGroupVersion.WithResource("pods"),
  554. oldObj: podWithOwnerRefs(),
  555. newObj: podWithOwnerRefs(blockRC1),
  556. checkError: expectCantSetBlockOwnerDeletionError,
  557. },
  558. {
  559. name: "non-rc-deleter, update, add new ownerReferences with blockOwnerDeletion=true, but the references are to daemonset",
  560. username: "non-rc-deleter",
  561. resource: api.SchemeGroupVersion.WithResource("pods"),
  562. oldObj: podWithOwnerRefs(),
  563. newObj: podWithOwnerRefs(blockDS1),
  564. checkError: expectNoError,
  565. },
  566. {
  567. name: "non-node-deleter, update, add ownerReferences with blockOwnerDeletion=true",
  568. username: "non-node-deleter",
  569. resource: api.SchemeGroupVersion.WithResource("pods"),
  570. oldObj: podWithOwnerRefs(),
  571. newObj: podWithOwnerRefs(blockNode),
  572. checkError: expectCantSetBlockOwnerDeletionError,
  573. },
  574. }
  575. gcAdmit, err := newGCPermissionsEnforcement()
  576. if err != nil {
  577. t.Error(err)
  578. }
  579. for _, tc := range tests {
  580. operation := admission.Create
  581. var options runtime.Object = &metav1.CreateOptions{}
  582. if tc.oldObj != nil {
  583. operation = admission.Update
  584. options = &metav1.UpdateOptions{}
  585. }
  586. user := &user.DefaultInfo{Name: tc.username}
  587. attributes := admission.NewAttributesRecord(tc.newObj, tc.oldObj, schema.GroupVersionKind{}, metav1.NamespaceDefault, "foo", tc.resource, tc.subresource, operation, options, false, user)
  588. err := gcAdmit.Validate(attributes, nil)
  589. if !tc.checkError(err) {
  590. t.Errorf("%v: unexpected err: %v", tc.name, err)
  591. }
  592. }
  593. }