pdb_test.go 9.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369
  1. /*
  2. Copyright 2017 The Kubernetes Authors.
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. http://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package versioned
  14. import (
  15. "reflect"
  16. "testing"
  17. policy "k8s.io/api/policy/v1beta1"
  18. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  19. "k8s.io/apimachinery/pkg/util/intstr"
  20. )
  21. func TestPodDisruptionBudgetV1Generate(t *testing.T) {
  22. name := "foo"
  23. minAvailable := "5"
  24. minAvailableIS := intstr.Parse(minAvailable)
  25. defaultMinAvailableIS := intstr.Parse("1")
  26. selector := "app=foo"
  27. labelSelector, err := metav1.ParseToLabelSelector(selector)
  28. if err != nil {
  29. t.Errorf("unexpected error: %v", err)
  30. }
  31. tests := []struct {
  32. name string
  33. params map[string]interface{}
  34. expectErrMsg string
  35. expectPDB *policy.PodDisruptionBudget
  36. }{
  37. {
  38. name: "test-valid-use",
  39. params: map[string]interface{}{
  40. "name": name,
  41. "min-available": minAvailable,
  42. "selector": selector,
  43. },
  44. expectPDB: &policy.PodDisruptionBudget{
  45. ObjectMeta: metav1.ObjectMeta{
  46. Name: name,
  47. },
  48. Spec: policy.PodDisruptionBudgetSpec{
  49. MinAvailable: &minAvailableIS,
  50. Selector: labelSelector,
  51. },
  52. },
  53. },
  54. {
  55. name: "test-missing-name-param",
  56. params: map[string]interface{}{
  57. "min-available": minAvailable,
  58. "selector": selector,
  59. },
  60. expectErrMsg: "Parameter: name is required",
  61. },
  62. {
  63. name: "test-blank-name-param",
  64. params: map[string]interface{}{
  65. "name": "",
  66. "min-available": minAvailable,
  67. "selector": selector,
  68. },
  69. expectErrMsg: "Parameter: name is required",
  70. },
  71. {
  72. name: "test-invalid-name-param",
  73. params: map[string]interface{}{
  74. "name": 1,
  75. "min-available": minAvailable,
  76. "selector": selector,
  77. },
  78. expectErrMsg: "expected string, found int for 'name'",
  79. },
  80. {
  81. name: "test-missing-min-available-param",
  82. params: map[string]interface{}{
  83. "name": name,
  84. "selector": selector,
  85. },
  86. expectErrMsg: "expected string, found <nil> for 'min-available'",
  87. },
  88. {
  89. name: "test-blank-min-available-param",
  90. params: map[string]interface{}{
  91. "name": name,
  92. "min-available": "",
  93. "selector": selector,
  94. },
  95. expectPDB: &policy.PodDisruptionBudget{
  96. ObjectMeta: metav1.ObjectMeta{
  97. Name: name,
  98. },
  99. Spec: policy.PodDisruptionBudgetSpec{
  100. MinAvailable: &defaultMinAvailableIS,
  101. Selector: labelSelector,
  102. },
  103. },
  104. },
  105. {
  106. name: "test-invalid-min-available-param",
  107. params: map[string]interface{}{
  108. "name": name,
  109. "min-available": 1,
  110. "selector": selector,
  111. },
  112. expectErrMsg: "expected string, found int for 'min-available'",
  113. },
  114. {
  115. name: "test-missing-selector-param",
  116. params: map[string]interface{}{
  117. "name": name,
  118. "min-available": minAvailable,
  119. },
  120. expectErrMsg: "Parameter: selector is required",
  121. },
  122. {
  123. name: "test-blank-selector-param",
  124. params: map[string]interface{}{
  125. "name": name,
  126. "min-available": minAvailable,
  127. "selector": "",
  128. },
  129. expectErrMsg: "Parameter: selector is required",
  130. },
  131. {
  132. name: "test-invalid-selector-param",
  133. params: map[string]interface{}{
  134. "name": name,
  135. "min-available": minAvailable,
  136. "selector": 1,
  137. },
  138. expectErrMsg: "expected string, found int for 'selector'",
  139. },
  140. }
  141. generator := PodDisruptionBudgetV1Generator{}
  142. for _, tt := range tests {
  143. t.Run(tt.name, func(t *testing.T) {
  144. obj, err := generator.Generate(tt.params)
  145. switch {
  146. case tt.expectErrMsg != "" && err != nil:
  147. if err.Error() != tt.expectErrMsg {
  148. t.Errorf("test '%s': expect error '%s', but saw '%s'", tt.name, tt.expectErrMsg, err.Error())
  149. }
  150. return
  151. case tt.expectErrMsg != "" && err == nil:
  152. t.Errorf("test '%s': expected error '%s' and didn't get one", tt.name, tt.expectErrMsg)
  153. return
  154. case tt.expectErrMsg == "" && err != nil:
  155. t.Errorf("test '%s': unexpected error %s", tt.name, err.Error())
  156. return
  157. }
  158. if !reflect.DeepEqual(obj.(*policy.PodDisruptionBudget), tt.expectPDB) {
  159. t.Errorf("test '%s': expected:\n%#v\nsaw:\n%#v", tt.name, tt.expectPDB, obj.(*policy.PodDisruptionBudget))
  160. }
  161. })
  162. }
  163. }
  164. func TestPodDisruptionBudgetV2Generate(t *testing.T) {
  165. name := "foo"
  166. minAvailable := "1"
  167. minAvailableIS := intstr.Parse(minAvailable)
  168. maxUnavailable := "5%"
  169. maxUnavailableIS := intstr.Parse(maxUnavailable)
  170. selector := "app=foo"
  171. labelSelector, err := metav1.ParseToLabelSelector(selector)
  172. if err != nil {
  173. t.Errorf("unexpected error: %v", err)
  174. }
  175. tests := []struct {
  176. name string
  177. params map[string]interface{}
  178. expectErrMsg string
  179. expectPDB *policy.PodDisruptionBudget
  180. }{
  181. {
  182. name: "test-valid-min-available",
  183. params: map[string]interface{}{
  184. "name": name,
  185. "min-available": minAvailable,
  186. "max-unavailable": "",
  187. "selector": selector,
  188. },
  189. expectPDB: &policy.PodDisruptionBudget{
  190. ObjectMeta: metav1.ObjectMeta{
  191. Name: name,
  192. },
  193. Spec: policy.PodDisruptionBudgetSpec{
  194. MinAvailable: &minAvailableIS,
  195. Selector: labelSelector,
  196. },
  197. },
  198. },
  199. {
  200. name: "test-valid-max-available",
  201. params: map[string]interface{}{
  202. "name": name,
  203. "min-available": "",
  204. "max-unavailable": maxUnavailable,
  205. "selector": selector,
  206. },
  207. expectPDB: &policy.PodDisruptionBudget{
  208. ObjectMeta: metav1.ObjectMeta{
  209. Name: name,
  210. },
  211. Spec: policy.PodDisruptionBudgetSpec{
  212. MaxUnavailable: &maxUnavailableIS,
  213. Selector: labelSelector,
  214. },
  215. },
  216. },
  217. {
  218. name: "test-missing-name-param",
  219. params: map[string]interface{}{
  220. "min-available": "",
  221. "max-unavailable": "",
  222. "selector": selector,
  223. },
  224. expectErrMsg: "Parameter: name is required",
  225. },
  226. {
  227. name: "test-blank-name-param",
  228. params: map[string]interface{}{
  229. "name": "",
  230. "min-available": "",
  231. "max-unavailable": "",
  232. "selector": selector,
  233. },
  234. expectErrMsg: "Parameter: name is required",
  235. },
  236. {
  237. name: "test-invalid-name-param",
  238. params: map[string]interface{}{
  239. "name": 1,
  240. "min-available": "",
  241. "max-unavailable": "",
  242. "selector": selector,
  243. },
  244. expectErrMsg: "expected string, found int for 'name'",
  245. },
  246. {
  247. name: "test-missing-min-available-param",
  248. params: map[string]interface{}{
  249. "name": name,
  250. "max-unavailable": "",
  251. "selector": selector,
  252. },
  253. expectErrMsg: "expected string, found <nil> for 'min-available'",
  254. },
  255. {
  256. name: "test-invalid-min-available-param",
  257. params: map[string]interface{}{
  258. "name": name,
  259. "min-available": 1,
  260. "max-unavailable": "",
  261. "selector": selector,
  262. },
  263. expectErrMsg: "expected string, found int for 'min-available'",
  264. },
  265. {
  266. name: "test-missing-max-available-param",
  267. params: map[string]interface{}{
  268. "name": name,
  269. "min-available": "",
  270. "selector": selector,
  271. },
  272. expectErrMsg: "expected string, found <nil> for 'max-unavailable'",
  273. },
  274. {
  275. name: "test-invalid-max-available-param",
  276. params: map[string]interface{}{
  277. "name": name,
  278. "min-available": "",
  279. "max-unavailable": 1,
  280. "selector": selector,
  281. },
  282. expectErrMsg: "expected string, found int for 'max-unavailable'",
  283. },
  284. {
  285. name: "test-blank-min-available-max-unavailable-param",
  286. params: map[string]interface{}{
  287. "name": name,
  288. "min-available": "",
  289. "max-unavailable": "",
  290. "selector": selector,
  291. },
  292. expectErrMsg: "one of min-available or max-unavailable must be specified",
  293. },
  294. {
  295. name: "test-min-available-max-unavailable-param",
  296. params: map[string]interface{}{
  297. "name": name,
  298. "min-available": minAvailable,
  299. "max-unavailable": maxUnavailable,
  300. "selector": selector,
  301. },
  302. expectErrMsg: "min-available and max-unavailable cannot be both specified",
  303. },
  304. {
  305. name: "test-missing-selector-param",
  306. params: map[string]interface{}{
  307. "name": name,
  308. "min-available": "",
  309. "max-unavailable": "",
  310. },
  311. expectErrMsg: "Parameter: selector is required",
  312. },
  313. {
  314. name: "test-blank-selector-param",
  315. params: map[string]interface{}{
  316. "name": name,
  317. "min-available": "",
  318. "max-unavailable": "",
  319. "selector": "",
  320. },
  321. expectErrMsg: "Parameter: selector is required",
  322. },
  323. {
  324. name: "test-invalid-selector-param",
  325. params: map[string]interface{}{
  326. "name": name,
  327. "min-available": "",
  328. "max-unavailable": "",
  329. "selector": 1,
  330. },
  331. expectErrMsg: "expected string, found int for 'selector'",
  332. },
  333. }
  334. generator := PodDisruptionBudgetV2Generator{}
  335. for _, tt := range tests {
  336. t.Run(tt.name, func(t *testing.T) {
  337. obj, err := generator.Generate(tt.params)
  338. switch {
  339. case tt.expectErrMsg != "" && err != nil:
  340. if err.Error() != tt.expectErrMsg {
  341. t.Errorf("test '%s': expect error '%s', but saw '%s'", tt.name, tt.expectErrMsg, err.Error())
  342. }
  343. return
  344. case tt.expectErrMsg != "" && err == nil:
  345. t.Errorf("test '%s': expected error '%s' and didn't get one", tt.name, tt.expectErrMsg)
  346. return
  347. case tt.expectErrMsg == "" && err != nil:
  348. t.Errorf("test '%s': unexpected error %s", tt.name, err.Error())
  349. return
  350. }
  351. if !reflect.DeepEqual(obj.(*policy.PodDisruptionBudget), tt.expectPDB) {
  352. t.Errorf("test '%s': expected:\n%#v\nsaw:\n%#v", tt.name, tt.expectPDB, obj.(*policy.PodDisruptionBudget))
  353. }
  354. })
  355. }
  356. }