123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161 |
- /*
- Copyright 2017 The Kubernetes Authors.
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- */
- package validation
- import (
- "testing"
- metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
- "k8s.io/apimachinery/pkg/util/validation/field"
- "k8s.io/kubernetes/pkg/apis/scheduling"
- )
- func TestValidatePriorityClass(t *testing.T) {
- spcs := scheduling.SystemPriorityClasses()
- successCases := map[string]scheduling.PriorityClass{
- "no description": {
- ObjectMeta: metav1.ObjectMeta{Name: "tier1", Namespace: ""},
- Value: 100,
- },
- "with description": {
- ObjectMeta: metav1.ObjectMeta{Name: "tier1", Namespace: ""},
- Value: 200,
- GlobalDefault: false,
- Description: "Used for the highest priority pods.",
- },
- "system node critical": {
- ObjectMeta: metav1.ObjectMeta{Name: spcs[0].Name, Namespace: ""},
- Value: spcs[0].Value,
- GlobalDefault: spcs[0].GlobalDefault,
- Description: "system priority class 0",
- },
- }
- for k, v := range successCases {
- if errs := ValidatePriorityClass(&v); len(errs) != 0 {
- t.Errorf("Expected success for %s, got %v", k, errs)
- }
- }
- errorCases := map[string]scheduling.PriorityClass{
- "with namespace": {
- ObjectMeta: metav1.ObjectMeta{Name: "tier1", Namespace: "foo"},
- Value: 100,
- },
- "invalid name": {
- ObjectMeta: metav1.ObjectMeta{Name: "tier&1", Namespace: ""},
- Value: 100,
- },
- "incorrect system class name": {
- ObjectMeta: metav1.ObjectMeta{Name: spcs[0].Name, Namespace: ""},
- Value: 0,
- GlobalDefault: spcs[0].GlobalDefault,
- },
- "incorrect system class value": {
- ObjectMeta: metav1.ObjectMeta{Name: "system-something", Namespace: ""},
- Value: spcs[0].Value,
- GlobalDefault: spcs[0].GlobalDefault,
- },
- }
- for k, v := range errorCases {
- if errs := ValidatePriorityClass(&v); len(errs) == 0 {
- t.Errorf("Expected error for %s, but it succeeded", k)
- }
- }
- }
- func TestValidatePriorityClassUpdate(t *testing.T) {
- old := scheduling.PriorityClass{
- ObjectMeta: metav1.ObjectMeta{Name: "tier1", Namespace: "", ResourceVersion: "1"},
- Value: 100,
- }
- successCases := map[string]scheduling.PriorityClass{
- "no change": {
- ObjectMeta: metav1.ObjectMeta{Name: "tier1", Namespace: "", ResourceVersion: "2"},
- Value: 100,
- Description: "Used for the highest priority pods.",
- },
- "change description": {
- ObjectMeta: metav1.ObjectMeta{Name: "tier1", Namespace: "", ResourceVersion: "2"},
- Value: 100,
- Description: "A different description.",
- },
- "remove description": {
- ObjectMeta: metav1.ObjectMeta{Name: "tier1", Namespace: "", ResourceVersion: "2"},
- Value: 100,
- },
- "change globalDefault": {
- ObjectMeta: metav1.ObjectMeta{Name: "tier1", Namespace: "", ResourceVersion: "2"},
- Value: 100,
- GlobalDefault: true,
- },
- }
- for k, v := range successCases {
- if errs := ValidatePriorityClassUpdate(&v, &old); len(errs) != 0 {
- t.Errorf("Expected success for %s, got %v", k, errs)
- }
- }
- errorCases := map[string]struct {
- P scheduling.PriorityClass
- T field.ErrorType
- }{
- "add namespace": {
- P: scheduling.PriorityClass{
- ObjectMeta: metav1.ObjectMeta{Name: "tier1", Namespace: "foo", ResourceVersion: "2"},
- Value: 100,
- },
- T: field.ErrorTypeInvalid,
- },
- "change name": {
- P: scheduling.PriorityClass{
- ObjectMeta: metav1.ObjectMeta{Name: "tier2", Namespace: "", ResourceVersion: "2"},
- Value: 100,
- },
- T: field.ErrorTypeInvalid,
- },
- "remove value": {
- P: scheduling.PriorityClass{
- ObjectMeta: metav1.ObjectMeta{Name: "tier1", Namespace: "", ResourceVersion: "2"},
- },
- T: field.ErrorTypeForbidden,
- },
- "change value": {
- P: scheduling.PriorityClass{
- ObjectMeta: metav1.ObjectMeta{Name: "tier1", Namespace: "", ResourceVersion: "2"},
- Value: 101,
- },
- T: field.ErrorTypeForbidden,
- },
- }
- for k, v := range errorCases {
- errs := ValidatePriorityClassUpdate(&v.P, &old)
- if len(errs) == 0 {
- t.Errorf("Expected error for %s, but it succeeded", k)
- continue
- }
- for i := range errs {
- if errs[i].Type != v.T {
- t.Errorf("%s: expected errors to have type %s: %v", k, v.T, errs[i])
- }
- }
- }
- }
|