volume_expand.go 13 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335
  1. /*
  2. Copyright 2017 The Kubernetes Authors.
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. http://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package storage
  14. import (
  15. "fmt"
  16. "time"
  17. "github.com/onsi/ginkgo"
  18. "github.com/onsi/gomega"
  19. v1 "k8s.io/api/core/v1"
  20. storage "k8s.io/api/storage/v1"
  21. "k8s.io/apimachinery/pkg/api/resource"
  22. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  23. "k8s.io/apimachinery/pkg/util/wait"
  24. clientset "k8s.io/client-go/kubernetes"
  25. "k8s.io/kubernetes/test/e2e/framework"
  26. e2elog "k8s.io/kubernetes/test/e2e/framework/log"
  27. "k8s.io/kubernetes/test/e2e/storage/testsuites"
  28. "k8s.io/kubernetes/test/e2e/storage/utils"
  29. )
  30. const (
  31. resizePollInterval = 2 * time.Second
  32. // total time to wait for cloudprovider or file system resize to finish
  33. totalResizeWaitPeriod = 20 * time.Minute
  34. )
  35. var _ = utils.SIGDescribe("Volume expand", func() {
  36. var (
  37. c clientset.Interface
  38. ns string
  39. err error
  40. pvc *v1.PersistentVolumeClaim
  41. storageClassVar *storage.StorageClass
  42. )
  43. f := framework.NewDefaultFramework("volume-expand")
  44. ginkgo.BeforeEach(func() {
  45. framework.SkipUnlessProviderIs("aws", "gce")
  46. c = f.ClientSet
  47. ns = f.Namespace.Name
  48. framework.ExpectNoError(framework.WaitForAllNodesSchedulable(c, framework.TestContext.NodeSchedulableTimeout))
  49. })
  50. setupFunc := func(allowExpansion bool, blockVolume bool) (*v1.PersistentVolumeClaim, *storage.StorageClass, error) {
  51. test := testsuites.StorageClassTest{
  52. Name: "default",
  53. ClaimSize: "2Gi",
  54. }
  55. if allowExpansion {
  56. test.AllowVolumeExpansion = true
  57. }
  58. if blockVolume {
  59. test.VolumeMode = v1.PersistentVolumeBlock
  60. }
  61. sc, err := createStorageClass(test, ns, "resizing", c)
  62. framework.ExpectNoError(err, "Error creating storage class for resizing")
  63. tPVC := newClaim(test, ns, "default")
  64. tPVC.Spec.StorageClassName = &sc.Name
  65. tPVC, err = c.CoreV1().PersistentVolumeClaims(tPVC.Namespace).Create(tPVC)
  66. if err != nil {
  67. return nil, sc, err
  68. }
  69. return tPVC, sc, nil
  70. }
  71. ginkgo.AfterEach(func() {
  72. framework.ExpectNoError(framework.DeletePersistentVolumeClaim(c, pvc.Name, pvc.Namespace))
  73. framework.ExpectNoError(c.StorageV1().StorageClasses().Delete(storageClassVar.Name, nil))
  74. })
  75. ginkgo.It("should not allow expansion of pvcs without AllowVolumeExpansion property", func() {
  76. pvc, storageClassVar, err = setupFunc(false /* allowExpansion */, false /*BlockVolume*/)
  77. framework.ExpectNoError(err, "Error creating non-expandable PVC")
  78. gomega.Expect(storageClassVar.AllowVolumeExpansion).To(gomega.BeNil())
  79. pvcClaims := []*v1.PersistentVolumeClaim{pvc}
  80. pvs, err := framework.WaitForPVClaimBoundPhase(c, pvcClaims, framework.ClaimProvisionTimeout)
  81. framework.ExpectNoError(err, "Failed waiting for PVC to be bound %v", err)
  82. gomega.Expect(len(pvs)).To(gomega.Equal(1))
  83. ginkgo.By("Expanding non-expandable pvc")
  84. newSize := resource.MustParse("6Gi")
  85. pvc, err = expandPVCSize(pvc, newSize, c)
  86. framework.ExpectError(err, "While updating non-expandable PVC")
  87. })
  88. ginkgo.It("Verify if offline PVC expansion works", func() {
  89. pvc, storageClassVar, err = setupFunc(true /* allowExpansion */, false /*BlockVolume*/)
  90. framework.ExpectNoError(err, "Error creating non-expandable PVC")
  91. ginkgo.By("Waiting for pvc to be in bound phase")
  92. pvcClaims := []*v1.PersistentVolumeClaim{pvc}
  93. pvs, err := framework.WaitForPVClaimBoundPhase(c, pvcClaims, framework.ClaimProvisionTimeout)
  94. framework.ExpectNoError(err, "Failed waiting for PVC to be bound %v", err)
  95. gomega.Expect(len(pvs)).To(gomega.Equal(1))
  96. ginkgo.By("Creating a pod with dynamically provisioned volume")
  97. pod, err := framework.CreatePod(c, ns, nil, pvcClaims, false, "")
  98. framework.ExpectNoError(err, "While creating pods for resizing")
  99. defer func() {
  100. err = framework.DeletePodWithWait(f, c, pod)
  101. framework.ExpectNoError(err, "while cleaning up pod already deleted in resize test")
  102. }()
  103. ginkgo.By("Deleting the previously created pod")
  104. err = framework.DeletePodWithWait(f, c, pod)
  105. framework.ExpectNoError(err, "while deleting pod for resizing")
  106. // We expand the PVC while no pod is using it to ensure offline expansion
  107. ginkgo.By("Expanding current pvc")
  108. newSize := resource.MustParse("6Gi")
  109. pvc, err = expandPVCSize(pvc, newSize, c)
  110. framework.ExpectNoError(err, "While updating pvc for more size")
  111. gomega.Expect(pvc).NotTo(gomega.BeNil())
  112. pvcSize := pvc.Spec.Resources.Requests[v1.ResourceStorage]
  113. if pvcSize.Cmp(newSize) != 0 {
  114. framework.Failf("error updating pvc size %q", pvc.Name)
  115. }
  116. ginkgo.By("Waiting for cloudprovider resize to finish")
  117. err = waitForControllerVolumeResize(pvc, c, totalResizeWaitPeriod)
  118. framework.ExpectNoError(err, "While waiting for pvc resize to finish")
  119. ginkgo.By("Checking for conditions on pvc")
  120. pvc, err = c.CoreV1().PersistentVolumeClaims(ns).Get(pvc.Name, metav1.GetOptions{})
  121. framework.ExpectNoError(err, "While fetching pvc after controller resize")
  122. inProgressConditions := pvc.Status.Conditions
  123. gomega.Expect(len(inProgressConditions)).To(gomega.Equal(1), "pvc must have file system resize pending condition")
  124. gomega.Expect(inProgressConditions[0].Type).To(gomega.Equal(v1.PersistentVolumeClaimFileSystemResizePending), "pvc must have fs resizing condition")
  125. ginkgo.By("Creating a new pod with same volume")
  126. pod2, err := framework.CreatePod(c, ns, nil, pvcClaims, false, "")
  127. framework.ExpectNoError(err, "while recreating pod for resizing")
  128. defer func() {
  129. err = framework.DeletePodWithWait(f, c, pod2)
  130. framework.ExpectNoError(err, "while cleaning up pod before exiting resizing test")
  131. }()
  132. ginkgo.By("Waiting for file system resize to finish")
  133. pvc, err = waitForFSResize(pvc, c)
  134. framework.ExpectNoError(err, "while waiting for fs resize to finish")
  135. pvcConditions := pvc.Status.Conditions
  136. gomega.Expect(len(pvcConditions)).To(gomega.Equal(0), "pvc should not have conditions")
  137. })
  138. ginkgo.It("should resize volume when PVC is edited while pod is using it", func() {
  139. pvc, storageClassVar, err = setupFunc(true /* allowExpansion */, false /*BlockVolume*/)
  140. framework.ExpectNoError(err, "Error creating non-expandable PVC")
  141. ginkgo.By("Waiting for pvc to be in bound phase")
  142. pvcClaims := []*v1.PersistentVolumeClaim{pvc}
  143. pvs, err := framework.WaitForPVClaimBoundPhase(c, pvcClaims, framework.ClaimProvisionTimeout)
  144. framework.ExpectNoError(err, "Failed waiting for PVC to be bound %v", err)
  145. gomega.Expect(len(pvs)).To(gomega.Equal(1))
  146. ginkgo.By("Creating a pod with dynamically provisioned volume")
  147. pod, err := framework.CreatePod(c, ns, nil, pvcClaims, false, "")
  148. framework.ExpectNoError(err, "While creating pods for resizing")
  149. defer func() {
  150. err = framework.DeletePodWithWait(f, c, pod)
  151. framework.ExpectNoError(err, "while cleaning up pod already deleted in resize test")
  152. }()
  153. // We expand the PVC while no pod is using it to ensure online expansion
  154. ginkgo.By("Expanding current pvc")
  155. newSize := resource.MustParse("6Gi")
  156. pvc, err = expandPVCSize(pvc, newSize, c)
  157. framework.ExpectNoError(err, "While updating pvc for more size")
  158. gomega.Expect(pvc).NotTo(gomega.BeNil())
  159. pvcSize := pvc.Spec.Resources.Requests[v1.ResourceStorage]
  160. if pvcSize.Cmp(newSize) != 0 {
  161. framework.Failf("error updating pvc size %q", pvc.Name)
  162. }
  163. ginkgo.By("Waiting for cloudprovider resize to finish")
  164. err = waitForControllerVolumeResize(pvc, c, totalResizeWaitPeriod)
  165. framework.ExpectNoError(err, "While waiting for pvc resize to finish")
  166. ginkgo.By("Waiting for file system resize to finish")
  167. pvc, err = waitForFSResize(pvc, c)
  168. framework.ExpectNoError(err, "while waiting for fs resize to finish")
  169. pvcConditions := pvc.Status.Conditions
  170. gomega.Expect(len(pvcConditions)).To(gomega.Equal(0), "pvc should not have conditions")
  171. })
  172. ginkgo.It("should allow expansion of block volumes", func() {
  173. pvc, storageClassVar, err = setupFunc(true /*allowExpansion*/, true /*blockVolume*/)
  174. ginkgo.By("Waiting for pvc to be in bound phase")
  175. pvcClaims := []*v1.PersistentVolumeClaim{pvc}
  176. pvs, err := framework.WaitForPVClaimBoundPhase(c, pvcClaims, framework.ClaimProvisionTimeout)
  177. framework.ExpectNoError(err, "Failed waiting for PVC to be bound %v", err)
  178. gomega.Expect(len(pvs)).To(gomega.Equal(1))
  179. ginkgo.By("Expanding current pvc")
  180. newSize := resource.MustParse("6Gi")
  181. pvc, err = expandPVCSize(pvc, newSize, c)
  182. framework.ExpectNoError(err, "While updating pvc for more size")
  183. gomega.Expect(pvc).NotTo(gomega.BeNil())
  184. pvcSize := pvc.Spec.Resources.Requests[v1.ResourceStorage]
  185. if pvcSize.Cmp(newSize) != 0 {
  186. framework.Failf("error updating pvc size %q", pvc.Name)
  187. }
  188. ginkgo.By("Waiting for cloudprovider resize to finish")
  189. err = waitForControllerVolumeResize(pvc, c, totalResizeWaitPeriod)
  190. framework.ExpectNoError(err, "While waiting for pvc resize to finish")
  191. ginkgo.By("Waiting for file system resize to finish")
  192. pvc, err = waitForFSResize(pvc, c)
  193. framework.ExpectNoError(err, "while waiting for fs resize to finish")
  194. pvcConditions := pvc.Status.Conditions
  195. gomega.Expect(len(pvcConditions)).To(gomega.Equal(0), "pvc should not have conditions")
  196. })
  197. })
  198. func createStorageClass(t testsuites.StorageClassTest, ns string, suffix string, c clientset.Interface) (*storage.StorageClass, error) {
  199. stKlass := newStorageClass(t, ns, suffix)
  200. var err error
  201. stKlass, err = c.StorageV1().StorageClasses().Create(stKlass)
  202. return stKlass, err
  203. }
  204. func expandPVCSize(origPVC *v1.PersistentVolumeClaim, size resource.Quantity, c clientset.Interface) (*v1.PersistentVolumeClaim, error) {
  205. pvcName := origPVC.Name
  206. updatedPVC := origPVC.DeepCopy()
  207. waitErr := wait.PollImmediate(resizePollInterval, 30*time.Second, func() (bool, error) {
  208. var err error
  209. updatedPVC, err = c.CoreV1().PersistentVolumeClaims(origPVC.Namespace).Get(pvcName, metav1.GetOptions{})
  210. if err != nil {
  211. return false, fmt.Errorf("error fetching pvc %q for resizing with %v", pvcName, err)
  212. }
  213. updatedPVC.Spec.Resources.Requests[v1.ResourceStorage] = size
  214. updatedPVC, err = c.CoreV1().PersistentVolumeClaims(origPVC.Namespace).Update(updatedPVC)
  215. if err == nil {
  216. return true, nil
  217. }
  218. e2elog.Logf("Error updating pvc %s with %v", pvcName, err)
  219. return false, nil
  220. })
  221. return updatedPVC, waitErr
  222. }
  223. func waitForResizingCondition(pvc *v1.PersistentVolumeClaim, c clientset.Interface, duration time.Duration) error {
  224. waitErr := wait.PollImmediate(resizePollInterval, duration, func() (bool, error) {
  225. var err error
  226. updatedPVC, err := c.CoreV1().PersistentVolumeClaims(pvc.Namespace).Get(pvc.Name, metav1.GetOptions{})
  227. if err != nil {
  228. return false, fmt.Errorf("error fetching pvc %q for checking for resize status : %v", pvc.Name, err)
  229. }
  230. pvcConditions := updatedPVC.Status.Conditions
  231. if len(pvcConditions) > 0 {
  232. if pvcConditions[0].Type == v1.PersistentVolumeClaimResizing {
  233. return true, nil
  234. }
  235. }
  236. return false, nil
  237. })
  238. return waitErr
  239. }
  240. func waitForControllerVolumeResize(pvc *v1.PersistentVolumeClaim, c clientset.Interface, duration time.Duration) error {
  241. pvName := pvc.Spec.VolumeName
  242. return wait.PollImmediate(resizePollInterval, duration, func() (bool, error) {
  243. pvcSize := pvc.Spec.Resources.Requests[v1.ResourceStorage]
  244. pv, err := c.CoreV1().PersistentVolumes().Get(pvName, metav1.GetOptions{})
  245. if err != nil {
  246. return false, fmt.Errorf("error fetching pv %q for resizing %v", pvName, err)
  247. }
  248. pvSize := pv.Spec.Capacity[v1.ResourceStorage]
  249. // If pv size is greater or equal to requested size that means controller resize is finished.
  250. if pvSize.Cmp(pvcSize) >= 0 {
  251. return true, nil
  252. }
  253. return false, nil
  254. })
  255. }
  256. func waitForFSResize(pvc *v1.PersistentVolumeClaim, c clientset.Interface) (*v1.PersistentVolumeClaim, error) {
  257. var updatedPVC *v1.PersistentVolumeClaim
  258. waitErr := wait.PollImmediate(resizePollInterval, totalResizeWaitPeriod, func() (bool, error) {
  259. var err error
  260. updatedPVC, err = c.CoreV1().PersistentVolumeClaims(pvc.Namespace).Get(pvc.Name, metav1.GetOptions{})
  261. if err != nil {
  262. return false, fmt.Errorf("error fetching pvc %q for checking for resize status : %v", pvc.Name, err)
  263. }
  264. pvcSize := updatedPVC.Spec.Resources.Requests[v1.ResourceStorage]
  265. pvcStatusSize := updatedPVC.Status.Capacity[v1.ResourceStorage]
  266. //If pvc's status field size is greater than or equal to pvc's size then done
  267. if pvcStatusSize.Cmp(pvcSize) >= 0 {
  268. return true, nil
  269. }
  270. return false, nil
  271. })
  272. return updatedPVC, waitErr
  273. }