123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534 |
- /*
- Copyright 2016 The Kubernetes Authors.
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- */
- package taint
- import (
- "reflect"
- "testing"
- corev1 "k8s.io/api/core/v1"
- )
- func TestDeleteTaint(t *testing.T) {
- cases := []struct {
- name string
- taints []corev1.Taint
- taintToDelete *corev1.Taint
- expectedTaints []corev1.Taint
- expectedResult bool
- }{
- {
- name: "delete taint with different name",
- taints: []corev1.Taint{
- {
- Key: "foo",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- taintToDelete: &corev1.Taint{Key: "foo_1", Effect: corev1.TaintEffectNoSchedule},
- expectedTaints: []corev1.Taint{
- {
- Key: "foo",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- expectedResult: false,
- },
- {
- name: "delete taint with different effect",
- taints: []corev1.Taint{
- {
- Key: "foo",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- taintToDelete: &corev1.Taint{Key: "foo", Effect: corev1.TaintEffectNoExecute},
- expectedTaints: []corev1.Taint{
- {
- Key: "foo",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- expectedResult: false,
- },
- {
- name: "delete taint successfully",
- taints: []corev1.Taint{
- {
- Key: "foo",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- taintToDelete: &corev1.Taint{Key: "foo", Effect: corev1.TaintEffectNoSchedule},
- expectedTaints: []corev1.Taint{},
- expectedResult: true,
- },
- {
- name: "delete taint from empty taint array",
- taints: []corev1.Taint{},
- taintToDelete: &corev1.Taint{Key: "foo", Effect: corev1.TaintEffectNoSchedule},
- expectedTaints: []corev1.Taint{},
- expectedResult: false,
- },
- }
- for _, c := range cases {
- taints, result := deleteTaint(c.taints, c.taintToDelete)
- if result != c.expectedResult {
- t.Errorf("[%s] should return %t, but got: %t", c.name, c.expectedResult, result)
- }
- if !reflect.DeepEqual(taints, c.expectedTaints) {
- t.Errorf("[%s] the result taints should be %v, but got: %v", c.name, c.expectedTaints, taints)
- }
- }
- }
- func TestDeleteTaintByKey(t *testing.T) {
- cases := []struct {
- name string
- taints []corev1.Taint
- taintKey string
- expectedTaints []corev1.Taint
- expectedResult bool
- }{
- {
- name: "delete taint unsuccessfully",
- taints: []corev1.Taint{
- {
- Key: "foo",
- Value: "bar",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- taintKey: "foo_1",
- expectedTaints: []corev1.Taint{
- {
- Key: "foo",
- Value: "bar",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- expectedResult: false,
- },
- {
- name: "delete taint successfully",
- taints: []corev1.Taint{
- {
- Key: "foo",
- Value: "bar",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- taintKey: "foo",
- expectedTaints: []corev1.Taint{},
- expectedResult: true,
- },
- {
- name: "delete taint from empty taint array",
- taints: []corev1.Taint{},
- taintKey: "foo",
- expectedTaints: []corev1.Taint{},
- expectedResult: false,
- },
- }
- for _, c := range cases {
- taints, result := deleteTaintsByKey(c.taints, c.taintKey)
- if result != c.expectedResult {
- t.Errorf("[%s] should return %t, but got: %t", c.name, c.expectedResult, result)
- }
- if !reflect.DeepEqual(c.expectedTaints, taints) {
- t.Errorf("[%s] the result taints should be %v, but got: %v", c.name, c.expectedTaints, taints)
- }
- }
- }
- func TestCheckIfTaintsAlreadyExists(t *testing.T) {
- oldTaints := []corev1.Taint{
- {
- Key: "foo_1",
- Value: "bar",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "foo_2",
- Value: "bar",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "foo_3",
- Value: "bar",
- Effect: corev1.TaintEffectNoSchedule,
- },
- }
- cases := []struct {
- name string
- taintsToCheck []corev1.Taint
- expectedResult string
- }{
- {
- name: "empty array",
- taintsToCheck: []corev1.Taint{},
- expectedResult: "",
- },
- {
- name: "no match",
- taintsToCheck: []corev1.Taint{
- {
- Key: "foo_1",
- Effect: corev1.TaintEffectNoExecute,
- },
- },
- expectedResult: "",
- },
- {
- name: "match one taint",
- taintsToCheck: []corev1.Taint{
- {
- Key: "foo_2",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- expectedResult: "foo_2",
- },
- {
- name: "match two taints",
- taintsToCheck: []corev1.Taint{
- {
- Key: "foo_2",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "foo_3",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- expectedResult: "foo_2,foo_3",
- },
- }
- for _, c := range cases {
- result := checkIfTaintsAlreadyExists(oldTaints, c.taintsToCheck)
- if result != c.expectedResult {
- t.Errorf("[%s] should return '%s', but got: '%s'", c.name, c.expectedResult, result)
- }
- }
- }
- func TestReorganizeTaints(t *testing.T) {
- node := &corev1.Node{
- Spec: corev1.NodeSpec{
- Taints: []corev1.Taint{
- {
- Key: "foo",
- Value: "bar",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- },
- }
- cases := []struct {
- name string
- overwrite bool
- taintsToAdd []corev1.Taint
- taintsToDelete []corev1.Taint
- expectedTaints []corev1.Taint
- expectedOperation string
- expectedErr bool
- }{
- {
- name: "no changes with overwrite is true",
- overwrite: true,
- taintsToAdd: []corev1.Taint{},
- taintsToDelete: []corev1.Taint{},
- expectedTaints: node.Spec.Taints,
- expectedOperation: MODIFIED,
- expectedErr: false,
- },
- {
- name: "no changes with overwrite is false",
- overwrite: false,
- taintsToAdd: []corev1.Taint{},
- taintsToDelete: []corev1.Taint{},
- expectedTaints: node.Spec.Taints,
- expectedOperation: UNTAINTED,
- expectedErr: false,
- },
- {
- name: "add new taint",
- overwrite: false,
- taintsToAdd: []corev1.Taint{
- {
- Key: "foo_1",
- Effect: corev1.TaintEffectNoExecute,
- },
- },
- taintsToDelete: []corev1.Taint{},
- expectedTaints: append([]corev1.Taint{{Key: "foo_1", Effect: corev1.TaintEffectNoExecute}}, node.Spec.Taints...),
- expectedOperation: TAINTED,
- expectedErr: false,
- },
- {
- name: "delete taint with effect",
- overwrite: false,
- taintsToAdd: []corev1.Taint{},
- taintsToDelete: []corev1.Taint{
- {
- Key: "foo",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- expectedTaints: []corev1.Taint{},
- expectedOperation: UNTAINTED,
- expectedErr: false,
- },
- {
- name: "delete taint with no effect",
- overwrite: false,
- taintsToAdd: []corev1.Taint{},
- taintsToDelete: []corev1.Taint{
- {
- Key: "foo",
- },
- },
- expectedTaints: []corev1.Taint{},
- expectedOperation: UNTAINTED,
- expectedErr: false,
- },
- {
- name: "delete non-exist taint",
- overwrite: false,
- taintsToAdd: []corev1.Taint{},
- taintsToDelete: []corev1.Taint{
- {
- Key: "foo_1",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- expectedTaints: node.Spec.Taints,
- expectedOperation: UNTAINTED,
- expectedErr: true,
- },
- {
- name: "add new taint and delete old one",
- overwrite: false,
- taintsToAdd: []corev1.Taint{
- {
- Key: "foo_1",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- taintsToDelete: []corev1.Taint{
- {
- Key: "foo",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- expectedTaints: []corev1.Taint{
- {
- Key: "foo_1",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- expectedOperation: MODIFIED,
- expectedErr: false,
- },
- }
- for _, c := range cases {
- operation, taints, err := reorganizeTaints(node, c.overwrite, c.taintsToAdd, c.taintsToDelete)
- if c.expectedErr && err == nil {
- t.Errorf("[%s] expect to see an error, but did not get one", c.name)
- } else if !c.expectedErr && err != nil {
- t.Errorf("[%s] expect not to see an error, but got one: %v", c.name, err)
- }
- if !reflect.DeepEqual(c.expectedTaints, taints) {
- t.Errorf("[%s] expect to see taint list %#v, but got: %#v", c.name, c.expectedTaints, taints)
- }
- if c.expectedOperation != operation {
- t.Errorf("[%s] expect to see operation %s, but got: %s", c.name, c.expectedOperation, operation)
- }
- }
- }
- func TestParseTaints(t *testing.T) {
- cases := []struct {
- name string
- spec []string
- expectedTaints []corev1.Taint
- expectedTaintsToRemove []corev1.Taint
- expectedErr bool
- }{
- {
- name: "invalid spec format",
- spec: []string{""},
- expectedErr: true,
- },
- {
- name: "invalid spec format",
- spec: []string{"foo=abc"},
- expectedErr: true,
- },
- {
- name: "invalid spec format",
- spec: []string{"foo=abc=xyz:NoSchedule"},
- expectedErr: true,
- },
- {
- name: "invalid spec format",
- spec: []string{"foo=abc:xyz:NoSchedule"},
- expectedErr: true,
- },
- {
- name: "invalid spec format for adding taint",
- spec: []string{"foo"},
- expectedErr: true,
- },
- {
- name: "invalid spec effect for adding taint",
- spec: []string{"foo=abc:invalid_effect"},
- expectedErr: true,
- },
- {
- name: "invalid spec effect for deleting taint",
- spec: []string{"foo:invalid_effect-"},
- expectedErr: true,
- },
- {
- name: "add new taints",
- spec: []string{"foo=abc:NoSchedule", "bar=abc:NoSchedule", "baz:NoSchedule", "qux:NoSchedule", "foobar=:NoSchedule"},
- expectedTaints: []corev1.Taint{
- {
- Key: "foo",
- Value: "abc",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "bar",
- Value: "abc",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "baz",
- Value: "",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "qux",
- Value: "",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "foobar",
- Value: "",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- expectedErr: false,
- },
- {
- name: "delete taints",
- spec: []string{"foo:NoSchedule-", "bar:NoSchedule-", "qux=:NoSchedule-", "dedicated-"},
- expectedTaintsToRemove: []corev1.Taint{
- {
- Key: "foo",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "bar",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "qux",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "dedicated",
- },
- },
- expectedErr: false,
- },
- {
- name: "add taints and delete taints",
- spec: []string{"foo=abc:NoSchedule", "bar=abc:NoSchedule", "baz:NoSchedule", "qux:NoSchedule", "foobar=:NoSchedule", "foo:NoSchedule-", "bar:NoSchedule-", "baz=:NoSchedule-"},
- expectedTaints: []corev1.Taint{
- {
- Key: "foo",
- Value: "abc",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "bar",
- Value: "abc",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "baz",
- Value: "",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "qux",
- Value: "",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "foobar",
- Value: "",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- expectedTaintsToRemove: []corev1.Taint{
- {
- Key: "foo",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "bar",
- Effect: corev1.TaintEffectNoSchedule,
- },
- {
- Key: "baz",
- Value: "",
- Effect: corev1.TaintEffectNoSchedule,
- },
- },
- expectedErr: false,
- },
- }
- for _, c := range cases {
- taints, taintsToRemove, err := parseTaints(c.spec)
- if c.expectedErr && err == nil {
- t.Errorf("[%s] expected error for spec %s, but got nothing", c.name, c.spec)
- }
- if !c.expectedErr && err != nil {
- t.Errorf("[%s] expected no error for spec %s, but got: %v", c.name, c.spec, err)
- }
- if !reflect.DeepEqual(c.expectedTaints, taints) {
- t.Errorf("[%s] expected returen taints as %v, but got: %v", c.name, c.expectedTaints, taints)
- }
- if !reflect.DeepEqual(c.expectedTaintsToRemove, taintsToRemove) {
- t.Errorf("[%s] expected return taints to be removed as %v, but got: %v", c.name, c.expectedTaintsToRemove, taintsToRemove)
- }
- }
- }
|