label_test.go 13 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499
  1. /*
  2. Copyright 2014 The Kubernetes Authors.
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. http://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package label
  14. import (
  15. "bytes"
  16. "net/http"
  17. "reflect"
  18. "strings"
  19. "testing"
  20. "k8s.io/api/core/v1"
  21. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  22. "k8s.io/apimachinery/pkg/runtime"
  23. "k8s.io/cli-runtime/pkg/genericclioptions"
  24. "k8s.io/cli-runtime/pkg/resource"
  25. "k8s.io/client-go/rest/fake"
  26. cmdtesting "k8s.io/kubernetes/pkg/kubectl/cmd/testing"
  27. "k8s.io/kubernetes/pkg/kubectl/scheme"
  28. )
  29. func TestValidateLabels(t *testing.T) {
  30. tests := []struct {
  31. meta *metav1.ObjectMeta
  32. labels map[string]string
  33. expectErr bool
  34. test string
  35. }{
  36. {
  37. meta: &metav1.ObjectMeta{
  38. Labels: map[string]string{
  39. "a": "b",
  40. "c": "d",
  41. },
  42. },
  43. labels: map[string]string{
  44. "a": "c",
  45. "d": "b",
  46. },
  47. test: "one shared",
  48. expectErr: true,
  49. },
  50. {
  51. meta: &metav1.ObjectMeta{
  52. Labels: map[string]string{
  53. "a": "b",
  54. "c": "d",
  55. },
  56. },
  57. labels: map[string]string{
  58. "b": "d",
  59. "c": "a",
  60. },
  61. test: "second shared",
  62. expectErr: true,
  63. },
  64. {
  65. meta: &metav1.ObjectMeta{
  66. Labels: map[string]string{
  67. "a": "b",
  68. "c": "d",
  69. },
  70. },
  71. labels: map[string]string{
  72. "b": "a",
  73. "d": "c",
  74. },
  75. test: "no overlap",
  76. },
  77. {
  78. meta: &metav1.ObjectMeta{},
  79. labels: map[string]string{
  80. "b": "a",
  81. "d": "c",
  82. },
  83. test: "no labels",
  84. },
  85. }
  86. for _, test := range tests {
  87. err := validateNoOverwrites(test.meta, test.labels)
  88. if test.expectErr && err == nil {
  89. t.Errorf("%s: unexpected non-error", test.test)
  90. }
  91. if !test.expectErr && err != nil {
  92. t.Errorf("%s: unexpected error: %v", test.test, err)
  93. }
  94. }
  95. }
  96. func TestParseLabels(t *testing.T) {
  97. tests := []struct {
  98. labels []string
  99. expected map[string]string
  100. expectedRemove []string
  101. expectErr bool
  102. }{
  103. {
  104. labels: []string{"a=b", "c=d"},
  105. expected: map[string]string{"a": "b", "c": "d"},
  106. },
  107. {
  108. labels: []string{},
  109. expected: map[string]string{},
  110. },
  111. {
  112. labels: []string{"a=b", "c=d", "e-"},
  113. expected: map[string]string{"a": "b", "c": "d"},
  114. expectedRemove: []string{"e"},
  115. },
  116. {
  117. labels: []string{"ab", "c=d"},
  118. expectErr: true,
  119. },
  120. {
  121. labels: []string{"a=b", "c=d", "a-"},
  122. expectErr: true,
  123. },
  124. {
  125. labels: []string{"a="},
  126. expected: map[string]string{"a": ""},
  127. },
  128. {
  129. labels: []string{"a=%^$"},
  130. expectErr: true,
  131. },
  132. }
  133. for _, test := range tests {
  134. labels, remove, err := parseLabels(test.labels)
  135. if test.expectErr && err == nil {
  136. t.Errorf("unexpected non-error: %v", test)
  137. }
  138. if !test.expectErr && err != nil {
  139. t.Errorf("unexpected error: %v %v", err, test)
  140. }
  141. if !reflect.DeepEqual(labels, test.expected) {
  142. t.Errorf("expected: %v, got %v", test.expected, labels)
  143. }
  144. if !reflect.DeepEqual(remove, test.expectedRemove) {
  145. t.Errorf("expected: %v, got %v", test.expectedRemove, remove)
  146. }
  147. }
  148. }
  149. func TestLabelFunc(t *testing.T) {
  150. tests := []struct {
  151. obj runtime.Object
  152. overwrite bool
  153. version string
  154. labels map[string]string
  155. remove []string
  156. expected runtime.Object
  157. expectErr bool
  158. }{
  159. {
  160. obj: &v1.Pod{
  161. ObjectMeta: metav1.ObjectMeta{
  162. Labels: map[string]string{"a": "b"},
  163. },
  164. },
  165. labels: map[string]string{"a": "b"},
  166. expectErr: true,
  167. },
  168. {
  169. obj: &v1.Pod{
  170. ObjectMeta: metav1.ObjectMeta{
  171. Labels: map[string]string{"a": "b"},
  172. },
  173. },
  174. labels: map[string]string{"a": "c"},
  175. overwrite: true,
  176. expected: &v1.Pod{
  177. ObjectMeta: metav1.ObjectMeta{
  178. Labels: map[string]string{"a": "c"},
  179. },
  180. },
  181. },
  182. {
  183. obj: &v1.Pod{
  184. ObjectMeta: metav1.ObjectMeta{
  185. Labels: map[string]string{"a": "b"},
  186. },
  187. },
  188. labels: map[string]string{"c": "d"},
  189. expected: &v1.Pod{
  190. ObjectMeta: metav1.ObjectMeta{
  191. Labels: map[string]string{"a": "b", "c": "d"},
  192. },
  193. },
  194. },
  195. {
  196. obj: &v1.Pod{
  197. ObjectMeta: metav1.ObjectMeta{
  198. Labels: map[string]string{"a": "b"},
  199. },
  200. },
  201. labels: map[string]string{"c": "d"},
  202. version: "2",
  203. expected: &v1.Pod{
  204. ObjectMeta: metav1.ObjectMeta{
  205. Labels: map[string]string{"a": "b", "c": "d"},
  206. ResourceVersion: "2",
  207. },
  208. },
  209. },
  210. {
  211. obj: &v1.Pod{
  212. ObjectMeta: metav1.ObjectMeta{
  213. Labels: map[string]string{"a": "b"},
  214. },
  215. },
  216. labels: map[string]string{},
  217. remove: []string{"a"},
  218. expected: &v1.Pod{
  219. ObjectMeta: metav1.ObjectMeta{
  220. Labels: map[string]string{},
  221. },
  222. },
  223. },
  224. {
  225. obj: &v1.Pod{
  226. ObjectMeta: metav1.ObjectMeta{
  227. Labels: map[string]string{"a": "b", "c": "d"},
  228. },
  229. },
  230. labels: map[string]string{"e": "f"},
  231. remove: []string{"a"},
  232. expected: &v1.Pod{
  233. ObjectMeta: metav1.ObjectMeta{
  234. Labels: map[string]string{
  235. "c": "d",
  236. "e": "f",
  237. },
  238. },
  239. },
  240. },
  241. {
  242. obj: &v1.Pod{
  243. ObjectMeta: metav1.ObjectMeta{},
  244. },
  245. labels: map[string]string{"a": "b"},
  246. expected: &v1.Pod{
  247. ObjectMeta: metav1.ObjectMeta{
  248. Labels: map[string]string{"a": "b"},
  249. },
  250. },
  251. },
  252. }
  253. for _, test := range tests {
  254. err := labelFunc(test.obj, test.overwrite, test.version, test.labels, test.remove)
  255. if test.expectErr {
  256. if err == nil {
  257. t.Errorf("unexpected non-error: %v", test)
  258. }
  259. continue
  260. }
  261. if !test.expectErr && err != nil {
  262. t.Errorf("unexpected error: %v %v", err, test)
  263. }
  264. if !reflect.DeepEqual(test.obj, test.expected) {
  265. t.Errorf("expected: %v, got %v", test.expected, test.obj)
  266. }
  267. }
  268. }
  269. func TestLabelErrors(t *testing.T) {
  270. testCases := map[string]struct {
  271. args []string
  272. flags map[string]string
  273. errFn func(error) bool
  274. }{
  275. "no args": {
  276. args: []string{},
  277. errFn: func(err error) bool { return strings.Contains(err.Error(), "one or more resources must be specified") },
  278. },
  279. "not enough labels": {
  280. args: []string{"pods"},
  281. errFn: func(err error) bool { return strings.Contains(err.Error(), "at least one label update is required") },
  282. },
  283. "wrong labels": {
  284. args: []string{"pods", "-"},
  285. errFn: func(err error) bool { return strings.Contains(err.Error(), "at least one label update is required") },
  286. },
  287. "wrong labels 2": {
  288. args: []string{"pods", "=bar"},
  289. errFn: func(err error) bool { return strings.Contains(err.Error(), "at least one label update is required") },
  290. },
  291. "no resources": {
  292. args: []string{"pods-"},
  293. errFn: func(err error) bool { return strings.Contains(err.Error(), "one or more resources must be specified") },
  294. },
  295. "no resources 2": {
  296. args: []string{"pods=bar"},
  297. errFn: func(err error) bool { return strings.Contains(err.Error(), "one or more resources must be specified") },
  298. },
  299. "resources but no selectors": {
  300. args: []string{"pods", "app=bar"},
  301. errFn: func(err error) bool {
  302. return strings.Contains(err.Error(), "resource(s) were provided, but no name, label selector, or --all flag specified")
  303. },
  304. },
  305. "multiple resources but no selectors": {
  306. args: []string{"pods,deployments", "app=bar"},
  307. errFn: func(err error) bool {
  308. return strings.Contains(err.Error(), "resource(s) were provided, but no name, label selector, or --all flag specified")
  309. },
  310. },
  311. }
  312. for k, testCase := range testCases {
  313. t.Run(k, func(t *testing.T) {
  314. tf := cmdtesting.NewTestFactory().WithNamespace("test")
  315. defer tf.Cleanup()
  316. tf.ClientConfigVal = cmdtesting.DefaultClientConfig()
  317. ioStreams, _, _, _ := genericclioptions.NewTestIOStreams()
  318. buf := bytes.NewBuffer([]byte{})
  319. cmd := NewCmdLabel(tf, ioStreams)
  320. cmd.SetOutput(buf)
  321. for k, v := range testCase.flags {
  322. cmd.Flags().Set(k, v)
  323. }
  324. opts := NewLabelOptions(ioStreams)
  325. err := opts.Complete(tf, cmd, testCase.args)
  326. if err == nil {
  327. err = opts.Validate()
  328. }
  329. if err == nil {
  330. err = opts.RunLabel()
  331. }
  332. if !testCase.errFn(err) {
  333. t.Errorf("%s: unexpected error: %v", k, err)
  334. return
  335. }
  336. if buf.Len() > 0 {
  337. t.Errorf("buffer should be empty: %s", string(buf.Bytes()))
  338. }
  339. })
  340. }
  341. }
  342. func TestLabelForResourceFromFile(t *testing.T) {
  343. pods, _, _ := cmdtesting.TestData()
  344. tf := cmdtesting.NewTestFactory().WithNamespace("test")
  345. defer tf.Cleanup()
  346. codec := scheme.Codecs.LegacyCodec(scheme.Scheme.PrioritizedVersionsAllGroups()...)
  347. tf.UnstructuredClient = &fake.RESTClient{
  348. NegotiatedSerializer: resource.UnstructuredPlusDefaultContentConfig().NegotiatedSerializer,
  349. Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) {
  350. switch req.Method {
  351. case "GET":
  352. switch req.URL.Path {
  353. case "/namespaces/test/replicationcontrollers/cassandra":
  354. return &http.Response{StatusCode: 200, Header: cmdtesting.DefaultHeader(), Body: cmdtesting.ObjBody(codec, &pods.Items[0])}, nil
  355. default:
  356. t.Fatalf("unexpected request: %#v\n%#v", req.URL, req)
  357. return nil, nil
  358. }
  359. case "PATCH":
  360. switch req.URL.Path {
  361. case "/namespaces/test/replicationcontrollers/cassandra":
  362. return &http.Response{StatusCode: 200, Header: cmdtesting.DefaultHeader(), Body: cmdtesting.ObjBody(codec, &pods.Items[0])}, nil
  363. default:
  364. t.Fatalf("unexpected request: %#v\n%#v", req.URL, req)
  365. return nil, nil
  366. }
  367. default:
  368. t.Fatalf("unexpected request: %s %#v\n%#v", req.Method, req.URL, req)
  369. return nil, nil
  370. }
  371. }),
  372. }
  373. tf.ClientConfigVal = cmdtesting.DefaultClientConfig()
  374. ioStreams, _, buf, _ := genericclioptions.NewTestIOStreams()
  375. cmd := NewCmdLabel(tf, ioStreams)
  376. opts := NewLabelOptions(ioStreams)
  377. opts.Filenames = []string{"../../../../test/e2e/testing-manifests/statefulset/cassandra/controller.yaml"}
  378. err := opts.Complete(tf, cmd, []string{"a=b"})
  379. if err == nil {
  380. err = opts.Validate()
  381. }
  382. if err == nil {
  383. err = opts.RunLabel()
  384. }
  385. if err != nil {
  386. t.Fatalf("unexpected error: %v", err)
  387. }
  388. if !strings.Contains(buf.String(), "labeled") {
  389. t.Errorf("did not set labels: %s", buf.String())
  390. }
  391. }
  392. func TestLabelLocal(t *testing.T) {
  393. tf := cmdtesting.NewTestFactory().WithNamespace("test")
  394. defer tf.Cleanup()
  395. tf.UnstructuredClient = &fake.RESTClient{
  396. NegotiatedSerializer: resource.UnstructuredPlusDefaultContentConfig().NegotiatedSerializer,
  397. Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) {
  398. t.Fatalf("unexpected request: %s %#v\n%#v", req.Method, req.URL, req)
  399. return nil, nil
  400. }),
  401. }
  402. tf.ClientConfigVal = cmdtesting.DefaultClientConfig()
  403. ioStreams, _, buf, _ := genericclioptions.NewTestIOStreams()
  404. cmd := NewCmdLabel(tf, ioStreams)
  405. opts := NewLabelOptions(ioStreams)
  406. opts.Filenames = []string{"../../../../test/e2e/testing-manifests/statefulset/cassandra/controller.yaml"}
  407. opts.local = true
  408. err := opts.Complete(tf, cmd, []string{"a=b"})
  409. if err == nil {
  410. err = opts.Validate()
  411. }
  412. if err == nil {
  413. err = opts.RunLabel()
  414. }
  415. if err != nil {
  416. t.Fatalf("unexpected error: %v", err)
  417. }
  418. if !strings.Contains(buf.String(), "labeled") {
  419. t.Errorf("did not set labels: %s", buf.String())
  420. }
  421. }
  422. func TestLabelMultipleObjects(t *testing.T) {
  423. pods, _, _ := cmdtesting.TestData()
  424. tf := cmdtesting.NewTestFactory().WithNamespace("test")
  425. defer tf.Cleanup()
  426. codec := scheme.Codecs.LegacyCodec(scheme.Scheme.PrioritizedVersionsAllGroups()...)
  427. tf.UnstructuredClient = &fake.RESTClient{
  428. NegotiatedSerializer: resource.UnstructuredPlusDefaultContentConfig().NegotiatedSerializer,
  429. Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) {
  430. switch req.Method {
  431. case "GET":
  432. switch req.URL.Path {
  433. case "/namespaces/test/pods":
  434. return &http.Response{StatusCode: 200, Header: cmdtesting.DefaultHeader(), Body: cmdtesting.ObjBody(codec, pods)}, nil
  435. default:
  436. t.Fatalf("unexpected request: %#v\n%#v", req.URL, req)
  437. return nil, nil
  438. }
  439. case "PATCH":
  440. switch req.URL.Path {
  441. case "/namespaces/test/pods/foo":
  442. return &http.Response{StatusCode: 200, Header: cmdtesting.DefaultHeader(), Body: cmdtesting.ObjBody(codec, &pods.Items[0])}, nil
  443. case "/namespaces/test/pods/bar":
  444. return &http.Response{StatusCode: 200, Header: cmdtesting.DefaultHeader(), Body: cmdtesting.ObjBody(codec, &pods.Items[1])}, nil
  445. default:
  446. t.Fatalf("unexpected request: %#v\n%#v", req.URL, req)
  447. return nil, nil
  448. }
  449. default:
  450. t.Fatalf("unexpected request: %s %#v\n%#v", req.Method, req.URL, req)
  451. return nil, nil
  452. }
  453. }),
  454. }
  455. tf.ClientConfigVal = cmdtesting.DefaultClientConfig()
  456. ioStreams, _, buf, _ := genericclioptions.NewTestIOStreams()
  457. opts := NewLabelOptions(ioStreams)
  458. opts.all = true
  459. cmd := NewCmdLabel(tf, ioStreams)
  460. err := opts.Complete(tf, cmd, []string{"pods", "a=b"})
  461. if err == nil {
  462. err = opts.Validate()
  463. }
  464. if err == nil {
  465. err = opts.RunLabel()
  466. }
  467. if err != nil {
  468. t.Fatalf("unexpected error: %v", err)
  469. }
  470. if strings.Count(buf.String(), "labeled") != len(pods.Items) {
  471. t.Errorf("not all labels are set: %s", buf.String())
  472. }
  473. }