conversion_test.go 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527
  1. /*
  2. Copyright 2019 The Kubernetes Authors.
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. http://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package v1alpha1
  14. import (
  15. "testing"
  16. "github.com/google/go-cmp/cmp"
  17. "k8s.io/apimachinery/pkg/conversion"
  18. "k8s.io/apimachinery/pkg/runtime"
  19. componentbaseconfig "k8s.io/component-base/config"
  20. componentbaseconfigv1alpha1 "k8s.io/component-base/config/v1alpha1"
  21. "k8s.io/kube-scheduler/config/v1alpha1"
  22. "k8s.io/kubernetes/pkg/scheduler/apis/config"
  23. "k8s.io/utils/pointer"
  24. )
  25. func TestConvertKubeSchedulerConfiguration(t *testing.T) {
  26. cases := []struct {
  27. name string
  28. cfg v1alpha1.KubeSchedulerConfiguration
  29. want config.KubeSchedulerConfiguration
  30. }{
  31. {
  32. name: "scheduler name",
  33. cfg: v1alpha1.KubeSchedulerConfiguration{
  34. SchedulerName: pointer.StringPtr("custom-name"),
  35. },
  36. want: config.KubeSchedulerConfiguration{
  37. Profiles: []config.KubeSchedulerProfile{
  38. {SchedulerName: "custom-name"},
  39. },
  40. },
  41. },
  42. {
  43. name: "plugins and plugin config",
  44. cfg: v1alpha1.KubeSchedulerConfiguration{
  45. Plugins: &v1alpha1.Plugins{
  46. QueueSort: &v1alpha1.PluginSet{
  47. Enabled: []v1alpha1.Plugin{
  48. {Name: "FooPlugin"},
  49. },
  50. },
  51. },
  52. PluginConfig: []v1alpha1.PluginConfig{
  53. {Name: "FooPlugin"},
  54. },
  55. },
  56. want: config.KubeSchedulerConfiguration{
  57. Profiles: []config.KubeSchedulerProfile{
  58. {
  59. Plugins: &config.Plugins{
  60. QueueSort: &config.PluginSet{
  61. Enabled: []config.Plugin{
  62. {Name: "FooPlugin"},
  63. },
  64. },
  65. },
  66. PluginConfig: []config.PluginConfig{
  67. {Name: "FooPlugin"},
  68. },
  69. },
  70. },
  71. },
  72. },
  73. {
  74. name: "custom hard pod affinity weight",
  75. cfg: v1alpha1.KubeSchedulerConfiguration{
  76. HardPodAffinitySymmetricWeight: pointer.Int32Ptr(3),
  77. },
  78. want: config.KubeSchedulerConfiguration{
  79. Profiles: []config.KubeSchedulerProfile{
  80. {
  81. PluginConfig: []config.PluginConfig{
  82. {
  83. Name: "InterPodAffinity",
  84. Args: runtime.Unknown{
  85. Raw: []byte(`{"hardPodAffinityWeight":3}`),
  86. },
  87. },
  88. },
  89. },
  90. },
  91. },
  92. },
  93. {
  94. name: "custom hard pod affinity weight and existing PluginConfig",
  95. cfg: v1alpha1.KubeSchedulerConfiguration{
  96. HardPodAffinitySymmetricWeight: pointer.Int32Ptr(3),
  97. PluginConfig: []v1alpha1.PluginConfig{
  98. {
  99. Name: "InterPodAffinity",
  100. Args: runtime.Unknown{
  101. Raw: []byte(`{"hardPodAffinityWeight":5}`),
  102. },
  103. },
  104. },
  105. },
  106. want: config.KubeSchedulerConfiguration{
  107. Profiles: []config.KubeSchedulerProfile{
  108. {
  109. PluginConfig: []config.PluginConfig{
  110. {
  111. Name: "InterPodAffinity",
  112. Args: runtime.Unknown{
  113. Raw: []byte(`{"hardPodAffinityWeight":5}`),
  114. },
  115. },
  116. {
  117. Name: "InterPodAffinity",
  118. Args: runtime.Unknown{
  119. Raw: []byte(`{"hardPodAffinityWeight":3}`),
  120. },
  121. },
  122. },
  123. },
  124. },
  125. },
  126. },
  127. }
  128. scheme := getScheme(t)
  129. for _, tc := range cases {
  130. t.Run(tc.name, func(t *testing.T) {
  131. var out config.KubeSchedulerConfiguration
  132. err := scheme.Convert(&tc.cfg, &out, nil)
  133. if err != nil {
  134. t.Fatal(err)
  135. }
  136. if diff := cmp.Diff(tc.want, out); diff != "" {
  137. t.Errorf("unexpected conversion (-want, +got):\n%s", diff)
  138. }
  139. })
  140. }
  141. }
  142. func TestV1alpha1ToConfigKubeSchedulerLeaderElectionConfiguration(t *testing.T) {
  143. configuration := &v1alpha1.KubeSchedulerLeaderElectionConfiguration{
  144. LockObjectName: "name",
  145. LockObjectNamespace: "namespace",
  146. LeaderElectionConfiguration: componentbaseconfigv1alpha1.LeaderElectionConfiguration{
  147. ResourceName: "name",
  148. ResourceNamespace: "namespace",
  149. },
  150. }
  151. emptyLockObjectNameConfig := configuration.DeepCopy()
  152. emptyLockObjectNameConfig.LockObjectName = ""
  153. emptyLockObjectNamespaceConfig := configuration.DeepCopy()
  154. emptyLockObjectNamespaceConfig.LockObjectNamespace = ""
  155. emptyResourceNameConfig := configuration.DeepCopy()
  156. emptyResourceNameConfig.ResourceName = ""
  157. emptyResourceNamespaceConfig := configuration.DeepCopy()
  158. emptyResourceNamespaceConfig.ResourceNamespace = ""
  159. differentNameConfig := configuration.DeepCopy()
  160. differentNameConfig.LockObjectName = "name1"
  161. differentNamespaceConfig := configuration.DeepCopy()
  162. differentNamespaceConfig.LockObjectNamespace = "namespace1"
  163. emptyconfig := &v1alpha1.KubeSchedulerLeaderElectionConfiguration{}
  164. scenarios := map[string]struct {
  165. expectedResourceNamespace string
  166. expectedResourceName string
  167. expectedToFailed bool
  168. config *v1alpha1.KubeSchedulerLeaderElectionConfiguration
  169. }{
  170. "both-set-same-name-and-namespace": {
  171. expectedResourceNamespace: "namespace",
  172. expectedResourceName: "name",
  173. expectedToFailed: false,
  174. config: configuration,
  175. },
  176. "not-set-lock-object-name": {
  177. expectedResourceNamespace: "namespace",
  178. expectedResourceName: "name",
  179. expectedToFailed: false,
  180. config: emptyLockObjectNameConfig,
  181. },
  182. "not-set-lock-object-namespace": {
  183. expectedResourceNamespace: "namespace",
  184. expectedResourceName: "name",
  185. expectedToFailed: false,
  186. config: emptyLockObjectNamespaceConfig,
  187. },
  188. "not-set-resource-name": {
  189. expectedResourceNamespace: "namespace",
  190. expectedResourceName: "name",
  191. expectedToFailed: false,
  192. config: emptyResourceNameConfig,
  193. },
  194. "not-set-resource-namespace": {
  195. expectedResourceNamespace: "namespace",
  196. expectedResourceName: "name",
  197. expectedToFailed: false,
  198. config: emptyResourceNamespaceConfig,
  199. },
  200. "set-different-name": {
  201. expectedResourceNamespace: "",
  202. expectedResourceName: "",
  203. expectedToFailed: true,
  204. config: differentNameConfig,
  205. },
  206. "set-different-namespace": {
  207. expectedResourceNamespace: "",
  208. expectedResourceName: "",
  209. expectedToFailed: true,
  210. config: differentNamespaceConfig,
  211. },
  212. "set-empty-name-and-namespace": {
  213. expectedResourceNamespace: "",
  214. expectedResourceName: "",
  215. expectedToFailed: false,
  216. config: emptyconfig,
  217. },
  218. }
  219. for name, scenario := range scenarios {
  220. out := &config.KubeSchedulerLeaderElectionConfiguration{}
  221. s := conversion.Scope(nil)
  222. err := Convert_v1alpha1_KubeSchedulerLeaderElectionConfiguration_To_config_KubeSchedulerLeaderElectionConfiguration(scenario.config, out, s)
  223. if err == nil && scenario.expectedToFailed {
  224. t.Errorf("Unexpected success for scenario: %s", name)
  225. }
  226. if err == nil && !scenario.expectedToFailed {
  227. if out.ResourceName != scenario.expectedResourceName {
  228. t.Errorf("Unexpected success for scenario: %s, out.ResourceName: %s, expectedResourceName: %s", name, out.ResourceName, scenario.expectedResourceName)
  229. }
  230. if out.ResourceNamespace != scenario.expectedResourceNamespace {
  231. t.Errorf("Unexpected success for scenario: %s, out.ResourceNamespace: %s, expectedResourceNamespace: %s", name, out.ResourceNamespace, scenario.expectedResourceNamespace)
  232. }
  233. }
  234. if err != nil && !scenario.expectedToFailed {
  235. t.Errorf("Unexpected failure for scenario: %s - %+v", name, err)
  236. }
  237. }
  238. }
  239. func TestConfigToV1alpha1KubeSchedulerLeaderElectionConfiguration(t *testing.T) {
  240. configuration := &config.KubeSchedulerLeaderElectionConfiguration{
  241. LeaderElectionConfiguration: componentbaseconfig.LeaderElectionConfiguration{
  242. ResourceName: "name",
  243. ResourceNamespace: "namespace",
  244. },
  245. }
  246. emptyconfig := &config.KubeSchedulerLeaderElectionConfiguration{}
  247. scenarios := map[string]struct {
  248. expectedResourceNamespace string
  249. expectedResourceName string
  250. expectedLockObjectNamespace string
  251. expectedLockObjectName string
  252. expectedToFailed bool
  253. config *config.KubeSchedulerLeaderElectionConfiguration
  254. }{
  255. "both-set-name-and-namespace": {
  256. expectedResourceNamespace: "namespace",
  257. expectedResourceName: "name",
  258. expectedLockObjectNamespace: "namespace",
  259. expectedLockObjectName: "name",
  260. expectedToFailed: false,
  261. config: configuration,
  262. },
  263. "set-empty-name-and-namespace": {
  264. expectedResourceNamespace: "",
  265. expectedResourceName: "",
  266. expectedLockObjectNamespace: "",
  267. expectedLockObjectName: "",
  268. expectedToFailed: false,
  269. config: emptyconfig,
  270. },
  271. }
  272. for name, scenario := range scenarios {
  273. out := &v1alpha1.KubeSchedulerLeaderElectionConfiguration{}
  274. s := conversion.Scope(nil)
  275. err := Convert_config_KubeSchedulerLeaderElectionConfiguration_To_v1alpha1_KubeSchedulerLeaderElectionConfiguration(scenario.config, out, s)
  276. if err == nil && scenario.expectedToFailed {
  277. t.Errorf("Unexpected success for scenario: %s", name)
  278. }
  279. if err == nil && !scenario.expectedToFailed {
  280. if out.ResourceName != scenario.expectedResourceName {
  281. t.Errorf("Unexpected success for scenario: %s, out.ResourceName: %s, expectedResourceName: %s", name, out.ResourceName, scenario.expectedResourceName)
  282. }
  283. if out.LockObjectName != scenario.expectedLockObjectName {
  284. t.Errorf("Unexpected success for scenario: %s, out.LockObjectName: %s, expectedLockObjectName: %s", name, out.LockObjectName, scenario.expectedLockObjectName)
  285. }
  286. if out.ResourceNamespace != scenario.expectedResourceNamespace {
  287. t.Errorf("Unexpected success for scenario: %s, out.ResourceNamespace: %s, expectedResourceNamespace: %s", name, out.ResourceNamespace, scenario.expectedResourceNamespace)
  288. }
  289. if out.LockObjectNamespace != scenario.expectedLockObjectNamespace {
  290. t.Errorf("Unexpected success for scenario: %s, out.LockObjectNamespace: %s, expectedLockObjectNamespace: %s", name, out.LockObjectNamespace, scenario.expectedLockObjectNamespace)
  291. }
  292. }
  293. if err != nil && !scenario.expectedToFailed {
  294. t.Errorf("Unexpected failure for scenario: %s - %+v", name, err)
  295. }
  296. }
  297. }
  298. func TestConvertBetweenV1Alpha1PluginsAndConfigPlugins(t *testing.T) {
  299. // weight is assigned to score plugins
  300. weight := int32(10)
  301. // DummyWeight is a placeholder for the v1alpha1.plugins' weight will be filled with zero when
  302. // convert back from config.
  303. dummyWeight := int32(42)
  304. v1alpha1Plugins := v1alpha1.Plugins{
  305. QueueSort: &v1alpha1.PluginSet{
  306. Enabled: []v1alpha1.Plugin{
  307. {Name: "queuesort-plugin", Weight: &dummyWeight},
  308. },
  309. Disabled: []v1alpha1.Plugin{
  310. {Name: "disabled-queuesort-plugin", Weight: &dummyWeight},
  311. },
  312. },
  313. PreFilter: &v1alpha1.PluginSet{
  314. Enabled: []v1alpha1.Plugin{
  315. {Name: "prefilter-plugin", Weight: &dummyWeight},
  316. },
  317. Disabled: []v1alpha1.Plugin{
  318. {Name: "disabled-prefilter-plugin", Weight: &dummyWeight},
  319. },
  320. },
  321. Filter: &v1alpha1.PluginSet{
  322. Enabled: []v1alpha1.Plugin{
  323. {Name: "filter-plugin", Weight: &dummyWeight},
  324. },
  325. Disabled: []v1alpha1.Plugin{
  326. {Name: "disabled-filter-plugin", Weight: &dummyWeight},
  327. },
  328. },
  329. PostFilter: &v1alpha1.PluginSet{
  330. Enabled: []v1alpha1.Plugin{
  331. {Name: "postfilter-plugin", Weight: &dummyWeight},
  332. },
  333. Disabled: []v1alpha1.Plugin{
  334. {Name: "disabled-postfilter-plugin", Weight: &dummyWeight},
  335. },
  336. },
  337. Score: &v1alpha1.PluginSet{
  338. Enabled: []v1alpha1.Plugin{
  339. {Name: "score-plugin", Weight: &weight},
  340. },
  341. Disabled: []v1alpha1.Plugin{
  342. {Name: "disabled-score-plugin", Weight: &weight},
  343. },
  344. },
  345. Reserve: &v1alpha1.PluginSet{
  346. Enabled: []v1alpha1.Plugin{
  347. {Name: "reserve-plugin", Weight: &dummyWeight},
  348. },
  349. Disabled: []v1alpha1.Plugin{
  350. {Name: "disabled-reserve-plugin", Weight: &dummyWeight},
  351. },
  352. },
  353. Permit: &v1alpha1.PluginSet{
  354. Enabled: []v1alpha1.Plugin{
  355. {Name: "permit-plugin", Weight: &dummyWeight},
  356. },
  357. Disabled: []v1alpha1.Plugin{
  358. {Name: "disabled-permit-plugin", Weight: &dummyWeight},
  359. },
  360. },
  361. PreBind: &v1alpha1.PluginSet{
  362. Enabled: []v1alpha1.Plugin{
  363. {Name: "prebind-plugin", Weight: &dummyWeight},
  364. },
  365. Disabled: []v1alpha1.Plugin{
  366. {Name: "disabled-prebind-plugin", Weight: &dummyWeight},
  367. },
  368. },
  369. Bind: &v1alpha1.PluginSet{
  370. Enabled: []v1alpha1.Plugin{
  371. {Name: "bind-plugin", Weight: &dummyWeight},
  372. },
  373. Disabled: []v1alpha1.Plugin{
  374. {Name: "disabled-bind-plugin", Weight: &dummyWeight},
  375. },
  376. },
  377. PostBind: &v1alpha1.PluginSet{
  378. Enabled: []v1alpha1.Plugin{
  379. {Name: "postbind-plugin", Weight: &dummyWeight},
  380. },
  381. Disabled: []v1alpha1.Plugin{
  382. {Name: "disabled-postbind-plugin", Weight: &dummyWeight},
  383. },
  384. },
  385. Unreserve: &v1alpha1.PluginSet{
  386. Enabled: []v1alpha1.Plugin{
  387. {Name: "unreserve-plugin", Weight: &dummyWeight},
  388. },
  389. Disabled: []v1alpha1.Plugin{
  390. {Name: "disabled-unreserve-plugin", Weight: &dummyWeight},
  391. },
  392. },
  393. }
  394. configPlugins := config.Plugins{
  395. QueueSort: &config.PluginSet{
  396. Enabled: []config.Plugin{
  397. {Name: "queuesort-plugin", Weight: dummyWeight},
  398. },
  399. Disabled: []config.Plugin{
  400. {Name: "disabled-queuesort-plugin", Weight: dummyWeight},
  401. },
  402. },
  403. PreFilter: &config.PluginSet{
  404. Enabled: []config.Plugin{
  405. {Name: "prefilter-plugin", Weight: dummyWeight},
  406. },
  407. Disabled: []config.Plugin{
  408. {Name: "disabled-prefilter-plugin", Weight: dummyWeight},
  409. },
  410. },
  411. Filter: &config.PluginSet{
  412. Enabled: []config.Plugin{
  413. {Name: "filter-plugin", Weight: dummyWeight},
  414. },
  415. Disabled: []config.Plugin{
  416. {Name: "disabled-filter-plugin", Weight: dummyWeight},
  417. },
  418. },
  419. PreScore: &config.PluginSet{
  420. Enabled: []config.Plugin{
  421. {Name: "postfilter-plugin", Weight: dummyWeight},
  422. },
  423. Disabled: []config.Plugin{
  424. {Name: "disabled-postfilter-plugin", Weight: dummyWeight},
  425. },
  426. },
  427. Score: &config.PluginSet{
  428. Enabled: []config.Plugin{
  429. {Name: "score-plugin", Weight: weight},
  430. },
  431. Disabled: []config.Plugin{
  432. {Name: "disabled-score-plugin", Weight: weight},
  433. },
  434. },
  435. Reserve: &config.PluginSet{
  436. Enabled: []config.Plugin{
  437. {Name: "reserve-plugin", Weight: dummyWeight},
  438. },
  439. Disabled: []config.Plugin{
  440. {Name: "disabled-reserve-plugin", Weight: dummyWeight},
  441. },
  442. },
  443. Permit: &config.PluginSet{
  444. Enabled: []config.Plugin{
  445. {Name: "permit-plugin", Weight: dummyWeight},
  446. },
  447. Disabled: []config.Plugin{
  448. {Name: "disabled-permit-plugin", Weight: dummyWeight},
  449. },
  450. },
  451. PreBind: &config.PluginSet{
  452. Enabled: []config.Plugin{
  453. {Name: "prebind-plugin", Weight: dummyWeight},
  454. },
  455. Disabled: []config.Plugin{
  456. {Name: "disabled-prebind-plugin", Weight: dummyWeight},
  457. },
  458. },
  459. Bind: &config.PluginSet{
  460. Enabled: []config.Plugin{
  461. {Name: "bind-plugin", Weight: dummyWeight},
  462. },
  463. Disabled: []config.Plugin{
  464. {Name: "disabled-bind-plugin", Weight: dummyWeight},
  465. },
  466. },
  467. PostBind: &config.PluginSet{
  468. Enabled: []config.Plugin{
  469. {Name: "postbind-plugin", Weight: dummyWeight},
  470. },
  471. Disabled: []config.Plugin{
  472. {Name: "disabled-postbind-plugin", Weight: dummyWeight},
  473. },
  474. },
  475. Unreserve: &config.PluginSet{
  476. Enabled: []config.Plugin{
  477. {Name: "unreserve-plugin", Weight: dummyWeight},
  478. },
  479. Disabled: []config.Plugin{
  480. {Name: "disabled-unreserve-plugin", Weight: dummyWeight},
  481. },
  482. },
  483. }
  484. convertedConfigPlugins := config.Plugins{}
  485. convertedV1Alpha1Plugins := v1alpha1.Plugins{}
  486. scheme := getScheme(t)
  487. if err := scheme.Convert(&v1alpha1Plugins, &convertedConfigPlugins, nil); err != nil {
  488. t.Fatal(err)
  489. }
  490. if err := scheme.Convert(&configPlugins, &convertedV1Alpha1Plugins, nil); err != nil {
  491. t.Fatal(err)
  492. }
  493. if diff := cmp.Diff(configPlugins, convertedConfigPlugins); diff != "" {
  494. t.Errorf("unexpected plugins diff (-want, +got): %s", diff)
  495. }
  496. if diff := cmp.Diff(v1alpha1Plugins, convertedV1Alpha1Plugins); diff != "" {
  497. t.Errorf("unexpected plugins diff (-want, +got): %s", diff)
  498. }
  499. }
  500. func getScheme(t *testing.T) *runtime.Scheme {
  501. scheme := runtime.NewScheme()
  502. if err := AddToScheme(scheme); err != nil {
  503. t.Fatal(err)
  504. }
  505. return scheme
  506. }