storage_test.go 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454
  1. /*
  2. Copyright 2015 The Kubernetes Authors.
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. http://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package storage
  14. import (
  15. "context"
  16. "fmt"
  17. "net/http"
  18. "reflect"
  19. "testing"
  20. apiequality "k8s.io/apimachinery/pkg/api/equality"
  21. "k8s.io/apimachinery/pkg/api/errors"
  22. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  23. "k8s.io/apimachinery/pkg/fields"
  24. "k8s.io/apimachinery/pkg/labels"
  25. "k8s.io/apimachinery/pkg/runtime"
  26. "k8s.io/apimachinery/pkg/util/diff"
  27. "k8s.io/apimachinery/pkg/util/intstr"
  28. genericapirequest "k8s.io/apiserver/pkg/endpoints/request"
  29. "k8s.io/apiserver/pkg/registry/generic"
  30. genericregistrytest "k8s.io/apiserver/pkg/registry/generic/testing"
  31. "k8s.io/apiserver/pkg/registry/rest"
  32. storeerr "k8s.io/apiserver/pkg/storage/errors"
  33. etcd3testing "k8s.io/apiserver/pkg/storage/etcd3/testing"
  34. "k8s.io/kubernetes/pkg/apis/apps"
  35. "k8s.io/kubernetes/pkg/apis/autoscaling"
  36. api "k8s.io/kubernetes/pkg/apis/core"
  37. "k8s.io/kubernetes/pkg/registry/registrytest"
  38. )
  39. const defaultReplicas = 100
  40. func newStorage(t *testing.T) (*DeploymentStorage, *etcd3testing.EtcdTestServer) {
  41. etcdStorage, server := registrytest.NewEtcdStorage(t, apps.GroupName)
  42. restOptions := generic.RESTOptions{StorageConfig: etcdStorage, Decorator: generic.UndecoratedStorage, DeleteCollectionWorkers: 1, ResourcePrefix: "deployments"}
  43. deploymentStorage, err := NewStorage(restOptions)
  44. if err != nil {
  45. t.Fatalf("unexpected error from REST storage: %v", err)
  46. }
  47. return &deploymentStorage, server
  48. }
  49. var namespace = "foo-namespace"
  50. var name = "foo-deployment"
  51. func validNewDeployment() *apps.Deployment {
  52. return &apps.Deployment{
  53. ObjectMeta: metav1.ObjectMeta{
  54. Name: name,
  55. Namespace: namespace,
  56. },
  57. Spec: apps.DeploymentSpec{
  58. Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"a": "b"}},
  59. Strategy: apps.DeploymentStrategy{
  60. Type: apps.RollingUpdateDeploymentStrategyType,
  61. RollingUpdate: &apps.RollingUpdateDeployment{
  62. MaxSurge: intstr.FromInt(1),
  63. MaxUnavailable: intstr.FromInt(1),
  64. },
  65. },
  66. Template: api.PodTemplateSpec{
  67. ObjectMeta: metav1.ObjectMeta{
  68. Labels: map[string]string{"a": "b"},
  69. },
  70. Spec: api.PodSpec{
  71. Containers: []api.Container{
  72. {
  73. Name: "test",
  74. Image: "test_image",
  75. ImagePullPolicy: api.PullIfNotPresent,
  76. TerminationMessagePolicy: api.TerminationMessageReadFile,
  77. },
  78. },
  79. RestartPolicy: api.RestartPolicyAlways,
  80. DNSPolicy: api.DNSClusterFirst,
  81. },
  82. },
  83. Replicas: 7,
  84. },
  85. Status: apps.DeploymentStatus{
  86. Replicas: 5,
  87. },
  88. }
  89. }
  90. var validDeployment = *validNewDeployment()
  91. func TestCreate(t *testing.T) {
  92. storage, server := newStorage(t)
  93. defer server.Terminate(t)
  94. defer storage.Deployment.Store.DestroyFunc()
  95. test := genericregistrytest.New(t, storage.Deployment.Store)
  96. deployment := validNewDeployment()
  97. deployment.ObjectMeta = metav1.ObjectMeta{}
  98. test.TestCreate(
  99. // valid
  100. deployment,
  101. // invalid (invalid selector)
  102. &apps.Deployment{
  103. Spec: apps.DeploymentSpec{
  104. Selector: &metav1.LabelSelector{MatchLabels: map[string]string{}},
  105. Template: validDeployment.Spec.Template,
  106. },
  107. },
  108. )
  109. }
  110. func TestUpdate(t *testing.T) {
  111. storage, server := newStorage(t)
  112. defer server.Terminate(t)
  113. defer storage.Deployment.Store.DestroyFunc()
  114. test := genericregistrytest.New(t, storage.Deployment.Store)
  115. test.TestUpdate(
  116. // valid
  117. validNewDeployment(),
  118. // updateFunc
  119. func(obj runtime.Object) runtime.Object {
  120. object := obj.(*apps.Deployment)
  121. object.Spec.Template.Spec.NodeSelector = map[string]string{"c": "d"}
  122. return object
  123. },
  124. // invalid updateFunc
  125. func(obj runtime.Object) runtime.Object {
  126. object := obj.(*apps.Deployment)
  127. object.Name = ""
  128. return object
  129. },
  130. func(obj runtime.Object) runtime.Object {
  131. object := obj.(*apps.Deployment)
  132. object.Spec.Template.Spec.RestartPolicy = api.RestartPolicyOnFailure
  133. return object
  134. },
  135. func(obj runtime.Object) runtime.Object {
  136. object := obj.(*apps.Deployment)
  137. object.Spec.Selector = &metav1.LabelSelector{MatchLabels: map[string]string{}}
  138. return object
  139. },
  140. )
  141. }
  142. func TestDelete(t *testing.T) {
  143. storage, server := newStorage(t)
  144. defer server.Terminate(t)
  145. defer storage.Deployment.Store.DestroyFunc()
  146. test := genericregistrytest.New(t, storage.Deployment.Store)
  147. test.TestDelete(validNewDeployment())
  148. }
  149. func TestGet(t *testing.T) {
  150. storage, server := newStorage(t)
  151. defer server.Terminate(t)
  152. defer storage.Deployment.Store.DestroyFunc()
  153. test := genericregistrytest.New(t, storage.Deployment.Store)
  154. test.TestGet(validNewDeployment())
  155. }
  156. func TestList(t *testing.T) {
  157. storage, server := newStorage(t)
  158. defer server.Terminate(t)
  159. defer storage.Deployment.Store.DestroyFunc()
  160. test := genericregistrytest.New(t, storage.Deployment.Store)
  161. test.TestList(validNewDeployment())
  162. }
  163. func TestWatch(t *testing.T) {
  164. storage, server := newStorage(t)
  165. defer server.Terminate(t)
  166. defer storage.Deployment.Store.DestroyFunc()
  167. test := genericregistrytest.New(t, storage.Deployment.Store)
  168. test.TestWatch(
  169. validNewDeployment(),
  170. // matching labels
  171. []labels.Set{},
  172. // not matching labels
  173. []labels.Set{
  174. {"a": "c"},
  175. {"foo": "bar"},
  176. },
  177. // matching fields
  178. []fields.Set{
  179. {"metadata.name": name},
  180. },
  181. // not matching fields
  182. []fields.Set{
  183. {"metadata.name": "bar"},
  184. {"name": name},
  185. },
  186. )
  187. }
  188. func TestScaleGet(t *testing.T) {
  189. storage, server := newStorage(t)
  190. defer server.Terminate(t)
  191. defer storage.Deployment.Store.DestroyFunc()
  192. var deployment apps.Deployment
  193. ctx := genericapirequest.WithNamespace(genericapirequest.NewContext(), namespace)
  194. key := "/deployments/" + namespace + "/" + name
  195. if err := storage.Deployment.Storage.Create(ctx, key, &validDeployment, &deployment, 0, false); err != nil {
  196. t.Fatalf("error setting new deployment (key: %s) %v: %v", key, validDeployment, err)
  197. }
  198. selector, err := metav1.LabelSelectorAsSelector(validDeployment.Spec.Selector)
  199. if err != nil {
  200. t.Fatal(err)
  201. }
  202. want := &autoscaling.Scale{
  203. ObjectMeta: metav1.ObjectMeta{
  204. Name: name,
  205. Namespace: namespace,
  206. UID: deployment.UID,
  207. ResourceVersion: deployment.ResourceVersion,
  208. CreationTimestamp: deployment.CreationTimestamp,
  209. },
  210. Spec: autoscaling.ScaleSpec{
  211. Replicas: validDeployment.Spec.Replicas,
  212. },
  213. Status: autoscaling.ScaleStatus{
  214. Replicas: validDeployment.Status.Replicas,
  215. Selector: selector.String(),
  216. },
  217. }
  218. obj, err := storage.Scale.Get(ctx, name, &metav1.GetOptions{})
  219. if err != nil {
  220. t.Fatalf("error fetching scale for %s: %v", name, err)
  221. }
  222. got := obj.(*autoscaling.Scale)
  223. if !apiequality.Semantic.DeepEqual(want, got) {
  224. t.Errorf("unexpected scale: %s", diff.ObjectDiff(want, got))
  225. }
  226. }
  227. func TestScaleUpdate(t *testing.T) {
  228. storage, server := newStorage(t)
  229. defer server.Terminate(t)
  230. defer storage.Deployment.Store.DestroyFunc()
  231. var deployment apps.Deployment
  232. ctx := genericapirequest.WithNamespace(genericapirequest.NewContext(), namespace)
  233. key := "/deployments/" + namespace + "/" + name
  234. if err := storage.Deployment.Storage.Create(ctx, key, &validDeployment, &deployment, 0, false); err != nil {
  235. t.Fatalf("error setting new deployment (key: %s) %v: %v", key, validDeployment, err)
  236. }
  237. replicas := int32(12)
  238. update := autoscaling.Scale{
  239. ObjectMeta: metav1.ObjectMeta{Name: name, Namespace: namespace},
  240. Spec: autoscaling.ScaleSpec{
  241. Replicas: replicas,
  242. },
  243. }
  244. if _, _, err := storage.Scale.Update(ctx, update.Name, rest.DefaultUpdatedObjectInfo(&update), rest.ValidateAllObjectFunc, rest.ValidateAllObjectUpdateFunc, false, &metav1.UpdateOptions{}); err != nil {
  245. t.Fatalf("error updating scale %v: %v", update, err)
  246. }
  247. obj, err := storage.Scale.Get(ctx, name, &metav1.GetOptions{})
  248. if err != nil {
  249. t.Fatalf("error fetching scale for %s: %v", name, err)
  250. }
  251. scale := obj.(*autoscaling.Scale)
  252. if scale.Spec.Replicas != replicas {
  253. t.Errorf("wrong replicas count expected: %d got: %d", replicas, deployment.Spec.Replicas)
  254. }
  255. update.ResourceVersion = deployment.ResourceVersion
  256. update.Spec.Replicas = 15
  257. if _, _, err = storage.Scale.Update(ctx, update.Name, rest.DefaultUpdatedObjectInfo(&update), rest.ValidateAllObjectFunc, rest.ValidateAllObjectUpdateFunc, false, &metav1.UpdateOptions{}); err != nil && !errors.IsConflict(err) {
  258. t.Fatalf("unexpected error, expecting an update conflict but got %v", err)
  259. }
  260. }
  261. func TestStatusUpdate(t *testing.T) {
  262. storage, server := newStorage(t)
  263. defer server.Terminate(t)
  264. defer storage.Deployment.Store.DestroyFunc()
  265. ctx := genericapirequest.WithNamespace(genericapirequest.NewContext(), namespace)
  266. key := "/deployments/" + namespace + "/" + name
  267. if err := storage.Deployment.Storage.Create(ctx, key, &validDeployment, nil, 0, false); err != nil {
  268. t.Fatalf("unexpected error: %v", err)
  269. }
  270. update := apps.Deployment{
  271. ObjectMeta: validDeployment.ObjectMeta,
  272. Spec: apps.DeploymentSpec{
  273. Replicas: defaultReplicas,
  274. },
  275. Status: apps.DeploymentStatus{
  276. Replicas: defaultReplicas,
  277. },
  278. }
  279. if _, _, err := storage.Status.Update(ctx, update.Name, rest.DefaultUpdatedObjectInfo(&update), rest.ValidateAllObjectFunc, rest.ValidateAllObjectUpdateFunc, false, &metav1.UpdateOptions{}); err != nil {
  280. t.Fatalf("unexpected error: %v", err)
  281. }
  282. obj, err := storage.Deployment.Get(ctx, name, &metav1.GetOptions{})
  283. if err != nil {
  284. t.Fatalf("unexpected error: %v", err)
  285. }
  286. deployment := obj.(*apps.Deployment)
  287. if deployment.Spec.Replicas != 7 {
  288. t.Errorf("we expected .spec.replicas to not be updated but it was updated to %v", deployment.Spec.Replicas)
  289. }
  290. if deployment.Status.Replicas != defaultReplicas {
  291. t.Errorf("we expected .status.replicas to be updated to %d but it was %v", defaultReplicas, deployment.Status.Replicas)
  292. }
  293. }
  294. func TestEtcdCreateDeploymentRollback(t *testing.T) {
  295. ctx := genericapirequest.WithNamespace(genericapirequest.NewContext(), namespace)
  296. testCases := map[string]struct {
  297. rollback apps.DeploymentRollback
  298. errOK func(error) bool
  299. }{
  300. "normal": {
  301. rollback: apps.DeploymentRollback{
  302. Name: name,
  303. UpdatedAnnotations: map[string]string{},
  304. RollbackTo: apps.RollbackConfig{Revision: 1},
  305. },
  306. errOK: func(err error) bool { return err == nil },
  307. },
  308. "noAnnotation": {
  309. rollback: apps.DeploymentRollback{
  310. Name: name,
  311. RollbackTo: apps.RollbackConfig{Revision: 1},
  312. },
  313. errOK: func(err error) bool { return err == nil },
  314. },
  315. "noName": {
  316. rollback: apps.DeploymentRollback{
  317. UpdatedAnnotations: map[string]string{},
  318. RollbackTo: apps.RollbackConfig{Revision: 1},
  319. },
  320. errOK: func(err error) bool { return err != nil },
  321. },
  322. }
  323. for k, test := range testCases {
  324. storage, server := newStorage(t)
  325. rollbackStorage := storage.Rollback
  326. if _, err := storage.Deployment.Create(ctx, validNewDeployment(), rest.ValidateAllObjectFunc, &metav1.CreateOptions{}); err != nil {
  327. t.Fatalf("%s: unexpected error: %v", k, err)
  328. }
  329. rollbackRespStatus, err := rollbackStorage.Create(ctx, test.rollback.Name, &test.rollback, rest.ValidateAllObjectFunc, &metav1.CreateOptions{})
  330. if !test.errOK(err) {
  331. t.Errorf("%s: unexpected error: %v", k, err)
  332. } else if err == nil {
  333. // If rollback succeeded, verify Rollback response and Rollback field of deployment
  334. status, ok := rollbackRespStatus.(*metav1.Status)
  335. if !ok {
  336. t.Errorf("%s: unexpected response format", k)
  337. }
  338. if status.Code != http.StatusOK || status.Status != metav1.StatusSuccess {
  339. t.Errorf("%s: unexpected response, code: %d, status: %s", k, status.Code, status.Status)
  340. }
  341. d, err := storage.Deployment.Get(ctx, validNewDeployment().ObjectMeta.Name, &metav1.GetOptions{})
  342. if err != nil {
  343. t.Errorf("%s: unexpected error: %v", k, err)
  344. } else if !reflect.DeepEqual(*d.(*apps.Deployment).Spec.RollbackTo, test.rollback.RollbackTo) {
  345. t.Errorf("%s: expected: %v, got: %v", k, *d.(*apps.Deployment).Spec.RollbackTo, test.rollback.RollbackTo)
  346. }
  347. }
  348. storage.Deployment.Store.DestroyFunc()
  349. server.Terminate(t)
  350. }
  351. }
  352. func TestCreateDeploymentRollbackValidation(t *testing.T) {
  353. storage, server := newStorage(t)
  354. rollbackStorage := storage.Rollback
  355. rollback := apps.DeploymentRollback{
  356. Name: name,
  357. UpdatedAnnotations: map[string]string{},
  358. RollbackTo: apps.RollbackConfig{Revision: 1},
  359. }
  360. ctx := genericapirequest.WithNamespace(genericapirequest.NewContext(), namespace)
  361. if _, err := storage.Deployment.Create(ctx, validNewDeployment(), rest.ValidateAllObjectFunc, &metav1.CreateOptions{}); err != nil {
  362. t.Fatalf("Unexpected error: %v", err)
  363. }
  364. validationError := fmt.Errorf("admission deny")
  365. alwaysDenyValidationFunc := func(ctx context.Context, obj runtime.Object) error { return validationError }
  366. _, err := rollbackStorage.Create(ctx, rollback.Name, &rollback, alwaysDenyValidationFunc, &metav1.CreateOptions{})
  367. if err == nil || validationError != err {
  368. t.Errorf("expected: %v, got: %v", validationError, err)
  369. }
  370. storage.Deployment.Store.DestroyFunc()
  371. server.Terminate(t)
  372. }
  373. // Ensure that when a deploymentRollback is created for a deployment that has already been deleted
  374. // by the API server, API server returns not-found error.
  375. func TestEtcdCreateDeploymentRollbackNoDeployment(t *testing.T) {
  376. storage, server := newStorage(t)
  377. defer server.Terminate(t)
  378. defer storage.Deployment.Store.DestroyFunc()
  379. rollbackStorage := storage.Rollback
  380. ctx := genericapirequest.WithNamespace(genericapirequest.NewContext(), namespace)
  381. _, err := rollbackStorage.Create(ctx, name, &apps.DeploymentRollback{
  382. Name: name,
  383. UpdatedAnnotations: map[string]string{},
  384. RollbackTo: apps.RollbackConfig{Revision: 1},
  385. }, rest.ValidateAllObjectFunc, &metav1.CreateOptions{})
  386. if err == nil {
  387. t.Fatalf("Expected not-found-error but got nothing")
  388. }
  389. if !errors.IsNotFound(storeerr.InterpretGetError(err, apps.Resource("deployments"), name)) {
  390. t.Fatalf("Unexpected error returned: %#v", err)
  391. }
  392. _, err = storage.Deployment.Get(ctx, name, &metav1.GetOptions{})
  393. if err == nil {
  394. t.Fatalf("Expected not-found-error but got nothing")
  395. }
  396. if !errors.IsNotFound(storeerr.InterpretGetError(err, apps.Resource("deployments"), name)) {
  397. t.Fatalf("Unexpected error: %v", err)
  398. }
  399. }
  400. func TestShortNames(t *testing.T) {
  401. storage, server := newStorage(t)
  402. defer server.Terminate(t)
  403. defer storage.Deployment.Store.DestroyFunc()
  404. expected := []string{"deploy"}
  405. registrytest.AssertShortNames(t, storage.Deployment, expected)
  406. }
  407. func TestCategories(t *testing.T) {
  408. storage, server := newStorage(t)
  409. defer server.Terminate(t)
  410. defer storage.Deployment.Store.DestroyFunc()
  411. expected := []string{"all"}
  412. registrytest.AssertCategories(t, storage.Deployment, expected)
  413. }