123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747 |
- /*
- Copyright 2019 The Kubernetes Authors.
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- */
- package topologymanager
- import (
- "fmt"
- "reflect"
- "strings"
- "testing"
- "k8s.io/api/core/v1"
- "k8s.io/apimachinery/pkg/types"
- "k8s.io/kubernetes/pkg/kubelet/cm/topologymanager/bitmask"
- "k8s.io/kubernetes/pkg/kubelet/lifecycle"
- )
- func NewTestBitMask(sockets ...int) bitmask.BitMask {
- s, _ := bitmask.NewBitMask(sockets...)
- return s
- }
- func TestNewManager(t *testing.T) {
- tcases := []struct {
- description string
- policyName string
- expectedPolicy string
- expectedError error
- }{
- {
- description: "Policy is set to best-effort",
- policyName: "best-effort",
- expectedPolicy: "best-effort",
- },
- {
- description: "Policy is set to restricted",
- policyName: "restricted",
- expectedPolicy: "restricted",
- },
- {
- description: "Policy is set to unknown",
- policyName: "unknown",
- expectedError: fmt.Errorf("unknown policy: \"unknown\""),
- },
- }
- for _, tc := range tcases {
- mngr, err := NewManager(nil, tc.policyName)
- if tc.expectedError != nil {
- if !strings.Contains(err.Error(), tc.expectedError.Error()) {
- t.Errorf("Unexpected error message. Have: %s wants %s", err.Error(), tc.expectedError.Error())
- }
- } else {
- rawMgr := mngr.(*manager)
- if rawMgr.policy.Name() != tc.expectedPolicy {
- t.Errorf("Unexpected policy name. Have: %q wants %q", rawMgr.policy.Name(), tc.expectedPolicy)
- }
- }
- }
- }
- type mockHintProvider struct {
- th map[string][]TopologyHint
- }
- func (m *mockHintProvider) GetTopologyHints(pod *v1.Pod, container *v1.Container) map[string][]TopologyHint {
- return m.th
- }
- func TestGetAffinity(t *testing.T) {
- tcases := []struct {
- name string
- containerName string
- podUID string
- expected TopologyHint
- }{
- {
- name: "case1",
- containerName: "nginx",
- podUID: "0aafa4c4-38e8-11e9-bcb1-a4bf01040474",
- expected: TopologyHint{},
- },
- }
- for _, tc := range tcases {
- mngr := manager{}
- actual := mngr.GetAffinity(tc.podUID, tc.containerName)
- if !reflect.DeepEqual(actual, tc.expected) {
- t.Errorf("Expected Affinity in result to be %v, got %v", tc.expected, actual)
- }
- }
- }
- func TestAccumulateProvidersHints(t *testing.T) {
- tcases := []struct {
- name string
- hp []HintProvider
- expected []map[string][]TopologyHint
- }{
- {
- name: "TopologyHint not set",
- hp: []HintProvider{},
- expected: nil,
- },
- {
- name: "HintProvider returns empty non-nil map[string][]TopologyHint",
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{},
- },
- },
- expected: []map[string][]TopologyHint{
- {},
- },
- },
- {
- name: "HintProvider returns - nil map[string][]TopologyHint from provider",
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource": nil,
- },
- },
- },
- expected: []map[string][]TopologyHint{
- {
- "resource": nil,
- },
- },
- },
- {
- name: "2 HintProviders with 1 resource returns hints",
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource1": {TopologyHint{}},
- },
- },
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource2": {TopologyHint{}},
- },
- },
- },
- expected: []map[string][]TopologyHint{
- {
- "resource1": {TopologyHint{}},
- },
- {
- "resource2": {TopologyHint{}},
- },
- },
- },
- {
- name: "2 HintProviders 1 with 1 resource 1 with nil hints",
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource1": {TopologyHint{}},
- },
- },
- &mockHintProvider{nil},
- },
- expected: []map[string][]TopologyHint{
- {
- "resource1": {TopologyHint{}},
- },
- nil,
- },
- },
- {
- name: "2 HintProviders 1 with 1 resource 1 empty hints",
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource1": {TopologyHint{}},
- },
- },
- &mockHintProvider{
- map[string][]TopologyHint{},
- },
- },
- expected: []map[string][]TopologyHint{
- {
- "resource1": {TopologyHint{}},
- },
- {},
- },
- },
- {
- name: "HintProvider with 2 resources returns hints",
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource1": {TopologyHint{}},
- "resource2": {TopologyHint{}},
- },
- },
- },
- expected: []map[string][]TopologyHint{
- {
- "resource1": {TopologyHint{}},
- "resource2": {TopologyHint{}},
- },
- },
- },
- }
- for _, tc := range tcases {
- mngr := manager{
- hintProviders: tc.hp,
- }
- actual := mngr.accumulateProvidersHints(&v1.Pod{}, &v1.Container{})
- if !reflect.DeepEqual(actual, tc.expected) {
- t.Errorf("Test Case %s: Expected NUMANodeAffinity in result to be %v, got %v", tc.name, tc.expected, actual)
- }
- }
- }
- type mockPolicy struct {
- nonePolicy
- ph []map[string][]TopologyHint
- }
- func (p *mockPolicy) Merge(providersHints []map[string][]TopologyHint) (TopologyHint, bool) {
- p.ph = providersHints
- return TopologyHint{}, true
- }
- func TestCalculateAffinity(t *testing.T) {
- tcases := []struct {
- name string
- hp []HintProvider
- expected []map[string][]TopologyHint
- }{
- {
- name: "No hint providers",
- hp: []HintProvider{},
- expected: ([]map[string][]TopologyHint)(nil),
- },
- {
- name: "HintProvider returns empty non-nil map[string][]TopologyHint",
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{},
- },
- },
- expected: []map[string][]TopologyHint{
- {},
- },
- },
- {
- name: "HintProvider returns -nil map[string][]TopologyHint from provider",
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource": nil,
- },
- },
- },
- expected: []map[string][]TopologyHint{
- {
- "resource": nil,
- },
- },
- },
- {
- name: "Assorted HintProviders",
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource-1/A": {
- {NUMANodeAffinity: NewTestBitMask(0), Preferred: true},
- {NUMANodeAffinity: NewTestBitMask(0, 1), Preferred: false},
- },
- "resource-1/B": {
- {NUMANodeAffinity: NewTestBitMask(1), Preferred: true},
- {NUMANodeAffinity: NewTestBitMask(1, 2), Preferred: false},
- },
- },
- },
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource-2/A": {
- {NUMANodeAffinity: NewTestBitMask(2), Preferred: true},
- {NUMANodeAffinity: NewTestBitMask(3, 4), Preferred: false},
- },
- "resource-2/B": {
- {NUMANodeAffinity: NewTestBitMask(2), Preferred: true},
- {NUMANodeAffinity: NewTestBitMask(3, 4), Preferred: false},
- },
- },
- },
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource-3": nil,
- },
- },
- },
- expected: []map[string][]TopologyHint{
- {
- "resource-1/A": {
- {NUMANodeAffinity: NewTestBitMask(0), Preferred: true},
- {NUMANodeAffinity: NewTestBitMask(0, 1), Preferred: false},
- },
- "resource-1/B": {
- {NUMANodeAffinity: NewTestBitMask(1), Preferred: true},
- {NUMANodeAffinity: NewTestBitMask(1, 2), Preferred: false},
- },
- },
- {
- "resource-2/A": {
- {NUMANodeAffinity: NewTestBitMask(2), Preferred: true},
- {NUMANodeAffinity: NewTestBitMask(3, 4), Preferred: false},
- },
- "resource-2/B": {
- {NUMANodeAffinity: NewTestBitMask(2), Preferred: true},
- {NUMANodeAffinity: NewTestBitMask(3, 4), Preferred: false},
- },
- },
- {
- "resource-3": nil,
- },
- },
- },
- }
- for _, tc := range tcases {
- mngr := manager{}
- mngr.policy = &mockPolicy{}
- mngr.hintProviders = tc.hp
- mngr.calculateAffinity(&v1.Pod{}, &v1.Container{})
- actual := mngr.policy.(*mockPolicy).ph
- if !reflect.DeepEqual(tc.expected, actual) {
- t.Errorf("Test Case: %s", tc.name)
- t.Errorf("Expected result to be %v, got %v", tc.expected, actual)
- }
- }
- }
- func TestAddContainer(t *testing.T) {
- testCases := []struct {
- name string
- containerID string
- podUID types.UID
- }{
- {
- name: "Case1",
- containerID: "nginx",
- podUID: "0aafa4c4-38e8-11e9-bcb1-a4bf01040474",
- },
- {
- name: "Case2",
- containerID: "Busy_Box",
- podUID: "b3ee37fc-39a5-11e9-bcb1-a4bf01040474",
- },
- }
- mngr := manager{}
- mngr.podMap = make(map[string]string)
- for _, tc := range testCases {
- pod := v1.Pod{}
- pod.UID = tc.podUID
- err := mngr.AddContainer(&pod, tc.containerID)
- if err != nil {
- t.Errorf("Expected error to be nil but got: %v", err)
- }
- if val, ok := mngr.podMap[tc.containerID]; ok {
- if reflect.DeepEqual(val, pod.UID) {
- t.Errorf("Error occurred")
- }
- } else {
- t.Errorf("Error occurred, Pod not added to podMap")
- }
- }
- }
- func TestRemoveContainer(t *testing.T) {
- testCases := []struct {
- name string
- containerID string
- podUID types.UID
- }{
- {
- name: "Case1",
- containerID: "nginx",
- podUID: "0aafa4c4-38e8-11e9-bcb1-a4bf01040474",
- },
- {
- name: "Case2",
- containerID: "Busy_Box",
- podUID: "b3ee37fc-39a5-11e9-bcb1-a4bf01040474",
- },
- }
- var len1, len2 int
- mngr := manager{}
- mngr.podMap = make(map[string]string)
- for _, tc := range testCases {
- mngr.podMap[tc.containerID] = string(tc.podUID)
- len1 = len(mngr.podMap)
- err := mngr.RemoveContainer(tc.containerID)
- len2 = len(mngr.podMap)
- if err != nil {
- t.Errorf("Expected error to be nil but got: %v", err)
- }
- if len1-len2 != 1 {
- t.Errorf("Remove Pod resulted in error")
- }
- }
- }
- func TestAddHintProvider(t *testing.T) {
- var len1 int
- tcases := []struct {
- name string
- hp []HintProvider
- }{
- {
- name: "Add HintProvider",
- hp: []HintProvider{
- &mockHintProvider{},
- },
- },
- }
- mngr := manager{}
- for _, tc := range tcases {
- mngr.hintProviders = []HintProvider{}
- len1 = len(mngr.hintProviders)
- mngr.AddHintProvider(tc.hp[0])
- }
- len2 := len(mngr.hintProviders)
- if len2-len1 != 1 {
- t.Errorf("error")
- }
- }
- func TestAdmit(t *testing.T) {
- numaNodes := []int{0, 1}
- tcases := []struct {
- name string
- result lifecycle.PodAdmitResult
- qosClass v1.PodQOSClass
- policy Policy
- hp []HintProvider
- expected bool
- }{
- {
- name: "QOSClass set as BestEffort. None Policy. No Hints.",
- qosClass: v1.PodQOSBestEffort,
- policy: NewNonePolicy(),
- hp: []HintProvider{},
- expected: true,
- },
- {
- name: "QOSClass set as Guaranteed. None Policy. No Hints.",
- qosClass: v1.PodQOSGuaranteed,
- policy: NewNonePolicy(),
- hp: []HintProvider{},
- expected: true,
- },
- {
- name: "QOSClass set as BestEffort. single-numa-node Policy. No Hints.",
- qosClass: v1.PodQOSBestEffort,
- policy: NewRestrictedPolicy(numaNodes),
- hp: []HintProvider{
- &mockHintProvider{},
- },
- expected: true,
- },
- {
- name: "QOSClass set as BestEffort. Restricted Policy. No Hints.",
- qosClass: v1.PodQOSBestEffort,
- policy: NewRestrictedPolicy(numaNodes),
- hp: []HintProvider{
- &mockHintProvider{},
- },
- expected: true,
- },
- {
- name: "QOSClass set as Guaranteed. BestEffort Policy. Preferred Affinity.",
- qosClass: v1.PodQOSGuaranteed,
- policy: NewBestEffortPolicy(numaNodes),
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource": {
- {
- NUMANodeAffinity: NewTestBitMask(0),
- Preferred: true,
- },
- {
- NUMANodeAffinity: NewTestBitMask(0, 1),
- Preferred: false,
- },
- },
- },
- },
- },
- expected: true,
- },
- {
- name: "QOSClass set as Guaranteed. BestEffort Policy. More than one Preferred Affinity.",
- qosClass: v1.PodQOSGuaranteed,
- policy: NewBestEffortPolicy(numaNodes),
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource": {
- {
- NUMANodeAffinity: NewTestBitMask(0),
- Preferred: true,
- },
- {
- NUMANodeAffinity: NewTestBitMask(1),
- Preferred: true,
- },
- {
- NUMANodeAffinity: NewTestBitMask(0, 1),
- Preferred: false,
- },
- },
- },
- },
- },
- expected: true,
- },
- {
- name: "QOSClass set as Burstable. BestEffort Policy. More than one Preferred Affinity.",
- qosClass: v1.PodQOSBurstable,
- policy: NewBestEffortPolicy(numaNodes),
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource": {
- {
- NUMANodeAffinity: NewTestBitMask(0),
- Preferred: true,
- },
- {
- NUMANodeAffinity: NewTestBitMask(1),
- Preferred: true,
- },
- {
- NUMANodeAffinity: NewTestBitMask(0, 1),
- Preferred: false,
- },
- },
- },
- },
- },
- expected: true,
- },
- {
- name: "QOSClass set as Guaranteed. BestEffort Policy. No Preferred Affinity.",
- qosClass: v1.PodQOSGuaranteed,
- policy: NewBestEffortPolicy(numaNodes),
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource": {
- {
- NUMANodeAffinity: NewTestBitMask(0, 1),
- Preferred: false,
- },
- },
- },
- },
- },
- expected: true,
- },
- {
- name: "QOSClass set as Guaranteed. Restricted Policy. Preferred Affinity.",
- qosClass: v1.PodQOSGuaranteed,
- policy: NewRestrictedPolicy(numaNodes),
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource": {
- {
- NUMANodeAffinity: NewTestBitMask(0),
- Preferred: true,
- },
- {
- NUMANodeAffinity: NewTestBitMask(0, 1),
- Preferred: false,
- },
- },
- },
- },
- },
- expected: true,
- },
- {
- name: "QOSClass set as Burstable. Restricted Policy. Preferred Affinity.",
- qosClass: v1.PodQOSBurstable,
- policy: NewRestrictedPolicy(numaNodes),
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource": {
- {
- NUMANodeAffinity: NewTestBitMask(0),
- Preferred: true,
- },
- {
- NUMANodeAffinity: NewTestBitMask(0, 1),
- Preferred: false,
- },
- },
- },
- },
- },
- expected: true,
- },
- {
- name: "QOSClass set as Guaranteed. Restricted Policy. More than one Preferred affinity.",
- qosClass: v1.PodQOSGuaranteed,
- policy: NewRestrictedPolicy(numaNodes),
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource": {
- {
- NUMANodeAffinity: NewTestBitMask(0),
- Preferred: true,
- },
- {
- NUMANodeAffinity: NewTestBitMask(1),
- Preferred: true,
- },
- {
- NUMANodeAffinity: NewTestBitMask(0, 1),
- Preferred: false,
- },
- },
- },
- },
- },
- expected: true,
- },
- {
- name: "QOSClass set as Burstable. Restricted Policy. More than one Preferred affinity.",
- qosClass: v1.PodQOSBurstable,
- policy: NewRestrictedPolicy(numaNodes),
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource": {
- {
- NUMANodeAffinity: NewTestBitMask(0),
- Preferred: true,
- },
- {
- NUMANodeAffinity: NewTestBitMask(1),
- Preferred: true,
- },
- {
- NUMANodeAffinity: NewTestBitMask(0, 1),
- Preferred: false,
- },
- },
- },
- },
- },
- expected: true,
- },
- {
- name: "QOSClass set as Guaranteed. Restricted Policy. No Preferred affinity.",
- qosClass: v1.PodQOSGuaranteed,
- policy: NewRestrictedPolicy(numaNodes),
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource": {
- {
- NUMANodeAffinity: NewTestBitMask(0, 1),
- Preferred: false,
- },
- },
- },
- },
- },
- expected: false,
- },
- {
- name: "QOSClass set as Burstable. Restricted Policy. No Preferred affinity.",
- qosClass: v1.PodQOSBurstable,
- policy: NewRestrictedPolicy(numaNodes),
- hp: []HintProvider{
- &mockHintProvider{
- map[string][]TopologyHint{
- "resource": {
- {
- NUMANodeAffinity: NewTestBitMask(0, 1),
- Preferred: false,
- },
- },
- },
- },
- },
- expected: false,
- },
- }
- for _, tc := range tcases {
- man := manager{
- policy: tc.policy,
- podTopologyHints: make(map[string]map[string]TopologyHint),
- hintProviders: tc.hp,
- }
- pod := &v1.Pod{
- Spec: v1.PodSpec{
- Containers: []v1.Container{
- {
- Resources: v1.ResourceRequirements{},
- },
- },
- },
- Status: v1.PodStatus{
- QOSClass: tc.qosClass,
- },
- }
- podAttr := lifecycle.PodAdmitAttributes{
- Pod: pod,
- }
- actual := man.Admit(&podAttr)
- if actual.Admit != tc.expected {
- t.Errorf("Error occurred, expected Admit in result to be %v got %v", tc.expected, actual.Admit)
- }
- }
- }
|