starpu_mpi.c 34 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077
  1. /* StarPU --- Runtime system for heterogeneous multicore architectures.
  2. *
  3. * Copyright (C) 2009, 2010-2013 Université de Bordeaux 1
  4. * Copyright (C) 2010, 2011, 2012, 2013 Centre National de la Recherche Scientifique
  5. *
  6. * StarPU is free software; you can redistribute it and/or modify
  7. * it under the terms of the GNU Lesser General Public License as published by
  8. * the Free Software Foundation; either version 2.1 of the License, or (at
  9. * your option) any later version.
  10. *
  11. * StarPU is distributed in the hope that it will be useful, but
  12. * WITHOUT ANY WARRANTY; without even the implied warranty of
  13. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
  14. *
  15. * See the GNU Lesser General Public License in COPYING.LGPL for more details.
  16. */
  17. #include <stdlib.h>
  18. #include <starpu_mpi.h>
  19. #include <starpu_mpi_datatype.h>
  20. //#define STARPU_MPI_VERBOSE 1
  21. #include <starpu_mpi_private.h>
  22. #include <starpu_profiling.h>
  23. #include <starpu_mpi_stats.h>
  24. #include <starpu_mpi_insert_task.h>
  25. #ifdef STARPU_DEVEL
  26. # warning TODO find a better way to select the polling method (perhaps during the configuration)
  27. #endif
  28. //#define USE_STARPU_ACTIVITY 1
  29. static void _starpu_mpi_submit_new_mpi_request(void *arg);
  30. static void _starpu_mpi_handle_request_termination(struct _starpu_mpi_req *req);
  31. #ifdef STARPU_MPI_VERBOSE
  32. static char *_starpu_mpi_request_type(enum _starpu_mpi_request_type request_type);
  33. #endif
  34. static struct _starpu_mpi_req *_starpu_mpi_isend_common(starpu_data_handle_t data_handle,
  35. int dest, int mpi_tag, MPI_Comm comm,
  36. unsigned detached, void (*callback)(void *), void *arg);
  37. static struct _starpu_mpi_req *_starpu_mpi_irecv_common(starpu_data_handle_t data_handle, int source, int mpi_tag, MPI_Comm comm, unsigned detached, void (*callback)(void *), void *arg);
  38. static void _starpu_mpi_handle_detached_request(struct _starpu_mpi_req *req);
  39. /* The list of requests that have been newly submitted by the application */
  40. static struct _starpu_mpi_req_list *new_requests;
  41. /* The list of detached requests that have already been submitted to MPI */
  42. static struct _starpu_mpi_req_list *detached_requests;
  43. static _starpu_pthread_mutex_t detached_requests_mutex;
  44. /* Condition to wake up progression thread */
  45. static _starpu_pthread_cond_t cond_progression;
  46. /* Condition to wake up waiting for all current MPI requests to finish */
  47. static _starpu_pthread_cond_t cond_finished;
  48. static _starpu_pthread_mutex_t mutex;
  49. static pthread_t progress_thread;
  50. static int running = 0;
  51. /* Count requests posted by the application and not yet submitted to MPI, i.e pushed into the new_requests list */
  52. static _starpu_pthread_mutex_t mutex_posted_requests;
  53. static int posted_requests = 0, newer_requests, barrier_running = 0;
  54. #define _STARPU_MPI_INC_POSTED_REQUESTS(value) { _STARPU_PTHREAD_MUTEX_LOCK(&mutex_posted_requests); posted_requests += value; _STARPU_PTHREAD_MUTEX_UNLOCK(&mutex_posted_requests); }
  55. /********************************************************/
  56. /* */
  57. /* Send/Receive functionalities */
  58. /* */
  59. /********************************************************/
  60. static struct _starpu_mpi_req *_starpu_mpi_isend_irecv_common(starpu_data_handle_t data_handle,
  61. int srcdst, int mpi_tag, MPI_Comm comm,
  62. unsigned detached, void (*callback)(void *), void *arg,
  63. enum _starpu_mpi_request_type request_type, void (*func)(struct _starpu_mpi_req *),
  64. enum starpu_access_mode mode)
  65. {
  66. _STARPU_MPI_LOG_IN();
  67. struct _starpu_mpi_req *req = calloc(1, sizeof(struct _starpu_mpi_req));
  68. STARPU_ASSERT(req);
  69. _STARPU_MPI_INC_POSTED_REQUESTS(1);
  70. /* Initialize the request structure */
  71. req->submitted = 0;
  72. req->completed = 0;
  73. _STARPU_PTHREAD_MUTEX_INIT(&req->req_mutex, NULL);
  74. _STARPU_PTHREAD_COND_INIT(&req->req_cond, NULL);
  75. req->request_type = request_type;
  76. req->user_datatype = -1;
  77. req->count = -1;
  78. req->data_handle = data_handle;
  79. req->srcdst = srcdst;
  80. req->mpi_tag = mpi_tag;
  81. req->comm = comm;
  82. req->detached = detached;
  83. req->callback = callback;
  84. req->callback_arg = arg;
  85. req->func = func;
  86. /* Asynchronously request StarPU to fetch the data in main memory: when
  87. * it is available in main memory, _starpu_mpi_submit_new_mpi_request(req) is called and
  88. * the request is actually submitted */
  89. starpu_data_acquire_cb(data_handle, mode, _starpu_mpi_submit_new_mpi_request, (void *)req);
  90. _STARPU_MPI_LOG_OUT();
  91. return req;
  92. }
  93. /********************************************************/
  94. /* */
  95. /* Send functionalities */
  96. /* */
  97. /********************************************************/
  98. static void _starpu_mpi_isend_data_func(struct _starpu_mpi_req *req)
  99. {
  100. _STARPU_MPI_LOG_IN();
  101. STARPU_ASSERT(req->ptr);
  102. _STARPU_MPI_DEBUG("post MPI isend request %p type %s tag %d src %d data %p ptr %p datatype %p count %d user_datatype %d \n", req, _starpu_mpi_request_type(req->request_type), req->mpi_tag, req->srcdst, req->data_handle, req->ptr, req->datatype, (int)req->count, req->user_datatype);
  103. _starpu_mpi_comm_amounts_inc(req->comm, req->srcdst, req->datatype, req->count);
  104. TRACE_MPI_ISEND_SUBMIT_BEGIN(req->srcdst, req->mpi_tag, 0);
  105. req->ret = MPI_Isend(req->ptr, req->count, req->datatype, req->srcdst, req->mpi_tag, req->comm, &req->request);
  106. STARPU_ASSERT(req->ret == MPI_SUCCESS);
  107. TRACE_MPI_ISEND_SUBMIT_END(req->srcdst, req->mpi_tag, 0);
  108. /* somebody is perhaps waiting for the MPI request to be posted */
  109. _STARPU_PTHREAD_MUTEX_LOCK(&req->req_mutex);
  110. req->submitted = 1;
  111. _STARPU_PTHREAD_COND_BROADCAST(&req->req_cond);
  112. _STARPU_PTHREAD_MUTEX_UNLOCK(&req->req_mutex);
  113. _starpu_mpi_handle_detached_request(req);
  114. _STARPU_MPI_LOG_OUT();
  115. }
  116. static void _starpu_mpi_isend_size_func(struct _starpu_mpi_req *req)
  117. {
  118. _starpu_mpi_handle_allocate_datatype(req->data_handle, &req->datatype, &req->user_datatype);
  119. if (req->user_datatype == 0)
  120. {
  121. req->count = 1;
  122. req->ptr = starpu_handle_get_local_ptr(req->data_handle);
  123. }
  124. else
  125. {
  126. ssize_t psize;
  127. // Do not pack the data, just try to find out the size
  128. starpu_handle_pack_data(req->data_handle, NULL, &psize);
  129. if (psize != -1)
  130. {
  131. // We already know the size of the data, let's send it to overlap with the packing of the data
  132. MPI_Isend(&psize, sizeof(psize), MPI_BYTE, req->srcdst, req->mpi_tag, req->comm, &req->size_req);
  133. req->count = psize;
  134. }
  135. // Pack the data
  136. starpu_handle_pack_data(req->data_handle, &req->ptr, &req->count);
  137. if (psize == -1)
  138. {
  139. // We know the size now, let's send it
  140. MPI_Isend(&req->count, sizeof(req->count), MPI_BYTE, req->srcdst, req->mpi_tag, req->comm, &req->size_req);
  141. }
  142. else
  143. {
  144. // We check the size returned with the 2 calls to pack is the same
  145. STARPU_ASSERT(req->count == psize);
  146. }
  147. // We can send the data now
  148. }
  149. _starpu_mpi_isend_data_func(req);
  150. }
  151. static struct _starpu_mpi_req *_starpu_mpi_isend_common(starpu_data_handle_t data_handle,
  152. int dest, int mpi_tag, MPI_Comm comm,
  153. unsigned detached, void (*callback)(void *), void *arg)
  154. {
  155. return _starpu_mpi_isend_irecv_common(data_handle, dest, mpi_tag, comm, detached, callback, arg, SEND_REQ, _starpu_mpi_isend_size_func, STARPU_R);
  156. }
  157. int starpu_mpi_isend(starpu_data_handle_t data_handle, starpu_mpi_req *public_req, int dest, int mpi_tag, MPI_Comm comm)
  158. {
  159. _STARPU_MPI_LOG_IN();
  160. STARPU_ASSERT(public_req);
  161. struct _starpu_mpi_req *req;
  162. req = _starpu_mpi_isend_common(data_handle, dest, mpi_tag, comm, 0, NULL, NULL);
  163. STARPU_ASSERT(req);
  164. *public_req = req;
  165. _STARPU_MPI_LOG_OUT();
  166. return 0;
  167. }
  168. int starpu_mpi_isend_detached(starpu_data_handle_t data_handle,
  169. int dest, int mpi_tag, MPI_Comm comm, void (*callback)(void *), void *arg)
  170. {
  171. _STARPU_MPI_LOG_IN();
  172. _starpu_mpi_isend_common(data_handle, dest, mpi_tag, comm, 1, callback, arg);
  173. _STARPU_MPI_LOG_OUT();
  174. return 0;
  175. }
  176. int starpu_mpi_send(starpu_data_handle_t data_handle, int dest, int mpi_tag, MPI_Comm comm)
  177. {
  178. starpu_mpi_req req;
  179. MPI_Status status;
  180. _STARPU_MPI_LOG_IN();
  181. memset(&status, 0, sizeof(MPI_Status));
  182. starpu_mpi_isend(data_handle, &req, dest, mpi_tag, comm);
  183. starpu_mpi_wait(&req, &status);
  184. _STARPU_MPI_LOG_OUT();
  185. return 0;
  186. }
  187. /********************************************************/
  188. /* */
  189. /* Receive functionalities */
  190. /* */
  191. /********************************************************/
  192. static void _starpu_mpi_irecv_data_func(struct _starpu_mpi_req *req)
  193. {
  194. _STARPU_MPI_LOG_IN();
  195. STARPU_ASSERT(req->ptr);
  196. _STARPU_MPI_DEBUG("post MPI irecv request %p type %s tag %d src %d data %p ptr %p datatype %p count %d user_datatype %d \n", req, _starpu_mpi_request_type(req->request_type), req->mpi_tag, req->srcdst, req->data_handle, req->ptr, req->datatype, (int)req->count, req->user_datatype);
  197. TRACE_MPI_IRECV_SUBMIT_BEGIN(req->srcdst, req->mpi_tag);
  198. req->ret = MPI_Irecv(req->ptr, req->count, req->datatype, req->srcdst, req->mpi_tag, req->comm, &req->request);
  199. STARPU_ASSERT(req->ret == MPI_SUCCESS);
  200. TRACE_MPI_IRECV_SUBMIT_END(req->srcdst, req->mpi_tag);
  201. /* somebody is perhaps waiting for the MPI request to be posted */
  202. _STARPU_PTHREAD_MUTEX_LOCK(&req->req_mutex);
  203. req->submitted = 1;
  204. _STARPU_PTHREAD_COND_BROADCAST(&req->req_cond);
  205. _STARPU_PTHREAD_MUTEX_UNLOCK(&req->req_mutex);
  206. _starpu_mpi_handle_detached_request(req);
  207. _STARPU_MPI_LOG_OUT();
  208. }
  209. struct _starpu_mpi_irecv_size_callback
  210. {
  211. starpu_data_handle_t handle;
  212. struct _starpu_mpi_req *req;
  213. };
  214. static void _starpu_mpi_irecv_size_callback(void *arg)
  215. {
  216. struct _starpu_mpi_irecv_size_callback *callback = (struct _starpu_mpi_irecv_size_callback *)arg;
  217. starpu_data_unregister(callback->handle);
  218. callback->req->ptr = malloc(callback->req->count);
  219. STARPU_ASSERT_MSG(callback->req->ptr, "cannot allocate message of size %ld\n", callback->req->count);
  220. _starpu_mpi_irecv_data_func(callback->req);
  221. free(callback);
  222. }
  223. static void _starpu_mpi_irecv_size_func(struct _starpu_mpi_req *req)
  224. {
  225. _STARPU_MPI_LOG_IN();
  226. _starpu_mpi_handle_allocate_datatype(req->data_handle, &req->datatype, &req->user_datatype);
  227. if (req->user_datatype == 0)
  228. {
  229. req->count = 1;
  230. req->ptr = starpu_handle_get_local_ptr(req->data_handle);
  231. _starpu_mpi_irecv_data_func(req);
  232. }
  233. else
  234. {
  235. struct _starpu_mpi_irecv_size_callback *callback = malloc(sizeof(struct _starpu_mpi_irecv_size_callback));
  236. callback->req = req;
  237. starpu_variable_data_register(&callback->handle, 0, (uintptr_t)&(callback->req->count), sizeof(callback->req->count));
  238. _starpu_mpi_irecv_common(callback->handle, req->srcdst, req->mpi_tag, req->comm, 1, _starpu_mpi_irecv_size_callback, callback);
  239. }
  240. }
  241. static struct _starpu_mpi_req *_starpu_mpi_irecv_common(starpu_data_handle_t data_handle, int source, int mpi_tag, MPI_Comm comm, unsigned detached, void (*callback)(void *), void *arg)
  242. {
  243. return _starpu_mpi_isend_irecv_common(data_handle, source, mpi_tag, comm, detached, callback, arg, RECV_REQ, _starpu_mpi_irecv_size_func, STARPU_W);
  244. }
  245. int starpu_mpi_irecv(starpu_data_handle_t data_handle, starpu_mpi_req *public_req, int source, int mpi_tag, MPI_Comm comm)
  246. {
  247. _STARPU_MPI_LOG_IN();
  248. STARPU_ASSERT(public_req);
  249. struct _starpu_mpi_req *req;
  250. req = _starpu_mpi_irecv_common(data_handle, source, mpi_tag, comm, 0, NULL, NULL);
  251. STARPU_ASSERT(req);
  252. *public_req = req;
  253. _STARPU_MPI_LOG_OUT();
  254. return 0;
  255. }
  256. int starpu_mpi_irecv_detached(starpu_data_handle_t data_handle, int source, int mpi_tag, MPI_Comm comm, void (*callback)(void *), void *arg)
  257. {
  258. _STARPU_MPI_LOG_IN();
  259. _starpu_mpi_irecv_common(data_handle, source, mpi_tag, comm, 1, callback, arg);
  260. _STARPU_MPI_LOG_OUT();
  261. return 0;
  262. }
  263. int starpu_mpi_recv(starpu_data_handle_t data_handle, int source, int mpi_tag, MPI_Comm comm, MPI_Status *status)
  264. {
  265. starpu_mpi_req req;
  266. _STARPU_MPI_LOG_IN();
  267. starpu_mpi_irecv(data_handle, &req, source, mpi_tag, comm);
  268. starpu_mpi_wait(&req, status);
  269. _STARPU_MPI_LOG_OUT();
  270. return 0;
  271. }
  272. static void _starpu_mpi_probe_func(struct _starpu_mpi_req *req)
  273. {
  274. _STARPU_MPI_LOG_IN();
  275. _starpu_mpi_handle_allocate_datatype(req->data_handle, &req->datatype, &req->user_datatype);
  276. #ifdef STARPU_DEVEL
  277. #warning TODO: release that assert
  278. #endif
  279. assert(req->user_datatype == 0);
  280. req->count = 1;
  281. req->ptr = starpu_handle_get_local_ptr(req->data_handle);
  282. _STARPU_MPI_DEBUG("MPI probe request %p type %s tag %d src %d data %p ptr %p datatype %p count %d user_datatype %d \n", req, _starpu_mpi_request_type(req->request_type), req->mpi_tag, req->srcdst, req->data_handle, req->ptr, req->datatype, (int)req->count, req->user_datatype);
  283. /* somebody is perhaps waiting for the MPI request to be posted */
  284. _STARPU_PTHREAD_MUTEX_LOCK(&req->req_mutex);
  285. req->submitted = 1;
  286. _STARPU_PTHREAD_COND_BROADCAST(&req->req_cond);
  287. _STARPU_PTHREAD_MUTEX_UNLOCK(&req->req_mutex);
  288. _starpu_mpi_handle_detached_request(req);
  289. _STARPU_MPI_LOG_OUT();
  290. }
  291. int starpu_mpi_irecv_probe_detached(starpu_data_handle_t data_handle, int source, int mpi_tag, MPI_Comm comm, void (*callback)(void *), void *arg)
  292. {
  293. _STARPU_MPI_LOG_IN();
  294. _starpu_mpi_isend_irecv_common(data_handle, source, mpi_tag, comm, 1, callback, arg, PROBE_REQ, _starpu_mpi_probe_func, STARPU_W);
  295. _STARPU_MPI_LOG_OUT();
  296. return 0;
  297. }
  298. /********************************************************/
  299. /* */
  300. /* Wait functionalities */
  301. /* */
  302. /********************************************************/
  303. static void _starpu_mpi_wait_func(struct _starpu_mpi_req *waiting_req)
  304. {
  305. _STARPU_MPI_LOG_IN();
  306. /* Which is the mpi request we are waiting for ? */
  307. struct _starpu_mpi_req *req = waiting_req->other_request;
  308. TRACE_MPI_UWAIT_BEGIN(req->srcdst, req->mpi_tag);
  309. req->ret = MPI_Wait(&req->request, waiting_req->status);
  310. STARPU_ASSERT(req->ret == MPI_SUCCESS);
  311. TRACE_MPI_UWAIT_END(req->srcdst, req->mpi_tag);
  312. _starpu_mpi_handle_request_termination(req);
  313. _STARPU_MPI_LOG_OUT();
  314. }
  315. int starpu_mpi_wait(starpu_mpi_req *public_req, MPI_Status *status)
  316. {
  317. _STARPU_MPI_LOG_IN();
  318. int ret;
  319. struct _starpu_mpi_req *waiting_req = calloc(1, sizeof(struct _starpu_mpi_req));
  320. STARPU_ASSERT(waiting_req);
  321. struct _starpu_mpi_req *req = *public_req;
  322. _STARPU_MPI_INC_POSTED_REQUESTS(1);
  323. /* We cannot try to complete a MPI request that was not actually posted
  324. * to MPI yet. */
  325. _STARPU_PTHREAD_MUTEX_LOCK(&(req->req_mutex));
  326. while (!(req->submitted))
  327. _STARPU_PTHREAD_COND_WAIT(&(req->req_cond), &(req->req_mutex));
  328. _STARPU_PTHREAD_MUTEX_UNLOCK(&(req->req_mutex));
  329. /* Initialize the request structure */
  330. _STARPU_PTHREAD_MUTEX_INIT(&(waiting_req->req_mutex), NULL);
  331. _STARPU_PTHREAD_COND_INIT(&(waiting_req->req_cond), NULL);
  332. waiting_req->status = status;
  333. waiting_req->other_request = req;
  334. waiting_req->func = _starpu_mpi_wait_func;
  335. waiting_req->request_type = WAIT_REQ;
  336. _starpu_mpi_submit_new_mpi_request(waiting_req);
  337. /* We wait for the MPI request to finish */
  338. _STARPU_PTHREAD_MUTEX_LOCK(&req->req_mutex);
  339. while (!req->completed)
  340. _STARPU_PTHREAD_COND_WAIT(&req->req_cond, &req->req_mutex);
  341. _STARPU_PTHREAD_MUTEX_UNLOCK(&req->req_mutex);
  342. ret = req->ret;
  343. /* The internal request structure was automatically allocated */
  344. *public_req = NULL;
  345. free(req);
  346. free(waiting_req);
  347. _STARPU_MPI_LOG_OUT();
  348. return ret;
  349. }
  350. /********************************************************/
  351. /* */
  352. /* Test functionalities */
  353. /* */
  354. /********************************************************/
  355. static void _starpu_mpi_test_func(struct _starpu_mpi_req *testing_req)
  356. {
  357. _STARPU_MPI_LOG_IN();
  358. /* Which is the mpi request we are testing for ? */
  359. struct _starpu_mpi_req *req = testing_req->other_request;
  360. _STARPU_MPI_DEBUG("Test request %p type %s tag %d src %d data %p ptr %p datatype %p count %d user_datatype %d \n", req, _starpu_mpi_request_type(req->request_type), req->mpi_tag, req->srcdst, req->data_handle, req->ptr, req->datatype, (int)req->count, req->user_datatype);
  361. TRACE_MPI_UTESTING_BEGIN(req->srcdst, req->mpi_tag);
  362. req->ret = MPI_Test(&req->request, testing_req->flag, testing_req->status);
  363. STARPU_ASSERT(req->ret == MPI_SUCCESS);
  364. TRACE_MPI_UTESTING_END(req->srcdst, req->mpi_tag);
  365. if (*testing_req->flag)
  366. {
  367. testing_req->ret = req->ret;
  368. _starpu_mpi_handle_request_termination(req);
  369. }
  370. _STARPU_PTHREAD_MUTEX_LOCK(&testing_req->req_mutex);
  371. testing_req->completed = 1;
  372. _STARPU_PTHREAD_COND_SIGNAL(&testing_req->req_cond);
  373. _STARPU_PTHREAD_MUTEX_UNLOCK(&testing_req->req_mutex);
  374. _STARPU_MPI_LOG_OUT();
  375. }
  376. int starpu_mpi_test(starpu_mpi_req *public_req, int *flag, MPI_Status *status)
  377. {
  378. _STARPU_MPI_LOG_IN();
  379. int ret = 0;
  380. STARPU_ASSERT(public_req);
  381. struct _starpu_mpi_req *req = *public_req;
  382. STARPU_ASSERT(!req->detached);
  383. _STARPU_PTHREAD_MUTEX_LOCK(&req->req_mutex);
  384. unsigned submitted = req->submitted;
  385. _STARPU_PTHREAD_MUTEX_UNLOCK(&req->req_mutex);
  386. if (submitted)
  387. {
  388. struct _starpu_mpi_req *testing_req = calloc(1, sizeof(struct _starpu_mpi_req));
  389. STARPU_ASSERT(testing_req);
  390. // memset(testing_req, 0, sizeof(struct _starpu_mpi_req));
  391. /* Initialize the request structure */
  392. _STARPU_PTHREAD_MUTEX_INIT(&(testing_req->req_mutex), NULL);
  393. _STARPU_PTHREAD_COND_INIT(&(testing_req->req_cond), NULL);
  394. testing_req->flag = flag;
  395. testing_req->status = status;
  396. testing_req->other_request = req;
  397. testing_req->func = _starpu_mpi_test_func;
  398. testing_req->completed = 0;
  399. testing_req->request_type = TEST_REQ;
  400. _STARPU_MPI_INC_POSTED_REQUESTS(1);
  401. _starpu_mpi_submit_new_mpi_request(testing_req);
  402. /* We wait for the test request to finish */
  403. _STARPU_PTHREAD_MUTEX_LOCK(&(testing_req->req_mutex));
  404. while (!(testing_req->completed))
  405. _STARPU_PTHREAD_COND_WAIT(&(testing_req->req_cond), &(testing_req->req_mutex));
  406. _STARPU_PTHREAD_MUTEX_UNLOCK(&(testing_req->req_mutex));
  407. ret = testing_req->ret;
  408. if (*(testing_req->flag))
  409. {
  410. /* The request was completed so we free the internal
  411. * request structure which was automatically allocated
  412. * */
  413. *public_req = NULL;
  414. free(req);
  415. }
  416. free(testing_req);
  417. }
  418. else
  419. {
  420. *flag = 0;
  421. }
  422. _STARPU_MPI_LOG_OUT();
  423. return ret;
  424. }
  425. /********************************************************/
  426. /* */
  427. /* Barrier functionalities */
  428. /* */
  429. /********************************************************/
  430. static void _starpu_mpi_barrier_func(struct _starpu_mpi_req *barrier_req)
  431. {
  432. _STARPU_MPI_LOG_IN();
  433. barrier_req->ret = MPI_Barrier(barrier_req->comm);
  434. STARPU_ASSERT(barrier_req->ret == MPI_SUCCESS);
  435. _starpu_mpi_handle_request_termination(barrier_req);
  436. _STARPU_MPI_LOG_OUT();
  437. }
  438. int starpu_mpi_barrier(MPI_Comm comm)
  439. {
  440. _STARPU_MPI_LOG_IN();
  441. int ret;
  442. struct _starpu_mpi_req *barrier_req = calloc(1, sizeof(struct _starpu_mpi_req));
  443. STARPU_ASSERT(barrier_req);
  444. /* First wait for *both* all tasks and MPI requests to finish, in case
  445. * some tasks generate MPI requests, MPI requests generate tasks, etc.
  446. */
  447. _STARPU_PTHREAD_MUTEX_LOCK(&mutex);
  448. STARPU_ASSERT_MSG(!barrier_running, "Concurrent starpu_mpi_barrier is not implemented, even on different communicators");
  449. barrier_running = 1;
  450. do
  451. {
  452. while (posted_requests)
  453. /* Wait for all current MPI requests to finish */
  454. _STARPU_PTHREAD_COND_WAIT(&cond_finished, &mutex);
  455. /* No current request, clear flag */
  456. newer_requests = 0;
  457. _STARPU_PTHREAD_MUTEX_UNLOCK(&mutex);
  458. /* Now wait for all tasks */
  459. starpu_task_wait_for_all();
  460. _STARPU_PTHREAD_MUTEX_LOCK(&mutex);
  461. /* Check newer_requests again, in case some MPI requests
  462. * triggered by tasks completed and triggered tasks between
  463. * wait_for_all finished and we take the lock */
  464. } while (posted_requests || newer_requests);
  465. barrier_running = 0;
  466. _STARPU_PTHREAD_MUTEX_UNLOCK(&mutex);
  467. /* Initialize the request structure */
  468. _STARPU_PTHREAD_MUTEX_INIT(&(barrier_req->req_mutex), NULL);
  469. _STARPU_PTHREAD_COND_INIT(&(barrier_req->req_cond), NULL);
  470. barrier_req->func = _starpu_mpi_barrier_func;
  471. barrier_req->request_type = BARRIER_REQ;
  472. barrier_req->comm = comm;
  473. _STARPU_MPI_INC_POSTED_REQUESTS(1);
  474. _starpu_mpi_submit_new_mpi_request(barrier_req);
  475. /* We wait for the MPI request to finish */
  476. _STARPU_PTHREAD_MUTEX_LOCK(&barrier_req->req_mutex);
  477. while (!barrier_req->completed)
  478. _STARPU_PTHREAD_COND_WAIT(&barrier_req->req_cond, &barrier_req->req_mutex);
  479. _STARPU_PTHREAD_MUTEX_UNLOCK(&barrier_req->req_mutex);
  480. ret = barrier_req->ret;
  481. free(barrier_req);
  482. _STARPU_MPI_LOG_OUT();
  483. return ret;
  484. }
  485. /********************************************************/
  486. /* */
  487. /* Progression */
  488. /* */
  489. /********************************************************/
  490. #ifdef STARPU_MPI_VERBOSE
  491. static char *_starpu_mpi_request_type(enum _starpu_mpi_request_type request_type)
  492. {
  493. switch (request_type)
  494. {
  495. case SEND_REQ: return "SEND_REQ";
  496. case RECV_REQ: return "RECV_REQ";
  497. case WAIT_REQ: return "WAIT_REQ";
  498. case TEST_REQ: return "TEST_REQ";
  499. case BARRIER_REQ: return "BARRIER_REQ";
  500. case PROBE_REQ: return "PROBE_REQ";
  501. default: return "unknown request type";
  502. }
  503. }
  504. #endif
  505. static void _starpu_mpi_handle_request_termination(struct _starpu_mpi_req *req)
  506. {
  507. _STARPU_MPI_LOG_IN();
  508. _STARPU_MPI_DEBUG("complete MPI request %p type %s tag %d src %d data %p ptr %p datatype %p count %d user_datatype %d \n", req, _starpu_mpi_request_type(req->request_type), req->mpi_tag, req->srcdst, req->data_handle, req->ptr, req->datatype, (int)req->count, req->user_datatype);
  509. if (req->request_type == PROBE_REQ)
  510. {
  511. #ifdef STARPU_DEVEL
  512. #warning TODO: instead of calling MPI_Recv, we should post a starpu mpi recv request
  513. #endif
  514. MPI_Status status;
  515. memset(&status, 0, sizeof(MPI_Status));
  516. req->ret = MPI_Recv(req->ptr, req->count, req->datatype, req->srcdst, req->mpi_tag, req->comm, &status);
  517. }
  518. if (req->request_type == RECV_REQ || req->request_type == SEND_REQ || req->request_type == PROBE_REQ)
  519. {
  520. if (req->user_datatype == 1)
  521. {
  522. if (req->request_type == SEND_REQ)
  523. {
  524. // We already know the request to send the size is completed, we just call MPI_Test to make sure that the request object is deallocated
  525. MPI_Status status;
  526. int flag;
  527. MPI_Test(&req->size_req, &flag, &status);
  528. STARPU_ASSERT(flag);
  529. }
  530. if (req->request_type == RECV_REQ)
  531. // req->ptr is freed by starpu_handle_unpack_data
  532. starpu_handle_unpack_data(req->data_handle, req->ptr, req->count);
  533. else
  534. free(req->ptr);
  535. }
  536. else
  537. {
  538. _starpu_mpi_handle_free_datatype(req->data_handle, &req->datatype);
  539. }
  540. starpu_data_release(req->data_handle);
  541. }
  542. /* Execute the specified callback, if any */
  543. if (req->callback)
  544. req->callback(req->callback_arg);
  545. /* tell anyone potentially waiting on the request that it is
  546. * terminated now */
  547. _STARPU_PTHREAD_MUTEX_LOCK(&req->req_mutex);
  548. req->completed = 1;
  549. _STARPU_PTHREAD_COND_BROADCAST(&req->req_cond);
  550. _STARPU_PTHREAD_MUTEX_UNLOCK(&req->req_mutex);
  551. _STARPU_MPI_LOG_OUT();
  552. }
  553. static void _starpu_mpi_submit_new_mpi_request(void *arg)
  554. {
  555. _STARPU_MPI_LOG_IN();
  556. struct _starpu_mpi_req *req = arg;
  557. _STARPU_MPI_INC_POSTED_REQUESTS(-1);
  558. _STARPU_PTHREAD_MUTEX_LOCK(&mutex);
  559. _starpu_mpi_req_list_push_front(new_requests, req);
  560. newer_requests = 1;
  561. _STARPU_MPI_DEBUG("Pushing new request %p type %s tag %d src %d data %p ptr %p datatype %p count %d user_datatype %d \n", req, _starpu_mpi_request_type(req->request_type), req->mpi_tag, req->srcdst, req->data_handle, req->ptr, req->datatype, (int)req->count, req->user_datatype);
  562. _STARPU_PTHREAD_COND_BROADCAST(&cond_progression);
  563. _STARPU_PTHREAD_MUTEX_UNLOCK(&mutex);
  564. _STARPU_MPI_LOG_OUT();
  565. }
  566. #ifdef USE_STARPU_ACTIVITY
  567. static unsigned _starpu_mpi_progression_hook_func(void *arg __attribute__((unused)))
  568. {
  569. unsigned may_block = 1;
  570. _STARPU_PTHREAD_MUTEX_LOCK(&mutex);
  571. if (!_starpu_mpi_req_list_empty(detached_requests))
  572. {
  573. _STARPU_PTHREAD_COND_SIGNAL(&cond_progression);
  574. may_block = 0;
  575. }
  576. _STARPU_PTHREAD_MUTEX_UNLOCK(&mutex);
  577. return may_block;
  578. }
  579. #endif
  580. static void _starpu_mpi_test_detached_requests(void)
  581. {
  582. _STARPU_MPI_LOG_IN();
  583. int flag;
  584. MPI_Status status;
  585. struct _starpu_mpi_req *req, *next_req;
  586. _STARPU_PTHREAD_MUTEX_LOCK(&detached_requests_mutex);
  587. for (req = _starpu_mpi_req_list_begin(detached_requests);
  588. req != _starpu_mpi_req_list_end(detached_requests);
  589. req = next_req)
  590. {
  591. next_req = _starpu_mpi_req_list_next(req);
  592. _STARPU_PTHREAD_MUTEX_UNLOCK(&detached_requests_mutex);
  593. //_STARPU_MPI_DEBUG("Test detached request %p - mpitag %d - TYPE %s %d\n", &req->request, req->mpi_tag, _starpu_mpi_request_type(req->request_type), req->srcdst);
  594. if (req->request_type == PROBE_REQ)
  595. {
  596. req->ret = MPI_Iprobe(req->srcdst, req->mpi_tag, req->comm, &flag, &status);
  597. }
  598. else
  599. {
  600. req->ret = MPI_Test(&req->request, &flag, &status);
  601. }
  602. STARPU_ASSERT(req->ret == MPI_SUCCESS);
  603. if (flag)
  604. {
  605. if (req->request_type == RECV_REQ || req->request_type == PROBE_REQ)
  606. {
  607. TRACE_MPI_IRECV_COMPLETE_BEGIN(req->srcdst, req->mpi_tag);
  608. }
  609. else if (req->request_type == SEND_REQ)
  610. {
  611. TRACE_MPI_ISEND_COMPLETE_BEGIN(req->srcdst, req->mpi_tag, 0);
  612. }
  613. _starpu_mpi_handle_request_termination(req);
  614. if (req->request_type == RECV_REQ || req->request_type == PROBE_REQ)
  615. {
  616. TRACE_MPI_IRECV_COMPLETE_END(req->srcdst, req->mpi_tag);
  617. }
  618. else if (req->request_type == SEND_REQ)
  619. {
  620. TRACE_MPI_ISEND_COMPLETE_END(req->srcdst, req->mpi_tag, 0);
  621. }
  622. }
  623. _STARPU_PTHREAD_MUTEX_LOCK(&detached_requests_mutex);
  624. if (flag)
  625. {
  626. _starpu_mpi_req_list_erase(detached_requests, req);
  627. free(req);
  628. }
  629. }
  630. _STARPU_PTHREAD_MUTEX_UNLOCK(&detached_requests_mutex);
  631. _STARPU_MPI_LOG_OUT();
  632. }
  633. static void _starpu_mpi_handle_detached_request(struct _starpu_mpi_req *req)
  634. {
  635. if (req->detached)
  636. {
  637. _STARPU_PTHREAD_MUTEX_LOCK(&mutex);
  638. _starpu_mpi_req_list_push_front(detached_requests, req);
  639. _STARPU_PTHREAD_MUTEX_UNLOCK(&mutex);
  640. starpu_wake_all_blocked_workers();
  641. /* put the submitted request into the list of pending requests
  642. * so that it can be handled by the progression mechanisms */
  643. _STARPU_PTHREAD_MUTEX_LOCK(&mutex);
  644. _STARPU_PTHREAD_COND_SIGNAL(&cond_progression);
  645. _STARPU_PTHREAD_MUTEX_UNLOCK(&mutex);
  646. }
  647. }
  648. static void _starpu_mpi_handle_new_request(struct _starpu_mpi_req *req)
  649. {
  650. _STARPU_MPI_LOG_IN();
  651. STARPU_ASSERT(req);
  652. /* submit the request to MPI */
  653. _STARPU_MPI_DEBUG("Handling new request %p type %s tag %d src %d data %p ptr %p datatype %p count %d user_datatype %d \n", req, _starpu_mpi_request_type(req->request_type), req->mpi_tag, req->srcdst, req->data_handle, req->ptr, req->datatype, (int)req->count, req->user_datatype);
  654. req->func(req);
  655. _STARPU_MPI_LOG_OUT();
  656. }
  657. struct _starpu_mpi_argc_argv
  658. {
  659. int initialize_mpi;
  660. int *argc;
  661. char ***argv;
  662. };
  663. static void _starpu_mpi_print_thread_level_support(int thread_level, char *msg)
  664. {
  665. switch (thread_level)
  666. {
  667. case MPI_THREAD_SERIALIZED:
  668. {
  669. _STARPU_DISP("MPI%s MPI_THREAD_SERIALIZED; Multiple threads may make MPI calls, but only one at a time.\n", msg);
  670. break;
  671. }
  672. case MPI_THREAD_FUNNELED:
  673. {
  674. _STARPU_DISP("MPI%s MPI_THREAD_FUNNELED; The application can safely make calls to StarPU-MPI functions, but should not call directly MPI communication functions.\n", msg);
  675. break;
  676. }
  677. case MPI_THREAD_SINGLE:
  678. {
  679. _STARPU_DISP("MPI%s MPI_THREAD_SINGLE; MPI does not have multi-thread support, this might cause problems. The application can make calls to StarPU-MPI functions, but not call directly MPI Communication functions.\n", msg);
  680. break;
  681. }
  682. }
  683. }
  684. static void *_starpu_mpi_progress_thread_func(void *arg)
  685. {
  686. struct _starpu_mpi_argc_argv *argc_argv = (struct _starpu_mpi_argc_argv *) arg;
  687. if (argc_argv->initialize_mpi)
  688. {
  689. int thread_support;
  690. _STARPU_DEBUG("Calling MPI_Init_thread\n");
  691. if (MPI_Init_thread(argc_argv->argc, argc_argv->argv, MPI_THREAD_SERIALIZED, &thread_support) != MPI_SUCCESS)
  692. {
  693. _STARPU_ERROR("MPI_Init_thread failed\n");
  694. }
  695. _starpu_mpi_print_thread_level_support(thread_support, "_Init_thread level =");
  696. }
  697. else
  698. {
  699. int provided;
  700. MPI_Query_thread(&provided);
  701. _starpu_mpi_print_thread_level_support(provided, " has been initialized with");
  702. }
  703. {
  704. int rank, worldsize;
  705. MPI_Comm_rank(MPI_COMM_WORLD, &rank);
  706. MPI_Comm_size(MPI_COMM_WORLD, &worldsize);
  707. TRACE_MPI_START(rank, worldsize);
  708. #ifdef STARPU_USE_FXT
  709. starpu_set_profiling_id(rank);
  710. #endif //STARPU_USE_FXT
  711. }
  712. /* notify the main thread that the progression thread is ready */
  713. _STARPU_PTHREAD_MUTEX_LOCK(&mutex);
  714. running = 1;
  715. _STARPU_PTHREAD_COND_SIGNAL(&cond_progression);
  716. _STARPU_PTHREAD_MUTEX_UNLOCK(&mutex);
  717. _STARPU_PTHREAD_MUTEX_LOCK(&mutex);
  718. while (running || posted_requests || !(_starpu_mpi_req_list_empty(new_requests)) || !(_starpu_mpi_req_list_empty(detached_requests)))
  719. {
  720. /* shall we block ? */
  721. unsigned block = _starpu_mpi_req_list_empty(new_requests);
  722. #ifndef USE_STARPU_ACTIVITY
  723. block = block && _starpu_mpi_req_list_empty(detached_requests);
  724. #endif
  725. if (block)
  726. {
  727. _STARPU_MPI_DEBUG("NO MORE REQUESTS TO HANDLE\n");
  728. TRACE_MPI_SLEEP_BEGIN();
  729. if (barrier_running)
  730. /* Tell mpi_barrier */
  731. _STARPU_PTHREAD_COND_SIGNAL(&cond_finished);
  732. _STARPU_PTHREAD_COND_WAIT(&cond_progression, &mutex);
  733. TRACE_MPI_SLEEP_END();
  734. }
  735. /* test whether there are some terminated "detached request" */
  736. _STARPU_PTHREAD_MUTEX_UNLOCK(&mutex);
  737. _starpu_mpi_test_detached_requests();
  738. _STARPU_PTHREAD_MUTEX_LOCK(&mutex);
  739. /* get one request */
  740. struct _starpu_mpi_req *req;
  741. while (!_starpu_mpi_req_list_empty(new_requests))
  742. {
  743. req = _starpu_mpi_req_list_pop_back(new_requests);
  744. /* handling a request is likely to block for a while
  745. * (on a sync_data_with_mem call), we want to let the
  746. * application submit requests in the meantime, so we
  747. * release the lock. */
  748. _STARPU_PTHREAD_MUTEX_UNLOCK(&mutex);
  749. _starpu_mpi_handle_new_request(req);
  750. _STARPU_PTHREAD_MUTEX_LOCK(&mutex);
  751. }
  752. }
  753. STARPU_ASSERT(_starpu_mpi_req_list_empty(detached_requests));
  754. STARPU_ASSERT(_starpu_mpi_req_list_empty(new_requests));
  755. STARPU_ASSERT(posted_requests == 0);
  756. if (argc_argv->initialize_mpi)
  757. {
  758. _STARPU_MPI_DEBUG("Calling MPI_Finalize()\n");
  759. MPI_Finalize();
  760. }
  761. _STARPU_PTHREAD_MUTEX_UNLOCK(&mutex);
  762. free(argc_argv);
  763. return NULL;
  764. }
  765. /********************************************************/
  766. /* */
  767. /* (De)Initialization methods */
  768. /* */
  769. /********************************************************/
  770. #ifdef USE_STARPU_ACTIVITY
  771. static int hookid = - 1;
  772. #endif
  773. static void _starpu_mpi_add_sync_point_in_fxt(void)
  774. {
  775. #ifdef STARPU_USE_FXT
  776. int rank;
  777. int worldsize;
  778. MPI_Comm_rank(MPI_COMM_WORLD, &rank);
  779. MPI_Comm_size(MPI_COMM_WORLD, &worldsize);
  780. int barrier_ret = MPI_Barrier(MPI_COMM_WORLD);
  781. STARPU_ASSERT(barrier_ret == MPI_SUCCESS);
  782. /* We generate a "unique" key so that we can make sure that different
  783. * FxT traces come from the same MPI run. */
  784. int random_number;
  785. /* XXX perhaps we don't want to generate a new seed if the application
  786. * specified some reproductible behaviour ? */
  787. if (rank == 0)
  788. {
  789. srand(time(NULL));
  790. random_number = rand();
  791. }
  792. MPI_Bcast(&random_number, 1, MPI_INT, 0, MPI_COMM_WORLD);
  793. TRACE_MPI_BARRIER(rank, worldsize, random_number);
  794. _STARPU_MPI_DEBUG("unique key %x\n", random_number);
  795. #endif
  796. }
  797. static
  798. int _starpu_mpi_initialize(int *argc, char ***argv, int initialize_mpi)
  799. {
  800. _STARPU_PTHREAD_MUTEX_INIT(&mutex, NULL);
  801. _STARPU_PTHREAD_COND_INIT(&cond_progression, NULL);
  802. _STARPU_PTHREAD_COND_INIT(&cond_finished, NULL);
  803. new_requests = _starpu_mpi_req_list_new();
  804. _STARPU_PTHREAD_MUTEX_INIT(&detached_requests_mutex, NULL);
  805. detached_requests = _starpu_mpi_req_list_new();
  806. _STARPU_PTHREAD_MUTEX_INIT(&mutex_posted_requests, NULL);
  807. struct _starpu_mpi_argc_argv *argc_argv = malloc(sizeof(struct _starpu_mpi_argc_argv));
  808. argc_argv->initialize_mpi = initialize_mpi;
  809. argc_argv->argc = argc;
  810. argc_argv->argv = argv;
  811. _STARPU_PTHREAD_CREATE("MPI progress", &progress_thread, NULL, _starpu_mpi_progress_thread_func, argc_argv);
  812. _STARPU_PTHREAD_MUTEX_LOCK(&mutex);
  813. while (!running)
  814. _STARPU_PTHREAD_COND_WAIT(&cond_progression, &mutex);
  815. _STARPU_PTHREAD_MUTEX_UNLOCK(&mutex);
  816. #ifdef USE_STARPU_ACTIVITY
  817. hookid = starpu_progression_hook_register(progression_hook_func, NULL);
  818. STARPU_ASSERT(hookid >= 0);
  819. #endif
  820. _starpu_mpi_add_sync_point_in_fxt();
  821. _starpu_mpi_comm_amounts_init(MPI_COMM_WORLD);
  822. _starpu_mpi_cache_init(MPI_COMM_WORLD);
  823. return 0;
  824. }
  825. int starpu_mpi_init(int *argc, char ***argv, int initialize_mpi)
  826. {
  827. return _starpu_mpi_initialize(argc, argv, initialize_mpi);
  828. }
  829. int starpu_mpi_initialize(void)
  830. {
  831. return _starpu_mpi_initialize(NULL, NULL, 0);
  832. }
  833. int starpu_mpi_initialize_extended(int *rank, int *world_size)
  834. {
  835. int ret;
  836. ret = _starpu_mpi_initialize(NULL, NULL, 1);
  837. if (ret == 0)
  838. {
  839. _STARPU_DEBUG("Calling MPI_Comm_rank\n");
  840. MPI_Comm_rank(MPI_COMM_WORLD, rank);
  841. MPI_Comm_size(MPI_COMM_WORLD, world_size);
  842. }
  843. return ret;
  844. }
  845. int starpu_mpi_shutdown(void)
  846. {
  847. void *value;
  848. int rank, world_size;
  849. /* We need to get the rank before calling MPI_Finalize to pass to _starpu_mpi_comm_amounts_display() */
  850. MPI_Comm_rank(MPI_COMM_WORLD, &rank);
  851. MPI_Comm_size(MPI_COMM_WORLD, &world_size);
  852. /* kill the progression thread */
  853. _STARPU_PTHREAD_MUTEX_LOCK(&mutex);
  854. running = 0;
  855. _STARPU_PTHREAD_COND_BROADCAST(&cond_progression);
  856. _STARPU_PTHREAD_MUTEX_UNLOCK(&mutex);
  857. pthread_join(progress_thread, &value);
  858. #ifdef USE_STARPU_ACTIVITY
  859. starpu_progression_hook_deregister(hookid);
  860. #endif
  861. TRACE_MPI_STOP(rank, world_size);
  862. /* free the request queues */
  863. _starpu_mpi_req_list_delete(detached_requests);
  864. _starpu_mpi_req_list_delete(new_requests);
  865. _starpu_mpi_comm_amounts_display(rank);
  866. _starpu_mpi_comm_amounts_free();
  867. _starpu_mpi_cache_free(world_size);
  868. return 0;
  869. }