starpu.suppr 4.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197
  1. {
  2. don't care about cache hit stats
  3. Helgrind:Race
  4. fun:_starpu_msi_cache_hit
  5. ...
  6. }
  7. {
  8. don't care about cache miss stats
  9. Helgrind:Race
  10. fun:_starpu_msi_cache_miss
  11. ...
  12. }
  13. {
  14. known race, but not problematic in practice, see comment in _starpu_tag_clear
  15. Helgrind:LockOrder
  16. ...
  17. fun:_starpu_tag_free
  18. fun:_starpu_htbl_clear_tags
  19. ...
  20. fun:_starpu_tag_clear
  21. fun:starpu_shutdown
  22. ...
  23. }
  24. {
  25. There is actually no race on current_mode, because the mode can not change unexpectedly, until _starpu_notify_data_dependencies() is called further down. Valgrind can not know about such software rwlock.
  26. Helgrind:Race
  27. fun:_starpu_release_data_on_node
  28. fun:_starpu_push_task_output
  29. ...
  30. }
  31. {
  32. We do not care about races on profiling statistics
  33. Helgrind:Race
  34. fun:_starpu_worker_get_status
  35. fun:_starpu_worker_reset_profiling_info_with_lock
  36. ...
  37. }
  38. {
  39. This is racy, but since we'll always put the same values, this is not a problem.
  40. Helgrind:Race
  41. fun:_starpu_codelet_check_deprecated_fields
  42. ...
  43. }
  44. {
  45. This is racy, but we don't care, it's only a statistic
  46. Helgrind:Race
  47. fun:starpu_task_nsubmitted
  48. ...
  49. }
  50. {
  51. This is racy, but we don't care, it's only a statistic
  52. Helgrind:Race
  53. fun:starpu_task_nready
  54. ...
  55. }
  56. {
  57. This is racy, but we don't care, it's only a statistic
  58. Helgrind:Race
  59. fun:_starpu_bus_update_profiling_info
  60. ...
  61. }
  62. {
  63. fscanf error
  64. Memcheck:Cond
  65. ...
  66. fun:fscanf
  67. fun:_starpu_load_bus_performance_files
  68. ...
  69. }
  70. {
  71. mc / handle locking order. We always take handle before mc, except when we tidy memory, where we use trylock, but helgrind doesn't handle that :/ https://bugs.kde.org/show_bug.cgi?id=243232
  72. Helgrind:LockOrder
  73. fun:mutex_trylock_WRK
  74. fun:__starpu_spin_trylock
  75. ...
  76. }
  77. {
  78. mc / handle locking order1
  79. Helgrind:LockOrder
  80. ...
  81. fun:__starpu_spin_lock
  82. fun:try_to_free_mem_chunk
  83. ...
  84. }
  85. {
  86. mc / handle locking order2
  87. Helgrind:LockOrder
  88. ...
  89. fun:__starpu_spin_lock
  90. fun:try_to_find_reusable_mem_chunk
  91. ...
  92. }
  93. {
  94. mc / handle locking order3
  95. Helgrind:LockOrder
  96. ...
  97. fun:__starpu_spin_lock
  98. fun:free_potentially_in_use_mc
  99. ...
  100. }
  101. {
  102. mc / handle locking order4
  103. Helgrind:LockOrder
  104. ...
  105. fun:__starpu_spin_lock
  106. fun:free_potentially_in_use_mc
  107. ...
  108. }
  109. {
  110. mc / handle locking order5
  111. Helgrind:LockOrder
  112. ...
  113. fun:__starpu_spin_lock
  114. fun:register_mem_chunk
  115. ...
  116. }
  117. {
  118. mc / handle locking order6
  119. Helgrind:LockOrder
  120. ...
  121. fun:__starpu_spin_lock
  122. fun:_starpu_request_mem_chunk_removal
  123. ...
  124. }
  125. {
  126. mc / handle locking order7
  127. Helgrind:LockOrder
  128. ...
  129. fun:__starpu_spin_lock
  130. fun:_starpu_allocate_interface
  131. ...
  132. }
  133. {
  134. mc / handle locking order8
  135. Helgrind:LockOrder
  136. ...
  137. fun:__starpu_spin_lock
  138. fun:_starpu_memchunk_recently_used
  139. ...
  140. }
  141. {
  142. TODO1: This is temporary. It perhaps does not pose problem because only the worker takes this mutex. Fixing this will require changing the scheduler interface, so that the schedulers themselves take the scheduling lock, not the caller. Filter it out for now, so we can see other races more easily.
  143. Helgrind:LockOrder
  144. fun:mutex_lock_WRK
  145. fun:simple_worker_pull_task
  146. ...
  147. }
  148. {
  149. TODO1: This is temporary. It perhaps does not pose problem because only the worker takes this mutex. Fixing this will require changing the scheduler interface, so that the schedulers themselves take the scheduling lock, not the caller. Filter it out for now, so we can see other races more easily.
  150. Helgrind:LockOrder
  151. fun:mutex_lock_WRK
  152. fun:starpu_pthread_mutex_lock_sched
  153. fun:_starpu_sched_component_worker_lock_scheduling
  154. fun:simple_worker_pull_task
  155. ...
  156. }
  157. {
  158. TODO2: This is temporary. It perhaps does not pose problem because only the worker takes this mutex. Fixing this will require changing the scheduler interface, so that the schedulers themselves take the scheduling lock, not the caller. Filter it out for now, so we can see other races more easily.
  159. Helgrind:LockOrder
  160. fun:mutex_lock_WRK
  161. fun:_starpu_sched_component_lock_worker
  162. fun:simple_worker_pull_task
  163. ...
  164. }
  165. {
  166. TODO2: This is temporary. It perhaps does not pose problem because only the worker takes this mutex. Fixing this will require changing the scheduler interface, so that the schedulers themselves take the scheduling lock, not the caller. Filter it out for now, so we can see other races more easily.
  167. Helgrind:LockOrder
  168. fun:mutex_lock_WRK
  169. fun:_starpu_sched_component_lock_worker
  170. fun:_starpu_sched_component_worker_lock_scheduling
  171. fun:simple_worker_pull_task
  172. ...
  173. }