Prechádzať zdrojové kódy

Remove the --disable-priority option which is really useless (someone who do
not want priorities should not provide them, or simply use a strategy that do
not use them).

Cédric Augonnet 15 rokov pred
rodič
commit
fab6e0a48a

+ 0 - 9
configure.ac

@@ -619,15 +619,6 @@ AC_DEFINE_UNQUOTED(STARPU_MAXNODES, [$maxnodes],
 		[maximum number of memory nodes])
 
 
-AC_MSG_CHECKING(whether priorities should be enabled)
-AC_ARG_ENABLE(priority, [AS_HELP_STRING([--disable-priority],
-			[do not use priorities])],
-			enable_priority=$enableval, enable_priority=yes)
-AC_MSG_RESULT($enable_priority)
-if test x$enable_priority = xno; then
-	AC_DEFINE(STARPU_NO_PRIO, [1], [Disable priorities])
-fi
-
 AC_MSG_CHECKING(whether allocation cache should be used)
 AC_ARG_ENABLE(allocation-cache, [AS_HELP_STRING([--enable-allocation-cache],
 			[enable data allocation cache])],

+ 0 - 4
doc/starpu.texi

@@ -283,10 +283,6 @@ Enable statistics.
 @item @code{--enable-maxbuffers=<nbuffers>}
 Define the maximum number of buffers that tasks will be able to take as parameters, then available as the STARPU_NMAXBUFS macro.
 
-@item @code{--disable-priority}
-Disable taking priorities into account in scheduling decisions. Mostly for
-comparison purposes.
-
 @item @code{--enable-allocation-cache}
 Enable the use of a data allocation cache to avoid the cost of it with
 CUDA. Still experimental.

+ 0 - 4
src/core/mechanisms/fifo_queues.c

@@ -75,7 +75,6 @@ void _starpu_destroy_fifo(struct starpu_jobq_s *jobq)
 
 int _starpu_fifo_push_prio_task(struct starpu_jobq_s *q, starpu_job_t task)
 {
-#ifndef STARPU_NO_PRIO
 	STARPU_ASSERT(q);
 	struct starpu_fifo_jobq_s *fifo_queue = q->queue;
 
@@ -96,9 +95,6 @@ int _starpu_fifo_push_prio_task(struct starpu_jobq_s *q, starpu_job_t task)
 	PTHREAD_MUTEX_UNLOCK(&q->activity_mutex);
 
 	return 0;
-#else
-	return _starpu_fifo_push_task(q, task);
-#endif
 }
 
 int _starpu_fifo_push_task(struct starpu_jobq_s *q, starpu_job_t task)

+ 0 - 4
src/core/mechanisms/stack_queues.c

@@ -87,7 +87,6 @@ unsigned _starpu_get_stack_nprocessed(struct starpu_jobq_s *q)
 
 void _starpu_stack_push_prio_task(struct starpu_jobq_s *q, starpu_job_t task)
 {
-#ifndef STARPU_NO_PRIO
 	STARPU_ASSERT(q);
 	struct starpu_stack_jobq_s *stack_queue = q->queue;
 
@@ -107,9 +106,6 @@ void _starpu_stack_push_prio_task(struct starpu_jobq_s *q, starpu_job_t task)
 
 	PTHREAD_COND_SIGNAL(&q->activity_cond);
 	PTHREAD_MUTEX_UNLOCK(&q->activity_mutex);
-#else
-	_starpu_stack_push_task(q, task);
-#endif
 }
 
 void _starpu_stack_push_task(struct starpu_jobq_s *q, starpu_job_t task)