Remove the no_auto_start_trace field, the user can call starpu_fxt_stop_profiling right after starpu_init herself

ChangeLog

@@ -116,8 +116,8 @@ Changes:
 
 Small features:
   * Add starpu_worker_get_by_type and starpu_worker_get_by_devid
-  * Add no_auto_start_trace configuration field to permit avoiding starting FxT
-  traces from starpu_init.
+  * Add starpu_fxt_stop_profiling/starpu_fxt_start_profiling which permits to
+  pause trace recording.
   * Add trace_buffer_size configuration field to permit to specify the tracing
   buffer size.
   * Add starpu_codelet_profile and starpu_codelet_histo_profile, tools which draw

doc/chapters/advanced-api.texi

@@ -102,9 +102,10 @@ task automatically created using the function
 
 @deftypefun void starpu_fxt_start_profiling (void)
 Start recording the trace. The trace is by default started from
-@code{starpu_init()} call, unless setting @code{no_auto_start_trace} to 1 in
-@code{starpu_conf}, in which case @code{starpu_fxt_start_profiling} should be
-called to specify when to start recording events.
+@code{starpu_init()} call, but can be paused by using
+@code{starpu_fxt_stop_profiling}, in which case
+@code{starpu_fxt_start_profiling} should be called to specify when to resume
+recording events.
 @end deftypefun
 
 @deftypefun void starpu_fxt_stop_profiling (void)

doc/chapters/basic-api.texi

@@ -193,11 +193,6 @@ The drivers that should not be launched by StarPU.
 @item @code{unsigned n_not_launched_drivers}
 The number of StarPU drivers that should not be launched by StarPU.
 
-@item @code{no_auto_start_trace}
-The default (0) means that the FxT tracing will start as soon as
-@code{starpu_init} is called.
-Setting it to 1 permits to avoid tracing start so early, and instead start when the application calls @code{starpu_fxt_start_profiling}.
-
 @item @code{trace_buffer_size}
 Specifies the buffer size used for FxT tracing. Starting from FxT version
 0.2.12, the buffer will automatically be flushed when it fills in, but it may

include/starpu.h

@@ -150,10 +150,6 @@ struct starpu_conf
 	struct starpu_driver *not_launched_drivers;
 	unsigned n_not_launched_drivers;
 
-	/* Indicates whether we start the tracing automatically
-	   or we leave the appl start it when it wants to */
-	unsigned no_auto_start_trace;
-
 	/* Specifies the buffer size for tracing */
 	unsigned trace_buffer_size;
 };

src/core/workers.c

@@ -690,7 +690,6 @@ int starpu_conf_init(struct starpu_conf *conf)
 		conf->disable_asynchronous_opencl_copy = 0;
 #endif
 
-	conf->no_auto_start_trace = 0;
 	/* 64MiB by default */
 	conf->trace_buffer_size = 64<<20;
 	return 0;
@@ -859,9 +858,6 @@ int starpu_init(struct starpu_conf *user_conf)
 	/* Launch "basic" workers (ie. non-combined workers) */
 	_starpu_launch_drivers(&config);
 
-	if (config.conf->no_auto_start_trace)
-		starpu_fxt_stop_profiling();
-
 	_STARPU_PTHREAD_MUTEX_LOCK(&init_mutex);
 	initialized = INITIALIZED;
 	/* Tell everybody that we initialized */