Browse Source

Check returned value

Samuel Thibault 12 years ago
parent
commit
af85f26492

+ 1 - 0
src/datawizard/filters.c

@@ -148,6 +148,7 @@ void starpu_data_partition(starpu_data_handle_t initial_handle, struct starpu_da
 		/* This is lazy allocation, allocate it now in main RAM, so as
 		 * to have somewhere to gather pieces later */
 		int ret = _starpu_allocate_memory_on_node(initial_handle, &initial_handle->per_node[0], 0);
+		/* TODO: devrait faire du reclaim */
 		STARPU_ASSERT(!ret);
 	}
 

+ 1 - 0
src/drivers/cpu/driver_cpu.c

@@ -208,6 +208,7 @@ static size_t _starpu_cpu_get_global_mem_size(int devid, struct _starpu_machine_
 	     global_mem = hwloc_get_root_obj(topology->hwtopology)->memory.total_memory;
 	else
 	     global_mem = hwloc_get_obj_by_depth(topology->hwtopology, depth_node, devid)->memory.local_memory;
+	/* devid ?! */
 
 #else /* STARPU_HAVE_HWLOC */
 #ifdef STARPU_DEVEL

+ 3 - 1
tests/datawizard/commute.c

@@ -102,6 +102,7 @@ static starpu_data_handle_t x_handle, f_handle;
 static void test(enum starpu_data_access_mode begin_mode, enum starpu_data_access_mode end_mode, int order)
 {
 	struct starpu_task *begin_t, *commute1_t, *commute2_t, *end_t;
+	int ret;
 
 	codelet_begin.modes[0] = begin_mode;
 	codelet_end.modes[0] = end_mode;
@@ -140,7 +141,8 @@ static void test(enum starpu_data_access_mode begin_mode, enum starpu_data_acces
 	if (starpu_task_submit(end_t) == -ENODEV)
 		exit(STARPU_TEST_SKIPPED);
 
-	starpu_task_wait(end_t);
+	ret = starpu_task_wait(end_t);
+	STARPU_CHECK_RETURN_VALUE(ret, "starpu_task_wait");
 	starpu_data_acquire(x_handle, STARPU_R);
 	if (x != 1 + order + !!(end_mode & STARPU_W))
 		exit(EXIT_FAILURE);

+ 3 - 3
tests/main/tag_task_data_deps.c

@@ -243,13 +243,13 @@ int main(int argc, char **argv)
 		STARPU_CHECK_RETURN_VALUE(ret, "starpu_task_submit");
 
 		ret = starpu_task_wait(taskA);
-		STARPU_CHECK_RETURN_VALUE(ret, "starpu_task_submit");
+		STARPU_CHECK_RETURN_VALUE(ret, "starpu_task_wait");
 
 		ret = starpu_task_wait(taskB);
-		STARPU_CHECK_RETURN_VALUE(ret, "starpu_task_submit");
+		STARPU_CHECK_RETURN_VALUE(ret, "starpu_task_wait");
 
 		ret = starpu_task_wait(taskC);
-		STARPU_CHECK_RETURN_VALUE(ret, "starpu_task_submit");
+		STARPU_CHECK_RETURN_VALUE(ret, "starpu_task_wait");
 	} while(0);
 
 	starpu_shutdown();