Browse Source

Note about racyness. We can't really add a suppression for this case, it would hide potential other races

Samuel Thibault 12 years ago
parent
commit
add756f1af
2 changed files with 1 additions and 26 deletions
  1. 1 0
      src/datawizard/data_request.c
  2. 0 26
      tools/valgrind/starpu.suppr

+ 1 - 0
src/datawizard/data_request.c

@@ -391,6 +391,7 @@ void _starpu_handle_node_data_requests(unsigned src_node, unsigned may_alloc)
 	struct _starpu_data_request *r;
 	struct _starpu_data_request_list *new_data_requests;
 
+	/* Note: this is not racy: list_empty just reads a pointer */
 	if (_starpu_data_request_list_empty(data_requests[src_node]))
 		return;
 

+ 0 - 26
tools/valgrind/starpu.suppr

@@ -126,29 +126,3 @@
    fun:_starpu_load_bus_performance_files
    ...
 }
-
-{
-   This is racy, but we don't care, if the function was called a bit earlier we would have had a different value
-   Helgrind:Race
-   fun:_starpu_fifo_empty
-   fun:pop_task_eager_policy
-   ...
-}
-
-{
-   This is the counterpart of the suppression above
-   Helgrind:Race
-   fun:_starpu_fifo_push_task
-   fun:push_task_eager_policy
-   ...
-}
-
-
-{
-   This is the counterpart of the suppression above
-   Helgrind:Race
-   fun:_starpu_fifo_push_sorted_task
-   fun:_starpu_fifo_push_task
-   fun:push_task_eager_policy
-   ...
-}