瀏覽代碼

write down why the ugly hack

Samuel Thibault 8 年之前
父節點
當前提交
97292596ab
共有 1 個文件被更改,包括 4 次插入1 次删除
  1. 4 1
      src/core/simgrid.c

+ 4 - 1
src/core/simgrid.c

@@ -298,7 +298,10 @@ void _starpu_simgrid_init_early(int *argc STARPU_ATTRIBUTE_UNUSED, char ***argv
 	if (!simgrid_started && !(smpi_main && smpi_simulated_main_ != _starpu_smpi_simulated_main_))
 	{
 		_STARPU_DISP("Warning: In simgrid mode, the file containing the main() function of this application should to be compiled with starpu.h or starpu_simgrid_wrap.h included, to properly rename it into starpu_main to avoid having to use --cfg=contexts/factory:thread which reduces performance\n");
-#if SIMGRID_VERSION_MAJOR > 3 || (SIMGRID_VERSION_MAJOR == 3 && SIMGRID_VERSION_MINOR >= 14)
+#if SIMGRID_VERSION_MAJOR > 3 || (SIMGRID_VERSION_MAJOR == 3 && SIMGRID_VERSION_MINOR >= 14) /* Only recent versions of simgrid support setting xbt_cfg_set_string before starting simgrid */
+		/* "Cannot create_maestro with this ContextFactory.
+		 * Try using --cfg=contexts/factory:thread instead."
+		 * See https://github.com/simgrid/simgrid/issues/141 */
 		xbt_cfg_set_string("contexts/factory", "thread");
 #endif
 		/* We didn't catch application's main. */