Browse Source

fix memory statistics printing

Nathalie Furmento 5 years ago
parent
commit
95772c4275
2 changed files with 26 additions and 31 deletions
  1. 25 29
      doc/doxygen/chapters/380_offline_performance_tools.doxy
  2. 1 2
      src/datawizard/memalloc.c

+ 25 - 29
doc/doxygen/chapters/380_offline_performance_tools.doxy

@@ -637,58 +637,50 @@ Moreover, statistics will be displayed at the end of the execution on
 data handles which have not been cleared out. This can be disabled by
 data handles which have not been cleared out. This can be disabled by
 setting the environment variable \ref STARPU_MEMORY_STATS to <c>0</c>.
 setting the environment variable \ref STARPU_MEMORY_STATS to <c>0</c>.
 
 
-For example, if you do not unregister data at the end of the complex
+For example, by adding a call to the function
-example, you will get something similar to:
+starpu_data_display_memory_stats() in the fblock example before
+unpartitioning the data, one will get something
+similar to:
 
 
 \verbatim
 \verbatim
-$ STARPU_MEMORY_STATS=0 ./examples/interface/complex
+$ STARPU_MEMORY_STATS=1 ./examples/filters/fblock
-Complex[0] = 45.00 + 12.00 i
+...
-Complex[0] = 78.00 + 78.00 i
-Complex[0] = 45.00 + 12.00 i
-Complex[0] = 45.00 + 12.00 i
-\endverbatim
-
-\verbatim
-$ STARPU_MEMORY_STATS=1 ./examples/interface/complex
-Complex[0] = 45.00 + 12.00 i
-Complex[0] = 78.00 + 78.00 i
-Complex[0] = 45.00 + 12.00 i
-Complex[0] = 45.00 + 12.00 i
-
 #---------------------
 #---------------------
-Memory stats:
+Memory stats :
 #-------
 #-------
-Data on Node #3
+Data on Node #2
 #-----
 #-----
-Data : 0x553ff40
+Data : 0x5562074e8670
-Size : 16
+Size : 144
 
 
 #--
 #--
 Data access stats
 Data access stats
 /!\ Work Underway
 /!\ Work Underway
 Node #0
 Node #0
-	Direct access : 4
+	Direct access : 0
 	Loaded (Owner) : 0
 	Loaded (Owner) : 0
 	Loaded (Shared) : 0
 	Loaded (Shared) : 0
-	Invalidated (was Owner) : 0
+	Invalidated (was Owner) : 1
 
 
-Node #3
+Node #2
 	Direct access : 0
 	Direct access : 0
-	Loaded (Owner) : 0
+	Loaded (Owner) : 1
-	Loaded (Shared) : 1
+	Loaded (Shared) : 0
 	Invalidated (was Owner) : 0
 	Invalidated (was Owner) : 0
 
 
+#-------
+Data on Node #3
 #-----
 #-----
-Data : 0x5544710
+Data : 0x5562074e9338
-Size : 16
+Size : 96
 
 
 #--
 #--
 Data access stats
 Data access stats
 /!\ Work Underway
 /!\ Work Underway
 Node #0
 Node #0
-	Direct access : 2
+	Direct access : 0
 	Loaded (Owner) : 0
 	Loaded (Owner) : 0
-	Loaded (Shared) : 1
+	Loaded (Shared) : 0
 	Invalidated (was Owner) : 1
 	Invalidated (was Owner) : 1
 
 
 Node #3
 Node #3
@@ -696,6 +688,10 @@ Node #3
 	Loaded (Owner) : 1
 	Loaded (Owner) : 1
 	Loaded (Shared) : 0
 	Loaded (Shared) : 0
 	Invalidated (was Owner) : 0
 	Invalidated (was Owner) : 0
+
+
+#---------------------
+...
 \endverbatim
 \endverbatim
 
 
 \section DataStatistics Data Statistics
 \section DataStatistics Data Statistics

+ 1 - 2
src/datawizard/memalloc.c

@@ -1709,8 +1709,7 @@ void _starpu_memory_display_stats_by_node(FILE *stream, int node)
 		     mc != _starpu_mem_chunk_list_end(&mc_list[node]);
 		     mc != _starpu_mem_chunk_list_end(&mc_list[node]);
 		     mc = _starpu_mem_chunk_list_next(mc))
 		     mc = _starpu_mem_chunk_list_next(mc))
 		{
 		{
-			if (mc->automatically_allocated == 0)
+			_starpu_memory_display_handle_stats(stream, mc->data);
-				_starpu_memory_display_handle_stats(stream, mc->data);
 		}
 		}
 
 
 	}
 	}