revert r#2246. No need to check the return value of _starpu_fetch_data_on_node

src/datawizard/coherency.h

@@ -129,7 +129,6 @@ struct starpu_data_state_t {
 
 void _starpu_display_msi_stats(void);
 
-__attribute__((warn_unused_result))
 int _starpu_fetch_data_on_node(struct starpu_data_state_t *state, uint32_t requesting_node,
 				starpu_access_mode mode, unsigned is_prefetch,
 				void (*callback_func)(void *), void *callback_arg);

src/datawizard/user_interactions.c

@@ -152,15 +152,13 @@ int starpu_data_sync_with_mem_non_blocking(starpu_data_handle handle,
  */
 static inline void _starpu_sync_data_with_mem_continuation(void *arg)
 {
-	int ret;
 	struct state_and_node *statenode = arg;
 
 	starpu_data_handle handle = statenode->state;
 
 	STARPU_ASSERT(handle);
 
-	ret = _starpu_fetch_data_on_node(handle, 0, statenode->mode, 0, NULL, NULL);
-	STARPU_ASSERT(!ret);
+	_starpu_fetch_data_on_node(handle, 0, statenode->mode, 0, NULL, NULL);
 	
 	/* continuation of starpu_data_sync_with_mem */
 	PTHREAD_MUTEX_LOCK(&statenode->lock);
@@ -293,11 +291,8 @@ int _starpu_prefetch_data_on_node_with_mode(starpu_data_handle handle, unsigned
 
 	if (!_starpu_attempt_to_submit_data_request_from_apps(handle, mode, _prefetch_data_on_node, &statenode))
 	{
-                int ret;
-
 		/* we can immediately proceed */
-		ret = _starpu_fetch_data_on_node(handle, node, mode, async, NULL, NULL);
-		STARPU_ASSERT(!ret);
+		_starpu_fetch_data_on_node(handle, node, mode, async, NULL, NULL);
 
 		/* remove the "lock"/reference */
 		if (!async)