浏览代码

Completely disable checking used_size, we can not teach helgrind a finer way

Samuel Thibault 10 年之前
父节点
当前提交
782a275e8d
共有 2 个文件被更改,包括 3 次插入7 次删除
  1. 3 0
      src/datawizard/memory_manager.c
  2. 0 7
      tools/valgrind/starpu.suppr

+ 3 - 0
src/datawizard/memory_manager.c

@@ -42,6 +42,9 @@ int _starpu_memory_manager_init()
 	{
 		global_size[i] = 0;
 		used_size[i] = 0;
+		/* This is accessed for statistics outside the lock, don't care
+		 * about that */
+		STARPU_HG_DISABLE_CHECKING(used_size[node]);
 		min_waiting_size[i] = 0;
 		STARPU_PTHREAD_MUTEX_INIT(&lock_nodes[i], NULL);
 		STARPU_PTHREAD_COND_INIT(&cond_nodes[i], NULL);

+ 0 - 7
tools/valgrind/starpu.suppr

@@ -72,13 +72,6 @@
 }
 
 {
-   Ignore used_size statistics access
-   Helgrind:Race
-   fun:starpu_memory_get_available
-   ...
-}
-
-{
    mc / handle locking order. We always take handle before mc, except when we tidy memory, where we use trylock, but helgrind doesn't handle that :/ https://bugs.kde.org/show_bug.cgi?id=243232
    Helgrind:LockOrder
    ...