Browse Source

core: fix dereference before NULL checks

No need to check if sched_ctx is not NULL, because it's already dereferenced.
Spotted by Coverity.
Samuel Pitoiset 9 years ago
parent
commit
550195a8a1
1 changed files with 2 additions and 2 deletions
  1. 2 2
      src/core/sched_policy.c

+ 2 - 2
src/core/sched_policy.c

@@ -390,7 +390,7 @@ int _starpu_repush_task(struct _starpu_job *j)
 			starpu_task_list_push_front(&sched_ctx->empty_ctx_tasks, task);
 			STARPU_PTHREAD_MUTEX_UNLOCK(&sched_ctx->empty_ctx_mutex);
 #ifdef STARPU_USE_SC_HYPERVISOR
-			if(sched_ctx != NULL && sched_ctx->id != 0 && sched_ctx->perf_counters != NULL 
+			if(sched_ctx->id != 0 && sched_ctx->perf_counters != NULL
 			   && sched_ctx->perf_counters->notify_empty_ctx)
 			{
 				_STARPU_TRACE_HYPERVISOR_BEGIN();
@@ -456,7 +456,7 @@ int _starpu_push_task_to_workers(struct starpu_task *task)
 			starpu_task_list_push_back(&sched_ctx->empty_ctx_tasks, task);
 			STARPU_PTHREAD_MUTEX_UNLOCK(&sched_ctx->empty_ctx_mutex);
 #ifdef STARPU_USE_SC_HYPERVISOR
-			if(sched_ctx != NULL && sched_ctx->id != 0 && sched_ctx->perf_counters != NULL 
+			if(sched_ctx->id != 0 && sched_ctx->perf_counters != NULL
 			   && sched_ctx->perf_counters->notify_empty_ctx)
 			{
 				_STARPU_TRACE_HYPERVISOR_BEGIN();