Browse Source

Explain why it does not happen in practice

Samuel Thibault 13 years ago
parent
commit
517fda4280
1 changed files with 2 additions and 3 deletions
  1. 2 3
      tools/valgrind/starpu.suppr

+ 2 - 3
tools/valgrind/starpu.suppr

@@ -40,13 +40,12 @@
 
 
 
 
 {
 {
-   Does not happen in practice.
+   There is actually no race on current_mode, because the mode can not change unexpectedly, until _starpu_notify_data_dependencies() is called further down. Valgrind can not know about such software rwlock.
    Helgrind:Race
    Helgrind:Race
    fun:_starpu_release_data_on_node
    fun:_starpu_release_data_on_node
    fun:_starpu_push_task_output
    fun:_starpu_push_task_output
    fun:execute_job_on_cpu
    fun:execute_job_on_cpu
    fun:_starpu_cpu_worker
    fun:_starpu_cpu_worker
-   obj:/usr/lib/valgrind/vgpreload_helgrind-amd64-linux.so
-   fun:start_thread
+   ...
 }
 }