瀏覽代碼

Drop some XXX.

It is easier not to change anything in create_task():
- the return values of starpu_worker_get_ids_by_type are checked, even if it is a bit later after they have been called.
- it does not really matter to call starpu_worker_get_ids_by_type for all possible PUs the first time create_task() is called.
Cyril Roelandt 12 年之前
父節點
當前提交
3df91027aa
共有 1 個文件被更改,包括 4 次插入2 次删除
  1. 4 2
      tests/datawizard/interfaces/test_interfaces.c

+ 4 - 2
tests/datawizard/interfaces/test_interfaces.c

@@ -295,8 +295,10 @@ create_task(struct starpu_task **taskp, enum starpu_archtype type, int id)
 
 	if (n_cpus == -1) /* First time here */
 	{
-		/* XXX Dont check them all at once. */
-		/* XXX Error checking */
+		/* We do not check the return values of the calls to
+		 * starpu_worker_get_ids_by_type now, because it is simpler to
+		 * detect a problem in the switch that comes right after this 
+		 * block of code. */
 		n_cpus = starpu_worker_get_ids_by_type(STARPU_CPU_WORKER,
 							cpu_workers,
 							STARPU_MAXCPUS);