瀏覽代碼

Remove some WIP tags where it should be fine on the long run

Samuel Thibault 10 年之前
父節點
當前提交
381eb29a05
共有 3 個文件被更改,包括 2 次插入6 次删除
  1. 2 2
      src/core/dependencies/data_concurrency.c
  2. 0 2
      src/datawizard/coherency.h
  3. 0 2
      src/datawizard/sort_data_handles.c

+ 2 - 2
src/core/dependencies/data_concurrency.c

@@ -273,7 +273,6 @@ static unsigned _submit_job_enforce_data_deps(struct _starpu_job *j, unsigned st
 
                 j->task->status = STARPU_TASK_BLOCKED_ON_DATA;
 
-		// WIP_COMMUTE Begin
 		if(handle->arbiter)
 		{
 			/* We arrived on an arbitered data, we stop and proceed
@@ -281,7 +280,6 @@ static unsigned _submit_job_enforce_data_deps(struct _starpu_job *j, unsigned st
 			_starpu_submit_job_enforce_arbitered_deps(j, buf, nbuffers);
 			return 1;
 		}
-		// WIP_COMMUTE End
 
                 if (attempt_to_submit_data_request_from_job(j, buf))
 		{
@@ -438,6 +436,8 @@ int _starpu_notify_data_dependencies(starpu_data_handle_t handle)
 
 	// WIP_COMMUTE Begin
 
+	/* TODO: directly call that */
+
 	if(handle->refcnt == 0 && handle->arbitered_req_list != NULL)
 	{
 		_starpu_spin_unlock(&handle->header_lock);

+ 0 - 2
src/datawizard/coherency.h

@@ -232,10 +232,8 @@ struct _starpu_data_state
 	/* hook to be called when unregistering the data */
 	_starpu_data_handle_unregister_hook unregister_hook;
 
-	// WIP_COMMUTE Begin
 	struct starpu_arbiter *arbiter;
 	struct _starpu_data_requester_list *arbitered_req_list;
-	// WIP_COMMUTE End
 };
 
 void _starpu_display_msi_stats(void);

+ 0 - 2
src/datawizard/sort_data_handles.c

@@ -93,7 +93,6 @@ static int _starpu_compar_handles(const struct _starpu_data_descr *descrA,
 			return 1;
 	}
 
-	// WIP_COMMUTE Begin
 	/* Put arbitered accesses after non-arbitered */
 	if (dataA->arbiter && !(dataB->arbiter))
 		return 1;
@@ -104,7 +103,6 @@ static int _starpu_compar_handles(const struct _starpu_data_descr *descrA,
 		return ((dataA->arbiter < dataB->arbiter)?-1:1);
 	/* If both are arbitered by the same arbiter (or they are both not
 	 * arbitered), we'll sort them by handle */
-	// WIP_COMMUTE End
 
 	/* In case we have data/subdata from different trees */
 	if (dataA->root_handle != dataB->root_handle)