Переглянути джерело

core: do not display the bus stats twice

When using both STARPU_ENABLE_STATS=1 and STARPU_BUS_STATS=1, the bus
statistics are displayed twice, this is useless.
Samuel Pitoiset 9 роки тому
батько
коміт
18e3e8138a

+ 0 - 1
src/core/workers.c

@@ -1522,7 +1522,6 @@ void starpu_shutdown(void)
 	     {
 		  _starpu_display_msi_stats();
 		  _starpu_display_alloc_cache_stats();
-		  _starpu_display_comm_amounts();
 	     }
 	}
 

+ 0 - 2
src/datawizard/copy_driver.c

@@ -115,8 +115,6 @@ static int copy_data_1_to_1_generic(starpu_data_handle_t handle,
 	STARPU_ASSERT(src_replicate->allocated);
 	STARPU_ASSERT(dst_replicate->allocated);
 
-	_starpu_comm_amounts_inc(src_node, dst_node, handle->ops->get_size(handle));
-
 #ifdef STARPU_SIMGRID
 	return _starpu_simgrid_transfer(handle->ops->get_size(handle), src_node, dst_node, req);
 #else /* !SIMGRID */

+ 0 - 49
src/datawizard/datastats.c

@@ -130,52 +130,3 @@ void _starpu_display_alloc_cache_stats(void)
 	}
 	fprintf(stderr, "#---------------------\n");
 }
-
-/* measure the amount of data transfers between each pair of nodes */
-static size_t comm_amount[STARPU_MAXNODES][STARPU_MAXNODES];
-
-void _starpu_comm_amounts_inc(unsigned src  STARPU_ATTRIBUTE_UNUSED, unsigned dst  STARPU_ATTRIBUTE_UNUSED, size_t size  STARPU_ATTRIBUTE_UNUSED)
-{
-	if (!starpu_enable_stats())
-		return;
-
-	STARPU_HG_DISABLE_CHECKING(comm_amount[src][dst]);
-	comm_amount[src][dst] += size;
-}
-
-void _starpu_display_comm_amounts(void)
-{
-#ifdef STARPU_DEVEL
-#  warning TODO. The information displayed here seems to be similar to the one displayed by starpu_profiling_bus_helper_display_summary()
-#endif
-
-	if (!starpu_enable_stats())
-		return;
-
-	unsigned src, dst;
-	size_t sum = 0;
-
-	fprintf(stderr, "\n#---------------------\n");
-	fprintf(stderr, "Data transfer stats:\n");
-
-	for (dst = 0; dst < STARPU_MAXNODES; dst++)
-		for (src = 0; src < STARPU_MAXNODES; src++)
-		{
-			sum += comm_amount[src][dst];
-			sum += comm_amount[dst][src];
-		}
-
-	fprintf(stderr, "TOTAL transfers %f MB\n", (float)sum/1024/1024);
-
-	for (dst = 0; dst < STARPU_MAXNODES; dst++)
-		for (src = dst + 1; src < STARPU_MAXNODES; src++)
-		{
-			if (comm_amount[src][dst])
-				fprintf(stderr, "\t%d <-> %d\t%f MB\n\t\t%d -> %d\t%f MB\n\t\t%d -> %d\t%f MB\n",
-					src, dst, ((float)comm_amount[src][dst] + (float)comm_amount[dst][src])/(1024*1024),
-					src, dst, ((float)comm_amount[src][dst])/(1024*1024),
-					dst, src, ((float)comm_amount[dst][src])/(1024*1024));
-		}
-	fprintf(stderr, "#---------------------\n");
-}
-

+ 0 - 2
src/datawizard/datastats.h

@@ -33,8 +33,6 @@ void _starpu_display_msi_stats(void);
 void _starpu_allocation_cache_hit(unsigned node STARPU_ATTRIBUTE_UNUSED);
 void _starpu_data_allocation_inc_stats(unsigned node STARPU_ATTRIBUTE_UNUSED);
 
-void _starpu_comm_amounts_inc(unsigned src, unsigned dst, size_t size);
-void _starpu_display_comm_amounts(void);
 void _starpu_display_alloc_cache_stats(void);
 
 #endif // __DATASTATS_H__