浏览代码

src/core/disk.c: code cleaning

Nathalie Furmento 10 年之前
父节点
当前提交
033a2d4425
共有 1 个文件被更改,包括 41 次插入63 次删除
  1. 41 63
      src/core/disk.c

+ 41 - 63
src/core/disk.c

@@ -40,24 +40,21 @@
 struct disk_register
 {
 	unsigned node;
-	void * base;
-	struct starpu_disk_ops * functions;
+	void *base;
+	struct starpu_disk_ops *functions;
 	/* disk condition (1 = all authorizations,  */
 	int flag;
 };
 
-static void add_disk_in_list(unsigned node, struct starpu_disk_ops * func, void * base);
+static void add_disk_in_list(unsigned node, struct starpu_disk_ops *func, void *base);
 static int get_location_with_node(unsigned node);
 
-static struct disk_register ** disk_register_list = NULL;
+static struct disk_register **disk_register_list = NULL;
 static int disk_number = -1;
 static int size_register_list = 2;
 
-
-int
-starpu_disk_register(struct starpu_disk_ops * func, void *parameter, starpu_ssize_t size)
+int starpu_disk_register(struct starpu_disk_ops *func, void *parameter, starpu_ssize_t size)
 {
-
 	STARPU_ASSERT_MSG(size < 0 || size >= SIZE_DISK_MIN,"Minimum disk size is %u Bytes ! (Here %u) \n", (int) SIZE_DISK_MIN, (int) size);
 	/* register disk */
 	unsigned memory_node = _starpu_memory_node_register(STARPU_DISK_RAM, 0);
@@ -66,37 +63,35 @@ starpu_disk_register(struct starpu_disk_ops * func, void *parameter, starpu_ssiz
 	_starpu_register_bus(memory_node, STARPU_MAIN_RAM);
 
 	/* connect disk */
-	void * base = func->plug(parameter, size);
+	void *base = func->plug(parameter, size);
 
 	/* remember it */
 	add_disk_in_list(memory_node,func,base);
 
 	int ret = func->bandwidth(memory_node);
 	/* have a problem with the disk */
-	if(ret == 0)
+	if (ret == 0)
 		return -ENOENT;
 	if (size >= 0)
 		_starpu_memory_manager_set_global_memory_size(memory_node, size);
 	return memory_node;
 }
 
-
-void
-_starpu_disk_unregister(void)
+void _starpu_disk_unregister(void)
 {
 	int i;
-	
+
 	/* search disk and delete it */
 	for (i = 0; i <= disk_number; ++i)
 	{
 		_starpu_set_disk_flag(disk_register_list[i]->node, STARPU_DISK_NO_RECLAIM);
-		_starpu_free_all_automatically_allocated_buffers(disk_register_list[i]->node);	
+		_starpu_free_all_automatically_allocated_buffers(disk_register_list[i]->node);
 
 		/* don't forget to unplug */
 		disk_register_list[i]->functions->unplug(disk_register_list[i]->base);
 		free(disk_register_list[i]);
 	}
-	
+
 	/* no disk in the list -> delete the list */
 	disk_number--;
 
@@ -107,26 +102,22 @@ _starpu_disk_unregister(void)
 	}
 }
 
-
 /* interface between user and disk memory */
 
-void *  
-_starpu_disk_alloc(unsigned node, size_t size)
+void *_starpu_disk_alloc(unsigned node, size_t size)
 {
 	int pos = get_location_with_node(node);
 	return disk_register_list[pos]->functions->alloc(disk_register_list[pos]->base, size);
 }
 
-void
-_starpu_disk_free(unsigned node, void *obj, size_t size)
+void _starpu_disk_free(unsigned node, void *obj, size_t size)
 {
 	int pos = get_location_with_node(node);
 	disk_register_list[pos]->functions->free(disk_register_list[pos]->base, obj, size);
 }
 
 /* src_node == disk node and dst_node == STARPU_MAIN_RAM */
-int 
-_starpu_disk_read(unsigned src_node, unsigned dst_node STARPU_ATTRIBUTE_UNUSED, void *obj, void *buf, off_t offset, size_t size, struct _starpu_async_channel * channel)
+int _starpu_disk_read(unsigned src_node, unsigned dst_node STARPU_ATTRIBUTE_UNUSED, void *obj, void *buf, off_t offset, size_t size, struct _starpu_async_channel *channel)
 {
 	int pos = get_location_with_node(src_node);
 
@@ -137,14 +128,14 @@ _starpu_disk_read(unsigned src_node, unsigned dst_node STARPU_ATTRIBUTE_UNUSED,
 		else
 		{
 			channel->type = STARPU_DISK_RAM;
-			channel->event.disk_event.memory_node = src_node;	
+			channel->event.disk_event.memory_node = src_node;
 
 			_STARPU_TRACE_START_DRIVER_COPY_ASYNC(src_node, dst_node);
 			channel->event.disk_event.backend_event = disk_register_list[pos]->functions->async_read(disk_register_list[pos]->base, obj, buf, offset, size);
 			_STARPU_TRACE_END_DRIVER_COPY_ASYNC(src_node, dst_node);
 		}
 	}
-	/* asynchronous request failed or synchronous request is asked */	
+	/* asynchronous request failed or synchronous request is asked */
 	if (channel == NULL || !channel->event.disk_event.backend_event)
 	{
 		disk_register_list[pos]->functions->read(disk_register_list[pos]->base, obj, buf, offset, size);
@@ -154,8 +145,7 @@ _starpu_disk_read(unsigned src_node, unsigned dst_node STARPU_ATTRIBUTE_UNUSED,
 }
 
 /* src_node == STARPU_MAIN_RAM and dst_node == disk node */
-int 
-_starpu_disk_write(unsigned src_node STARPU_ATTRIBUTE_UNUSED, unsigned dst_node, void *obj, void *buf, off_t offset, size_t size, struct _starpu_async_channel * channel)
+int _starpu_disk_write(unsigned src_node STARPU_ATTRIBUTE_UNUSED, unsigned dst_node, void *obj, void *buf, off_t offset, size_t size, struct _starpu_async_channel *channel)
 {
 	int pos = get_location_with_node(dst_node);
 
@@ -182,21 +172,20 @@ _starpu_disk_write(unsigned src_node STARPU_ATTRIBUTE_UNUSED, unsigned dst_node,
         return -EAGAIN;
 }
 
-int
-_starpu_disk_copy(unsigned node_src, void* obj_src, off_t offset_src, unsigned node_dst, void* obj_dst, off_t offset_dst, size_t size, struct _starpu_async_channel* channel)
+int _starpu_disk_copy(unsigned node_src, void *obj_src, off_t offset_src, unsigned node_dst, void *obj_dst, off_t offset_dst, size_t size, struct _starpu_async_channel *channel)
 {
 	int pos_src = get_location_with_node(node_src);
 	int pos_dst = get_location_with_node(node_dst);
 	/* both nodes have same copy function */
 	channel->event.disk_event.memory_node = node_src;
-	channel->event.disk_event.backend_event = disk_register_list[pos_src]->functions->copy(disk_register_list[pos_src]->base, obj_src, offset_src, 
-						        disk_register_list[pos_dst]->base, obj_dst, offset_dst,
-							size);
+	channel->event.disk_event.backend_event = disk_register_list[pos_src]->functions->copy(disk_register_list[pos_src]->base, obj_src, offset_src,
+											       disk_register_list[pos_dst]->base, obj_dst, offset_dst,
+											       size);
 	STARPU_ASSERT(channel->event.disk_event.backend_event);
 	return -EAGAIN;
 }
 
-int _starpu_disk_full_read(unsigned src_node, unsigned dst_node STARPU_ATTRIBUTE_UNUSED, void * obj, void ** ptr, size_t * size, struct _starpu_async_channel *channel)
+int _starpu_disk_full_read(unsigned src_node, unsigned dst_node STARPU_ATTRIBUTE_UNUSED, void *obj, void **ptr, size_t *size, struct _starpu_async_channel *channel)
 {
 	int pos = get_location_with_node(src_node);
 
@@ -223,7 +212,7 @@ int _starpu_disk_full_read(unsigned src_node, unsigned dst_node STARPU_ATTRIBUTE
 	return -EAGAIN;
 }
 
-int _starpu_disk_full_write(unsigned src_node STARPU_ATTRIBUTE_UNUSED, unsigned dst_node, void * obj, void * ptr, size_t size, struct _starpu_async_channel *channel)
+int _starpu_disk_full_write(unsigned src_node STARPU_ATTRIBUTE_UNUSED, unsigned dst_node, void *obj, void *ptr, size_t size, struct _starpu_async_channel *channel)
 {
 	int pos = get_location_with_node(dst_node);
 
@@ -250,18 +239,16 @@ int _starpu_disk_full_write(unsigned src_node STARPU_ATTRIBUTE_UNUSED, unsigned
 	return -EAGAIN;
 }
 
-void * 
-starpu_disk_open(unsigned node, void *pos, size_t size)
+void *starpu_disk_open(unsigned node, void *pos, size_t size)
 {
 	int position = get_location_with_node(node);
 	return disk_register_list[position]->functions->open(disk_register_list[position]->base, pos, size);
 }
 
-void 
-starpu_disk_close(unsigned node, void *obj, size_t size)
+void starpu_disk_close(unsigned node, void *obj, size_t size)
 {
 	int position = get_location_with_node(node);
-	disk_register_list[position]->functions->close(disk_register_list[position]->base, obj, size);	
+	disk_register_list[position]->functions->close(disk_register_list[position]->base, obj, size);
 }
 
 void starpu_disk_wait_request(struct _starpu_async_channel *async_channel)
@@ -283,20 +270,19 @@ void starpu_disk_free_request(struct _starpu_async_channel *async_channel)
 		disk_register_list[position]->functions->free_request(async_channel->event.disk_event.backend_event);
 }
 
-static void 
-add_disk_in_list(unsigned node,  struct starpu_disk_ops * func, void * base)
+static void add_disk_in_list(unsigned node,  struct starpu_disk_ops *func, void *base)
 {
 	/* initialization */
-	if(disk_register_list == NULL)
+	if (disk_register_list == NULL)
 	{
 		disk_register_list = malloc(size_register_list*sizeof(struct disk_register *));
 		STARPU_ASSERT(disk_register_list != NULL);
 	}
 	/* small size -> new size  */
-	if((disk_number+1) > size_register_list)
+	if ((disk_number+1) > size_register_list)
 	{
-		struct disk_register ** ptr_realloc = realloc(disk_register_list, 2*size_register_list*sizeof(struct disk_register *));
- 
+		struct disk_register **ptr_realloc = realloc(disk_register_list, 2*size_register_list*sizeof(struct disk_register *));
+
 		if (ptr_realloc != NULL)
 		{
 			size_register_list *= 2;
@@ -308,7 +294,7 @@ add_disk_in_list(unsigned node,  struct starpu_disk_ops * func, void * base)
 		}
 	}
 
-	struct disk_register * dr = malloc(sizeof(struct disk_register));
+	struct disk_register *dr = malloc(sizeof(struct disk_register));
 	STARPU_ASSERT(dr != NULL);
 	dr->node = node;
 	dr->base = base;
@@ -317,54 +303,46 @@ add_disk_in_list(unsigned node,  struct starpu_disk_ops * func, void * base)
 	disk_register_list[++disk_number] = dr;
 }
 
-static int
-get_location_with_node(unsigned node)
+static int get_location_with_node(unsigned node)
 {
 #ifdef STARPU_DEVEL
 #warning optimize with a MAXNODE array
 #endif
 	int i;
-	for(i = 0; i <= disk_number; ++i)
+	for (i = 0; i <= disk_number; ++i)
 		if (disk_register_list[i]->node == node)
 			return i;
 	STARPU_ASSERT_MSG(false, "Disk node not found !(%u) ", node);
 	return -1;
 }
 
-int 
-_starpu_is_same_kind_disk(unsigned node1, unsigned node2)
+int _starpu_is_same_kind_disk(unsigned node1, unsigned node2)
 {
-	
-	if(starpu_node_get_kind(node1) == STARPU_DISK_RAM && starpu_node_get_kind(node2) == STARPU_DISK_RAM)
+	if (starpu_node_get_kind(node1) == STARPU_DISK_RAM && starpu_node_get_kind(node2) == STARPU_DISK_RAM)
 	{
 		int pos1 = get_location_with_node(node1);
 		int pos2 = get_location_with_node(node2);
-		if(disk_register_list[pos1]->functions == disk_register_list[pos2]->functions)
+		if (disk_register_list[pos1]->functions == disk_register_list[pos2]->functions)
 			/* they must have a copy function */
-			if(disk_register_list[pos1]->functions->copy != NULL)
+			if (disk_register_list[pos1]->functions->copy != NULL)
 				return 1;
 	}
 	return 0;
 }
 
-
-void
-_starpu_set_disk_flag(unsigned node, int flag)
+void _starpu_set_disk_flag(unsigned node, int flag)
 {
 	int pos = get_location_with_node(node);
 	disk_register_list[pos]->flag = flag;
 }
 
-
-int
-_starpu_get_disk_flag(unsigned node)
+int _starpu_get_disk_flag(unsigned node)
 {
 	int pos = get_location_with_node(node);
 	return disk_register_list[pos]->flag;
 }
 
-void
-_starpu_swap_init(void)
+void _starpu_swap_init(void)
 {
 	char *backend;
 	char *path;