Browse Source

Disable mlr by default

Its support for dgels is not technically strong enough for now.
Samuel Thibault 4 years ago
parent
commit
00a73d8364

+ 3 - 9
configure.ac

@@ -2997,15 +2997,9 @@ AC_SUBST(BLAS_LIB,$blas_lib)
 #			 Multiple linear regression			      #
 #			 Multiple linear regression			      #
 #                                                                             #
 #                                                                             #
 ###############################################################################
 ###############################################################################
-if test x$enable_simgrid = xyes ; then
+AC_ARG_ENABLE(mlr, [AS_HELP_STRING([--enable-mlr],
-	# There is no need for building mlr models in simgrid mode
+			[Enable multiple linear regression models])],
-	default_enable_mlr=no
+			enable_mlr=$enableval, enable_mlr=no)
-else
-	default_enable_mlr=yes
-fi
-AC_ARG_ENABLE(mlr, [AS_HELP_STRING([--disable-mlr],
-			[Disable multiple linear regression models])],
-			enable_mlr=$enableval, enable_mlr=$default_enable_mlr)
 AC_ARG_ENABLE(mlr-system-blas, [AS_HELP_STRING([--enable-mlr-system-blas],
 AC_ARG_ENABLE(mlr-system-blas, [AS_HELP_STRING([--enable-mlr-system-blas],
 			[Make the multiple linear regression models use the system BLAS instead of min-dgels])],
 			[Make the multiple linear regression models use the system BLAS instead of min-dgels])],
 			enable_mlr_blas=$enableval, enable_mlr_blas=no)
 			enable_mlr_blas=$enableval, enable_mlr_blas=no)

+ 4 - 3
doc/doxygen/chapters/370_online_performance_tools.doxy

@@ -366,7 +366,8 @@ are computed automatically by the StarPU at the end of the execution, using leas
 squares method of the <c>dgels_</c> LAPACK function.
 squares method of the <c>dgels_</c> LAPACK function.
 
 
 <c>examples/mlr/mlr.c</c> example provides more details on
 <c>examples/mlr/mlr.c</c> example provides more details on
-the usage of ::STARPU_MULTIPLE_REGRESSION_BASED models.
+the usage of ::STARPU_MULTIPLE_REGRESSION_BASED models. The \ref enable-mlr
+"--enable-mlr" configure option needs to be set to calibrate the model.
 
 
 Coefficients computation is done at the end of the execution, and the
 Coefficients computation is done at the end of the execution, and the
 results are stored in standard codelet perfmodel files. Additional
 results are stored in standard codelet perfmodel files. Additional
@@ -379,8 +380,8 @@ executions. By default StarPU uses a lightweight dgels implementation, but the
 \ref enable-mlr-system-blas "--enable-mlr-system-blas" configure option can be
 \ref enable-mlr-system-blas "--enable-mlr-system-blas" configure option can be
 used to make StarPU use a system-provided dgels BLAS.
 used to make StarPU use a system-provided dgels BLAS.
 
 
-Additionally, when multiple linear regression models are
+Additionally, when multiple linear regression models are not enabled through 
-disabled (using \ref disable-mlr "--disable-mlr" configure option) or when the
+\ref enable-mlr "--enable-mlr" or when the
 <c>model->combinations</c> are not defined, StarPU will still write
 <c>model->combinations</c> are not defined, StarPU will still write
 output files into <c>.starpu/sampling/codelets/tmp/</c> to allow
 output files into <c>.starpu/sampling/codelets/tmp/</c> to allow
 performing an analysis. This analysis typically aims at finding the
 performing an analysis. This analysis typically aims at finding the

+ 4 - 4
doc/doxygen/chapters/510_configure_options.doxy

@@ -761,11 +761,11 @@ of this parameter must be in [0..100]. The default value of
 this parameter is 10. Experimental.
 this parameter is 10. Experimental.
 </dd>
 </dd>
 
 
-<dt>--disable-mlr</dt>
+<dt>--enable-mlr</dt>
 <dd>
 <dd>
-\anchor disable-mlr
+\anchor enable-mlr
-\addindex __configure__--disable-mlr
+\addindex __configure__--enable-mlr
-Allow to disable multiple linear regression models (see \ref PerformanceModelExample)
+Allow to enable multiple linear regression models (see \ref PerformanceModelExample)
 </dd>
 </dd>
 
 
 <dt>--enable-mlr-system-blas</dt>
 <dt>--enable-mlr-system-blas</dt>